From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.114]) by mx.groups.io with SMTP id smtpd.web12.519.1616521293359387290 for ; Tue, 23 Mar 2021 10:41:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=ORn/wPMP; spf=pass (domain: microsoft.com, ip: 40.107.244.114, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvFzA5EoX4UtwATTHxAK2DaN3ISC3isLQfjIsfzLcn+iFAm1UqpOoxlEcPIvKr5jQV1Q8C7dooPG6jGTpilnjen9eRoSVk1q2tYgNjQf9R5mHOQyb4wwN0NKuo4wrwX245f92pnfTyMNpxnGqDDZom5y5RURGmX8vpvYv7sY8K6dFTh45Q+AdQXcxHrTbUSdEK+DcWN/yylZs36xdEnbiBvuQyZcAaz7ZB2Ou8Yh1AcWEzXfm2kO0FOOdqofVE0L461xZ1BCHxfx995zuon65RX8kDIC14IiaJ0JjgJGzYeG/LdeWGnLcioKwr+dR0nPH+aIq+QE7g7pelt6iK6e0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4q3oD2+78tAVttpOJ7ks7KMbxs/R/yakn6Crl/iSNM=; b=Z2Li3nbeFzs8bBT39+Rn+1I8aBGTW2E8dKwHfJUF7igseGXJqm0rQ2Ms87Lt02r67/GC6US/gIkEl3tiUd8NTR4hBN54M1TxIDvNL6B+hA4VAznuepqaGBliYtOCeUfMJL/l3926aeVd9tkgbXA9E600T4yZgtBz/pBKZPchKfAXUvNGcOkYLR7HvEtWxNw6aMC0WdakougBGUjmbKIoehjMl71KTenjbuWXrVtum595ksCeWsG+5ZqHW7CgtPu2mhCoRaXUhpEa9o4VhBKC/Q26b/HL03yed6u59Nw65sxcJipYdWIAEStUFOJ1jhl5VJrSsHFvNDUHFu0hriTqLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4q3oD2+78tAVttpOJ7ks7KMbxs/R/yakn6Crl/iSNM=; b=ORn/wPMPq+X5TKnvhKKid3dee0hp1xcTKD9dpTiuUrcouNaEvhnZccJiMIHqEcohws27e7oO5Dly93IkC1l7hP5dzPMiVNuKXBu6Ld+2FHk5gp6XUq8AbDNV0yiS/qa+w/w9ZWXnFkXNtz/exxUCakCVwZOcXRLm7tKVED9SvsU= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MW2PR2101MB0892.namprd21.prod.outlook.com (2603:10b6:302:10::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.5; Tue, 23 Mar 2021 17:41:28 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.3999.005; Tue, 23 Mar 2021 17:41:28 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "jbrasen@nvidia.com" CC: "jian.j.wang@intel.com" , "ao.a.wu@intel.com" , Jeff Brasen Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 1/1] MdeModulePkg/BmpSupportLib: Allow BMP with extra data Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 1/1] MdeModulePkg/BmpSupportLib: Allow BMP with extra data Thread-Index: AQHXIAolx3JfgU4qrkW2Ofg9DVVe4qqR1zIu Date: Tue, 23 Mar 2021 17:41:28 +0000 Message-ID: References: <70c26f78d461d1b8021462d3c3fe6eb717b19193.1616520420.git.jbrasen@nvidia.com> In-Reply-To: <70c26f78d461d1b8021462d3c3fe6eb717b19193.1616520420.git.jbrasen@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-03-23T17:40:38.6943998Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.153.143] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 82a26ca5-a775-4153-8ffd-08d8ee22e389 x-ms-traffictypediagnostic: MW2PR2101MB0892: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Ckfs4cpiACPwaTQgZ4OHi+2/ruGhI40TfdKNu5mgUOnx4wgCI52Ib2GCqhSBPJAqMXoybTvexVmVs3A86zI/ex3K65Od7UIOQ5VJZW8BqBKwAb/i5IWmDQ5qS3mm7f5g95HCS1oj3BIXRovTnO8jTdI8S9Djgel6xNOFlhFkGXbbxbY2FdcKyvUzIjKBV7VpVo+Gl1vHvtHOL8I216aw40Bgl5KY9ZsfBnz12HxWIU+FsDcJuqQhtq5U21XzLSzMi8TCgOY2eJiFp099s0mk5IDC4OpXBnDRa3U6xrB8sHJI/BaxqTrhQJqrKp0BZs1ZMypy+4lwxia/TTkSspq6bHUTvDU3/Wi7dSWdJyCQjUR3dC4oUU5ZW7e6BveprQoM2zrRD+PSadQEdkmN+pL1Wr32wMnd2rqm9YRs7ihWWh6ByUIBK97HYeaoX/UgkAe+gEGqU6NkVww3rnF8k1N0ILeY5gWUdeeEkEVMZmMYq0s6/Z3bune4a9tutLuwu3HHpm+w1RoDxxCEN4/ck+tgglBHw2FNwivnwJcZhaBhHC8I8YgOK8o4LwzIatx3E/ch8Mjm2ymW5IiyINVU5Z1CoWZompcW95q17BeG605H+cwzUPKI6ctzAjQAptuVOCFS+JbhJISUU3rAaGnpjfx4PzQ/lRjA1bjaULjkLRDTpvNJSaKHT/4nWvr+cpd6crjPAUks2AYHobWAvOSUU6jsevmQGMqWup33XBqyuy2gj080xsmBf6iNw/NzJRe+A6H x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(110136005)(54906003)(8936002)(38100700001)(9686003)(4326008)(83380400001)(53546011)(52536014)(8676002)(186003)(6506007)(5660300002)(33656002)(55016002)(7696005)(86362001)(478600001)(26005)(82960400001)(66446008)(71200400001)(76116006)(10290500003)(64756008)(66946007)(66476007)(82950400001)(8990500004)(966005)(166002)(2906002)(316002)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?zZpJeTLd0hXo5YVHS+OKTmg87yS8L1SfJkdfgsLveMx/rvIdI4rAdrNr?= =?Windows-1252?Q?uraR/iMYJ3DuAEo5XxL7nILup8TYPBPDsEPDguVmFb2yFYia1i0dI70V?= =?Windows-1252?Q?2YZM6FunipipoFIKaQT3GTT6du/q68KZadcp7Oz13os663gygwEYR/kU?= =?Windows-1252?Q?W7sjAYNNhQGY8Z4EQTpa8Wd5cSMQRk7eYzts8KLGS0vATbuvIrJ065q4?= =?Windows-1252?Q?J+j3Sc6/jp2QWS0CURlSMiYKClnHdvC3HvxqX/fn//TZUBjcTJWq8aNG?= =?Windows-1252?Q?uUAUmdW6Fhrh/buBYkam7P8f7n+HOtigY5ZJ9DeH9nefF+uGCERK9bdP?= =?Windows-1252?Q?1HycPQmE49HI7v1ViNnEpxAT7M75TSSxYPc+eXKQSbtyp5PkU6+gtgcT?= =?Windows-1252?Q?K7vRZjTVIbxguAP+qSF7HfqVPk1EBts2tew3H/IPS4yzCR2j9deHMCxW?= =?Windows-1252?Q?w61H8oy6KWBYcDO33bsEHdneY8KETgNyuibMuA5cZ7uSa4ipaLMAES8B?= =?Windows-1252?Q?IpnAr+zP+eiayjTsUOIAH6CDooz6G5XVajoJfO5UVVTlIypnIlzKoBQa?= =?Windows-1252?Q?7GLcOTmrVMhYCUk3yuO0An2d1YgV/ZIleMYcjM18GNKARU2awA/RRQq4?= =?Windows-1252?Q?VhWVOtTmfeKvxQCIIfjWdeVF88ejy/v3AFcw568O+ghxHEWzGHGR5h42?= =?Windows-1252?Q?KoVd9zVGwt1UfMqIeLIpcBOuseXLhQqlOnOJG4TJE8VaotlxD5e/+R1y?= =?Windows-1252?Q?yA2MxCHWZDwH0PwxHfuNTLOhVYegY13zMRGX0I8yawawDGObw+ZuAEsZ?= =?Windows-1252?Q?n8WfOuKJcY8AmSP5J7jrahIm3aR372bDr9X82tz7NJyAeSPuwy67Ssq0?= =?Windows-1252?Q?eOAzhGjXZjKPA2asgbMhV3aOSO6V3ahuEbW0g2yp6wpZ9qUHF6O2x5M+?= =?Windows-1252?Q?mIrk3mFGF/VOmLp5w8LxC41zfkM/hFUMp1Gp0Bnm1ANesRiLfxUtNmwO?= =?Windows-1252?Q?H36fC5TMq/5Dq+7IQko4HodAE+IGxW55tgShw9GmOhsEzqbqXBznJwCC?= =?Windows-1252?Q?JPWH/Meyb74l40JhOdoOtgr3tDK1Q1/7PSSlSVhtvGvsma8cfZNolo/v?= =?Windows-1252?Q?a6auvKRo5ToBci0fNULqtX7hCjgNSlPaQjq3KffHlOsgNwSBYJbYo2Y1?= =?Windows-1252?Q?Xcjt8wJAEExGxS5qXlfA0t4fRqG6Jy8DFTXwS0gER6XaX+8e8dCDwN4u?= =?Windows-1252?Q?Z9VzemhVsYu6m4JGETxGwnbKtelPTi994miaB5WL36yMzIbmB6QC2fZ3?= =?Windows-1252?Q?CbNP2m3KRBHe70ctwjTup4EsFuh5RSC6IO8UG/8i0GsvGj/ZHa3bKt7e?= =?Windows-1252?Q?vt3jvNCelOeTOopjYAv1ldEpBl7gENk4zWs5RP6vHk/y3kla4c/D28iz?= =?Windows-1252?Q?pROS9nV5K+D23SKjcoEZzg=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82a26ca5-a775-4153-8ffd-08d8ee22e389 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 17:41:28.5661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OnoTNRKRz5LSfjXjszCln4LG0OMcYNIEUt4/PS/Tcs8FN6sA0Jtvk5lWgq5JVoKWcvdP1BXZcAv7sj39qdZFmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0892 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907D81FE3C97F62AD10C4DBEF649MW4PR21MB1907namp_" --_000_MW4PR21MB1907D81FE3C97F62AD10C4DBEF649MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Is this a *good* idea? What is considered valid extra data? If it=92s immaterial to the FW displa= ying the image, our policy has been to strip it off BEFORE adding it to the= FW image. - Bret From: Jeff Brasen via groups.io Sent: Tuesday, March 23, 2021 10:29 AM To: devel@edk2.groups.io Cc: jian.j.wang@intel.com; ao.a.wu@intel.com= ; Jeff Brasen Subject: [EXTERNAL] [edk2-devel] [PATCH 1/1] MdeModulePkg/BmpSupportLib: A= llow BMP with extra data Add support for processing BMP data that contains extra data after the image array, this data will not be parsed in anyway in the library but images that contain this will not be rejected from processing. --- MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c b/MdeM= odulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c index 3ac31f6723d0..944d01fe7cdf 100644 --- a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c +++ b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c @@ -213,7 +213,7 @@ TranslateBmpToGopBlt ( if ((BmpHeader->Size !=3D BmpImageSize) || (BmpHeader->Size < BmpHeader->ImageOffset) || - (BmpHeader->Size - BmpHeader->ImageOffset !=3D DataSize)) { + (BmpHeader->Size - BmpHeader->ImageOffset < DataSize)) { DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: invalid BmpImage... \n"))= ; DEBUG ((DEBUG_ERROR, " BmpHeader->Size: 0x%x\n", BmpHeader->Size)); -- 2.25.1 --_000_MW4PR21MB1907D81FE3C97F62AD10C4DBEF649MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Is this a *good* idea?

 

What is considered valid extra data? If it=92s imma= terial to the FW displaying the image, our policy has been to strip it off = BEFORE adding it to the FW image.

 

- Bret

 

 

Add support for proc= essing BMP data that contains extra data after the
image array, this data will not be parsed in anyway in the library but
images that contain this will not be rejected from processing.

---
 MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c b/MdeM= odulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
index 3ac31f6723d0..944d01fe7cdf 100644
--- a/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
+++ b/MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c
@@ -213,7 +213,7 @@ TranslateBmpToGopBlt (
 
   if ((BmpHeader->Size !=3D BmpImageSize) ||
       (BmpHeader->Size < BmpHeader-&g= t;ImageOffset) ||
-      (BmpHeader->Size - BmpHeader->ImageO= ffset !=3D DataSize)) {
+      (BmpHeader->Size - BmpHeader->ImageO= ffset < DataSize)) {
 
     DEBUG ((DEBUG_ERROR, "TranslateBmpToGopBlt: = invalid BmpImage... \n"));
     DEBUG ((DEBUG_ERROR, "   BmpHeader= ->Size: 0x%x\n", BmpHeader->Size));
--
2.25.1





 

--_000_MW4PR21MB1907D81FE3C97F62AD10C4DBEF649MW4PR21MB1907namp_--