From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: Pierre Gondois <pierre.gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
Date: Mon, 26 Apr 2021 20:58:54 +0000 [thread overview]
Message-ID: <MW4PR21MB1907E88F2524415D987BF429EF429@MW4PR21MB1907.namprd21.prod.outlook.com> (raw)
In-Reply-To: <898503a9-99dd-e813-5e4d-322143328142@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]
Those look good to me. Made one comment on 12/12. Also screwed up my hyphen on 8, 9, 10, and 12.
- Bret
From: Pierre Gondois<mailto:pierre.gondois@arm.com>
Sent: Monday, April 26, 2021 9:40 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
Hi Bret,
Ok I will do that in a V2.
Do these patches look ok to you ?
[PATCH v1 08/12] .pytool: Enable CI for ArmPkg
[PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
[PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
[PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
[PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
Regards,
Pierre
On 4/21/21 8:13 PM, brbarkel via groups.io wrote:
>
> 1) To expedite the required reviews, you may want to add CC to the
> package maintainers for ArmPkg to this commit message and email. I
> know a lot of people filter based on direct mention vs mailing list.
>
> 2) Generally, other packages have a brief description of the lib in
> the DEC, as well. Example:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9%2FMdeModulePkg%2FMdeModulePkg.dec%23L55&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&reserved=0
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9%2FMdeModulePkg%2FMdeModulePkg.dec%23L55&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&reserved=0>
> However, I see that this has not historically been maintained in this
> package, so I'm not going to make a big deal of it.
>
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
>
>
[-- Attachment #2: Type: text/html, Size: 5399 bytes --]
next prev parent reply other threads:[~2021-04-26 20:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-21 12:20 ` [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003 PierreGondois
2021-04-22 9:40 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
2021-04-22 9:40 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
2021-04-21 19:13 ` [edk2-devel] " brbarkel
2021-04-26 16:40 ` PierreGondois
2021-04-26 20:58 ` Bret Barkelew [this message]
2021-04-22 9:51 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
2021-04-21 19:14 ` [edk2-devel] " brbarkel
2021-04-22 9:52 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 05/12] ArmPkg: Correct small typos PierreGondois
2021-04-22 9:53 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
2021-04-22 10:02 ` Sami Mujawar
2021-04-27 14:30 ` PierreGondois
2021-04-21 12:20 ` [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
2021-04-22 10:05 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
2021-04-22 10:07 ` Sami Mujawar
2021-04-26 20:54 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
2021-04-22 10:07 ` Sami Mujawar
2021-04-26 20:55 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
2021-04-22 10:08 ` Sami Mujawar
2021-04-26 20:56 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-22 10:09 ` Sami Mujawar
2021-04-26 20:58 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
2021-04-22 10:09 ` Sami Mujawar
2021-04-26 20:57 ` [EXTERNAL] " Bret Barkelew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR21MB1907E88F2524415D987BF429EF429@MW4PR21MB1907.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox