Those look good to me. Made one comment on 12/12. Also screwed up my hyphen on 8, 9, 10, and 12. - Bret From: Pierre Gondois Sent: Monday, April 26, 2021 9:40 AM To: devel@edk2.groups.io; Bret Barkelew Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec Hi Bret, Ok I will do that in a V2. Do these patches look ok to you ? [PATCH v1 08/12] .pytool: Enable CI for ArmPkg [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg Regards, Pierre On 4/21/21 8:13 PM, brbarkel via groups.io wrote: > > 1) To expedite the required reviews, you may want to add CC to the > package maintainers for ArmPkg to this commit message and email. I > know a lot of people filter based on direct mention vs mailing list. > > 2) Generally, other packages have a brief description of the lib in > the DEC, as well. Example: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9%2FMdeModulePkg%2FMdeModulePkg.dec%23L55&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&reserved=0 > > However, I see that this has not historically been maintained in this > package, so I'm not going to make a big deal of it. > > Reviewed-by: Bret Barkelew > >