From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.133]) by mx.groups.io with SMTP id smtpd.web09.35.1619470736508742403 for ; Mon, 26 Apr 2021 13:58:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=aFPFZUwN; spf=pass (domain: microsoft.com, ip: 40.107.93.133, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F56kNwQpKAzs12oSYiGcgKmqgzmmk84eAq/NRmFpLjLSThRp75xFddx98TX3wHaEVveJw43uc+XGp5A5b2LKEGYOBIqKHBqRnShFGfQkVFJbJarRu/GLfaee9Xh8ZtENPUFGTSBGt2WC59637bc8kQi2ZQZZiIYb+PmOIRKgz4A1YrThlEt9KxBCJwSpGmb4nOI/vvXZgl3TK+5LQFUrsgDG3sU1AN5rK3c7adH0lkgz07zUl1NjzgWDMuAOcWzgFjmC0nlJ2YSVCLU44m/3hDttYcdfyjvp3oRvSHyihaWwA42h3miveZovCvTLFaqRdsgiosSvzlazIrEi2QiDGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oHCYH5cCxtbgO9vIHUYXQ9XAeJccsVzbSY/lbu1ymQw=; b=U1Q9ODmQTXpVA2pMMsdFbWevMM7seJgAYKBIIcRGr7Y6Ee7Wl9taovILfP9CFre78hYwos3yVxDYAowRJ6hkS/QWZrXMc+JVoy/xYdzwDofIt6CA4t2NhzleZ01kW2fILmCqESi3d9O4V6ORUVr26/KHLqzaUgN2tTANEuz1Hu3HKvCTQ5dH5DM3ZPrX4qPM+Zb4rcQcVlH4zs2xm45JV1MqTzrn7DiFRB65DPMSJ093xs7hBOwhFZAPFLV1JqRrCJp5W3fG63Yfm0pD4qZL28V3BKJvhvOTXFWYYtJLYGq9Hx8MCno9R0ZsVQpWTKtA9qHAlgZUX5r1j997QulBSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oHCYH5cCxtbgO9vIHUYXQ9XAeJccsVzbSY/lbu1ymQw=; b=aFPFZUwNrQiFTrbHGY9CSJtdwxncZVJhLWKvvf1SeR1XuPBaB0naUg3xs1V5b2aJzuYyj3LJLSd4o9iOZ9NALnYJ7F/O0aaWCl9j95Fb0Xor6ue5iKarn6hGt0S7jOHrpodmVuBKgQLj86+3dcl1b31qOMBk6dFFCMHSDnyJX34= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MWHPR21MB0142.namprd21.prod.outlook.com (2603:10b6:300:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.4; Mon, 26 Apr 2021 20:58:54 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::adcb:b821:ee26:3348%8]) with mapi id 15.20.4108.003; Mon, 26 Apr 2021 20:58:54 +0000 From: "Bret Barkelew" To: Pierre Gondois , "devel@edk2.groups.io" Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec Thread-Index: AQHXNuJwfnNqud8atUiCP2DNnzWoTKrHCA0AgABH+kc= Date: Mon, 26 Apr 2021 20:58:54 +0000 Message-ID: References: <20210421122048.11729-4-Pierre.Gondois@arm.com> <17614.1619032416748367718@groups.io>,<898503a9-99dd-e813-5e4d-322143328142@arm.com> In-Reply-To: <898503a9-99dd-e813-5e4d-322143328142@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-26T20:58:25.0185283Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.70.23] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c300484-b703-4d3a-8ec0-08d908f61a56 x-ms-traffictypediagnostic: MWHPR21MB0142: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:466; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v5QYwofJtG0nAOVNeeU4Uq7WMn+oQXpMeabGY+7QKf1axlGkcaGKDExI6nNOnEv4Be/gVJ/hrk0JLJheQuqSxI380GTtX2t/RQA41SaXrt5H9dbMXJ4B+Dqvpi2WPfrdOG5l+JSuAoIizAFxB3XNQBUCC71M9e5wyxkDGMyEZZ3JvWe2UVGeExN6zdBFTTwuIE739kFy8yHvn93a8VrmPlQ1tIWLddPz+8uYxImKEIRHD78n9rXLFUxVVdamqmWWI2j78ZvKkPuF04n5vRuVr6uQbxfhuKsphQu1KIFWAoRxqKTpO7GfgrT09s/EZlROx+XeDg1tY8MTI+HV5jGcO/qhuSrE73srK9wEPLMqdFSxbUjmlbBB4pXhiz61xl6lRmYPZVq9UTpG9BN5pZfT1ofeHkgS6S0Cc3mWeSEz6lhdrwMyrxCnlZrqBXd8f984Cf8sKPd5t2JgJvwrH7ve7a1M0HLOOu/gHaf4cNmbw3vyksMzKe6mI6xkxdOawRc9MBgOTCoOrCViacoJdeRrvic4aV2P5kl3bu5CeACy+km0pdFRjGBSaiOpPSJNA5r1bR9H+iwRwivpxxcfjDzrIL2SbnlRFKWQM1F5R+7ilb52u8A3zZ3bpvr7oFkCWhd5BxkrNjXiQyebtQa8JBuSbctix6pTdOP3UPIV9ZqT5cvVuYtqZbwoI+fxF0EPYsEC x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(82960400001)(82950400001)(86362001)(166002)(83380400001)(8936002)(64756008)(2906002)(122000001)(5660300002)(8676002)(38100700002)(71200400001)(52536014)(316002)(110136005)(8990500004)(26005)(7696005)(186003)(966005)(6506007)(33656002)(53546011)(66446008)(55016002)(10290500003)(9686003)(66946007)(76116006)(478600001)(66556008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M+/TFrJyuu7Yg1gCGqkclRjBUn0G9i6wj1m8g6X9wu+CszcYZSbjfCkWlH/t?= =?us-ascii?Q?2cLfsyrbDl8zGdxsrwmDiS+mXew9i1ffCsaWPeMVJgi0kdYYUjjZvbIgmrKd?= =?us-ascii?Q?IucU6wopKvDo4Aihf47FEUat8wn1+/lHmL/ECtmJ04tJbziAOJAlR/l8UMsa?= =?us-ascii?Q?eXO/AhKiW9JsPETfC6b+toRSav+uF2G8izmEMt3HsEqq7ffN6Dzup1km94aQ?= =?us-ascii?Q?TW3rF+yPR1iFAPrKNNMOcLqgw/YpcMoPUKwXq4tT4Dp45+jXxah7Tw7eU5Om?= =?us-ascii?Q?EZvaVywQ9atefRzH7AN5N5gJpbUi35Agpb31r2sxEy5NihXvBVZY0bvsqUQt?= =?us-ascii?Q?LoRdNVbMWlhHi29wfKdR3ImQ3Kd5PJ189Yg7moKV4ENI8bW5fiXZw0qLeuXX?= =?us-ascii?Q?6nEVLMSnmpqzW9ScWLUoYN8l5f/V64Pmhe/EWshdu4X+8+4AZrD34Z0+vqCp?= =?us-ascii?Q?2+OYb2ckUZeF1QLXMKlb60An0oEXMoHgXGPTuGX+9tnhJijP4ZSK/n9RwA49?= =?us-ascii?Q?7Arqo7MSTsyC3N94Q635glI/VwJY3pugnTQuGl1c5tGbUKvbx9MyeF9XZSwW?= =?us-ascii?Q?Xy4GHA/hRgSoVrSZa3kULsovuQX48NL8nQ7V7HZtmpQW3ouSV2hK7CefECVO?= =?us-ascii?Q?P6TBYwbSkEWaWXGF/r/sPIKKunu+7ceTshknqWjj1OZ9gp776r2WcVTSy8U3?= =?us-ascii?Q?6fMqa36vpfUIr1sCm8YfM0fPl/BUTAEFsKHWvQBzsfVDzNDT+LQ52WYwZEoI?= =?us-ascii?Q?3Yrzwd/cPMILuL+TOhDioT4gug01kuJo6LbCitiw0lFRIYFELPrEU6FQSKUb?= =?us-ascii?Q?rKdCo8b/qcvpyvWbr7b2lz5wpUp1DiDu3qeYbceDa2Aqv6zSmlcfR3jl5jAc?= =?us-ascii?Q?EkLNe4DPeAzpW57+FzW7FvIKux7BzrDqPKviqnb3SmNHACFoLLiYoi66K+EB?= =?us-ascii?Q?ju0O4GTOQr/zk4rDZoEVViXafXoK9cu2hNyAKgo4yW0LiFArnydp3KZAmrIr?= =?us-ascii?Q?IUeQp/igvjHHoxORWPwkR0MnNoXlYOIfxvC+rdhgE0seqdVHL7S8R7m+970M?= =?us-ascii?Q?1U7In960+pUaDbEQs5H3KzcufLF8JeI5ivA7MeNqIAgTr8PI2IpHhnt8dcQz?= =?us-ascii?Q?yrzmEFdid864mv6uQu+Y7NzNINrKNsPPm3HRXZ2l6rQKTnSy6oeYhcO+Dqa6?= =?us-ascii?Q?ifPMcja9U0kmEPeRVkXQtjLOs9qNaLIqVefPQQM8ECuvJvBrM06RODmYbDoj?= =?us-ascii?Q?i8il/sa4Vm926MyNaidj3X8151fWdB/xS0i7BP1uxKaaHGUcwU3vs2OXZLIW?= =?us-ascii?Q?7kMDBKMGE7jkd3JiEB+AOepMU9Z7DvYiF9HHgMwHRpSsbA=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c300484-b703-4d3a-8ec0-08d908f61a56 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 20:58:54.5826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zairpPM/y9FRBgtFOBX2gqgSmxv5iTVlZd7dOV7sfmAXhGZPSURHofXAi6nD2KZEVYqhzA5VpA2wXMdP7wpfUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0142 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907E88F2524415D987BF429EF429MW4PR21MB1907namp_" --_000_MW4PR21MB1907E88F2524415D987BF429EF429MW4PR21MB1907namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Those look good to me. Made one comment on 12/12. Also screwed up my hyphen= on 8, 9, 10, and 12. - Bret From: Pierre Gondois Sent: Monday, April 26, 2021 9:40 AM To: devel@edk2.groups.io; Bret Barkelew Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing = library headers to ArmPkg.dec Hi Bret, Ok I will do that in a V2. Do these patches look ok to you ? [PATCH v1 08/12] .pytool: Enable CI for ArmPkg [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg Regards, Pierre On 4/21/21 8:13 PM, brbarkel via groups.io wrote: > > 1) To expedite the required reviews, you may want to add CC to the > package maintainers for ArmPkg to this commit message and email. I > know a lot of people filter based on direct mention vs mailing list. > > 2) Generally, other packages have a brief description of the lib in > the DEC, as well. Example: > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith= ub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9= %2FMdeModulePkg%2FMdeModulePkg.dec%23L55&data=3D04%7C01%7CBret.Barkelew= %40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91ab2= d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC= 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata= =3DMsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&reserved=3D0 > > However, I see that this has not historically been maintained in this > package, so I'm not going to make a big deal of it. > > Reviewed-by: Bret Barkelew > >=20 --_000_MW4PR21MB1907E88F2524415D987BF429EF429MW4PR21MB1907namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Those look good to me. Made one comment on 12/12. A= lso screwed up my hyphen on 8, 9, 10, and 12.

 

- Bret

 

From: Pierre Gondois
Sent: Monday, April 26, 2021 9:40 AM
To: devel@edk2.groups.io; Bret Barkelew
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add m= issing library headers to ArmPkg.dec

 

Hi Bret,
Ok I will do that in a V2.

Do these patches look ok to you ?

[PATCH v1 08/12] .pytool: Enable CI for ArmPkg
[PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
[PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
[PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
[PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg

Regards,
Pierre

On 4/21/21 8:13 PM, brbarkel via groups.io wrote:
>
> 1) To expedite the required reviews, you may want to add CC to the > package maintainers for ArmPkg to this commit message and email. I > know a lot of people filter based on direct mention vs mailing list.<= br> >
> 2) Generally, other packages have a brief description of the lib in <= br> > the DEC, as well. Example:
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9%2= FMdeModulePkg%2FMdeModulePkg.dec%23L55&amp;data=3D04%7C01%7CBret.Barkel= ew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91a= b2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi= MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;s= data=3DMsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&amp;reserved=3D0<= /a>
> <https://nam06.safelinks.protection.outlook.com/?url=3D= https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa75= 0612a47234b83976f9%2FMdeModulePkg%2FMdeModulePkg.dec%23L55&amp;data=3D0= 4%7C01%7CBret.Barkelew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7= C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7C= TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0= %3D%7C1000&amp;sdata=3DMsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&a= mp;amp;reserved=3D0>
> However, I see that this has not historically been maintained in this=
> package, so I'm not going to make a big deal of it.
>
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
>

 

--_000_MW4PR21MB1907E88F2524415D987BF429EF429MW4PR21MB1907namp_--