* [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 9:40 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
` (10 subsequent siblings)
11 siblings, 1 reply; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
The #ifndef at the start of an include file should have
one postfix underscore, and no prefix underscore character
Some include guards have been modified to match the name of the
header file. Some comments have also been added on the closing
'#endif'.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 6 +++---
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 6 +++---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h | 6 +++---
ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h | 6 +++---
ArmPkg/Include/AsmMacroIoLib.h | 6 +++---
ArmPkg/Include/AsmMacroIoLibV8.h | 6 +++---
ArmPkg/Include/Chipset/AArch64.h | 6 +++---
ArmPkg/Include/Chipset/AArch64Mmu.h | 6 +++---
ArmPkg/Include/Chipset/ArmCortexA9.h | 6 +++---
ArmPkg/Include/Chipset/ArmV7.h | 6 +++---
ArmPkg/Include/Chipset/ArmV7Mmu.h | 6 +++---
ArmPkg/Include/Guid/ArmMpCoreInfo.h | 6 +++---
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 6 +++---
ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 6 +++---
ArmPkg/Include/Library/ArmDisassemblerLib.h | 6 +++---
ArmPkg/Include/Library/ArmGenericTimerCounterLib.h | 6 +++---
ArmPkg/Include/Library/ArmGicArchLib.h | 6 +++---
ArmPkg/Include/Library/ArmHvcLib.h | 6 +++---
ArmPkg/Include/Library/ArmLib.h | 6 +++---
ArmPkg/Include/Library/ArmMmuLib.h | 6 +++---
ArmPkg/Include/Library/ArmSmcLib.h | 6 +++---
ArmPkg/Include/Library/ArmSvcLib.h | 6 +++---
ArmPkg/Include/Library/DefaultExceptionHandlerLib.h | 6 +++---
ArmPkg/Include/Library/OpteeLib.h | 6 +++---
ArmPkg/Include/Library/SemihostLib.h | 6 +++---
ArmPkg/Include/Library/StandaloneMmMmuLib.h | 6 +++---
ArmPkg/Include/Ppi/ArmMpCoreInfo.h | 6 +++---
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 +++---
ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 +++---
ArmPkg/Library/ArmLib/ArmLibPrivate.h | 6 +++---
ArmPkg/Library/OpteeLib/OpteeSmc.h | 6 +++---
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h | 6 +++---
ArmPkg/Library/SemihostLib/SemihostPrivate.h | 6 +++---
33 files changed, 99 insertions(+), 99 deletions(-)
diff --git a/ArmPkg/Drivers/ArmGic/ArmGicDxe.h b/ArmPkg/Drivers/ArmGic/ArmGicDxe.h
index bf067ae03e08..c78b788ac012 100644
--- a/ArmPkg/Drivers/ArmGic/ArmGicDxe.h
+++ b/ArmPkg/Drivers/ArmGic/ArmGicDxe.h
@@ -6,8 +6,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
--*/
-#ifndef __ARM_GIC_DXE_H__
-#define __ARM_GIC_DXE_H__
+#ifndef ARM_GIC_DXE_H_
+#define ARM_GIC_DXE_H_
#include <Library/ArmGicLib.h>
#include <Library/ArmLib.h>
@@ -76,4 +76,4 @@ GicGetDistributorIcfgBaseAndBit (
OUT UINTN *Config1Bit
);
-#endif
+#endif // ARM_GIC_DXE_H_
diff --git a/ArmPkg/Drivers/CpuDxe/CpuDxe.h b/ArmPkg/Drivers/CpuDxe/CpuDxe.h
index 3fe5c24d5e5b..4cf3ab258c24 100644
--- a/ArmPkg/Drivers/CpuDxe/CpuDxe.h
+++ b/ArmPkg/Drivers/CpuDxe/CpuDxe.h
@@ -7,8 +7,8 @@
**/
-#ifndef __CPU_DXE_ARM_EXCEPTION_H__
-#define __CPU_DXE_ARM_EXCEPTION_H__
+#ifndef CPU_DXE_H_
+#define CPU_DXE_H_
#include <Uefi.h>
@@ -143,4 +143,4 @@ SetGcdMemorySpaceAttributes (
IN UINT64 Attributes
);
-#endif // __CPU_DXE_ARM_EXCEPTION_H__
+#endif // CPU_DXE_H_
diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h
index c64bc5c4627d..28db57e07bdf 100644
--- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h
+++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h
@@ -5,8 +5,8 @@
* SPDX-License-Identifier: BSD-2-Clause-Patent
*
**/
-#ifndef __GENERIC_WATCHDOG_H__
-#define __GENERIC_WATCHDOG_H__
+#ifndef GENERIC_WATCHDOG_H_
+#define GENERIC_WATCHDOG_H_
// Refresh Frame:
#define GENERIC_WDOG_REFRESH_REG ((UINTN)FixedPcdGet64 (PcdGenericWatchdogRefreshBase) + 0x000)
@@ -21,4 +21,4 @@
#define GENERIC_WDOG_ENABLED 1
#define GENERIC_WDOG_DISABLED 0
-#endif // __GENERIC_WATCHDOG_H__
+#endif // GENERIC_WATCHDOG_H_
diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
index ce92fe9f1b91..5fe7c5f4d4e3 100644
--- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
+++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
@@ -7,8 +7,8 @@
**/
-#ifndef __SEMIHOST_FS_H__
-#define __SEMIHOST_FS_H__
+#ifndef SEMIHOST_FS_H_
+#define SEMIHOST_FS_H_
EFI_STATUS
VolumeOpen (
@@ -242,5 +242,5 @@ FileFlush (
IN EFI_FILE *File
);
-#endif // __SEMIHOST_FS_H__
+#endif // SEMIHOST_FS_H_
diff --git a/ArmPkg/Include/AsmMacroIoLib.h b/ArmPkg/Include/AsmMacroIoLib.h
index e3576c8beb6e..6c901ac3871b 100644
--- a/ArmPkg/Include/AsmMacroIoLib.h
+++ b/ArmPkg/Include/AsmMacroIoLib.h
@@ -10,8 +10,8 @@
**/
-#ifndef __MACRO_IO_LIB_H__
-#define __MACRO_IO_LIB_H__
+#ifndef ASM_MACRO_IO_LIB_H_
+#define ASM_MACRO_IO_LIB_H_
#define _ASM_FUNC(Name, Section) \
.global Name ; \
@@ -36,4 +36,4 @@
movt Reg, #:upper16:(Sym) - (. + 12) ; \
ldr Reg, [pc, Reg]
-#endif
+#endif // ASM_MACRO_IO_LIB_H_
diff --git a/ArmPkg/Include/AsmMacroIoLibV8.h b/ArmPkg/Include/AsmMacroIoLibV8.h
index bcc0d8dafe0c..337d9ae0168e 100644
--- a/ArmPkg/Include/AsmMacroIoLibV8.h
+++ b/ArmPkg/Include/AsmMacroIoLibV8.h
@@ -10,8 +10,8 @@
**/
-#ifndef __MACRO_IO_LIBV8_H__
-#define __MACRO_IO_LIBV8_H__
+#ifndef ASM_MACRO_IO_LIBV8_H_
+#define ASM_MACRO_IO_LIBV8_H_
// CurrentEL : 0xC = EL3; 8 = EL2; 4 = EL1
// This only selects between EL1 and EL2, else we die.
@@ -54,4 +54,4 @@
movk Reg, ((Val) >> 16) & 0xffff, lsl #16 ; \
movk Reg, (Val) & 0xffff
-#endif // __MACRO_IO_LIBV8_H__
+#endif // ASM_MACRO_IO_LIBV8_H_
diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/Include/Chipset/AArch64.h
index 09d4cfe28da7..10aeb9a15ad8 100644
--- a/ArmPkg/Include/Chipset/AArch64.h
+++ b/ArmPkg/Include/Chipset/AArch64.h
@@ -7,8 +7,8 @@
**/
-#ifndef __AARCH64_H__
-#define __AARCH64_H__
+#ifndef AARCH64_H_
+#define AARCH64_H_
#include <Chipset/AArch64Mmu.h>
@@ -238,4 +238,4 @@ ArmWriteCntHctl (
IN UINT32 CntHctl
);
-#endif // __AARCH64_H__
+#endif // AARCH64_H_
diff --git a/ArmPkg/Include/Chipset/AArch64Mmu.h b/ArmPkg/Include/Chipset/AArch64Mmu.h
index 6c7ada16b18a..fe38ba1c50ce 100644
--- a/ArmPkg/Include/Chipset/AArch64Mmu.h
+++ b/ArmPkg/Include/Chipset/AArch64Mmu.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __AARCH64_MMU_H_
-#define __AARCH64_MMU_H_
+#ifndef AARCH64_MMU_H_
+#define AARCH64_MMU_H_
//
// Memory Attribute Indirection register Definitions
@@ -194,5 +194,5 @@
// Uses LPAE Page Table format
-#endif // __AARCH64_MMU_H_
+#endif // AARCH64_MMU_H_
diff --git a/ArmPkg/Include/Chipset/ArmCortexA9.h b/ArmPkg/Include/Chipset/ArmCortexA9.h
index 13d18e5893dd..cb937ebc8c8b 100644
--- a/ArmPkg/Include/Chipset/ArmCortexA9.h
+++ b/ArmPkg/Include/Chipset/ArmCortexA9.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_CORTEX_A9_H__
-#define __ARM_CORTEX_A9_H__
+#ifndef ARM_CORTEX_A9_H_
+#define ARM_CORTEX_A9_H_
#include <Chipset/ArmV7.h>
@@ -55,5 +55,5 @@ ArmGetScuBaseAddress (
VOID
);
-#endif
+#endif // ARM_CORTEX_A9_H_
diff --git a/ArmPkg/Include/Chipset/ArmV7.h b/ArmPkg/Include/Chipset/ArmV7.h
index 025f87a56d16..6b20b988e364 100644
--- a/ArmPkg/Include/Chipset/ArmV7.h
+++ b/ArmPkg/Include/Chipset/ArmV7.h
@@ -7,8 +7,8 @@
**/
-#ifndef __ARM_V7_H__
-#define __ARM_V7_H__
+#ifndef ARM_V7_H_
+#define ARM_V7_H_
#include <Chipset/ArmV7Mmu.h>
@@ -120,4 +120,4 @@ ArmWriteNsacr (
IN UINT32 Nsacr
);
-#endif // __ARM_V7_H__
+#endif // ARM_V7_H_
diff --git a/ArmPkg/Include/Chipset/ArmV7Mmu.h b/ArmPkg/Include/Chipset/ArmV7Mmu.h
index 25d82d029795..87c443df3fce 100644
--- a/ArmPkg/Include/Chipset/ArmV7Mmu.h
+++ b/ArmPkg/Include/Chipset/ArmV7Mmu.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARMV7_MMU_H_
-#define __ARMV7_MMU_H_
+#ifndef ARMV7_MMU_H_
+#define ARMV7_MMU_H_
#define TTBR_NOT_OUTER_SHAREABLE BIT5
#define TTBR_RGN_OUTER_NON_CACHEABLE 0
@@ -235,4 +235,4 @@ ConvertSectionAttributesToPageAttributes (
IN BOOLEAN IsLargePage
);
-#endif
+#endif // ARMV7_MMU_H_
diff --git a/ArmPkg/Include/Guid/ArmMpCoreInfo.h b/ArmPkg/Include/Guid/ArmMpCoreInfo.h
index 3f9d17bb72c0..b810767879ae 100644
--- a/ArmPkg/Include/Guid/ArmMpCoreInfo.h
+++ b/ArmPkg/Include/Guid/ArmMpCoreInfo.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_MP_CORE_INFO_GUID_H_
-#define __ARM_MP_CORE_INFO_GUID_H_
+#ifndef ARM_MP_CORE_INFO_GUID_H_
+#define ARM_MP_CORE_INFO_GUID_H_
#define MAX_CPUS_PER_MPCORE_SYSTEM 0x04
#define SCU_CONFIG_REG_OFFSET 0x04
@@ -57,4 +57,4 @@ typedef struct {
extern EFI_GUID gArmMpCoreInfoGuid;
-#endif /* MPCOREINFO_H_ */
+#endif /* ARM_MP_CORE_INFO_GUID_H_ */
diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
index 71a5398558b8..33d60ccf17bc 100644
--- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_MM_SVC_H__
-#define __ARM_MM_SVC_H__
+#ifndef ARM_MM_SVC_H_
+#define ARM_MM_SVC_H_
/*
* SVC IDs to allow the MM secure partition to initialise itself, handle
@@ -44,4 +44,4 @@
#define SPM_MAJOR_VERSION 0
#define SPM_MINOR_VERSION 1
-#endif
+#endif // ARM_MM_SVC_H_
diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
index 9e0a3a3960d5..67afb0ea2d3d 100644
--- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
@@ -10,8 +10,8 @@
* (https://developer.arm.com/documentation/den0028/c/?lang=en)
**/
-#ifndef __ARM_STD_SMC_H__
-#define __ARM_STD_SMC_H__
+#ifndef ARM_STD_SMC_H_
+#define ARM_STD_SMC_H_
/*
* SMC function IDs for Standard Service queries
@@ -129,4 +129,4 @@
/* 0xbf00ff02 is reserved */
#define ARM_SMC_ID_TOS_REVISION 0xbf00ff03
-#endif
+#endif // ARM_STD_SMC_H_
diff --git a/ArmPkg/Include/Library/ArmDisassemblerLib.h b/ArmPkg/Include/Library/ArmDisassemblerLib.h
index c103b72e8127..d8c7af029dd3 100644
--- a/ArmPkg/Include/Library/ArmDisassemblerLib.h
+++ b/ArmPkg/Include/Library/ArmDisassemblerLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_DISASSEBLER_LIB_H__
-#define __ARM_DISASSEBLER_LIB_H__
+#ifndef ARM_DISASSEMBLER_LIB_H_
+#define ARM_DISASSEMBLER_LIB_H_
/**
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
@@ -34,4 +34,4 @@ DisassembleInstruction (
OUT UINTN Size
);
-#endif
+#endif // ARM_DISASSEMBLER_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h b/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h
index d3051be30f2d..96bdffbf1ee3 100644
--- a/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h
+++ b/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h
@@ -7,8 +7,8 @@
**/
-#ifndef __ARM_GENERIC_TIMER_COUNTER_LIB_H__
-#define __ARM_GENERIC_TIMER_COUNTER_LIB_H__
+#ifndef ARM_GENERIC_TIMER_COUNTER_LIB_H_
+#define ARM_GENERIC_TIMER_COUNTER_LIB_H_
VOID
EFIAPI
@@ -82,4 +82,4 @@ ArmGenericTimerSetCompareVal (
IN UINT64 Value
);
-#endif
+#endif // ARM_GENERIC_TIMER_COUNTER_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h
index 264322f1d0df..b3635d226866 100644
--- a/ArmPkg/Include/Library/ArmGicArchLib.h
+++ b/ArmPkg/Include/Library/ArmGicArchLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_GIC_ARCH_LIB_H__
-#define __ARM_GIC_ARCH_LIB_H__
+#ifndef ARM_GIC_ARCH_LIB_H_
+#define ARM_GIC_ARCH_LIB_H_
//
// GIC definitions
@@ -24,4 +24,4 @@ ArmGicGetSupportedArchRevision (
VOID
);
-#endif
+#endif // ARM_GIC_ARCH_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmHvcLib.h b/ArmPkg/Include/Library/ArmHvcLib.h
index d26f0cff31eb..d202c2af6ee3 100644
--- a/ArmPkg/Include/Library/ArmHvcLib.h
+++ b/ArmPkg/Include/Library/ArmHvcLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_HVC_LIB__
-#define __ARM_HVC_LIB__
+#ifndef ARM_HVC_LIB_H_
+#define ARM_HVC_LIB_H_
/**
* The size of the HVC arguments are different between AArch64 and AArch32.
@@ -37,4 +37,4 @@ ArmCallHvc (
IN OUT ARM_HVC_ARGS *Args
);
-#endif
+#endif // ARM_HVC_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
index 70b9d816b74c..5c232d779c83 100644
--- a/ArmPkg/Include/Library/ArmLib.h
+++ b/ArmPkg/Include/Library/ArmLib.h
@@ -8,8 +8,8 @@
**/
-#ifndef __ARM_LIB__
-#define __ARM_LIB__
+#ifndef ARM_LIB_H_
+#define ARM_LIB_H_
#include <Uefi/UefiBaseType.h>
@@ -753,4 +753,4 @@ ArmHasSecurityExtensions (
);
#endif // MDE_CPU_ARM
-#endif // __ARM_LIB__
+#endif // ARM_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmMmuLib.h b/ArmPkg/Include/Library/ArmMmuLib.h
index 23e89a0c6584..410f06ce373c 100644
--- a/ArmPkg/Include/Library/ArmMmuLib.h
+++ b/ArmPkg/Include/Library/ArmMmuLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_MMU_LIB__
-#define __ARM_MMU_LIB__
+#ifndef ARM_MMU_LIB_H_
+#define ARM_MMU_LIB_H_
#include <Uefi/UefiBaseType.h>
@@ -64,4 +64,4 @@ ArmSetMemoryAttributes (
IN UINT64 Attributes
);
-#endif
+#endif // ARM_MMU_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmSmcLib.h b/ArmPkg/Include/Library/ArmSmcLib.h
index 835d6788e0b9..ced60b3c1147 100644
--- a/ArmPkg/Include/Library/ArmSmcLib.h
+++ b/ArmPkg/Include/Library/ArmSmcLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_SMC_LIB__
-#define __ARM_SMC_LIB__
+#ifndef ARM_SMC_LIB_H_
+#define ARM_SMC_LIB_H_
/**
* The size of the SMC arguments are different between AArch64 and AArch32.
@@ -37,4 +37,4 @@ ArmCallSmc (
IN OUT ARM_SMC_ARGS *Args
);
-#endif
+#endif // ARM_SMC_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmSvcLib.h b/ArmPkg/Include/Library/ArmSvcLib.h
index a4414270f3b9..d4a1a8f11863 100644
--- a/ArmPkg/Include/Library/ArmSvcLib.h
+++ b/ArmPkg/Include/Library/ArmSvcLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_SVC_LIB__
-#define __ARM_SVC_LIB__
+#ifndef ARM_SVC_LIB_H_
+#define ARM_SVC_LIB_H_
/**
* The size of the SVC arguments are different between AArch64 and AArch32.
@@ -43,4 +43,4 @@ ArmCallSvc (
IN OUT ARM_SVC_ARGS *Args
);
-#endif
+#endif // ARM_SVC_LIB_H_
diff --git a/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h b/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h
index bbcf30f85752..57dc555e1332 100644
--- a/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h
+++ b/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __DEFAULT_EXCEPTION_HANDLER_LIB_H__
-#define __DEFAULT_EXCEPTION_HANDLER_LIB_H__
+#ifndef DEFAULT_EXCEPTION_HANDLER_LIB_H_
+#define DEFAULT_EXCEPTION_HANDLER_LIB_H_
/**
This is the default action to take on an unexpected exception
@@ -22,4 +22,4 @@ DefaultExceptionHandler (
IN OUT EFI_SYSTEM_CONTEXT SystemContext
);
-#endif
+#endif // DEFAULT_EXCEPTION_HANDLER_LIB_H_
diff --git a/ArmPkg/Include/Library/OpteeLib.h b/ArmPkg/Include/Library/OpteeLib.h
index 8ceab117d132..b9399d2e1810 100644
--- a/ArmPkg/Include/Library/OpteeLib.h
+++ b/ArmPkg/Include/Library/OpteeLib.h
@@ -8,8 +8,8 @@
**/
-#ifndef _OPTEE_H_
-#define _OPTEE_H_
+#ifndef OPTEE_LIB_H_
+#define OPTEE_LIB_H_
/*
* The 'Trusted OS Call UID' is supposed to return the following UUID for
@@ -117,4 +117,4 @@ OpteeInvokeFunction (
IN OUT OPTEE_INVOKE_FUNCTION_ARG *InvokeFunctionArg
);
-#endif
+#endif // OPTEE_LIB_H_
diff --git a/ArmPkg/Include/Library/SemihostLib.h b/ArmPkg/Include/Library/SemihostLib.h
index ce08b2778d72..590728c804f4 100644
--- a/ArmPkg/Include/Library/SemihostLib.h
+++ b/ArmPkg/Include/Library/SemihostLib.h
@@ -7,8 +7,8 @@
**/
-#ifndef __SEMIHOSTING_H__
-#define __SEMIHOSTING_H__
+#ifndef SEMIHOSTING_LIB_H_
+#define SEMIHOSTING_LIB_H_
/*
*
@@ -129,4 +129,4 @@ SemihostSystem (
IN CHAR8 *CommandLine
);
-#endif // __SEMIHOSTING_H__
+#endif // SEMIHOSTING_LIB_H_
diff --git a/ArmPkg/Include/Library/StandaloneMmMmuLib.h b/ArmPkg/Include/Library/StandaloneMmMmuLib.h
index 1d2a0e0c2bac..ccc016d0350a 100644
--- a/ArmPkg/Include/Library/StandaloneMmMmuLib.h
+++ b/ArmPkg/Include/Library/StandaloneMmMmuLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __STANDALONEMM_MMU_LIB__
-#define __STANDALONEMM_MMU_LIB__
+#ifndef STANDALONE_MM_MMU_LIB_
+#define STANDALONE_MM_MMU_LIB_
EFI_STATUS
ArmSetMemoryRegionNoExec (
@@ -33,4 +33,4 @@ ArmClearMemoryRegionReadOnly (
IN UINT64 Length
);
-#endif /* __STANDALONEMM_MMU_LIB__ */
+#endif /* STANDALONE_MM_MMU_LIB_ */
diff --git a/ArmPkg/Include/Ppi/ArmMpCoreInfo.h b/ArmPkg/Include/Ppi/ArmMpCoreInfo.h
index 871119bde2f0..b1e404ce1364 100644
--- a/ArmPkg/Include/Ppi/ArmMpCoreInfo.h
+++ b/ArmPkg/Include/Ppi/ArmMpCoreInfo.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_MP_CORE_INFO_PPI_H__
-#define __ARM_MP_CORE_INFO_PPI_H__
+#ifndef ARM_MP_CORE_INFO_PPI_H_
+#define ARM_MP_CORE_INFO_PPI_H_
#include <Guid/ArmMpCoreInfo.h>
@@ -49,4 +49,4 @@ typedef struct {
extern EFI_GUID gArmMpCoreInfoPpiGuid;
extern EFI_GUID gArmMpCoreInfoGuid;
-#endif
+#endif // ARM_MP_CORE_INFO_PPI_H_
diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
index cfc0c878a415..318020277b24 100644
--- a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
+++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
@@ -8,8 +8,8 @@
**/
-#ifndef __AARCH64_LIB_H__
-#define __AARCH64_LIB_H__
+#ifndef AARCH64_LIB_H_
+#define AARCH64_LIB_H_
typedef VOID (*AARCH64_CACHE_OPERATION)(UINTN);
@@ -52,5 +52,5 @@ ArmReadIdAA64Mmfr2 (
VOID
);
-#endif // __AARCH64_LIB_H__
+#endif // AARCH64_LIB_H_
diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h
index dcf6723b803b..5a92ade2b313 100644
--- a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h
+++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_V7_LIB_H__
-#define __ARM_V7_LIB_H__
+#ifndef ARM_V7_LIB_H_
+#define ARM_V7_LIB_H_
#define ID_MMFR0_SHARELVL_SHIFT 12
#define ID_MMFR0_SHARELVL_MASK 0xf
@@ -64,5 +64,5 @@ ArmReadIdPfr1 (
VOID
);
-#endif // __ARM_V7_LIB_H__
+#endif // ARM_V7_LIB_H_
diff --git a/ArmPkg/Library/ArmLib/ArmLibPrivate.h b/ArmPkg/Library/ArmLib/ArmLibPrivate.h
index 1818a1994dc3..5db83d620bfc 100644
--- a/ArmPkg/Library/ArmLib/ArmLibPrivate.h
+++ b/ArmPkg/Library/ArmLib/ArmLibPrivate.h
@@ -8,8 +8,8 @@
**/
-#ifndef __ARM_LIB_PRIVATE_H__
-#define __ARM_LIB_PRIVATE_H__
+#ifndef ARM_LIB_PRIVATE_H_
+#define ARM_LIB_PRIVATE_H_
#define CACHE_SIZE_4_KB (3UL)
#define CACHE_SIZE_8_KB (4UL)
@@ -186,4 +186,4 @@ ReadCLIDR (
VOID
);
-#endif // __ARM_LIB_PRIVATE_H__
+#endif // ARM_LIB_PRIVATE_H_
diff --git a/ArmPkg/Library/OpteeLib/OpteeSmc.h b/ArmPkg/Library/OpteeLib/OpteeSmc.h
index 62319d718dc5..b760ec8f8227 100644
--- a/ArmPkg/Library/OpteeLib/OpteeSmc.h
+++ b/ArmPkg/Library/OpteeLib/OpteeSmc.h
@@ -7,8 +7,8 @@
**/
-#ifndef _OPTEE_SMC_H_
-#define _OPTEE_SMC_H_
+#ifndef OPTEE_SMC_H_
+#define OPTEE_SMC_H_
/* Returned in Arg0 only from Trusted OS functions */
#define OPTEE_SMC_RETURN_OK 0x0
@@ -47,4 +47,4 @@ typedef struct {
UINT8 Data4[8];
} RFC4122_UUID;
-#endif
+#endif // OPTEE_SMC_H_
diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
index 0bb3645ddc47..a40a2ff5cb4f 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
@@ -9,8 +9,8 @@
**/
-#ifndef _PLATFORM_BM_H_
-#define _PLATFORM_BM_H_
+#ifndef PLATFORM_BM_H_
+#define PLATFORM_BM_H_
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
@@ -50,4 +50,4 @@ DisableQuietBoot (
VOID
);
-#endif // _PLATFORM_BM_H_
+#endif // PLATFORM_BM_H_
diff --git a/ArmPkg/Library/SemihostLib/SemihostPrivate.h b/ArmPkg/Library/SemihostLib/SemihostPrivate.h
index 30103b04b53f..886472611623 100644
--- a/ArmPkg/Library/SemihostLib/SemihostPrivate.h
+++ b/ArmPkg/Library/SemihostLib/SemihostPrivate.h
@@ -7,8 +7,8 @@
**/
-#ifndef __SEMIHOST_PRIVATE_H__
-#define __SEMIHOST_PRIVATE_H__
+#ifndef SEMIHOST_PRIVATE_H_
+#define SEMIHOST_PRIVATE_H_
typedef struct {
CHAR8 *FileName;
@@ -209,4 +209,4 @@ GccSemihostCall (
#endif // __CC_ARM
-#endif //__SEMIHOST_PRIVATE_H__
+#endif // SEMIHOST_PRIVATE_H_
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003
2021-04-21 12:20 ` [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003 PierreGondois
@ 2021-04-22 9:40 ` Sami Mujawar
0 siblings, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 9:40 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com, nd
[-- Attachment #1: Type: text/plain, Size: 22403 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
The #ifndef at the start of an include file should have
one postfix underscore, and no prefix underscore character
Some include guards have been modified to match the name of the
header file. Some comments have also been added on the closing
'#endif'.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 6 +++---
ArmPkg/Drivers/CpuDxe/CpuDxe.h | 6 +++---
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h | 6 +++---
ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h | 6 +++---
ArmPkg/Include/AsmMacroIoLib.h | 6 +++---
ArmPkg/Include/AsmMacroIoLibV8.h | 6 +++---
ArmPkg/Include/Chipset/AArch64.h | 6 +++---
ArmPkg/Include/Chipset/AArch64Mmu.h | 6 +++---
ArmPkg/Include/Chipset/ArmCortexA9.h | 6 +++---
ArmPkg/Include/Chipset/ArmV7.h | 6 +++---
ArmPkg/Include/Chipset/ArmV7Mmu.h | 6 +++---
ArmPkg/Include/Guid/ArmMpCoreInfo.h | 6 +++---
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 6 +++---
ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 6 +++---
ArmPkg/Include/Library/ArmDisassemblerLib.h | 6 +++---
ArmPkg/Include/Library/ArmGenericTimerCounterLib.h | 6 +++---
ArmPkg/Include/Library/ArmGicArchLib.h | 6 +++---
ArmPkg/Include/Library/ArmHvcLib.h | 6 +++---
ArmPkg/Include/Library/ArmLib.h | 6 +++---
ArmPkg/Include/Library/ArmMmuLib.h | 6 +++---
ArmPkg/Include/Library/ArmSmcLib.h | 6 +++---
ArmPkg/Include/Library/ArmSvcLib.h | 6 +++---
ArmPkg/Include/Library/DefaultExceptionHandlerLib.h | 6 +++---
ArmPkg/Include/Library/OpteeLib.h | 6 +++---
ArmPkg/Include/Library/SemihostLib.h | 6 +++---
ArmPkg/Include/Library/StandaloneMmMmuLib.h | 6 +++---
ArmPkg/Include/Ppi/ArmMpCoreInfo.h | 6 +++---
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 +++---
ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 +++---
ArmPkg/Library/ArmLib/ArmLibPrivate.h | 6 +++---
ArmPkg/Library/OpteeLib/OpteeSmc.h | 6 +++---
ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h | 6 +++---
ArmPkg/Library/SemihostLib/SemihostPrivate.h | 6 +++---
33 files changed, 99 insertions(+), 99 deletions(-)
diff --git a/ArmPkg/Drivers/ArmGic/ArmGicDxe.h b/ArmPkg/Drivers/ArmGic/ArmGicDxe.h
index bf067ae03e08..c78b788ac012 100644
--- a/ArmPkg/Drivers/ArmGic/ArmGicDxe.h
+++ b/ArmPkg/Drivers/ArmGic/ArmGicDxe.h
@@ -6,8 +6,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
--*/
-#ifndef __ARM_GIC_DXE_H__
-#define __ARM_GIC_DXE_H__
+#ifndef ARM_GIC_DXE_H_
+#define ARM_GIC_DXE_H_
#include <Library/ArmGicLib.h>
#include <Library/ArmLib.h>
@@ -76,4 +76,4 @@ GicGetDistributorIcfgBaseAndBit (
OUT UINTN *Config1Bit
);
-#endif
+#endif // ARM_GIC_DXE_H_
diff --git a/ArmPkg/Drivers/CpuDxe/CpuDxe.h b/ArmPkg/Drivers/CpuDxe/CpuDxe.h
index 3fe5c24d5e5b..4cf3ab258c24 100644
--- a/ArmPkg/Drivers/CpuDxe/CpuDxe.h
+++ b/ArmPkg/Drivers/CpuDxe/CpuDxe.h
@@ -7,8 +7,8 @@
**/
-#ifndef __CPU_DXE_ARM_EXCEPTION_H__
-#define __CPU_DXE_ARM_EXCEPTION_H__
+#ifndef CPU_DXE_H_
+#define CPU_DXE_H_
#include <Uefi.h>
@@ -143,4 +143,4 @@ SetGcdMemorySpaceAttributes (
IN UINT64 Attributes
);
-#endif // __CPU_DXE_ARM_EXCEPTION_H__
+#endif // CPU_DXE_H_
diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h
index c64bc5c4627d..28db57e07bdf 100644
--- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h
+++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h
@@ -5,8 +5,8 @@
* SPDX-License-Identifier: BSD-2-Clause-Patent
*
**/
-#ifndef __GENERIC_WATCHDOG_H__
-#define __GENERIC_WATCHDOG_H__
+#ifndef GENERIC_WATCHDOG_H_
+#define GENERIC_WATCHDOG_H_
// Refresh Frame:
#define GENERIC_WDOG_REFRESH_REG ((UINTN)FixedPcdGet64 (PcdGenericWatchdogRefreshBase) + 0x000)
@@ -21,4 +21,4 @@
#define GENERIC_WDOG_ENABLED 1
#define GENERIC_WDOG_DISABLED 0
-#endif // __GENERIC_WATCHDOG_H__
+#endif // GENERIC_WATCHDOG_H_
diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
index ce92fe9f1b91..5fe7c5f4d4e3 100644
--- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
+++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.h
@@ -7,8 +7,8 @@
**/
-#ifndef __SEMIHOST_FS_H__
-#define __SEMIHOST_FS_H__
+#ifndef SEMIHOST_FS_H_
+#define SEMIHOST_FS_H_
EFI_STATUS
VolumeOpen (
@@ -242,5 +242,5 @@ FileFlush (
IN EFI_FILE *File
);
-#endif // __SEMIHOST_FS_H__
+#endif // SEMIHOST_FS_H_
diff --git a/ArmPkg/Include/AsmMacroIoLib.h b/ArmPkg/Include/AsmMacroIoLib.h
index e3576c8beb6e..6c901ac3871b 100644
--- a/ArmPkg/Include/AsmMacroIoLib.h
+++ b/ArmPkg/Include/AsmMacroIoLib.h
@@ -10,8 +10,8 @@
**/
-#ifndef __MACRO_IO_LIB_H__
-#define __MACRO_IO_LIB_H__
+#ifndef ASM_MACRO_IO_LIB_H_
+#define ASM_MACRO_IO_LIB_H_
#define _ASM_FUNC(Name, Section) \
.global Name ; \
@@ -36,4 +36,4 @@
movt Reg, #:upper16:(Sym) - (. + 12) ; \
ldr Reg, [pc, Reg]
-#endif
+#endif // ASM_MACRO_IO_LIB_H_
diff --git a/ArmPkg/Include/AsmMacroIoLibV8.h b/ArmPkg/Include/AsmMacroIoLibV8.h
index bcc0d8dafe0c..337d9ae0168e 100644
--- a/ArmPkg/Include/AsmMacroIoLibV8.h
+++ b/ArmPkg/Include/AsmMacroIoLibV8.h
@@ -10,8 +10,8 @@
**/
-#ifndef __MACRO_IO_LIBV8_H__
-#define __MACRO_IO_LIBV8_H__
+#ifndef ASM_MACRO_IO_LIBV8_H_
+#define ASM_MACRO_IO_LIBV8_H_
// CurrentEL : 0xC = EL3; 8 = EL2; 4 = EL1
// This only selects between EL1 and EL2, else we die.
@@ -54,4 +54,4 @@
movk Reg, ((Val) >> 16) & 0xffff, lsl #16 ; \
movk Reg, (Val) & 0xffff
-#endif // __MACRO_IO_LIBV8_H__
+#endif // ASM_MACRO_IO_LIBV8_H_
diff --git a/ArmPkg/Include/Chipset/AArch64.h b/ArmPkg/Include/Chipset/AArch64.h
index 09d4cfe28da7..10aeb9a15ad8 100644
--- a/ArmPkg/Include/Chipset/AArch64.h
+++ b/ArmPkg/Include/Chipset/AArch64.h
@@ -7,8 +7,8 @@
**/
-#ifndef __AARCH64_H__
-#define __AARCH64_H__
+#ifndef AARCH64_H_
+#define AARCH64_H_
#include <Chipset/AArch64Mmu.h>
@@ -238,4 +238,4 @@ ArmWriteCntHctl (
IN UINT32 CntHctl
);
-#endif // __AARCH64_H__
+#endif // AARCH64_H_
diff --git a/ArmPkg/Include/Chipset/AArch64Mmu.h b/ArmPkg/Include/Chipset/AArch64Mmu.h
index 6c7ada16b18a..fe38ba1c50ce 100644
--- a/ArmPkg/Include/Chipset/AArch64Mmu.h
+++ b/ArmPkg/Include/Chipset/AArch64Mmu.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __AARCH64_MMU_H_
-#define __AARCH64_MMU_H_
+#ifndef AARCH64_MMU_H_
+#define AARCH64_MMU_H_
//
// Memory Attribute Indirection register Definitions
@@ -194,5 +194,5 @@
// Uses LPAE Page Table format
-#endif // __AARCH64_MMU_H_
+#endif // AARCH64_MMU_H_
diff --git a/ArmPkg/Include/Chipset/ArmCortexA9.h b/ArmPkg/Include/Chipset/ArmCortexA9.h
index 13d18e5893dd..cb937ebc8c8b 100644
--- a/ArmPkg/Include/Chipset/ArmCortexA9.h
+++ b/ArmPkg/Include/Chipset/ArmCortexA9.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_CORTEX_A9_H__
-#define __ARM_CORTEX_A9_H__
+#ifndef ARM_CORTEX_A9_H_
+#define ARM_CORTEX_A9_H_
#include <Chipset/ArmV7.h>
@@ -55,5 +55,5 @@ ArmGetScuBaseAddress (
VOID
);
-#endif
+#endif // ARM_CORTEX_A9_H_
diff --git a/ArmPkg/Include/Chipset/ArmV7.h b/ArmPkg/Include/Chipset/ArmV7.h
index 025f87a56d16..6b20b988e364 100644
--- a/ArmPkg/Include/Chipset/ArmV7.h
+++ b/ArmPkg/Include/Chipset/ArmV7.h
@@ -7,8 +7,8 @@
**/
-#ifndef __ARM_V7_H__
-#define __ARM_V7_H__
+#ifndef ARM_V7_H_
+#define ARM_V7_H_
#include <Chipset/ArmV7Mmu.h>
@@ -120,4 +120,4 @@ ArmWriteNsacr (
IN UINT32 Nsacr
);
-#endif // __ARM_V7_H__
+#endif // ARM_V7_H_
diff --git a/ArmPkg/Include/Chipset/ArmV7Mmu.h b/ArmPkg/Include/Chipset/ArmV7Mmu.h
index 25d82d029795..87c443df3fce 100644
--- a/ArmPkg/Include/Chipset/ArmV7Mmu.h
+++ b/ArmPkg/Include/Chipset/ArmV7Mmu.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARMV7_MMU_H_
-#define __ARMV7_MMU_H_
+#ifndef ARMV7_MMU_H_
+#define ARMV7_MMU_H_
#define TTBR_NOT_OUTER_SHAREABLE BIT5
#define TTBR_RGN_OUTER_NON_CACHEABLE 0
@@ -235,4 +235,4 @@ ConvertSectionAttributesToPageAttributes (
IN BOOLEAN IsLargePage
);
-#endif
+#endif // ARMV7_MMU_H_
diff --git a/ArmPkg/Include/Guid/ArmMpCoreInfo.h b/ArmPkg/Include/Guid/ArmMpCoreInfo.h
index 3f9d17bb72c0..b810767879ae 100644
--- a/ArmPkg/Include/Guid/ArmMpCoreInfo.h
+++ b/ArmPkg/Include/Guid/ArmMpCoreInfo.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_MP_CORE_INFO_GUID_H_
-#define __ARM_MP_CORE_INFO_GUID_H_
+#ifndef ARM_MP_CORE_INFO_GUID_H_
+#define ARM_MP_CORE_INFO_GUID_H_
#define MAX_CPUS_PER_MPCORE_SYSTEM 0x04
#define SCU_CONFIG_REG_OFFSET 0x04
@@ -57,4 +57,4 @@ typedef struct {
extern EFI_GUID gArmMpCoreInfoGuid;
-#endif /* MPCOREINFO_H_ */
+#endif /* ARM_MP_CORE_INFO_GUID_H_ */
diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
index 71a5398558b8..33d60ccf17bc 100644
--- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_MM_SVC_H__
-#define __ARM_MM_SVC_H__
+#ifndef ARM_MM_SVC_H_
+#define ARM_MM_SVC_H_
/*
* SVC IDs to allow the MM secure partition to initialise itself, handle
@@ -44,4 +44,4 @@
#define SPM_MAJOR_VERSION 0
#define SPM_MINOR_VERSION 1
-#endif
+#endif // ARM_MM_SVC_H_
diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
index 9e0a3a3960d5..67afb0ea2d3d 100644
--- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
@@ -10,8 +10,8 @@
* (https://developer.arm.com/documentation/den0028/c/?lang=en)
**/
-#ifndef __ARM_STD_SMC_H__
-#define __ARM_STD_SMC_H__
+#ifndef ARM_STD_SMC_H_
+#define ARM_STD_SMC_H_
/*
* SMC function IDs for Standard Service queries
@@ -129,4 +129,4 @@
/* 0xbf00ff02 is reserved */
#define ARM_SMC_ID_TOS_REVISION 0xbf00ff03
-#endif
+#endif // ARM_STD_SMC_H_
diff --git a/ArmPkg/Include/Library/ArmDisassemblerLib.h b/ArmPkg/Include/Library/ArmDisassemblerLib.h
index c103b72e8127..d8c7af029dd3 100644
--- a/ArmPkg/Include/Library/ArmDisassemblerLib.h
+++ b/ArmPkg/Include/Library/ArmDisassemblerLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_DISASSEBLER_LIB_H__
-#define __ARM_DISASSEBLER_LIB_H__
+#ifndef ARM_DISASSEMBLER_LIB_H_
+#define ARM_DISASSEMBLER_LIB_H_
/**
Place a disassembly of **OpCodePtr into buffer, and update OpCodePtr to
@@ -34,4 +34,4 @@ DisassembleInstruction (
OUT UINTN Size
);
-#endif
+#endif // ARM_DISASSEMBLER_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h b/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h
index d3051be30f2d..96bdffbf1ee3 100644
--- a/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h
+++ b/ArmPkg/Include/Library/ArmGenericTimerCounterLib.h
@@ -7,8 +7,8 @@
**/
-#ifndef __ARM_GENERIC_TIMER_COUNTER_LIB_H__
-#define __ARM_GENERIC_TIMER_COUNTER_LIB_H__
+#ifndef ARM_GENERIC_TIMER_COUNTER_LIB_H_
+#define ARM_GENERIC_TIMER_COUNTER_LIB_H_
VOID
EFIAPI
@@ -82,4 +82,4 @@ ArmGenericTimerSetCompareVal (
IN UINT64 Value
);
-#endif
+#endif // ARM_GENERIC_TIMER_COUNTER_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h
index 264322f1d0df..b3635d226866 100644
--- a/ArmPkg/Include/Library/ArmGicArchLib.h
+++ b/ArmPkg/Include/Library/ArmGicArchLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_GIC_ARCH_LIB_H__
-#define __ARM_GIC_ARCH_LIB_H__
+#ifndef ARM_GIC_ARCH_LIB_H_
+#define ARM_GIC_ARCH_LIB_H_
//
// GIC definitions
@@ -24,4 +24,4 @@ ArmGicGetSupportedArchRevision (
VOID
);
-#endif
+#endif // ARM_GIC_ARCH_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmHvcLib.h b/ArmPkg/Include/Library/ArmHvcLib.h
index d26f0cff31eb..d202c2af6ee3 100644
--- a/ArmPkg/Include/Library/ArmHvcLib.h
+++ b/ArmPkg/Include/Library/ArmHvcLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_HVC_LIB__
-#define __ARM_HVC_LIB__
+#ifndef ARM_HVC_LIB_H_
+#define ARM_HVC_LIB_H_
/**
* The size of the HVC arguments are different between AArch64 and AArch32.
@@ -37,4 +37,4 @@ ArmCallHvc (
IN OUT ARM_HVC_ARGS *Args
);
-#endif
+#endif // ARM_HVC_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
index 70b9d816b74c..5c232d779c83 100644
--- a/ArmPkg/Include/Library/ArmLib.h
+++ b/ArmPkg/Include/Library/ArmLib.h
@@ -8,8 +8,8 @@
**/
-#ifndef __ARM_LIB__
-#define __ARM_LIB__
+#ifndef ARM_LIB_H_
+#define ARM_LIB_H_
#include <Uefi/UefiBaseType.h>
@@ -753,4 +753,4 @@ ArmHasSecurityExtensions (
);
#endif // MDE_CPU_ARM
-#endif // __ARM_LIB__
+#endif // ARM_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmMmuLib.h b/ArmPkg/Include/Library/ArmMmuLib.h
index 23e89a0c6584..410f06ce373c 100644
--- a/ArmPkg/Include/Library/ArmMmuLib.h
+++ b/ArmPkg/Include/Library/ArmMmuLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_MMU_LIB__
-#define __ARM_MMU_LIB__
+#ifndef ARM_MMU_LIB_H_
+#define ARM_MMU_LIB_H_
#include <Uefi/UefiBaseType.h>
@@ -64,4 +64,4 @@ ArmSetMemoryAttributes (
IN UINT64 Attributes
);
-#endif
+#endif // ARM_MMU_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmSmcLib.h b/ArmPkg/Include/Library/ArmSmcLib.h
index 835d6788e0b9..ced60b3c1147 100644
--- a/ArmPkg/Include/Library/ArmSmcLib.h
+++ b/ArmPkg/Include/Library/ArmSmcLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_SMC_LIB__
-#define __ARM_SMC_LIB__
+#ifndef ARM_SMC_LIB_H_
+#define ARM_SMC_LIB_H_
/**
* The size of the SMC arguments are different between AArch64 and AArch32.
@@ -37,4 +37,4 @@ ArmCallSmc (
IN OUT ARM_SMC_ARGS *Args
);
-#endif
+#endif // ARM_SMC_LIB_H_
diff --git a/ArmPkg/Include/Library/ArmSvcLib.h b/ArmPkg/Include/Library/ArmSvcLib.h
index a4414270f3b9..d4a1a8f11863 100644
--- a/ArmPkg/Include/Library/ArmSvcLib.h
+++ b/ArmPkg/Include/Library/ArmSvcLib.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_SVC_LIB__
-#define __ARM_SVC_LIB__
+#ifndef ARM_SVC_LIB_H_
+#define ARM_SVC_LIB_H_
/**
* The size of the SVC arguments are different between AArch64 and AArch32.
@@ -43,4 +43,4 @@ ArmCallSvc (
IN OUT ARM_SVC_ARGS *Args
);
-#endif
+#endif // ARM_SVC_LIB_H_
diff --git a/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h b/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h
index bbcf30f85752..57dc555e1332 100644
--- a/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h
+++ b/ArmPkg/Include/Library/DefaultExceptionHandlerLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __DEFAULT_EXCEPTION_HANDLER_LIB_H__
-#define __DEFAULT_EXCEPTION_HANDLER_LIB_H__
+#ifndef DEFAULT_EXCEPTION_HANDLER_LIB_H_
+#define DEFAULT_EXCEPTION_HANDLER_LIB_H_
/**
This is the default action to take on an unexpected exception
@@ -22,4 +22,4 @@ DefaultExceptionHandler (
IN OUT EFI_SYSTEM_CONTEXT SystemContext
);
-#endif
+#endif // DEFAULT_EXCEPTION_HANDLER_LIB_H_
diff --git a/ArmPkg/Include/Library/OpteeLib.h b/ArmPkg/Include/Library/OpteeLib.h
index 8ceab117d132..b9399d2e1810 100644
--- a/ArmPkg/Include/Library/OpteeLib.h
+++ b/ArmPkg/Include/Library/OpteeLib.h
@@ -8,8 +8,8 @@
**/
-#ifndef _OPTEE_H_
-#define _OPTEE_H_
+#ifndef OPTEE_LIB_H_
+#define OPTEE_LIB_H_
/*
* The 'Trusted OS Call UID' is supposed to return the following UUID for
@@ -117,4 +117,4 @@ OpteeInvokeFunction (
IN OUT OPTEE_INVOKE_FUNCTION_ARG *InvokeFunctionArg
);
-#endif
+#endif // OPTEE_LIB_H_
diff --git a/ArmPkg/Include/Library/SemihostLib.h b/ArmPkg/Include/Library/SemihostLib.h
index ce08b2778d72..590728c804f4 100644
--- a/ArmPkg/Include/Library/SemihostLib.h
+++ b/ArmPkg/Include/Library/SemihostLib.h
@@ -7,8 +7,8 @@
**/
-#ifndef __SEMIHOSTING_H__
-#define __SEMIHOSTING_H__
+#ifndef SEMIHOSTING_LIB_H_
+#define SEMIHOSTING_LIB_H_
/*
*
@@ -129,4 +129,4 @@ SemihostSystem (
IN CHAR8 *CommandLine
);
-#endif // __SEMIHOSTING_H__
+#endif // SEMIHOSTING_LIB_H_
diff --git a/ArmPkg/Include/Library/StandaloneMmMmuLib.h b/ArmPkg/Include/Library/StandaloneMmMmuLib.h
index 1d2a0e0c2bac..ccc016d0350a 100644
--- a/ArmPkg/Include/Library/StandaloneMmMmuLib.h
+++ b/ArmPkg/Include/Library/StandaloneMmMmuLib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __STANDALONEMM_MMU_LIB__
-#define __STANDALONEMM_MMU_LIB__
+#ifndef STANDALONE_MM_MMU_LIB_
+#define STANDALONE_MM_MMU_LIB_
EFI_STATUS
ArmSetMemoryRegionNoExec (
@@ -33,4 +33,4 @@ ArmClearMemoryRegionReadOnly (
IN UINT64 Length
);
-#endif /* __STANDALONEMM_MMU_LIB__ */
+#endif /* STANDALONE_MM_MMU_LIB_ */
diff --git a/ArmPkg/Include/Ppi/ArmMpCoreInfo.h b/ArmPkg/Include/Ppi/ArmMpCoreInfo.h
index 871119bde2f0..b1e404ce1364 100644
--- a/ArmPkg/Include/Ppi/ArmMpCoreInfo.h
+++ b/ArmPkg/Include/Ppi/ArmMpCoreInfo.h
@@ -6,8 +6,8 @@
*
**/
-#ifndef __ARM_MP_CORE_INFO_PPI_H__
-#define __ARM_MP_CORE_INFO_PPI_H__
+#ifndef ARM_MP_CORE_INFO_PPI_H_
+#define ARM_MP_CORE_INFO_PPI_H_
#include <Guid/ArmMpCoreInfo.h>
@@ -49,4 +49,4 @@ typedef struct {
extern EFI_GUID gArmMpCoreInfoPpiGuid;
extern EFI_GUID gArmMpCoreInfoGuid;
-#endif
+#endif // ARM_MP_CORE_INFO_PPI_H_
diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
index cfc0c878a415..318020277b24 100644
--- a/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
+++ b/ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h
@@ -8,8 +8,8 @@
**/
-#ifndef __AARCH64_LIB_H__
-#define __AARCH64_LIB_H__
+#ifndef AARCH64_LIB_H_
+#define AARCH64_LIB_H_
typedef VOID (*AARCH64_CACHE_OPERATION)(UINTN);
@@ -52,5 +52,5 @@ ArmReadIdAA64Mmfr2 (
VOID
);
-#endif // __AARCH64_LIB_H__
+#endif // AARCH64_LIB_H_
diff --git a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h
index dcf6723b803b..5a92ade2b313 100644
--- a/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h
+++ b/ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h
@@ -6,8 +6,8 @@
**/
-#ifndef __ARM_V7_LIB_H__
-#define __ARM_V7_LIB_H__
+#ifndef ARM_V7_LIB_H_
+#define ARM_V7_LIB_H_
#define ID_MMFR0_SHARELVL_SHIFT 12
#define ID_MMFR0_SHARELVL_MASK 0xf
@@ -64,5 +64,5 @@ ArmReadIdPfr1 (
VOID
);
-#endif // __ARM_V7_LIB_H__
+#endif // ARM_V7_LIB_H_
diff --git a/ArmPkg/Library/ArmLib/ArmLibPrivate.h b/ArmPkg/Library/ArmLib/ArmLibPrivate.h
index 1818a1994dc3..5db83d620bfc 100644
--- a/ArmPkg/Library/ArmLib/ArmLibPrivate.h
+++ b/ArmPkg/Library/ArmLib/ArmLibPrivate.h
@@ -8,8 +8,8 @@
**/
-#ifndef __ARM_LIB_PRIVATE_H__
-#define __ARM_LIB_PRIVATE_H__
+#ifndef ARM_LIB_PRIVATE_H_
+#define ARM_LIB_PRIVATE_H_
#define CACHE_SIZE_4_KB (3UL)
#define CACHE_SIZE_8_KB (4UL)
@@ -186,4 +186,4 @@ ReadCLIDR (
VOID
);
-#endif // __ARM_LIB_PRIVATE_H__
+#endif // ARM_LIB_PRIVATE_H_
diff --git a/ArmPkg/Library/OpteeLib/OpteeSmc.h b/ArmPkg/Library/OpteeLib/OpteeSmc.h
index 62319d718dc5..b760ec8f8227 100644
--- a/ArmPkg/Library/OpteeLib/OpteeSmc.h
+++ b/ArmPkg/Library/OpteeLib/OpteeSmc.h
@@ -7,8 +7,8 @@
**/
-#ifndef _OPTEE_SMC_H_
-#define _OPTEE_SMC_H_
+#ifndef OPTEE_SMC_H_
+#define OPTEE_SMC_H_
/* Returned in Arg0 only from Trusted OS functions */
#define OPTEE_SMC_RETURN_OK 0x0
@@ -47,4 +47,4 @@ typedef struct {
UINT8 Data4[8];
} RFC4122_UUID;
-#endif
+#endif // OPTEE_SMC_H_
diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
index 0bb3645ddc47..a40a2ff5cb4f 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.h
@@ -9,8 +9,8 @@
**/
-#ifndef _PLATFORM_BM_H_
-#define _PLATFORM_BM_H_
+#ifndef PLATFORM_BM_H_
+#define PLATFORM_BM_H_
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
@@ -50,4 +50,4 @@ DisableQuietBoot (
VOID
);
-#endif // _PLATFORM_BM_H_
+#endif // PLATFORM_BM_H_
diff --git a/ArmPkg/Library/SemihostLib/SemihostPrivate.h b/ArmPkg/Library/SemihostLib/SemihostPrivate.h
index 30103b04b53f..886472611623 100644
--- a/ArmPkg/Library/SemihostLib/SemihostPrivate.h
+++ b/ArmPkg/Library/SemihostLib/SemihostPrivate.h
@@ -7,8 +7,8 @@
**/
-#ifndef __SEMIHOST_PRIVATE_H__
-#define __SEMIHOST_PRIVATE_H__
+#ifndef SEMIHOST_PRIVATE_H_
+#define SEMIHOST_PRIVATE_H_
typedef struct {
CHAR8 *FileName;
@@ -209,4 +209,4 @@ GccSemihostCall (
#endif // __CC_ARM
-#endif //__SEMIHOST_PRIVATE_H__
+#endif // SEMIHOST_PRIVATE_H_
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 34250 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-21 12:20 ` [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003 PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 9:40 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
` (9 subsequent siblings)
11 siblings, 1 reply; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
Non-Boolean comparisons should use a compare operator
(==, !=, >, < >=, <=)
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 5f453d18e415..31672ae5cf4d 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -101,7 +101,7 @@ SendMemoryPermissionRequest (
}
// Check error response from Callee.
- if (*RetVal & BIT31) {
+ if ((*RetVal & BIT31) != 0) {
// Bit 31 set means there is an error retured
// See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and
// Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64.
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib
2021-04-21 12:20 ` [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
@ 2021-04-22 9:40 ` Sami Mujawar
0 siblings, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 9:40 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com, nd
[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
Non-Boolean comparisons should use a compare operator
(==, !=, >, < >=, <=)
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 5f453d18e415..31672ae5cf4d 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -101,7 +101,7 @@ SendMemoryPermissionRequest (
}
// Check error response from Callee.
- if (*RetVal & BIT31) {
+ if ((*RetVal & BIT31) != 0) {
// Bit 31 set means there is an error retured
// See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and
// Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64.
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 4566 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
2021-04-21 12:20 ` [PATCH v1 01/12] ArmPkg: Fix Ecc error 8003 PierreGondois
2021-04-21 12:20 ` [PATCH v1 02/12] ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-21 19:13 ` [edk2-devel] " brbarkel
2021-04-22 9:51 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
` (8 subsequent siblings)
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Some library headers are missing/incorrect in ArmPkg.dec.
This makes the 'LibraryClassCheck' CI test fail. This patch
adds/corrects them.
According to .pytool/Readme about the 'LibraryClassCheck' test:
This test scans at all library header files found in the
`Library` folders in all of the package's declared include
directories and ensures that all files have a matching
LibraryClass declaration in the DEC file for the package.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3254
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3258
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/ArmPkg.dec | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index a8a22c649ff8..496f588bd0ca 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -2,7 +2,7 @@
# ARM processor package.
#
# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
-# Copyright (c) 2011 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -29,14 +29,20 @@ [Includes.common]
[LibraryClasses.common]
ArmLib|Include/Library/ArmLib.h
ArmMmuLib|Include/Library/ArmMmuLib.h
- SemihostLib|Include/Library/Semihosting.h
+ SemihostLib|Include/Library/SemihostLib.h
DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h
ArmDisassemblerLib|Include/Library/ArmDisassemblerLib.h
ArmGicArchLib|Include/Library/ArmGicArchLib.h
- ArmMtlLib|ArmPlatformPkg/Include/Library/ArmMtlLib.h
+ ArmMtlLib|Include/Library/ArmMtlLib.h
ArmSvcLib|Include/Library/ArmSvcLib.h
OpteeLib|Include/Library/OpteeLib.h
StandaloneMmMmuLib|Include/Library/StandaloneMmMmuLib.h
+ ArmGenericTimerCounterLib|Include/Library/ArmGenericTimerCounterLib.h
+ ArmGicLib|Include/Library/ArmGicLib.h
+ ArmHvcLib|Include/Library/ArmHvcLib.h
+ OemMiscLib|Include/Library/OemMiscLib.h
+ ArmSmcLib|Include/Library/ArmSmcLib.h
+
[Guids.common]
gArmTokenSpaceGuid = { 0xBB11ECFE, 0x820F, 0x4968, { 0xBB, 0xA6, 0xF7, 0x6A, 0xFE, 0x30, 0x25, 0x96 } }
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
@ 2021-04-21 19:13 ` brbarkel
2021-04-26 16:40 ` PierreGondois
2021-04-22 9:51 ` Sami Mujawar
1 sibling, 1 reply; 35+ messages in thread
From: brbarkel @ 2021-04-21 19:13 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
1) To expedite the required reviews, you may want to add CC to the package maintainers for ArmPkg to this commit message and email. I know a lot of people filter based on direct mention vs mailing list.
2) Generally, other packages have a brief description of the lib in the DEC, as well. Example:
https://github.com/tianocore/edk2/blob/d3b0d007a135284981fa750612a47234b83976f9/MdeModulePkg/MdeModulePkg.dec#L55
However, I see that this has not historically been maintained in this package, so I'm not going to make a big deal of it.
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
[-- Attachment #2: Type: text/html, Size: 793 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
2021-04-21 19:13 ` [edk2-devel] " brbarkel
@ 2021-04-26 16:40 ` PierreGondois
2021-04-26 20:58 ` [EXTERNAL] " Bret Barkelew
0 siblings, 1 reply; 35+ messages in thread
From: PierreGondois @ 2021-04-26 16:40 UTC (permalink / raw)
To: devel, brbarkel
Hi Bret,
Ok I will do that in a V2.
Do these patches look ok to you ?
[PATCH v1 08/12] .pytool: Enable CI for ArmPkg
[PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
[PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
[PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
[PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
Regards,
Pierre
On 4/21/21 8:13 PM, brbarkel via groups.io wrote:
>
> 1) To expedite the required reviews, you may want to add CC to the
> package maintainers for ArmPkg to this commit message and email. I
> know a lot of people filter based on direct mention vs mailing list.
>
> 2) Generally, other packages have a brief description of the lib in
> the DEC, as well. Example:
> https://github.com/tianocore/edk2/blob/d3b0d007a135284981fa750612a47234b83976f9/MdeModulePkg/MdeModulePkg.dec#L55
> <https://github.com/tianocore/edk2/blob/d3b0d007a135284981fa750612a47234b83976f9/MdeModulePkg/MdeModulePkg.dec#L55>
> However, I see that this has not historically been maintained in this
> package, so I'm not going to make a big deal of it.
>
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
>
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
2021-04-26 16:40 ` PierreGondois
@ 2021-04-26 20:58 ` Bret Barkelew
0 siblings, 0 replies; 35+ messages in thread
From: Bret Barkelew @ 2021-04-26 20:58 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io
[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]
Those look good to me. Made one comment on 12/12. Also screwed up my hyphen on 8, 9, 10, and 12.
- Bret
From: Pierre Gondois<mailto:pierre.gondois@arm.com>
Sent: Monday, April 26, 2021 9:40 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
Hi Bret,
Ok I will do that in a V2.
Do these patches look ok to you ?
[PATCH v1 08/12] .pytool: Enable CI for ArmPkg
[PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
[PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
[PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
[PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
Regards,
Pierre
On 4/21/21 8:13 PM, brbarkel via groups.io wrote:
>
> 1) To expedite the required reviews, you may want to add CC to the
> package maintainers for ArmPkg to this commit message and email. I
> know a lot of people filter based on direct mention vs mailing list.
>
> 2) Generally, other packages have a brief description of the lib in
> the DEC, as well. Example:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9%2FMdeModulePkg%2FMdeModulePkg.dec%23L55&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&reserved=0
> <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fd3b0d007a135284981fa750612a47234b83976f9%2FMdeModulePkg%2FMdeModulePkg.dec%23L55&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C11a94a7986c94a1dc9dd08d908d20f74%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637550520568164761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MsbriQVK47dxlgZxsTWgpiKS0XM8FOVwFY5askVkvAA%3D&reserved=0>
> However, I see that this has not historically been maintained in this
> package, so I'm not going to make a big deal of it.
>
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
>
>
[-- Attachment #2: Type: text/html, Size: 5399 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
2021-04-21 19:13 ` [edk2-devel] " brbarkel
@ 2021-04-22 9:51 ` Sami Mujawar
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 9:51 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
[-- Attachment #1: Type: text/plain, Size: 3179 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec
From: Pierre Gondois <Pierre.Gondois@arm.com>
Some library headers are missing/incorrect in ArmPkg.dec.
This makes the 'LibraryClassCheck' CI test fail. This patch
adds/corrects them.
According to .pytool/Readme about the 'LibraryClassCheck' test:
This test scans at all library header files found in the
`Library` folders in all of the package's declared include
directories and ensures that all files have a matching
LibraryClass declaration in the DEC file for the package.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3254
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3258
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/ArmPkg.dec | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
index a8a22c649ff8..496f588bd0ca 100644
--- a/ArmPkg/ArmPkg.dec
+++ b/ArmPkg/ArmPkg.dec
@@ -2,7 +2,7 @@
# ARM processor package.
#
# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
-# Copyright (c) 2011 - 2018, ARM Limited. All rights reserved.
+# Copyright (c) 2011 - 2021, ARM Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -29,14 +29,20 @@ [Includes.common]
[LibraryClasses.common]
ArmLib|Include/Library/ArmLib.h
ArmMmuLib|Include/Library/ArmMmuLib.h
- SemihostLib|Include/Library/Semihosting.h
+ SemihostLib|Include/Library/SemihostLib.h
DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h
ArmDisassemblerLib|Include/Library/ArmDisassemblerLib.h
ArmGicArchLib|Include/Library/ArmGicArchLib.h
- ArmMtlLib|ArmPlatformPkg/Include/Library/ArmMtlLib.h
+ ArmMtlLib|Include/Library/ArmMtlLib.h
ArmSvcLib|Include/Library/ArmSvcLib.h
OpteeLib|Include/Library/OpteeLib.h
StandaloneMmMmuLib|Include/Library/StandaloneMmMmuLib.h
+ ArmGenericTimerCounterLib|Include/Library/ArmGenericTimerCounterLib.h
+ ArmGicLib|Include/Library/ArmGicLib.h
+ ArmHvcLib|Include/Library/ArmHvcLib.h
+ OemMiscLib|Include/Library/OemMiscLib.h
+ ArmSmcLib|Include/Library/ArmSmcLib.h
+
[Guids.common]
gArmTokenSpaceGuid = { 0xBB11ECFE, 0x820F, 0x4968, { 0xBB, 0xA6, 0xF7, 0x6A, 0xFE, 0x30, 0x25, 0x96 } }
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 6321 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (2 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-21 19:14 ` [edk2-devel] " brbarkel
2021-04-22 9:52 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 05/12] ArmPkg: Correct small typos PierreGondois
` (7 subsequent siblings)
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add the OemMiscLibNull library to the [Components] section of
ArmPkg.dsc, allowing to complete the 'DscCompleteCheck' CI test.
According to .pytool/Readme about the 'DscCompleteCheck' test:
The test considers it an error if any INF does not appear in the
`Components` section of the package-level DSC.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3258
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/ArmPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 282950b953a8..926986cf7fbb 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -156,6 +156,7 @@ [Components.common]
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
+ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
[Components.AARCH64]
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [edk2-devel] [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
@ 2021-04-21 19:14 ` brbarkel
2021-04-22 9:52 ` Sami Mujawar
1 sibling, 0 replies; 35+ messages in thread
From: brbarkel @ 2021-04-21 19:14 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 111 bytes --]
Same comment about CC to the package maintainers.
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
[-- Attachment #2: Type: text/html, Size: 125 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
2021-04-21 19:14 ` [edk2-devel] " brbarkel
@ 2021-04-22 9:52 ` Sami Mujawar
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 9:52 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com, nd
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add the OemMiscLibNull library to the [Components] section of
ArmPkg.dsc, allowing to complete the 'DscCompleteCheck' CI test.
According to .pytool/Readme about the 'DscCompleteCheck' test:
The test considers it an error if any INF does not appear in the
`Components` section of the package-level DSC.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3258
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/ArmPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 282950b953a8..926986cf7fbb 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -156,6 +156,7 @@ [Components.common]
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf
+ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
[Components.AARCH64]
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 4606 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 05/12] ArmPkg: Correct small typos
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (3 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 9:53 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
` (6 subsequent siblings)
11 siblings, 1 reply; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
The 'cspell' CI test detected some small typos in ArmPkg.
Correct them.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 2 +-
ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +-
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 4 ++--
ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c | 6 +++---
.../StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +-
.../SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 2 +-
.../Type13/MiscNumberOfInstallableLanguagesFunction.c | 6 +++---
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
index 6c58d2b49317..54fad23cb42d 100644
--- a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
+++ b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
@@ -345,7 +345,7 @@ EfiAttributeToArmAttribute (
break;
case EFI_MEMORY_WC:
- // Map to normal non-cachable
+ // Map to normal non-cacheable
ArmAttributes = TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0
break;
diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
index 6a06b38ab949..c5036b7b5c70 100644
--- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
+++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
@@ -51,7 +51,7 @@ EFI_FILE gSemihostFsFile = {
};
//
-// Device path for semi-hosting. It contains our autogened Caller ID GUID.
+// Device path for semi-hosting. It contains our auto-generated Caller ID GUID.
//
typedef struct {
VENDOR_DEVICE_PATH Guid;
diff --git a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
index 940e4bc797f2..6b9d7eba90b9 100644
--- a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
+++ b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
@@ -124,7 +124,7 @@ UpdatePageEntries (
} else if ((Attributes & EFI_MEMORY_WC) != 0) {
// modify cacheability attributes
EntryMask |= TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK;
- // map to normal non-cachable
+ // map to normal non-cacheable
EntryValue |= TT_DESCRIPTOR_PAGE_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0
} else if ((Attributes & EFI_MEMORY_WT) != 0) {
// modify cacheability attributes
@@ -254,7 +254,7 @@ UpdateSectionEntries (
} else if ((Attributes & EFI_MEMORY_WC) != 0) {
// modify cacheability attributes
EntryMask |= TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK;
- // map to normal non-cachable
+ // map to normal non-cacheable
EntryValue |= TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0
} else if ((Attributes & EFI_MEMORY_WT) != 0) {
// modify cacheability attributes
diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
index e35bcee38098..b6a07dd46608 100644
--- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
+++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
@@ -37,11 +37,11 @@ SerialPortInitialize (
/**
Write data to serial device.
- @param Buffer Point of data buffer which need to be writed.
+ @param Buffer Point of data buffer which need to be written.
@param NumberOfBytes Number of output bytes which are cached in Buffer.
@retval 0 Write data failed.
- @retval !0 Actual number of bytes writed to serial device.
+ @retval !0 Actual number of bytes written to serial device.
**/
@@ -103,7 +103,7 @@ SerialPortWrite (
/**
Read data from serial device and save the datas in buffer.
- @param Buffer Point of data buffer which need to be writed.
+ @param Buffer Point of data buffer which need to be written.
@param NumberOfBytes Number of output bytes which are cached in Buffer.
@retval 0 Read data failed.
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 31672ae5cf4d..dd014beec873 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -102,7 +102,7 @@ SendMemoryPermissionRequest (
// Check error response from Callee.
if ((*RetVal & BIT31) != 0) {
- // Bit 31 set means there is an error retured
+ // Bit 31 set means there is an error returned
// See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and
// Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64.
switch (*RetVal) {
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c
index 137bd941d0b1..29449b871902 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c
@@ -23,7 +23,7 @@ SMBIOS_MISC_TABLE_DATA(SMBIOS_TABLE_TYPE3, MiscChassisManufacturer) = {
0, // Length,
0 // Handle
},
- 1, // Manufactrurer
+ 1, // Manufacturer
MiscChassisTypeMainServerChassis, // Type
2, // Version
3, // SerialNumber
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
index 19b60ed71f8c..7c941b5c0709 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
@@ -23,9 +23,9 @@
/**
Get next language from language code list (with separator ';').
- @param LangCode Input: point to first language in the list. On
- Otput: point to next language in the list, or
- NULL if no more language in the list.
+ @param LangCode Input: point to first language in the list. On
+ Output: point to next language in the list, or
+ NULL if no more language in the list.
@param Lang The first language in the list.
**/
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 05/12] ArmPkg: Correct small typos
2021-04-21 12:20 ` [PATCH v1 05/12] ArmPkg: Correct small typos PierreGondois
@ 2021-04-22 9:53 ` Sami Mujawar
0 siblings, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 9:53 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com, nd
[-- Attachment #1: Type: text/plain, Size: 7802 bytes --]
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 05/12] ArmPkg: Correct small typos
From: Pierre Gondois <Pierre.Gondois@arm.com>
The 'cspell' CI test detected some small typos in ArmPkg.
Correct them.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 2 +-
ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +-
ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 4 ++--
ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c | 6 +++---
.../StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +-
.../SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 2 +-
.../Type13/MiscNumberOfInstallableLanguagesFunction.c | 6 +++---
7 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
index 6c58d2b49317..54fad23cb42d 100644
--- a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
+++ b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
@@ -345,7 +345,7 @@ EfiAttributeToArmAttribute (
break;
case EFI_MEMORY_WC:
- // Map to normal non-cachable
+ // Map to normal non-cacheable
ArmAttributes = TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0
break;
diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
index 6a06b38ab949..c5036b7b5c70 100644
--- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
+++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c
@@ -51,7 +51,7 @@ EFI_FILE gSemihostFsFile = {
};
//
-// Device path for semi-hosting. It contains our autogened Caller ID GUID.
+// Device path for semi-hosting. It contains our auto-generated Caller ID GUID.
//
typedef struct {
VENDOR_DEVICE_PATH Guid;
diff --git a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
index 940e4bc797f2..6b9d7eba90b9 100644
--- a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
+++ b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c
@@ -124,7 +124,7 @@ UpdatePageEntries (
} else if ((Attributes & EFI_MEMORY_WC) != 0) {
// modify cacheability attributes
EntryMask |= TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK;
- // map to normal non-cachable
+ // map to normal non-cacheable
EntryValue |= TT_DESCRIPTOR_PAGE_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0
} else if ((Attributes & EFI_MEMORY_WT) != 0) {
// modify cacheability attributes
@@ -254,7 +254,7 @@ UpdateSectionEntries (
} else if ((Attributes & EFI_MEMORY_WC) != 0) {
// modify cacheability attributes
EntryMask |= TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK;
- // map to normal non-cachable
+ // map to normal non-cacheable
EntryValue |= TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // TEX [2:0]= 001 = 0x2, B=0, C=0
} else if ((Attributes & EFI_MEMORY_WT) != 0) {
// modify cacheability attributes
diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
index e35bcee38098..b6a07dd46608 100644
--- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
+++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c
@@ -37,11 +37,11 @@ SerialPortInitialize (
/**
Write data to serial device.
- @param Buffer Point of data buffer which need to be writed.
+ @param Buffer Point of data buffer which need to be written.
@param NumberOfBytes Number of output bytes which are cached in Buffer.
@retval 0 Write data failed.
- @retval !0 Actual number of bytes writed to serial device.
+ @retval !0 Actual number of bytes written to serial device.
**/
@@ -103,7 +103,7 @@ SerialPortWrite (
/**
Read data from serial device and save the datas in buffer.
- @param Buffer Point of data buffer which need to be writed.
+ @param Buffer Point of data buffer which need to be written.
@param NumberOfBytes Number of output bytes which are cached in Buffer.
@retval 0 Read data failed.
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 31672ae5cf4d..dd014beec873 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -102,7 +102,7 @@ SendMemoryPermissionRequest (
// Check error response from Callee.
if ((*RetVal & BIT31) != 0) {
- // Bit 31 set means there is an error retured
+ // Bit 31 set means there is an error returned
// See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and
// Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64.
switch (*RetVal) {
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c
index 137bd941d0b1..29449b871902 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c
@@ -23,7 +23,7 @@ SMBIOS_MISC_TABLE_DATA(SMBIOS_TABLE_TYPE3, MiscChassisManufacturer) = {
0, // Length,
0 // Handle
},
- 1, // Manufactrurer
+ 1, // Manufacturer
MiscChassisTypeMainServerChassis, // Type
2, // Version
3, // SerialNumber
diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
index 19b60ed71f8c..7c941b5c0709 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c
@@ -23,9 +23,9 @@
/**
Get next language from language code list (with separator ';').
- @param LangCode Input: point to first language in the list. On
- Otput: point to next language in the list, or
- NULL if no more language in the list.
+ @param LangCode Input: point to first language in the list. On
+ Output: point to next language in the list, or
+ NULL if no more language in the list.
@param Lang The first language in the list.
**/
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 15140 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (4 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 05/12] ArmPkg: Correct small typos PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:02 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
` (5 subsequent siblings)
11 siblings, 1 reply; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add ArmPkg.ci.yaml to configure the CI for the
ArmPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/ArmPkg.ci.yaml | 222 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 222 insertions(+)
create mode 100644 ArmPkg/ArmPkg.ci.yaml
diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
new file mode 100644
index 000000000000..ba502cd647c9
--- /dev/null
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -0,0 +1,222 @@
+## @file
+# CI configuration for ArmPkg
+#
+# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ ## options defined .pytool/Plugin/LicenseCheck
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Library/ArmSoftFloatLib/berkeley-softfloat-3"
+ ]
+ },
+
+ ## options defined .pytool/Plugin/CompilerPlugin
+ "CompilerPlugin": {
+ "DscPath": "ArmPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+ "HostUnitTestCompilerPlugin": {
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/CharEncodingCheck
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/DependencyCheck
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "ArmPlatformPkg/ArmPlatformPkg.dec",
+ "ArmPkg/ArmPkg.dec",
+ "EmbeddedPkg/EmbeddedPkg.dec",
+ "MdeModulePkg/MdeModulePkg.dec",
+ "MdePkg/MdePkg.dec",
+ "ShellPkg/ShellPkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[
+ "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+ ],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[],
+ "IgnoreInf": []
+ },
+
+ ## options defined .pytool/Plugin/DscCompleteCheck
+ "DscCompleteCheck": {
+ "IgnoreInf": [],
+ "DscPath": "ArmPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+ "HostUnitTestDscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/GuidCheck
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": [],
+ },
+
+ ## options defined .pytool/Plugin/LibraryClassCheck
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined .pytool/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": False,
+ "IgnoreFiles": [
+ "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
+ ], # use gitignore syntax to ignore errors
+ # in matching files
+ "ExtendWords": [
+ "api's",
+ "ackintid",
+ "actlr",
+ "aeabi",
+ "ashldi",
+ "ashrdi",
+ "ccidx",
+ "ccsidr",
+ "clidr",
+ "clrex",
+ "clzsi",
+ "cpuactlr",
+ "csselr",
+ "ctzsi",
+ "cygdrive",
+ "cygpaths",
+ "datas",
+ "dcmpeq",
+ "dcmpge",
+ "dcmpgt",
+ "dcmple",
+ "dcmplt",
+ "ddisable",
+ "divdi",
+ "divsi",
+ "dmdepkg",
+ "drsub",
+ "eoi'ed",
+ "fcmpeq",
+ "fcmpge",
+ "fcmpgt",
+ "fcmple",
+ "fcmplt",
+ "ffreestanding",
+ "frsub",
+ "hisilicon",
+ "iccbpr",
+ "icciar",
+ "iccicr",
+ "icciidr",
+ "iccpmr",
+ "icdicer",
+ "icdicfr",
+ "icdictr",
+ "icdiser",
+ "icdisr",
+ "icdsgir",
+ "icenabler",
+ "intid",
+ "ipriority",
+ "irouter",
+ "isenabler",
+ "istatus",
+ "itargets",
+ "lable",
+ "ldivmod",
+ "ldmdb",
+ "ldmia",
+ "ldrbt",
+ "ldrex",
+ "ldrexb",
+ "ldrexd",
+ "ldrexh",
+ "ldrhbt",
+ "ldrht",
+ "ldrsb",
+ "ldrsbt",
+ "ldrsh",
+ "lshrdi",
+ "moddi",
+ "modsi",
+ "mpidr",
+ "muldi",
+ "mullu",
+ "nonshareable",
+ "nsacr",
+ "nsasedis",
+ "nuvia",
+ "oldit",
+ "readc",
+ "revsh",
+ "rfedb",
+ "sctlr",
+ "smccc",
+ "smlabb",
+ "smlabt",
+ "smlad",
+ "smladx",
+ "smlatb",
+ "smlatt",
+ "smlawb",
+ "smlawt",
+ "smlsd",
+ "smlsdx",
+ "smmla",
+ "smmlar",
+ "smmls",
+ "smmlsr",
+ "sourcery",
+ "srsdb",
+ "stmdb",
+ "stmia",
+ "strbt",
+ "strexb",
+ "strexd",
+ "strexh",
+ "strht",
+ "switchu",
+ "tpidrurw",
+ "ttbcr",
+ "typer",
+ "ucmpdi",
+ "udivdi",
+ "udivmoddi",
+ "udivsi",
+ "uefi's",
+ "uldiv",
+ "umoddi",
+ "umodsi",
+ "usada",
+ "vlpis",
+ "writec"
+ ], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [ # Standard Plugin defined paths that
+ "*.asm", "*.s" # should be ignore
+ ],
+ "AdditionalIncludePaths": [] # Additional paths to spell check
+ # (wildcards supported)
+ }
+}
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
2021-04-21 12:20 ` [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
@ 2021-04-22 10:02 ` Sami Mujawar
2021-04-27 14:30 ` PierreGondois
0 siblings, 1 reply; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:02 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com, nd
[-- Attachment #1: Type: text/plain, Size: 7593 bytes --]
Hi Pierre,
I have a few minor comments marked inline as [SAMI].
With those changed.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add ArmPkg.ci.yaml to configure the CI for the
ArmPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPkg/ArmPkg.ci.yaml | 222 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 222 insertions(+)
create mode 100644 ArmPkg/ArmPkg.ci.yaml
diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
new file mode 100644
index 000000000000..ba502cd647c9
--- /dev/null
+++ b/ArmPkg/ArmPkg.ci.yaml
@@ -0,0 +1,222 @@
+## @file
+# CI configuration for ArmPkg
+#
+# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ ## options defined .pytool/Plugin/LicenseCheck
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Library/ArmSoftFloatLib/berkeley-softfloat-3"
+ ]
+ },
+
+ ## options defined .pytool/Plugin/CompilerPlugin
+ "CompilerPlugin": {
+ "DscPath": "ArmPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+ "HostUnitTestCompilerPlugin": {
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/CharEncodingCheck
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/DependencyCheck
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "ArmPlatformPkg/ArmPlatformPkg.dec",
+ "ArmPkg/ArmPkg.dec",
+ "EmbeddedPkg/EmbeddedPkg.dec",
+ "MdeModulePkg/MdeModulePkg.dec",
+ "MdePkg/MdePkg.dec",
+ "ShellPkg/ShellPkg.dec"
[SAMI] Can this list be sorted in alphabetical order, please?
[/SAMI]
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[
+ "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+ ],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[],
+ "IgnoreInf": []
+ },
+
+ ## options defined .pytool/Plugin/DscCompleteCheck
+ "DscCompleteCheck": {
+ "IgnoreInf": [],
+ "DscPath": "ArmPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+ "HostUnitTestDscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/GuidCheck
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": [],
+ },
+
+ ## options defined .pytool/Plugin/LibraryClassCheck
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined .pytool/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": False,
+ "IgnoreFiles": [
+ "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
+ ], # use gitignore syntax to ignore errors
+ # in matching files
+ "ExtendWords": [
+ "api's",
+ "ackintid",
[SAMI] Can this list be sorted in alphabetical order, please?
[/SAMI]
+ "actlr",
+ "aeabi",
+ "ashldi",
+ "ashrdi",
+ "ccidx",
+ "ccsidr",
+ "clidr",
+ "clrex",
+ "clzsi",
+ "cpuactlr",
+ "csselr",
+ "ctzsi",
+ "cygdrive",
+ "cygpaths",
+ "datas",
+ "dcmpeq",
+ "dcmpge",
+ "dcmpgt",
+ "dcmple",
+ "dcmplt",
+ "ddisable",
+ "divdi",
+ "divsi",
+ "dmdepkg",
+ "drsub",
+ "eoi'ed",
[SAMI] I don’t think there is such a word. Should the original text be fixed?
[/SAMI]
+ "fcmpeq",
+ "fcmpge",
+ "fcmpgt",
+ "fcmple",
+ "fcmplt",
+ "ffreestanding",
+ "frsub",
+ "hisilicon",
+ "iccbpr",
+ "icciar",
+ "iccicr",
+ "icciidr",
+ "iccpmr",
+ "icdicer",
+ "icdicfr",
+ "icdictr",
+ "icdiser",
+ "icdisr",
+ "icdsgir",
+ "icenabler",
+ "intid",
+ "ipriority",
+ "irouter",
+ "isenabler",
+ "istatus",
+ "itargets",
+ "lable",
+ "ldivmod",
+ "ldmdb",
+ "ldmia",
+ "ldrbt",
+ "ldrex",
+ "ldrexb",
+ "ldrexd",
+ "ldrexh",
+ "ldrhbt",
+ "ldrht",
+ "ldrsb",
+ "ldrsbt",
+ "ldrsh",
+ "lshrdi",
+ "moddi",
+ "modsi",
+ "mpidr",
+ "muldi",
+ "mullu",
+ "nonshareable",
+ "nsacr",
+ "nsasedis",
+ "nuvia",
+ "oldit",
+ "readc",
+ "revsh",
+ "rfedb",
+ "sctlr",
+ "smccc",
+ "smlabb",
+ "smlabt",
+ "smlad",
+ "smladx",
+ "smlatb",
+ "smlatt",
+ "smlawb",
+ "smlawt",
+ "smlsd",
+ "smlsdx",
+ "smmla",
+ "smmlar",
+ "smmls",
+ "smmlsr",
+ "sourcery",
+ "srsdb",
+ "stmdb",
+ "stmia",
+ "strbt",
+ "strexb",
+ "strexd",
+ "strexh",
+ "strht",
+ "switchu",
+ "tpidrurw",
+ "ttbcr",
+ "typer",
+ "ucmpdi",
+ "udivdi",
+ "udivmoddi",
+ "udivsi",
+ "uefi's",
+ "uldiv",
+ "umoddi",
+ "umodsi",
+ "usada",
+ "vlpis",
+ "writec"
+ ], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [ # Standard Plugin defined paths that
+ "*.asm", "*.s" # should be ignore
+ ],
+ "AdditionalIncludePaths": [] # Additional paths to spell check
+ # (wildcards supported)
+ }
+}
--
2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 21800 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
2021-04-22 10:02 ` Sami Mujawar
@ 2021-04-27 14:30 ` PierreGondois
0 siblings, 0 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-27 14:30 UTC (permalink / raw)
To: Sami Mujawar, devel@edk2.groups.io, nd
Hi Sami,
I think the lists are already alphabetically ordered. I will re-order
the libraries in ArmPkg.dec though.
I will remove the "eio'ed" word from the exception list in a V2.
Thanks for the review,
Pierre
On 4/22/21 11:02 AM, Sami Mujawar wrote:
>
> Hi Pierre,
>
> I have a few minor comments marked inline as [SAMI].
>
> With those changed.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> *From: *Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> *Date: *Wednesday, 21 April 2021 at 13:21
> *To: *devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar
> <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>,
> ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>,
> sean.brogan@microsoft.com <sean.brogan@microsoft.com>,
> Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
> *Subject: *[PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml
>
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Add ArmPkg.ci.yaml to configure the CI for the
> ArmPkg.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> ArmPkg/ArmPkg.ci.yaml | 222 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 222 insertions(+)
> create mode 100644 ArmPkg/ArmPkg.ci.yaml
>
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> new file mode 100644
> index 000000000000..ba502cd647c9
> --- /dev/null
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -0,0 +1,222 @@
> +## @file
> +# CI configuration for ArmPkg
> +#
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> + ## options defined .pytool/Plugin/LicenseCheck
> + "LicenseCheck": {
> + "IgnoreFiles": []
> + },
> +
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": [
> + "Library/ArmSoftFloatLib/berkeley-softfloat-3"
> + ]
> + },
> +
> + ## options defined .pytool/Plugin/CompilerPlugin
> + "CompilerPlugin": {
> + "DscPath": "ArmPkg.dsc"
> + },
> +
> + ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
> + "HostUnitTestCompilerPlugin": {
> + "DscPath": "" # Don't support this test
> + },
> +
> + ## options defined .pytool/Plugin/CharEncodingCheck
> + "CharEncodingCheck": {
> + "IgnoreFiles": []
> + },
> +
> + ## options defined .pytool/Plugin/DependencyCheck
> + "DependencyCheck": {
> + "AcceptableDependencies": [
> + "ArmPlatformPkg/ArmPlatformPkg.dec",
> + "ArmPkg/ArmPkg.dec",
> + "EmbeddedPkg/EmbeddedPkg.dec",
> + "MdeModulePkg/MdeModulePkg.dec",
> + "MdePkg/MdePkg.dec",
> + "ShellPkg/ShellPkg.dec"
>
> [SAMI] Can this list be sorted in alphabetical order, please?
>
> [/SAMI]
> + ],
> + # For host based unit tests
> + "AcceptableDependencies-HOST_APPLICATION":[
> + "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
> + ],
> + # For UEFI shell based apps
> + "AcceptableDependencies-UEFI_APPLICATION":[],
> + "IgnoreInf": []
> + },
> +
> + ## options defined .pytool/Plugin/DscCompleteCheck
> + "DscCompleteCheck": {
> + "IgnoreInf": [],
> + "DscPath": "ArmPkg.dsc"
> + },
> +
> + ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
> + "HostUnitTestDscCompleteCheck": {
> + "IgnoreInf": [""],
> + "DscPath": "" # Don't support this test
> + },
> +
> + ## options defined .pytool/Plugin/GuidCheck
> + "GuidCheck": {
> + "IgnoreGuidName": [],
> + "IgnoreGuidValue": [],
> + "IgnoreFoldersAndFiles": [],
> + "IgnoreDuplicates": [],
> + },
> +
> + ## options defined .pytool/Plugin/LibraryClassCheck
> + "LibraryClassCheck": {
> + "IgnoreHeaderFile": []
> + },
> +
> + ## options defined .pytool/Plugin/SpellCheck
> + "SpellCheck": {
> + "AuditOnly": False,
> + "IgnoreFiles": [
> + "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
> + ], # use gitignore syntax to ignore
> errors
> + # in matching files
> + "ExtendWords": [
> + "api's",
> + "ackintid",
>
> [SAMI] Can this list be sorted in alphabetical order, please?
>
> [/SAMI]
> + "actlr",
> + "aeabi",
> + "ashldi",
> + "ashrdi",
> + "ccidx",
> + "ccsidr",
> + "clidr",
> + "clrex",
> + "clzsi",
> + "cpuactlr",
> + "csselr",
> + "ctzsi",
> + "cygdrive",
> + "cygpaths",
> + "datas",
> + "dcmpeq",
> + "dcmpge",
> + "dcmpgt",
> + "dcmple",
> + "dcmplt",
> + "ddisable",
> + "divdi",
> + "divsi",
> + "dmdepkg",
> + "drsub",
> + "eoi'ed",
>
> [SAMI] I don’t think there is such a word. Should the original text be
> fixed?
>
> [/SAMI]
> + "fcmpeq",
> + "fcmpge",
> + "fcmpgt",
> + "fcmple",
> + "fcmplt",
> + "ffreestanding",
> + "frsub",
> + "hisilicon",
> + "iccbpr",
> + "icciar",
> + "iccicr",
> + "icciidr",
> + "iccpmr",
> + "icdicer",
> + "icdicfr",
> + "icdictr",
> + "icdiser",
> + "icdisr",
> + "icdsgir",
> + "icenabler",
> + "intid",
> + "ipriority",
> + "irouter",
> + "isenabler",
> + "istatus",
> + "itargets",
> + "lable",
> + "ldivmod",
> + "ldmdb",
> + "ldmia",
> + "ldrbt",
> + "ldrex",
> + "ldrexb",
> + "ldrexd",
> + "ldrexh",
> + "ldrhbt",
> + "ldrht",
> + "ldrsb",
> + "ldrsbt",
> + "ldrsh",
> + "lshrdi",
> + "moddi",
> + "modsi",
> + "mpidr",
> + "muldi",
> + "mullu",
> + "nonshareable",
> + "nsacr",
> + "nsasedis",
> + "nuvia",
> + "oldit",
> + "readc",
> + "revsh",
> + "rfedb",
> + "sctlr",
> + "smccc",
> + "smlabb",
> + "smlabt",
> + "smlad",
> + "smladx",
> + "smlatb",
> + "smlatt",
> + "smlawb",
> + "smlawt",
> + "smlsd",
> + "smlsdx",
> + "smmla",
> + "smmlar",
> + "smmls",
> + "smmlsr",
> + "sourcery",
> + "srsdb",
> + "stmdb",
> + "stmia",
> + "strbt",
> + "strexb",
> + "strexd",
> + "strexh",
> + "strht",
> + "switchu",
> + "tpidrurw",
> + "ttbcr",
> + "typer",
> + "ucmpdi",
> + "udivdi",
> + "udivmoddi",
> + "udivsi",
> + "uefi's",
> + "uldiv",
> + "umoddi",
> + "umodsi",
> + "usada",
> + "vlpis",
> + "writec"
> + ], # words to extend to the
> dictionary for this package
> + "IgnoreStandardPaths": [ # Standard Plugin defined paths that
> + "*.asm", "*.s" # should be ignore
> + ],
> + "AdditionalIncludePaths": [] # Additional paths to spell check
> + # (wildcards supported)
> + }
> +}
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (5 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 06/12] ArmPkg: Add ArmPkg.ci.yaml PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:05 ` Sami Mujawar
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
` (4 subsequent siblings)
11 siblings, 1 reply; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add ArmPlatformPkg.ci.yaml to configure the CI for the
ArmPlatformPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 100 ++++++++++++++++++++++++++
1 file changed, 100 insertions(+)
create mode 100644 ArmPlatformPkg/ArmPlatformPkg.ci.yaml
diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
new file mode 100644
index 000000000000..1abaa2f6870c
--- /dev/null
+++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
@@ -0,0 +1,100 @@
+## @file
+# CI configuration for ArmPlatformPkg
+#
+# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ ## options defined .pytool/Plugin/LicenseCheck
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Scripts/Ds5/"
+ ]
+ },
+
+ ## options defined .pytool/Plugin/CompilerPlugin
+ "CompilerPlugin": {
+ "DscPath": "ArmPlatformPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+ "HostUnitTestCompilerPlugin": {
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/CharEncodingCheck
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/DependencyCheck
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "ArmPlatformPkg/ArmPlatformPkg.dec",
+ "ArmPkg/ArmPkg.dec",
+ "EmbeddedPkg/EmbeddedPkg.dec",
+ "MdeModulePkg/MdeModulePkg.dec",
+ "MdePkg/MdePkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[
+ "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+ ],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[],
+ "IgnoreInf": []
+ },
+
+ ## options defined .pytool/Plugin/DscCompleteCheck
+ "DscCompleteCheck": {
+ "IgnoreInf": [],
+ "DscPath": "ArmPlatformPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+ "HostUnitTestDscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/GuidCheck
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": [],
+ },
+
+ ## options defined .pytool/Plugin/LibraryClassCheck
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined .pytool/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": False,
+ "IgnoreFiles": [], # use gitignore syntax to ignore errors
+ # in matching files
+ "ExtendWords": [
+ "hdlcd",
+ "icdsgir",
+ "primecells"
+ ], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [ # Standard Plugin defined paths that
+ "*.asm", "*.s" # should be ignore
+ ],
+ "AdditionalIncludePaths": [] # Additional paths to spell check
+ # (wildcards supported)
+ }
+}
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml
2021-04-21 12:20 ` [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
@ 2021-04-22 10:05 ` Sami Mujawar
0 siblings, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:05 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
Cc: nd
[-- Attachment #1: Type: text/plain, Size: 4462 bytes --]
Hi Pierre,
I have a minor comment marked inline as [SAMI].
With that changed.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add ArmPlatformPkg.ci.yaml to configure the CI for the
ArmPlatformPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 100 ++++++++++++++++++++++++++
1 file changed, 100 insertions(+)
create mode 100644 ArmPlatformPkg/ArmPlatformPkg.ci.yaml
diff --git a/ArmPlatformPkg/ArmPlatformPkg.ci.yaml b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
new file mode 100644
index 000000000000..1abaa2f6870c
--- /dev/null
+++ b/ArmPlatformPkg/ArmPlatformPkg.ci.yaml
@@ -0,0 +1,100 @@
+## @file
+# CI configuration for ArmPlatformPkg
+#
+# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ ## options defined .pytool/Plugin/LicenseCheck
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ "Scripts/Ds5/"
+ ]
+ },
+
+ ## options defined .pytool/Plugin/CompilerPlugin
+ "CompilerPlugin": {
+ "DscPath": "ArmPlatformPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestCompilerPlugin
+ "HostUnitTestCompilerPlugin": {
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/CharEncodingCheck
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+
+ ## options defined .pytool/Plugin/DependencyCheck
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "ArmPlatformPkg/ArmPlatformPkg.dec",
+ "ArmPkg/ArmPkg.dec",
[SAMI] Can this list be sorted in alphabetical order, please?
[/SAMI]
+ "EmbeddedPkg/EmbeddedPkg.dec",
+ "MdeModulePkg/MdeModulePkg.dec",
+ "MdePkg/MdePkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[
+ "UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
+ ],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[],
+ "IgnoreInf": []
+ },
+
+ ## options defined .pytool/Plugin/DscCompleteCheck
+ "DscCompleteCheck": {
+ "IgnoreInf": [],
+ "DscPath": "ArmPlatformPkg.dsc"
+ },
+
+ ## options defined .pytool/Plugin/HostUnitTestDscCompleteCheck
+ "HostUnitTestDscCompleteCheck": {
+ "IgnoreInf": [""],
+ "DscPath": "" # Don't support this test
+ },
+
+ ## options defined .pytool/Plugin/GuidCheck
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": [],
+ },
+
+ ## options defined .pytool/Plugin/LibraryClassCheck
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined .pytool/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": False,
+ "IgnoreFiles": [], # use gitignore syntax to ignore errors
+ # in matching files
+ "ExtendWords": [
+ "hdlcd",
+ "icdsgir",
+ "primecells"
+ ], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [ # Standard Plugin defined paths that
+ "*.asm", "*.s" # should be ignore
+ ],
+ "AdditionalIncludePaths": [] # Additional paths to spell check
+ # (wildcards supported)
+ }
+}
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 12926 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 08/12] .pytool: Enable CI for ArmPkg
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (6 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 07/12] ArmPlatformPkg: Add ArmPlatformPkg.ci.yaml PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:07 ` Sami Mujawar
2021-04-26 20:54 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
` (3 subsequent siblings)
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Enable the CI for the ArmPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/CISettings.py | 3 ++-
.pytool/Readme.md | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 5f71eca1992e..6f7daeca076b 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -49,7 +49,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
''' return iterable of edk2 packages supported by this build.
These should be edk2 workspace relative paths '''
- return ("ArmVirtPkg",
+ return ("ArmPkg",
+ "ArmVirtPkg",
"DynamicTablesPkg",
"EmulatorPkg",
"MdePkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index e158b2b81a34..cbce1f6cd54a 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -4,7 +4,7 @@
| Package | Windows VS2019 (IA32/X64)| Ubuntu GCC (IA32/X64/ARM/AARCH64) | Known Issues |
| :---- | :----- | :---- | :--- |
-| ArmPkg |
+| ArmPkg | | :heavy_check_mark: |
| ArmPlatformPkg |
| ArmVirtPkg | SEE PACKAGE README | SEE PACKAGE README |
| CryptoPkg | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 08/12] .pytool: Enable CI for ArmPkg
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
@ 2021-04-22 10:07 ` Sami Mujawar
2021-04-26 20:54 ` [EXTERNAL] " Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:07 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
Cc: nd
[-- Attachment #1: Type: text/plain, Size: 2119 bytes --]
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 08/12] .pytool: Enable CI for ArmPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Enable the CI for the ArmPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/CISettings.py | 3 ++-
.pytool/Readme.md | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 5f71eca1992e..6f7daeca076b 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -49,7 +49,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
''' return iterable of edk2 packages supported by this build.
These should be edk2 workspace relative paths '''
- return ("ArmVirtPkg",
+ return ("ArmPkg",
+ "ArmVirtPkg",
"DynamicTablesPkg",
"EmulatorPkg",
"MdePkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index e158b2b81a34..cbce1f6cd54a 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -4,7 +4,7 @@
| Package | Windows VS2019 (IA32/X64)| Ubuntu GCC (IA32/X64/ARM/AARCH64) | Known Issues |
| :---- | :----- | :---- | :--- |
-| ArmPkg |
+| ArmPkg | | :heavy_check_mark: |
| ArmPlatformPkg |
| ArmVirtPkg | SEE PACKAGE README | SEE PACKAGE README |
| CryptoPkg | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 7478 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [EXTERNAL] [PATCH v1 08/12] .pytool: Enable CI for ArmPkg
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
2021-04-22 10:07 ` Sami Mujawar
@ 2021-04-26 20:54 ` Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Bret Barkelew @ 2021-04-26 20:54 UTC (permalink / raw)
To: Pierre.Gondois@arm.com, devel@edk2.groups.io,
sami.mujawar@arm.com, leif@nuviainc.com,
ardb+tianocore@kernel.org, Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 2071 bytes --]
Reviewed by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Pierre.Gondois@arm.com<mailto:Pierre.Gondois@arm.com>
Sent: Wednesday, April 21, 2021 5:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 08/12] .pytool: Enable CI for ArmPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Enable the CI for the ArmPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/CISettings.py | 3 ++-
.pytool/Readme.md | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 5f71eca1992e..6f7daeca076b 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -49,7 +49,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
''' return iterable of edk2 packages supported by this build.
These should be edk2 workspace relative paths '''
- return ("ArmVirtPkg",
+ return ("ArmPkg",
+ "ArmVirtPkg",
"DynamicTablesPkg",
"EmulatorPkg",
"MdePkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index e158b2b81a34..cbce1f6cd54a 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -4,7 +4,7 @@
| Package | Windows VS2019 (IA32/X64)| Ubuntu GCC (IA32/X64/ARM/AARCH64) | Known Issues |
| :---- | :----- | :---- | :--- |
-| ArmPkg |
+| ArmPkg | | :heavy_check_mark: |
| ArmPlatformPkg |
| ArmVirtPkg | SEE PACKAGE README | SEE PACKAGE README |
| CryptoPkg | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 5466 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (7 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 08/12] .pytool: Enable CI for ArmPkg PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:07 ` Sami Mujawar
2021-04-26 20:55 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
` (2 subsequent siblings)
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Enable the CI for the ArmPlatformPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/CISettings.py | 1 +
.pytool/Readme.md | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 6f7daeca076b..96e6baa5190d 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -50,6 +50,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
These should be edk2 workspace relative paths '''
return ("ArmPkg",
+ "ArmPlatformPkg",
"ArmVirtPkg",
"DynamicTablesPkg",
"EmulatorPkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index cbce1f6cd54a..eca86c6a822d 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -5,7 +5,7 @@
| Package | Windows VS2019 (IA32/X64)| Ubuntu GCC (IA32/X64/ARM/AARCH64) | Known Issues |
| :---- | :----- | :---- | :--- |
| ArmPkg | | :heavy_check_mark: |
-| ArmPlatformPkg |
+| ArmPlatformPkg | | :heavy_check_mark: |
| ArmVirtPkg | SEE PACKAGE README | SEE PACKAGE README |
| CryptoPkg | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
| DynamicTablesPkg | | :heavy_check_mark: |
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
@ 2021-04-22 10:07 ` Sami Mujawar
2021-04-26 20:55 ` [EXTERNAL] " Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:07 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
Cc: nd
[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Enable the CI for the ArmPlatformPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/CISettings.py | 1 +
.pytool/Readme.md | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 6f7daeca076b..96e6baa5190d 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -50,6 +50,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
These should be edk2 workspace relative paths '''
return ("ArmPkg",
+ "ArmPlatformPkg",
"ArmVirtPkg",
"DynamicTablesPkg",
"EmulatorPkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index cbce1f6cd54a..eca86c6a822d 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -5,7 +5,7 @@
| Package | Windows VS2019 (IA32/X64)| Ubuntu GCC (IA32/X64/ARM/AARCH64) | Known Issues |
| :---- | :----- | :---- | :--- |
| ArmPkg | | :heavy_check_mark: |
-| ArmPlatformPkg |
+| ArmPlatformPkg | | :heavy_check_mark: |
| ArmVirtPkg | SEE PACKAGE README | SEE PACKAGE README |
| CryptoPkg | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
| DynamicTablesPkg | | :heavy_check_mark: |
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 7939 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [EXTERNAL] [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
2021-04-22 10:07 ` Sami Mujawar
@ 2021-04-26 20:55 ` Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Bret Barkelew @ 2021-04-26 20:55 UTC (permalink / raw)
To: Pierre.Gondois@arm.com, devel@edk2.groups.io,
sami.mujawar@arm.com, leif@nuviainc.com,
ardb+tianocore@kernel.org, Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
Reviewed by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Pierre.Gondois@arm.com<mailto:Pierre.Gondois@arm.com>
Sent: Wednesday, April 21, 2021 5:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Enable the CI for the ArmPlatformPkg.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/CISettings.py | 1 +
.pytool/Readme.md | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 6f7daeca076b..96e6baa5190d 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -50,6 +50,7 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
These should be edk2 workspace relative paths '''
return ("ArmPkg",
+ "ArmPlatformPkg",
"ArmVirtPkg",
"DynamicTablesPkg",
"EmulatorPkg",
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index cbce1f6cd54a..eca86c6a822d 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -5,7 +5,7 @@
| Package | Windows VS2019 (IA32/X64)| Ubuntu GCC (IA32/X64/ARM/AARCH64) | Known Issues |
| :---- | :----- | :---- | :--- |
| ArmPkg | | :heavy_check_mark: |
-| ArmPlatformPkg |
+| ArmPlatformPkg | | :heavy_check_mark: |
| ArmVirtPkg | SEE PACKAGE README | SEE PACKAGE README |
| CryptoPkg | :heavy_check_mark: | :heavy_check_mark: | Spell checking in audit mode
| DynamicTablesPkg | | :heavy_check_mark: |
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 5573 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (8 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 09/12] .pytool: Enable CI for ArmPlatformPkg PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:08 ` Sami Mujawar
2021-04-26 20:56 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry in the documentation for the LicenseCheck and
EccCheck plugins.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/Readme.md | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index eca86c6a822d..f6505507966a 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -254,6 +254,16 @@ Install
More cspell info: https://github.com/streetsidesoftware/cspell
+### License Checking - LicenseCheck
+
+Scans all new added files in a package to make sure code is contributed under
+BSD-2-Clause-Patent.
+
+### Ecc tool - EccCheck
+
+Run the Ecc tool on the package. The Ecc tool is available in the BaseTools
+package. It checks that the code complies to the EDKII coding standard.
+
## PyTool Scopes
Scopes are how the PyTool ext_dep, path_env, and plugins are activated. Meaning
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
@ 2021-04-22 10:08 ` Sami Mujawar
2021-04-26 20:56 ` [EXTERNAL] " Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:08 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
Cc: nd
[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry in the documentation for the LicenseCheck and
EccCheck plugins.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/Readme.md | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index eca86c6a822d..f6505507966a 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -254,6 +254,16 @@ Install
More cspell info: https://github.com/streetsidesoftware/cspell
+### License Checking - LicenseCheck
+
+Scans all new added files in a package to make sure code is contributed under
+BSD-2-Clause-Patent.
+
+### Ecc tool - EccCheck
+
+Run the Ecc tool on the package. The Ecc tool is available in the BaseTools
+package. It checks that the code complies to the EDKII coding standard.
+
## PyTool Scopes
Scopes are how the PyTool ext_dep, path_env, and plugins are activated. Meaning
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 4118 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [EXTERNAL] [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
2021-04-22 10:08 ` Sami Mujawar
@ 2021-04-26 20:56 ` Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Bret Barkelew @ 2021-04-26 20:56 UTC (permalink / raw)
To: pierre.gondois@arm.com, devel@edk2.groups.io,
sami.mujawar@arm.com, leif@nuviainc.com,
ardb+tianocore@kernel.org, Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]
Acked by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: pierre.gondois@arm.com<mailto:pierre.gondois@arm.com>
Sent: Wednesday, April 21, 2021 5:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; sami.mujawar@arm.com<mailto:Sami.Mujawar@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry in the documentation for the LicenseCheck and
EccCheck plugins.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.pytool/Readme.md | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index eca86c6a822d..f6505507966a 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -254,6 +254,16 @@ Install
More cspell info: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstreetsidesoftware%2Fcspell&data=04%7C01%7CBret.Barkelew%40microsoft.com%7Cd3baca9349a5434e411408d904bffb9b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637546044883177478%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=r%2BsyJEm3F5LEoSXSJ8wvtklOlVbkHrkK7mQGh5qzxEs%3D&reserved=0
+### License Checking - LicenseCheck
+
+Scans all new added files in a package to make sure code is contributed under
+BSD-2-Clause-Patent.
+
+### Ecc tool - EccCheck
+
+Run the Ecc tool on the package. The Ecc tool is available in the BaseTools
+package. It checks that the code complies to the EDKII coding standard.
+
## PyTool Scopes
Scopes are how the PyTool ext_dep, path_env, and plugins are activated. Meaning
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 4416 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (9 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 10/12] .pytool: Document LicenseCheck and EccCheck PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:09 ` Sami Mujawar
2021-04-26 20:58 ` [EXTERNAL] " Bret Barkelew
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry to build the ArmPkg in the CI.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3348
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 3e6d275b1b9a..837079e7bd97 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -21,6 +21,9 @@ jobs:
#Use matrix to speed up the build process
strategy:
matrix:
+ TARGET_ARM:
+ Build.Pkgs: 'ArmPkg'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_MDE_CPU:
Build.Pkgs: 'MdePkg,UefiCpuPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
@ 2021-04-22 10:09 ` Sami Mujawar
2021-04-26 20:58 ` [EXTERNAL] " Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:09 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
Cc: nd
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry to build the ArmPkg in the CI.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3348
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 3e6d275b1b9a..837079e7bd97 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -21,6 +21,9 @@ jobs:
#Use matrix to speed up the build process
strategy:
matrix:
+ TARGET_ARM:
+ Build.Pkgs: 'ArmPkg'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_MDE_CPU:
Build.Pkgs: 'MdePkg,UefiCpuPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 4240 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [EXTERNAL] [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
2021-04-22 10:09 ` Sami Mujawar
@ 2021-04-26 20:58 ` Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Bret Barkelew @ 2021-04-26 20:58 UTC (permalink / raw)
To: pierre.gondois@arm.com, devel@edk2.groups.io,
sami.mujawar@arm.com, leif@nuviainc.com,
ardb+tianocore@kernel.org, Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
Just realized I left a hyphen out of my other reviews today. Apologies.
- Bret
From: pierre.gondois@arm.com<mailto:pierre.gondois@arm.com>
Sent: Wednesday, April 21, 2021 5:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; sami.mujawar@arm.com<mailto:Sami.Mujawar@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry to build the ArmPkg in the CI.
Fixes: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3348&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C1480560cf7934a9ecb3508d904bffccc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637546044922056341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=hJmH1ZPKXHLKyHJozmsRM3By8%2BXewjBY235NhkflflI%3D&reserved=0
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 3e6d275b1b9a..837079e7bd97 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -21,6 +21,9 @@ jobs:
#Use matrix to speed up the build process
strategy:
matrix:
+ TARGET_ARM:
+ Build.Pkgs: 'ArmPkg'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_MDE_CPU:
Build.Pkgs: 'MdePkg,UefiCpuPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 4702 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
2021-04-21 12:20 [PATCH v1 00/12] ArmPkg/ArmPlatformPkg CI enablement PierreGondois
` (10 preceding siblings ...)
2021-04-21 12:20 ` [PATCH v1 11/12] AzurePipelines: Add support for ArmPkg PierreGondois
@ 2021-04-21 12:20 ` PierreGondois
2021-04-22 10:09 ` Sami Mujawar
2021-04-26 20:57 ` [EXTERNAL] " Bret Barkelew
11 siblings, 2 replies; 35+ messages in thread
From: PierreGondois @ 2021-04-21 12:20 UTC (permalink / raw)
To: devel, sami.mujawar, leif, ardb+tianocore, sean.brogan,
Bret.Barkelew
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry to build the ArmPlatformPkg in the CI.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3349
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 837079e7bd97..16d197cde913 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
TARGET_ARM:
- Build.Pkgs: 'ArmPkg'
+ Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_MDE_CPU:
Build.Pkgs: 'MdePkg,UefiCpuPkg'
--
2.17.1
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
@ 2021-04-22 10:09 ` Sami Mujawar
2021-04-26 20:57 ` [EXTERNAL] " Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Sami Mujawar @ 2021-04-22 10:09 UTC (permalink / raw)
To: Pierre Gondois, devel@edk2.groups.io, leif@nuviainc.com,
ardb+tianocore@kernel.org, sean.brogan@microsoft.com,
Bret.Barkelew@microsoft.com
Cc: nd
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
Regards,
Sami Mujawar
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
Date: Wednesday, 21 April 2021 at 13:21
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>, leif@nuviainc.com <leif@nuviainc.com>, ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, sean.brogan@microsoft.com <sean.brogan@microsoft.com>, Bret.Barkelew@microsoft.com <Bret.Barkelew@microsoft.com>
Subject: [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry to build the ArmPlatformPkg in the CI.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3349
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 837079e7bd97..16d197cde913 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
TARGET_ARM:
- Build.Pkgs: 'ArmPkg'
+ Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_MDE_CPU:
Build.Pkgs: 'MdePkg,UefiCpuPkg'
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 4393 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread* Re: [EXTERNAL] [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
2021-04-21 12:20 ` [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg PierreGondois
2021-04-22 10:09 ` Sami Mujawar
@ 2021-04-26 20:57 ` Bret Barkelew
1 sibling, 0 replies; 35+ messages in thread
From: Bret Barkelew @ 2021-04-26 20:57 UTC (permalink / raw)
To: pierre.gondois@arm.com, devel@edk2.groups.io,
sami.mujawar@arm.com, leif@nuviainc.com,
ardb+tianocore@kernel.org, Sean Brogan
[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]
I think the TARGET name should be updated to TARGET_ARM_ARMPLATFORM.
Otherwise,
Reviewed by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: pierre.gondois@arm.com<mailto:pierre.gondois@arm.com>
Sent: Wednesday, April 21, 2021 5:21 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; sami.mujawar@arm.com<mailto:Sami.Mujawar@arm.com>; leif@nuviainc.com<mailto:leif@nuviainc.com>; ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>; Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [PATCH v1 12/12] AzurePipelines: Add support for ArmPlatformPkg
From: Pierre Gondois <Pierre.Gondois@arm.com>
Add an entry to build the ArmPlatformPkg in the CI.
Fixes: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3349&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C5d0e796c603443cba5cb08d904bffdf6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637546044920304051%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=A8udDEiGEU4kXwVm88lNlnOCJq4c65uW7R4n%2FYYGUCs%3D&reserved=0
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 837079e7bd97..16d197cde913 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
TARGET_ARM:
- Build.Pkgs: 'ArmPkg'
+ Build.Pkgs: 'ArmPkg,ArmPlatformPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_MDE_CPU:
Build.Pkgs: 'MdePkg,UefiCpuPkg'
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 4699 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread