Re: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages

["Bret Barkelew" <bret.barkelew@microsoft.com>]

[-- Attachment #1: Type: text/plain, Size: 9886 bytes --]

“I had to jump through hoops to collect the individual patches from my list folder”
Man, it’s almost like you had Outlook. *shudder*

- Bret

From: Laszlo Ersek via groups.io<mailto:lersek=redhat.com@groups.io>
Sent: Friday, March 5, 2021 7:28 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kun.q@outlook.com<mailto:kun.q@outlook.com>
Cc: Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Zhiguang Liu<mailto:zhiguang.liu@intel.com>; Yao, Jiewen<mailto:jiewen.yao@intel.com>; Jian J Wang<mailto:jian.j.wang@intel.com>; Hao A Wu<mailto:hao.a.wu@intel.com>; Ard Biesheuvel<mailto:ardb+tianocore@kernel.org>; Jordan Justen<mailto:jordan.l.justen@intel.com>; Qi Zhang<mailto:qi1.zhang@intel.com>; Rahul Kumar<mailto:rahul1.kumar@intel.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages

On 03/05/21 05:59, Kun Qin wrote:
> Hi,
>
> Thanks to all the reviewers helping through this patch series. Each individual patch has received reviewed-by tag in this v6 version. It has also just passed all CI build tests here: Unblock mem v6 by kuqin12 · Pull Request #1473 · tianocore/edk2 (github.com)<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1473&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=lDOoKamHkUjubKvNxJ%2B6h7TN%2Bc3d%2B5iPkPexgyccLrY%3D&amp;reserved=0> Could one of the maintainers help to merge these patches into the mainline when you have a chance?
>
> Please let me know if there is anything needed from me to merge in these patches. Thanks in advance!

(1) Series merged as commit range c5740f360636..59a3ccb09e7a, via
<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1475&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=LlWsBbmenynuTUpPrfHE7ys1jH8w6XL6Zui3FEbFHNE%3D&amp;reserved=0>.


(2) I couldn't tell if there was a TianoCore BZ specifically associated
with this series. Some patches in the series do not reference any BZs,
while some other patches reference two different BZs, namely #3168 and
#3169.

Neither #3168 nor #3169 contains links to *all six* postings (versions)
of the patch series. So I can't decide if now, with the v6 series
merged, I should close these tickets, or not. (IOW, if other tasks
remain, for solving the BZs.)

In case the tickets should be closed at this point, please go ahead and
close them yourself, as RESOLVED|FIXED. Please also include a new
comment in each ticket, repeating my point (1) above, verbatim -- each
solved BZ should highlight the commit range and the pull request that
solved it.


(3) For the future, please fix up your email setup. I'm not sure what's
happening -- it looks like whatever SMTP server you use throws away the
Message-Id headers generated by git-send-email, and generates new
Message-Ids. Or something similar -- FWIW, the In-Reply-To headers look
questionable as well.

Whatever the background, the threading in your posted patch set is
broken; I had to jump through hoops to collect the individual patches
from my list folder. Please fix this issue for your next contribution.

Thanks,
Laszlo


>
> Regards,
> Kun
>
> From: Kun Qin<mailto:kun.q@outlook.com>
> Sent: Thursday, March 4, 2021 20:13
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Michael D Kinney<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Zhiguang Liu<mailto:zhiguang.liu@intel.com>; Jiewen Yao<mailto:jiewen.yao@intel.com>; Jian J Wang<mailto:jian.j.wang@intel.com>; Hao A Wu<mailto:hao.a.wu@intel.com>; Laszlo Ersek<mailto:lersek@redhat.com>; Ard Biesheuvel<mailto:ardb+tianocore@kernel.org>; Jordan Justen<mailto:jordan.l.justen@intel.com>; Qi Zhang<mailto:qi1.zhang@intel.com>; Rahul Kumar<mailto:rahul1.kumar@intel.com>
> Subject: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages
>
> This patch series is a follow up of previous submission:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F72442&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=cNexu92PbyNbxrUN7l%2BdZqVcwfvHfKFohUuWPvO2Py4%3D&amp;reserved=0
>
> v6 patches mainly focus on feedback for reviewed commits in v5 patches,
> including:
> a. Adding "Reviewed-by" and "Acked-by" tags for applicable patch;
> b. Updating library class description for newly added interface;
>
> Patch v6 branch: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkuqin12%2Fedk2%2Ftree%2Funblock_mem_v6&amp;data=04%7C01%7Cbret.barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=y9LxiikpUmJsoRZNesHJFhrEMOFlGpXDG1IAB7s%2FRKE%3D&amp;reserved=0
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>
> Kun Qin (7):
>   MdePkg: MmUnblockMemoryLib: Added definition and null instance
>   OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeDxe)
>   MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory
>     interface
>   SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst
>   SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules
>   SecurityPkg: Tcg2Smm: Added support for Standalone Mm
>   SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region
>
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c   |  42 +
>  MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c           |  44 +
>  SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c => Tcg2Acpi/Tcg2Acpi.c}           | 362 ++++-----
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c                        |  48 ++
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c                                    | 857 ++++----------------
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c                           |  71 ++
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c                          |  82 ++
>  MdeModulePkg/MdeModulePkg.dsc                                        |   1 +
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf |   1 +
>  MdePkg/Include/Library/MmUnblockMemoryLib.h                          |  44 +
>  MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf         |  34 +
>  MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.uni         |  21 +
>  MdePkg/MdePkg.dec                                                    |   5 +
>  MdePkg/MdePkg.dsc                                                    |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc                                              |   3 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                                           |   3 +
>  OvmfPkg/OvmfPkgX64.dsc                                               |   3 +
>  SecurityPkg/Include/Guid/TpmNvsMm.h                                  |  68 ++
>  SecurityPkg/SecurityPkg.ci.yaml                                      |   1 +
>  SecurityPkg/SecurityPkg.dec                                          |   8 +
>  SecurityPkg/SecurityPkg.dsc                                          |  12 +
>  SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf => Tcg2Acpi/Tcg2Acpi.inf}       |  35 +-
>  SecurityPkg/Tcg/{Tcg2Smm => Tcg2Acpi}/Tpm.asl                        |   0
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf                      |  43 +
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h                                    | 121 +--
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf                                  |  27 +-
>  SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf => Tcg2StandaloneMm.inf}        |  50 +-
>  27 files changed, 952 insertions(+), 1035 deletions(-)
>  create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c
>  copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c => Tcg2Acpi/Tcg2Acpi.c} (72%)
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c
>  create mode 100644 MdePkg/Include/Library/MmUnblockMemoryLib.h
>  create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
>  create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.uni
>  create mode 100644 SecurityPkg/Include/Guid/TpmNvsMm.h
>  copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf => Tcg2Acpi/Tcg2Acpi.inf} (76%)
>  rename SecurityPkg/Tcg/{Tcg2Smm => Tcg2Acpi}/Tpm.asl (100%)
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf
>  copy SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf => Tcg2StandaloneMm.inf} (52%)
>
> --
> 2.30.0.windows.1
>
>
>
>
>
>
>
>
>
>
>
>







[-- Attachment #2: Type: text/html, Size: 19007 bytes --]