From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.95]) by mx.groups.io with SMTP id smtpd.web10.296.1614964179225536437 for ; Fri, 05 Mar 2021 09:09:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=C0Djtu4Z; spf=pass (domain: microsoft.com, ip: 40.107.93.95, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h1/+1Qn/S0pC5TScFASGarOEVt/E+lLfWvbHwQIywukIZ+0dEQK87EngyuDrhyBMNaUIk9Ss93IXHoZGQRk92Hp1T+Urax+8WcfsmHy4kRk2eyhXh691n1NAc4OCB4P8SlKtA4BgLZ9XveUKvLf2gPIiJeAHimSwbhzkNJVgZ6UKxuFLssDtXdy3Sm4OOZ+zjGGT0l6u9hMaXMo5RoroIZTlAXezuzxk3+ft+0t4CH1YGhhBgxao8Sgt/Fj5jq/6a9TIbLO1G+EFnWOKqX1mXFZlze0ELUBRKHyzU+CRD2ay7+UEizQTKXnZJQI4gJn1Q4VpSpQI6SIjF/0X/rmw/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iu4rWrbbgwe2sU/7IK2C8GdDWJm54lBFoKi9guZnyZ0=; b=gQUdoVuCyZmy7wWQI0IoKl7VdMuj3GgPUjaDMMszTle7RiI0HO2QCbr+4oKyFFh51SoVHaGcbnMFv6nsyTqhHh8w1Zvp1exEyCMYfm6ekSbQJpvxzHtcq7+xxtwhYCEN//1zDF7Tu3S4+vR2I5vXKONzmJyq7XwFTBKKR8MW0QRqDWn0DlkYA2UvthTDauJ4isHS5nFigkFjPTD2CuJJRv9hFcX7DOf0N6CsvmuxFlh6xvJhjN9CcwDGLpEjgvD4QCLBpY6azVUvg28O7snUelOLmKX6vVdw4sbtUfkNW5ItwS/E99YCH10UccqcDwbazIGN/olUVloOWUz8lbgMOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iu4rWrbbgwe2sU/7IK2C8GdDWJm54lBFoKi9guZnyZ0=; b=C0Djtu4Zl+ylrPYDHZw9cu//AZkeKJwsaZSMGYKnHBs2NIbwFWsijdCjUV3zQ9ekga3SO2owdxIO5tiKmGQRCp27gv6l/WtxDw3GZgnAVejnUwkMWXjTLBZGgtyuy13b7hnmw5fnAjWiSAKjEdcyV0Lc4j4HMX8N8SYq5bYh5SU= Received: from MW4PR21MB1907.namprd21.prod.outlook.com (2603:10b6:303:71::8) by MWHPR21MB0512.namprd21.prod.outlook.com (2603:10b6:300:df::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.8; Fri, 5 Mar 2021 17:09:37 +0000 Received: from MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::8ddb:dbee:7757:2d6a]) by MW4PR21MB1907.namprd21.prod.outlook.com ([fe80::8ddb:dbee:7757:2d6a%7]) with mapi id 15.20.3933.020; Fri, 5 Mar 2021 17:09:36 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "kun.q@outlook.com" CC: "Kinney, Michael D" , Liming Gao , Zhiguang Liu , "Yao, Jiewen" , Jian J Wang , Hao A Wu , Ard Biesheuvel , Jordan Justen , Qi Zhang , Rahul Kumar Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages Thread-Index: AQHXEXXft+4KVjiciUu+8r2eDLqS8ap0zxrbgAC2OgCAABwFUw== Date: Fri, 5 Mar 2021 17:09:36 +0000 Message-ID: References: <166956FE12B1DAB7.16425@groups.io> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-03-05T17:08:17.1673793Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.153.143] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ee535540-c08b-4fbd-aed7-08d8dff974a4 x-ms-traffictypediagnostic: MWHPR21MB0512: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BrBZQRVXySqkM7A65o20IFBp5Seb9PqsM9E5QTMlc60FDd8EP922YSWIA7ub1XD6k1Z2clCJ9D2ZYPcM3Kib6Pu7Sv3OrBMIHWE14Jzwn6bohnpfxDKwoJyZDp0GQhmcA9eXG0shJc2iBLWthalmxTvgHFyQ8DImxXCBtFNDlm5RyZ3E5wGiz5BJhEWvQ5B3svrpOoPwZk25M7Gd0aFbJ14vnDNFC9aHA6omk+52lt/1Ztb0VXBp1BjfhAIlPaOTiNbefZeDoAEXaSZY2GSVxtJOWJSidx5sPL/eOqB8J6XPpH6hEyAgcL5QMnsfXS8WNwAIWqL8/6s9F0AyAAMLW6Ux/78u5+p8wjsKyaFa9cztFC0CClmKevYYVzP8FDCyJASCecdQRCIHgZmmZCHlE5REAIX/Rfa48pHxAcXrK4qdFGHN4iZFGDKoeCjINjeDNWe9fQ3oC/NMiqOvHkHxVrlNa1mp+xG4RGy24bUq4sV28x7QzNL1DWxt8k4/PKOyuMd1ZQ+Kdy4olwWufdao/Qhhq+B9Tm2uWRNEAgEZu60WZXfS+F6eYhMB+uv14FVnEdUk6T9JH/F0a9dU5kPd4ujKplxUWOKaVjln6+dnoDM+FeRXe9MFsXLdsDfJCnuV7aPaLiQlNhAX07Zy7kLKgQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR21MB1907.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(2906002)(66446008)(478600001)(66476007)(66556008)(166002)(10290500003)(6506007)(8990500004)(7696005)(186003)(4326008)(8676002)(66946007)(64756008)(8936002)(110136005)(55016002)(52536014)(5660300002)(76116006)(966005)(26005)(54906003)(71200400001)(82960400001)(316002)(83380400001)(82950400001)(7416002)(33656002)(86362001)(9686003)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?5ooozMOXAwQSdHTgjs9VXtJeapLLEfPsAswwH/va5yOCLHZT2mrW+FvB?= =?Windows-1252?Q?JRlW/UNCvbeUyDoEytheGj+vXPKxbHC467fBrMXTMQQnnRrdGQEQ/Fy1?= =?Windows-1252?Q?zXTpashNauqsms12Ft9ZHPsLvV+fSAc7mnZbxpOkzAgZNpzcdWahg7Qo?= =?Windows-1252?Q?tT4ZOQG/VSPo3GNWY9aYFqpIAOshL60evTsPMC0tzD26FiV7a8MQfQ+K?= =?Windows-1252?Q?0ou6dJNJNqFrfRaMneXRRlhgFdZjCpoai1OnSqmUKMQtFmQd0YTO9vAc?= =?Windows-1252?Q?Yj/kYKhSTzRH6Z3nAAQvdljfzLp7NlQ0pBlrNYHgu8fak8ajUzBhcIUu?= =?Windows-1252?Q?9/jqabmPiongujb0tyO4ekgkJxYUBkY/egeae34VPtKcMWAfsNEpWVZc?= =?Windows-1252?Q?4Z/DD3x80kTTE4qnYg8YtG1QwgmnQf/HvOPCbYZQT0OMxCKAt07llvzr?= =?Windows-1252?Q?WMKKRaxgBgMk+Lv8gqbOouNn9hFky4EMX1H9+aNhJqvOsY57F28Foj4w?= =?Windows-1252?Q?HK/iTqJOWzEtv04ZKlYEuzImQx9TUE+GE3K9jr+3RXB19OSjVzbEVOBF?= =?Windows-1252?Q?nz4Bv6iaDUVqLxaM389iicCX2z4r4EDuksXuk+HzVzLbymObD1ysmtMA?= =?Windows-1252?Q?DJUANQiNrSgAV1H+8frhLJl+mINjLbYulI+pDWl6nlV+r4rkRhE/qpVf?= =?Windows-1252?Q?/HjjOVnCpNhTQk/R1KcDAi6yq7L16AHDqqxHSHGn4VCRxFTRnekxxzA3?= =?Windows-1252?Q?s/wK2XWkONlRHzXD3zBvpjDRAGrMtrLdFT7DIJMIsBGK3Wue/jb7Q3lr?= =?Windows-1252?Q?aOgulmi/1exTzTwZxe2A6eHYYLApXgvXW3dcxSDCTGkUsJr8sZ8zkKFQ?= =?Windows-1252?Q?qWn8p1ueHXYnNcnsN9BARK9i2oqcPuQJG7lFr4CkgF5obdMbroMbOrKQ?= =?Windows-1252?Q?Mw/qODPd8IQatDakT4l2Tj2bvX1uvhlEYimikWs4dL3eFcJY1uA+3FLm?= =?Windows-1252?Q?oJC//Pik7l0Np6CjtuivS+SYMntQqbBqNfX5dw+pYt7VrCWIHpAmzJPN?= =?Windows-1252?Q?RusuOnTPOSzk/1SgI/7q1Sud6Ya9K3DHI5bpzS0qWe1iB6+02tKCu50B?= =?Windows-1252?Q?u39bTjMzjU3q5nk1ZK2h+HI17uf6c0tt60y8tcG8DAZJgO9Cecq9us2k?= =?Windows-1252?Q?UR2KJmW40fur0qebhpnLDeff2AMTZSFXhJJD/givalHHo1HdW0KR8T4/?= =?Windows-1252?Q?xjWXVamk0+X+y2acs5RXf986YMACaFsqjkmhczk1du+LyAMfMmt5OK3l?= =?Windows-1252?Q?ioOsW8T5lslISOTpiF4uZ2tiyp6wLl2k+EQTSGrtPDrZjnwM1yPnNrns?= =?Windows-1252?Q?JVT3B4juaaMMCH/whvqyUwM3nxVYqlqwNjtkDNI0DeaLt7CHiJMvFo/q?= =?Windows-1252?Q?6JbPapUa92w0uP921S8zMA=3D=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB1907.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee535540-c08b-4fbd-aed7-08d8dff974a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 17:09:36.9367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VMSRM2rWn1Sh9qGxOuKK625oEbCwJs/KAKKTO4DdqU1LTfWyBNk1L16PUpL5xPl+014YY1do6NDseCpMMWnY5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0512 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR21MB1907F4FA06F544DE0344D1EDEF969MW4PR21MB1907namp_" --_000_MW4PR21MB1907F4FA06F544DE0344D1EDEF969MW4PR21MB1907namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable =93I had to jump through hoops to collect the individual patches from my li= st folder=94 Man, it=92s almost like you had Outlook. *shudder* - Bret From: Laszlo Ersek via groups.io Sent: Friday, March 5, 2021 7:28 AM To: devel@edk2.groups.io; kun.q@outlook.com Cc: Kinney, Michael D; Liming Gao; Zhiguang Liu; Y= ao, Jiewen; Jian J Wang; Hao A Wu; Ard Biesheuvel; Jordan Justen; Qi Zh= ang; Rahul Kumar Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib= Interface and Usages On 03/05/21 05:59, Kun Qin wrote: > Hi, > > Thanks to all the reviewers helping through this patch series. Each indi= vidual patch has received reviewed-by tag in this v6 version. It has also j= ust passed all CI build tests here: Unblock mem v6 by kuqin12 =B7 Pull Requ= est #1473 =B7 tianocore/edk2 (github.com) Could one of the maintainers help to mer= ge these patches into the mainline when you have a chance? > > Please let me know if there is anything needed from me to merge in these= patches. Thanks in advance! (1) Series merged as commit range c5740f360636..59a3ccb09e7a, via . (2) I couldn't tell if there was a TianoCore BZ specifically associated with this series. Some patches in the series do not reference any BZs, while some other patches reference two different BZs, namely #3168 and #3169. Neither #3168 nor #3169 contains links to *all six* postings (versions) of the patch series. So I can't decide if now, with the v6 series merged, I should close these tickets, or not. (IOW, if other tasks remain, for solving the BZs.) In case the tickets should be closed at this point, please go ahead and close them yourself, as RESOLVED|FIXED. Please also include a new comment in each ticket, repeating my point (1) above, verbatim -- each solved BZ should highlight the commit range and the pull request that solved it. (3) For the future, please fix up your email setup. I'm not sure what's happening -- it looks like whatever SMTP server you use throws away the Message-Id headers generated by git-send-email, and generates new Message-Ids. Or something similar -- FWIW, the In-Reply-To headers look questionable as well. Whatever the background, the threading in your posted patch set is broken; I had to jump through hoops to collect the individual patches from my list folder. Please fix this issue for your next contribution. Thanks, Laszlo > > Regards, > Kun > > From: Kun Qin > Sent: Thursday, March 4, 2021 20:13 > To: devel@edk2.groups.io > Cc: Michael D Kinney; Liming Gao; Zhiguang Liu; = Jiewen Yao; Jian J Wang; Hao A Wu; Laszlo Ersek; Ard Biesheuvel; Jordan Justen<= mailto:jordan.l.justen@intel.com>; Qi Zhang; Ra= hul Kumar > Subject: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface an= d Usages > > This patch series is a follow up of previous submission: > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2= .groups.io%2Fg%2Fdevel%2Fmessage%2F72442&data=3D04%7C01%7Cbret.barkelew= %40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91ab2= d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC= 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata= =3DcNexu92PbyNbxrUN7l%2BdZqVcwfvHfKFohUuWPvO2Py4%3D&reserved=3D0 > > v6 patches mainly focus on feedback for reviewed commits in v5 patches, > including: > a. Adding "Reviewed-by" and "Acked-by" tags for applicable patch; > b. Updating library class description for newly added interface; > > Patch v6 branch: https://nam06.safelinks.protection.outlook.com/?url=3Dh= ttps%3A%2F%2Fgithub.com%2Fkuqin12%2Fedk2%2Ftree%2Funblock_mem_v6&data= =3D04%7C01%7Cbret.barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb4= 9ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnkno= wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC= I6Mn0%3D%7C1000&sdata=3Dy9LxiikpUmJsoRZNesHJFhrEMOFlGpXDG1IAB7s%2FRKE%3= D&reserved=3D0 > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Qi Zhang > Cc: Rahul Kumar > > Kun Qin (7): > MdePkg: MmUnblockMemoryLib: Added definition and null instance > OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeDxe) > MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory > interface > SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst > SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules > SecurityPkg: Tcg2Smm: Added support for Standalone Mm > SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region > > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | = 42 + > MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c | = 44 + > SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c} = | 362 ++++----- > SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c | = 48 ++ > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | = 857 ++++---------------- > SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c | = 71 ++ > SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c | = 82 ++ > MdeModulePkg/MdeModulePkg.dsc | = 1 + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | = 1 + > MdePkg/Include/Library/MmUnblockMemoryLib.h | = 44 + > MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf | = 34 + > MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.uni | = 21 + > MdePkg/MdePkg.dec | = 5 + > MdePkg/MdePkg.dsc | = 1 + > OvmfPkg/OvmfPkgIa32.dsc | = 3 + > OvmfPkg/OvmfPkgIa32X64.dsc | = 3 + > OvmfPkg/OvmfPkgX64.dsc | = 3 + > SecurityPkg/Include/Guid/TpmNvsMm.h | = 68 ++ > SecurityPkg/SecurityPkg.ci.yaml | = 1 + > SecurityPkg/SecurityPkg.dec | = 8 + > SecurityPkg/SecurityPkg.dsc | = 12 + > SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.inf} = | 35 +- > SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl = | 0 > SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf | = 43 + > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h | = 121 +-- > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | = 27 +- > SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.inf} = | 50 +- > 27 files changed, 952 insertions(+), 1035 deletions(-) > create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLib= Null.c > copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c} (72%) > create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c > create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c > create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c > create mode 100644 MdePkg/Include/Library/MmUnblockMemoryLib.h > create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLib= Null.inf > create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLib= Null.uni > create mode 100644 SecurityPkg/Include/Guid/TpmNvsMm.h > copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.inf} (= 76%) > rename SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl (100%) > create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf > copy SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.inf} (5= 2%) > > -- > 2.30.0.windows.1 > > > > > > > > > > > > --_000_MW4PR21MB1907F4FA06F544DE0344D1EDEF969MW4PR21MB1907namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

=93I had to jump through hoops to collect the indiv= idual patches from my list folder=94

Man, it=92s almost like you had Outlook. *shudder*<= /p>

 

- Bret

 

From: Laszlo Ersek via groups.io=
Sent: Friday, March 5, 2021 7:28 AM
To: devel@edk2.groups.io; kun.q@outlook.com
Cc: Kinney, Michael D= ; Liming Gao; Zhiguang Liu= ; Yao, Jiewen; Jian J Wang;= Hao A Wu; Ard Biesheuvel<= /a>; Jordan Justen; Qi Zhang; Rahul Kumar
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMe= moryLib Interface and Usages

 

On 03/05/21 05:59, K= un Qin wrote:
> Hi,
>
> Thanks to all the reviewers helping through this patch series. Each i= ndividual patch has received reviewed-by tag in this v6 version. It has als= o just passed all CI build tests here: Unblock mem v6 by kuqin12 =B7 Pull R= equest #1473 =B7 tianocore/edk2 (github.com)<https://nam06.safelinks.pro= tection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpu= ll%2F1473&amp;data=3D04%7C01%7Cbret.barkelew%40microsoft.com%7C043a8827= bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63750= 5548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL= CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DlDOoKamHkUjubKvNxJ%2B6= h7TN%2Bc3d%2B5iPkPexgyccLrY%3D&amp;reserved=3D0> Could one of the maintainers help to merge these patches into the mainlin= e when you have a chance?
>
> Please let me know if there is anything needed from me to merge in th= ese patches. Thanks in advance!

(1) Series merged as commit range c5740f360636..59a3ccb09e7a, via
<https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%= 3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1475&amp;data=3D04%7C01%= 7Cbret.barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988= bf86f141af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZ= sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1= 000&amp;sdata=3DLlWsBbmenynuTUpPrfHE7ys1jH8w6XL6Zui3FEbFHNE%3D&amp;= reserved=3D0>.


(2) I couldn't tell if there was a TianoCore BZ specifically associated with this series. Some patches in the series do not reference any BZs,
while some other patches reference two different BZs, namely #3168 and
#3169.

Neither #3168 nor #3169 contains links to *all six* postings (versions) of the patch series. So I can't decide if now, with the v6 series
merged, I should close these tickets, or not. (IOW, if other tasks
remain, for solving the BZs.)

In case the tickets should be closed at this point, please go ahead and close them yourself, as RESOLVED|FIXED. Please also include a new
comment in each ticket, repeating my point (1) above, verbatim -- each
solved BZ should highlight the commit range and the pull request that
solved it.


(3) For the future, please fix up your email setup. I'm not sure what's happening -- it looks like whatever SMTP server you use throws away the Message-Id headers generated by git-send-email, and generates new
Message-Ids. Or something similar -- FWIW, the In-Reply-To headers look questionable as well.

Whatever the background, the threading in your posted patch set is
broken; I had to jump through hoops to collect the individual patches
from my list folder. Please fix this issue for your next contribution.

Thanks,
Laszlo


>
> Regards,
> Kun
>
> From: Kun Qin<mailto:kun.q@ou= tlook.com>
> Sent: Thursday, March 4, 2021 20:13
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Michael D Kinney<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Zhiguan= g Liu<mailto:zhiguang.liu@inte= l.com>; Jiewen Yao<mailto:jiewen.yao@i= ntel.com>; Jian J Wang<m= ailto:jian.j.wang@intel.com>; Hao A Wu<mailto:hao.a.wu@intel.com>; Laszlo Ersek<mailto:lersek@redhat.com>; Ard Biesheuvel<mailto:ard= b+tianocore@kernel.org>; Jordan Justen<mailto:jordan.l.justen@intel.com>; Qi Zhang<mailto:qi1.zhang@intel.com>; Rahul Kumar<mailto:rahul1.ku= mar@intel.com>
> Subject: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface= and Usages
>
> This patch series is a follow up of previous submission:
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.g= roups.io%2Fg%2Fdevel%2Fmessage%2F72442&amp;data=3D04%7C01%7Cbret.barkel= ew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f141af91a= b2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi= MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;s= data=3DcNexu92PbyNbxrUN7l%2BdZqVcwfvHfKFohUuWPvO2Py4%3D&amp;reserved=3D= 0
>
> v6 patches mainly focus on feedback for reviewed commits in v5 patche= s,
> including:
> a. Adding "Reviewed-by" and "Acked-by" tags for a= pplicable patch;
> b. Updating library class description for newly added interface;
>
> Patch v6 branch: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Fkuqin12%2Fedk2%2Ftree%2Funblock_mem_v6&amp;data=3D04%7C01%7Cbret= .barkelew%40microsoft.com%7C043a8827bad043bd7e9d08d8dfeb49ff%7C72f988bf86f1= 41af91ab2d7cd011db47%7C1%7C0%7C637505548948688125%7CUnknown%7CTWFpbGZsb3d8e= yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&am= p;amp;sdata=3Dy9LxiikpUmJsoRZNesHJFhrEMOFlGpXDG1IAB7s%2FRKE%3D&amp;rese= rved=3D0
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>
> Kun Qin (7):
>   MdePkg: MmUnblockMemoryLib: Added definition and null ins= tance
>   OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableS= mmRuntimeDxe)
>   MdeModulePkg: VariableSmmRuntimeDxe: Added request unbloc= k memory
>     interface
>   SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst
>   SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules
>   SecurityPkg: Tcg2Smm: Added support for Standalone Mm
>   SecurityPkg: Tcg2Acpi: Added unblock memory interface for= NVS region
>
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDx= e.c   |  42 +
>  MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c = ;          |  44 +
>  SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c}=            | 362 ++++----= -
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c   =             &nb= sp;        |  48 ++
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c     =             &nb= sp;            =       | 857 ++++----------------
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c   &nb= sp;            =            |  71 ++<= br> >  SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c   &n= bsp;            = ;          |  82 ++
>  MdeModulePkg/MdeModulePkg.dsc     &nbs= p;            &= nbsp;           &nbs= p;         |   1 +
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDx= e.inf |   1 +
>  MdePkg/Include/Library/MmUnblockMemoryLib.h   &n= bsp;            = ;          |  44 +
>  MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf&nb= sp;        |  34 +
>  MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.uni&nb= sp;        |  21 +
>  MdePkg/MdePkg.dec       &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;      |   5 +
>  MdePkg/MdePkg.dsc       &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp;      |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc      &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp; |   3 +
>  OvmfPkg/OvmfPkgIa32X64.dsc      &= nbsp;           &nbs= p;            &= nbsp;           | &n= bsp; 3 +
>  OvmfPkg/OvmfPkgX64.dsc       = ;            &n= bsp;            = ;            &n= bsp;  |   3 +
>  SecurityPkg/Include/Guid/TpmNvsMm.h    &nbs= p;            &= nbsp;           &nbs= p;    |  68 ++
>  SecurityPkg/SecurityPkg.ci.yaml     &n= bsp;            = ;            &n= bsp;       |   1 +
>  SecurityPkg/SecurityPkg.dec      =             &nb= sp;            =            |   = 8 +
>  SecurityPkg/SecurityPkg.dsc      =             &nb= sp;            =            |  12 + >  SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.= inf}       |  35 +-
>  SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl  &= nbsp;           &nbs= p;         |   0
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf  &nbs= p;            &= nbsp;      |  43 +
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h     =             &nb= sp;            =       | 121 +--
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf    &nbs= p;            &= nbsp;           &nbs= p;    |  27 +-
>  SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.i= nf}        |  50 +-
>  27 files changed, 952 insertions(+), 1035 deletions(-)
>  create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockM= emoryLibNull.c
>  copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Ac= pi.c} (72%)
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.= c
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c >  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c<= br> >  create mode 100644 MdePkg/Include/Library/MmUnblockMemoryLib.h<= br> >  create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockM= emoryLibNull.inf
>  create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockM= emoryLibNull.uni
>  create mode 100644 SecurityPkg/Include/Guid/TpmNvsMm.h
>  copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2= Acpi.inf} (76%)
>  rename SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl (100%= )
>  create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.= inf
>  copy SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2Standalon= eMm.inf} (52%)
>
> --
> 2.30.0.windows.1
>
>
>
>
>
>
>
>
>
>
>
>





 

--_000_MW4PR21MB1907F4FA06F544DE0344D1EDEF969MW4PR21MB1907namp_--