From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: Abner Chang <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Nickle Wang <nickle.wang@hpe.com>,
Peter O'Hanley <peter.ohanley@hpe.com>
Subject: Re: [EXTERNAL] [PATCH v12 6/6] .pytool: Add required submodule for JsonLib
Date: Sat, 2 Jan 2021 19:15:16 +0000 [thread overview]
Message-ID: <MW4PR21MB1987C48B03471FEA1F56006AEFD49@MW4PR21MB1987.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20201229055557.4679-7-abner.chang@hpe.com>
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]
Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
- Bret
From: Abner Chang<mailto:abner.chang@hpe.com>
Sent: Monday, December 28, 2020 10:43 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Nickle Wang<mailto:nickle.wang@hpe.com>; Peter O'Hanley<mailto:peter.ohanley@hpe.com>
Subject: [EXTERNAL] [PATCH v12 6/6] .pytool: Add required submodule for JsonLib
Open source project jansson is leveraged by edk2 JsonLib.
Add jansson to the required submodule in CiSettings.py.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Peter O'Hanley <peter.ohanley@hpe.com>
---
.pytool/CISettings.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index b337d046ae..416de023cc 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -158,6 +158,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
"MdeModulePkg/Library/BrotliCustomDecompressLib/brotli", False))
rs.append(RequiredSubmodule(
"BaseTools/Source/C/BrotliCompress/brotli", False))
+ rs.append(RequiredSubmodule(
+ "RedfishPkg/Library/JsonLib/jansson", False))
return rs
def GetName(self):
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 3851 bytes --]
next prev parent reply other threads:[~2021-01-02 19:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 5:55 [PATCH v12 0/6] jansson edk2 port Abner Chang
2020-12-29 5:55 ` [PATCH v12 1/6] RedfishPkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Abner Chang
2020-12-29 5:55 ` [PATCH v12 2/6] edk2: jansson submodule for edk2 JSON library Abner Chang
2020-12-29 5:55 ` [PATCH v12 3/6] RedfishPkg/RedfishCrtLib: Redfish C runtime library Abner Chang
2020-12-29 5:55 ` [PATCH v12 4/6] RedfishPkg/library: EDK2 port of jansson library Abner Chang
2020-12-29 5:55 ` [PATCH v12 5/6] RedfishPkg: Add EDK2 port of jansson library to build Abner Chang
2020-12-29 5:55 ` [PATCH v12 6/6] .pytool: Add required submodule for JsonLib Abner Chang
2021-01-02 19:15 ` Bret Barkelew [this message]
2021-01-04 23:01 ` [edk2-devel] [PATCH v12 0/6] jansson edk2 port Michael D Kinney
2021-01-05 1:09 ` Michael D Kinney
2021-01-05 7:11 ` Abner Chang
2021-01-06 17:26 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR21MB1987C48B03471FEA1F56006AEFD49@MW4PR21MB1987.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox