From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.22167.1658106902693629608 for ; Sun, 17 Jul 2022 18:15:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=E8wHaQZV; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=01985c5b6e=walon.li@hpe.com) Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26I0TWrK017230; Mon, 18 Jul 2022 01:14:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=2MTZOCb/gkpccN4h5ngvtL2nJNySezqikIPbWMWo68Y=; b=E8wHaQZVgZPEqSsDA8yUd8A+KVZpn6tbKDm/KoDo9gn9M04sNRKo4clVpSHkXW476yjQ Ic8diavMynU42fLYqo8UcEM7tk59QZYJpdTAE0ABBROmnUuNgJgEbnhT+aO38iVbuDNE 1YPjuclWAWj0S/O3Diz1k7NMtYWnWTQkHGoCgOLx+FMgZKBBV3zYbh4W7qBBGqlDlFH5 Q2/X69nkLbeCkCjg43LCrW16Vt11Q5nTqfjnatkIFbsVl3AKwdXwhKv2HhN8FDpfLbOi sF1fdsvYxWWrfz+Sc1ZXnq1S+nIABozWCnAUtAArR2lPEFFB/4eSJCqwvB+KdN7N26SH vw== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3hcw0nr62g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jul 2022 01:14:43 +0000 Received: from p1wg14925.americas.hpqcorp.net (unknown [10.119.18.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id F08E88058EF; Mon, 18 Jul 2022 01:14:41 +0000 (UTC) Received: from p1wg14927.americas.hpqcorp.net (10.119.18.117) by p1wg14925.americas.hpqcorp.net (10.119.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Sun, 17 Jul 2022 13:14:41 -1200 Received: from P1WG14918.americas.hpqcorp.net (16.230.19.121) by p1wg14927.americas.hpqcorp.net (10.119.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15 via Frontend Transport; Sun, 17 Jul 2022 13:14:41 -1200 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Mon, 18 Jul 2022 01:14:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQhlvPzkMsG0NKE0HiUDTC77i+ixRBNiL7uqubVuIdbhlpxpS9ACq74LNCjNvrYtXXONnGQiW+u7HZihncsNpne6KyQ0QqlqzViH5apGdXorgS2EyjVaGG/IAzQgiQMsRJ5nENYEcHZ/VmSThp51lzY5xFPkkuSsclh41hKxUbxEgAh6ZnREO9YnHRBlSlZese2fgR4TiFcOjffa1QqCtjo7eBeEtsZS3RB4W9JfNOxEpIJeNSouSVWHnsZT8YMfkXlxBY8ew7eBuBhnVe4KpdEPcBWmGFtzXioNQi1+53yhcHFjUu3JhMdZVdDG3nnbKFO7FdtfGwhlAcGBXl3XtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3bz14m9w6YZy5TTPgN1AGO6kyUMLhlsErw6cKBISDfk=; b=GsQbECAzj60tHqVKDIfxzYl5r/hngoWh0ubl3ISrUQXWhcHLAsHZoy2CoeYA9C0/rbu5CmhYQc9nRaWyqDax6Z6sTIoYCNBxCrsYvLCF/0GBmEk4n7NKqwxG9OQpuHkXpwbJ/ixm8389FJadT25pZ9Zw3OtGvpLbiLkCuNC/0noX7kGHOni8mHGotXQmUoNtQOvIuIcP7OhuZelBbu13HgKf+2MewSnHRUtOSk0PwHl0ruK1z6r2aMVFjmszajUxrhvYyAQJEm+BVtFY/rln42eeqObW+KQj8jyfd/gODjcIolD2vV/sL/FlI2F+RbnXPPiVLCQxHidAoQtk8V5wNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from MW4PR84MB1491.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1a6::9) by PH7PR84MB3129.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:1a7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 01:14:39 +0000 Received: from MW4PR84MB1491.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c930:fa0c:c8a0:540f]) by MW4PR84MB1491.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c930:fa0c:c8a0:540f%6]) with mapi id 15.20.5438.020; Mon, 18 Jul 2022 01:14:39 +0000 From: "Li, Walon" To: "devel@edk2.groups.io" , "gaoliming@byosoft.com.cn" CC: "Wang, Nickle (Server BIOS)" , "Li, Walon" Subject: Re: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way to reconnect driver Thread-Topic: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way to reconnect driver Thread-Index: AQHYh5DjbeQiqt6BEUG8EwYI9rNp762DeCsw Date: Mon, 18 Jul 2022 01:14:39 +0000 Message-ID: References: <20220624060747.1800-1-walon.li@hpe.com> In-Reply-To: <20220624060747.1800-1-walon.li@hpe.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bd438117-60c9-4866-be79-08da685ae32b x-ms-traffictypediagnostic: PH7PR84MB3129:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: en25TX4G8HlaC8KF7b0rMNHOTORr/sMajvEMaqmSd5q6YVlodsnPG2VIIg6/ZFjHuKw6HeqIhKhfLqnMgKA9qM7PH6Ju1zpaepZU1SafEcAAKQAmnUTgu8U9fP8d/0mp0vw/OlSwpy8D0Z7u1iqYh0K1pgYfuDki619XqFsDZQQN1m+JtIVpZ0EbbNwTFf2dmxBfebZy0yVqVQDDRdgKxIjPL8T9o6U72zBrgH/yacjcwUjck/BpY8MKdeIIvnInFdEY6tB2jSX1/WoBXbt1SYcVN5hkHLVVztyUCzfhK/VHRM+a9KYgx5Xyu3dDfdXma9bIvhwNJ4wxFV4XwoWvbaH4K+9eowKB/UQrZ3p1k/332zPCqUj8xCr0+w74f/DLlyA7TbcDkE53tacgTxVL7UUhr8lCaovFtNJ9IV2DAgBky86s3zbPm/Qc/SA88/AQJ3U9hlGHjuWgddRi9vFmVYcDgrxDDc7XJBmDrq9A1sUiCZ3rqV4rlSZ1IgR23Awee3HbR3MkqA/v8BWt6Uri+J2T3Z6gMDInHgO96108wksA4FJjm6Fzvt9tiaiadCPAWi93QNpoFa2GN6oBaQXsVNwaMS7rAYOhS45j5KCXyLMrIQ6CEd37kJoz1SR61Azppkv2b8R9NOb9uRMIh+tJLw8pVAe69/83VpD4bqso6UmPYFpBAbNc3vhzH7vAaOdmNT//0v3nzEY8mRLDx5m+hBIh4458mRE50qoNgcmpW7T8/4oRRuwAuz9wjXYumochSjtZBuERRkRshOysPFgqasXrvUe0uafQQ9vDD8caWUxd+pgDbpFd81FhhaBCaJlKDoM42eeHV66qPdUSINoOpKucYknXA5CF9CwsDcp86qDTHmTb6Ex9WR66K1K1OeL5 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR84MB1491.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(136003)(346002)(376002)(366004)(7696005)(6506007)(53546011)(41300700001)(71200400001)(478600001)(66574015)(186003)(83380400001)(26005)(9686003)(2906002)(5660300002)(55016003)(110136005)(54906003)(316002)(8936002)(52536014)(4326008)(8676002)(66446008)(66476007)(66556008)(66946007)(76116006)(64756008)(122000001)(38070700005)(33656002)(38100700002)(82960400001)(86362001)(43043002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t/QEDUiiTH90/ekxAzgRXAANUzbzyf3n0r8/e1d1VOgkDkEVg0Z2xj0SsR4i?= =?us-ascii?Q?FHkVXAIj66bwwVf6da9FazUywM7B1A86LL5kHj8lJe7xYgIf1ewUW9Er/OgK?= =?us-ascii?Q?06ZYrHbYIJjevZOYW77FtsEFqVDcCNUQDj6OjtbR7yXUHSOVOq5bmTG7lNj+?= =?us-ascii?Q?/QkeUJ0so+9x1eD5+ZP9G1SYU/psG2DDGpdxfapq12lTkzOfRmdDCq+wMSfh?= =?us-ascii?Q?ZLuni+LeITuBOCyTnKa3ZvpyK2Xg2SPkZkSu00HKvBvMJUdNKqIOjvIKz8Y9?= =?us-ascii?Q?iVli/EzLpW4jPWia0UoVtjPpu8gOxoNQuxKR8DQm/+OduT3Xbv10Dt+85zYF?= =?us-ascii?Q?J/LZ6Z6k5nQxyPUfWck1fMyXKIcUdlTsmF1ca8FRSy4oKeiPnZ/b38JO6kje?= =?us-ascii?Q?8mtuCKUm/xto3s2LFhIG/khCb2f51aW+q7bEtNANXOQK/qvGjL60mUd2KPZl?= =?us-ascii?Q?cYGb1Hy6om4Dro/32UMaG4QNHkRPxZ/PU7oNbudPZhfoPvmWxKdFu84eMh6V?= =?us-ascii?Q?eB/ttggz1guLRjp59Zq4FL39UTnjEtP2640xrrDiDQXZMIglwzejOfwKhdbz?= =?us-ascii?Q?Yo0etepDaOE4Mp3mqQ+nw2F4K2qxXJgPoU4+uU746Z7mIy2IsQqy89PCrDXF?= =?us-ascii?Q?75CGLl4P7XmgkRcJZZc/xz4Csu4z2xpA6+GsgzFwHi6HjyAyavliJdSpLiHF?= =?us-ascii?Q?eh3nTJIx0rTCo1bjRtQhlv/w06eVpaQK9/LhM1fpamWLCI8UWjn8EVAX2wvP?= =?us-ascii?Q?VPhvQrSU9Jn6gXEJipsw0IlioGfjBLLHax26nj0ExXj0R5/QsN3QYvnYY1K6?= =?us-ascii?Q?qYPeowefogAzAd+B3F0JQu2uMhTNiGpFDj61apLO1oXGQDVtcxmDht/MgMAu?= =?us-ascii?Q?2BJssd/BSOy4fbb1wUiOeA7f1VLkwzeHgu/T2DojMuSaC0ZPoa9x6oGZuoH/?= =?us-ascii?Q?/5y8d4uXlxlbQxpDMkeLBFB7CCevr4G2vYsz16HiR37BTT6naYcmzT9kogms?= =?us-ascii?Q?BSNTRVSrpZFL+iUmkoOM0LRqvkwx5abvOc3LYjAt/nOP973EPBHbneo6Dl3D?= =?us-ascii?Q?4iYqVxl3Iw4A5fLxr/rS9KUcMN1Ehfv5ASS22Ju6LgauZbMjjwNZKU5CMJ9f?= =?us-ascii?Q?V1+/FwAh38hOGNZWN9rADDuxjpw8g9s7mxLxCR+tjMlnQLKrIExk0isUF3VH?= =?us-ascii?Q?/3H0/8htF1Ep3onTXvDLPEJ5Ux9HZ6saeR47nG3/Wp/mvyLM6p5VJfkmsJAm?= =?us-ascii?Q?fUiUBrXlPa67aCai+Vi2FYdt5ph5+JnE1iAcXgt9Sr+HNBZyzq2PL5q2IDcJ?= =?us-ascii?Q?0BL/0BUXpMs1uFJfkhZ038jxyH4V7dubikgv7LpK6BaJFTnPfgpkMFloQEDK?= =?us-ascii?Q?+M9Y4xM385jQ8+tvihar5MjKLvgK3W2KppxuwLkQE6k+nEbCHLnKdaGCYkNA?= =?us-ascii?Q?ESxZ3EaA2wSBdOSlne11dbAKLtaIE7tNKOiiV0cJBu31LugW5sx6jAE1qBYD?= =?us-ascii?Q?VW/yTE5SCZDof9CnleNTWVi6QhVdu9eLKfL4IO4g3u3TIpGHxOG0ZztZ/Ynr?= =?us-ascii?Q?iajtiXujNrQwltOWMqU=3D?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR84MB1491.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: bd438117-60c9-4866-be79-08da685ae32b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 01:14:39.3673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TxoT4/QeQm+X5qmHxtcO0/Qu9+qvrQOZaxVId4nW4FSm+XAji/5Xti4NWXKhGHtIQIbwU+cyJ8K1qM1kpuY2/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB3129 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: bFsgCJmvgGpQHWJBCDdw45K6CEP6zxbK X-Proofpoint-GUID: bFsgCJmvgGpQHWJBCDdw45K6CEP6zxbK X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_01,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 mlxlogscore=793 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180004 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi edk2 and Liming, Who can help to review this change? Thanks. -----Original Message----- From: Li, Walon =20 Sent: Friday, June 24, 2022 2:08 PM To: devel@edk2.groups.io Cc: Li, Walon ; Wang, Nickle (Server BIOS) ; gaoliming@byosoft.com.cn Subject: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way to reconnec= t driver REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3952 In UEFI spec, it defines reconnect timing that will be activated upon exiti= ng of the formset or the browser. However, we did't use this kind of way to= check reconnect conditioncode. Code only blocks reconnect if page is updat= ed dynamically. That's not matched spec'd way. We should check current form= set whether is exiting, then reconnect driver. Signed-off-by: Walon Li --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 +--- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 +++------ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeMod= ulePkg/Universal/SetupBrowserDxe/Presentation.c index 9587b08d6d..babef21497 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c @@ -2,7 +2,7 @@ Utility functions for UI presentation. Copyright (c) 2004 - 2018, Intel C= orporation. All rights reserved.
-(C) Copyright 2015 Hewlett Packard Ent= erprise Development LP
+(C) Copyright 2015 - 2022 Hewlett Packard Enterp= rise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent **/@@= -21,7 +21,6 @@ LIST_ENTRY mRefreshEventList =3D INITIALIZE= _LIST_HEAD_VARIABLE (mR UINT16 mCurFakeQestId; FORM_DISPLAY_ENGINE_FORM gDispl= ayFormData; BOOLEAN mFinishRetrieveCall =3D FALSE;-BOOLEA= N mDynamicFormUpdated =3D FALSE; /** Check whether the= ConfigAccess protocol is available.@@ -1791,7 +1790,6 @@ FormUpdateNotify ( ) { mHiiPackageListUpdated =3D TRUE;- mDynamicFormUpdated =3D TRUE= ; return EFI_SUCCESS; }diff --git a/MdeModulePkg/Universal/SetupBrowserD= xe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index fe0d46d93f..5158baf5bd 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -2,7 +2,7 @@ Entry and initialization module for the browser. Copyright (c) 2007 - 201= 8, Intel Corporation. All rights reserved.
-(C) Copyright 2020 Hewlett P= ackard Enterprise Development LP
+(C) Copyright 2020 - 2022 Hewlett Pack= ard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Pat= ent **/@@ -68,7 +68,6 @@ extern EFI_GUID mCurrentFormSetG= uid; extern EFI_HII_HANDLE mCurrentHiiHandle; extern UINT16 = mCurrentFormId; extern FORM_DISPLAY_ENGINE_FORM gDisplayFormDat= a;-extern BOOLEAN mDynamicFormUpdated; /** Create a me= nu with specified formset GUID and form ID, and add it as a child@@ -539,7 = +538,6 @@ SendForm ( Selection->FormSet =3D FormSet; mSystemLevelFormSet =3D Form= Set;- mDynamicFormUpdated =3D FALSE; // // Display this f= ormset@@ -552,10 +550,9 @@ SendForm ( mSystemLevelFormSet =3D NULL; //- // If callback update = form dynamically, it's not exiting of the formset for user so system do not= reconnect driver hanlde- // this time.+ // Check incoming formse= t whether is same with previous. If yes, that means action is not exiting o= f formset so do not reconnect controller. //- if (!mDynamicFormU= pdated && (gFlagReconnect || gCallbackReconnect)) {+ if ((gFlagReconne= ct || gCallbackReconnect) && !CompareGuid (&FormSet->Guid, &Selection->Form= SetGuid)) { RetVal =3D ReconnectController (FormSet->DriverHandle);= if (!RetVal) { PopupErrorMessage (BROWSER_RECONNECT_FAIL= , NULL, NULL, NULL);--=20 2.23.0.windows.1