From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53C00780091 for ; Thu, 16 May 2024 01:38:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6DQA2VGszPH2RcpoK5S8t17Rj3FQl3U2ucoIOkIwaXY=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715823482; v=1; b=WXzPFgSvF5x/o/0NlQrHu62nBdfU3sWZAj9Xs+kEN8BvDaE/naBRMhCDXRM/6GZ/LcSDRZ5j dkqtycTTLxE33C2M9xzD7eJxw9D+SzG/UiymcdZTf+S9O/rqUto3qV44p55cilo6XAe8uGGquFL QP+MwQONUK8SXUIO6gQDkcWlxmQDAtjyVv9PRfhNW+SMxMjegylY9FEix2W6v9jniepSX66v5AM C5x7X5qxDB72hU+gX199WOfth5oBHGqrxEJyJ1BTrUR1Z+Td+lff0mbzWky+kVoCBVXHcjdHsTW wMLh1rzzKRU3cGFfN+woKdXq/wCbguwcozOK8IYWXqKhg== X-Received: by 127.0.0.2 with SMTP id ybVxYY7687511x1FIJP1U8Yx; Wed, 15 May 2024 18:38:02 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.56]) by mx.groups.io with SMTP id smtpd.web11.3073.1715823481359850907 for ; Wed, 15 May 2024 18:38:01 -0700 X-Received: from MW4SPRMB0024.namprd12.prod.outlook.com (2603:10b6:303:1bf::5) by SJ2PR12MB7944.namprd12.prod.outlook.com (2603:10b6:a03:4c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.26; Thu, 16 May 2024 01:37:55 +0000 X-Received: from MW4SPRMB0024.namprd12.prod.outlook.com ([fe80::8af8:fb3f:3821:c571]) by MW4SPRMB0024.namprd12.prod.outlook.com ([fe80::8af8:fb3f:3821:c571%5]) with mapi id 15.20.7544.052; Thu, 16 May 2024 01:37:55 +0000 From: "Nickle Wang via groups.io" To: "Chang, Abner" , Igor Kulchytskyy , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe Thread-Topic: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe Thread-Index: AQHalVHC+eOwnTG3tUCDH2WLi/Js3bGWzJvQgAG6VgCAAKjSAIAABYRw Date: Thu, 16 May 2024 01:37:55 +0000 Message-ID: References: <20240418122730.18204-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=02042108-8add-4e61-9fed-ea197e2b5c86;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-22T02:10:33Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4SPRMB0024:EE_|SJ2PR12MB7944:EE_ x-ms-office365-filtering-correlation-id: a30edc64-5fdf-4850-7c5c-08dc7548cf06 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?Dc17X0nIc/pJ34OebPDM/iiR/rhK/VQy9Ufw+UC3zq93V5oTUYjQ+CdppC9E?= =?us-ascii?Q?wxZwJ4WkTgZSFyNsTSuF7PvlfuqC9/aP/nkMNL/TEBVZM7fFrG8ELk1SH9cZ?= =?us-ascii?Q?8/p+VSQsIuDtzwKHdYHlhNpGmpStG9x154EiCbaU1OZQ5xp+KtIMkLNORdDN?= =?us-ascii?Q?XTww06AGMJKdhSK6+4o2cs9/VPqrbvA5A0BkfPfLl92ZNGhhprG10a/kXqxi?= =?us-ascii?Q?3y1GqBIYFp1vjFDt8OZnaLkYsXs3ci+u2iGcqcELcme7RE5rTKKWi97GFStb?= =?us-ascii?Q?yGPf2ohMA/DcHRGJGtZh2yUvVM3P221NzTJQHGPQWIB+5rZftK6q+T4MrVDJ?= =?us-ascii?Q?sciGvpDhwwX8b/n2kIEMvCt4naYyFBcDQ0kmtyoh28HnL593IQ/DQ2Adudk1?= =?us-ascii?Q?CMPV84HPDOunwL/jSq7sA+GAKFr2PwdW5+BWe0Rnt5ibdxeZyse6E0bSEIr0?= =?us-ascii?Q?m4XPMq/JZue7GJiuoL5KGvaaCDESKuriMgQhZA67a7EOWu53G670K5p+SywI?= =?us-ascii?Q?DtxBPbpiPDrML5QGgec0Bm5EoLPz/elY3zFLpQYXGGJDTn3aMAZbAHKmiOVa?= =?us-ascii?Q?/u5oNxItxnnumhVpmIR/mSzK2Cnui6hHAUUzhuYqXQj4pvZdwV8QwTH7quJV?= =?us-ascii?Q?o8ia3Hjzo2wqepZlH0hHikJ1r0JvtuvXV99+4zc5+beQPc9q5BetZVEQfKN8?= =?us-ascii?Q?dzx+8e5etRXmXLkd+qcXuY5l4ukN9IDDjFHwOhn7FFeAVaMJ+rFaRuCRivFH?= =?us-ascii?Q?nvW0/0fhnv5Si0Mk3qoeC2otCfetx2rciKM/EBYXevRMECp1Bvmj/EPszqIJ?= =?us-ascii?Q?xWWRA1kVOEfN6lESMuvHh55s9BElFihRF1DXBO4PTjTgauD9Nnnm5UtWjOHF?= =?us-ascii?Q?lMYR7DBPukvBv7YNpPEGQMnxJfD6dwp9OrR8Wn+fdGGMp3r6B6dUlmW0VBIb?= =?us-ascii?Q?qYyPz34tk/E6QWwL8ijSmmmkdCMcAOet5RDkqzMlM+jlRlKBDdi4PDphGxBn?= =?us-ascii?Q?98qCtL2s6VgXaxIfQpulVnsMLD15Zw+tGQr/os0bWLTSBDV8YxfT7gbj9x0N?= =?us-ascii?Q?NAVeR0MOcl1Rl250OkEIOkuxT3C6kMRV15DRxx/67gD8dg7zGPQkBic9nHsJ?= =?us-ascii?Q?6hLaeIXmnOJVqSfTkZHRismlQvtKyqyHH5b7rWj6y/6JlVCD9euLp6eQjIm2?= =?us-ascii?Q?87ue+BcZDOD4W3PWOqtnA2qPzV5p0s+x9/eS5ySNDINbLMKVQcUqeeZ003R8?= =?us-ascii?Q?CHQSXpUVjuUpqt+4HE3ijX7tbA4M+DIP8pEYixTdaTIU3ozLEE6dc0Ppe5BZ?= =?us-ascii?Q?js6GjME7KYLOLctw8+QHbIMIJYkmBuyRejlsviVVysy/+w=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LyDybpK5HLJq0mKiuLfCD6fvXHk9y6yQeew+Ii9XgBMb/GAfeRJWgRq4rRHJ?= =?us-ascii?Q?L++BIMVxvuFLkMvgMlRZuWarIgG1TsUSh3QH3KevLtPIDypRKP4I4ZffOsBq?= =?us-ascii?Q?Bl4R53+BMlnPNjpK7uChXj4NCrIi3QC8vEbua6+67ifq1/GNJ2dXjK4nVW86?= =?us-ascii?Q?xuV+TpxM5yvDFFp4K4ZqlK0SBBWLsm//0swZ/WS4Bq3txVRg1Zmj2nH0zc4Z?= =?us-ascii?Q?jDBO03voSkC5fFZi98nqp6JtE6jiYC1nixjaZHMhpNokx1J0Np0bagplRX+q?= =?us-ascii?Q?mv/vIIaiZsVr3E8Vgn/jEH29ROwD16Fj9yM5J4t+U6k51rKoyBTtSt7W2oXN?= =?us-ascii?Q?qLQCQ2rz6Y/AJIJt6lJSq9dnaIckOcadsNP4VNWQwt3F1A1NP9ACPWz0WdkQ?= =?us-ascii?Q?qtwdg/b6fG5cdknxTY+3HmR3ymTf+J5Y873vdMJn9N0ZOYg0v5l+oV1D2/Ko?= =?us-ascii?Q?KmOAdfD/kSfnsNgSAZzX+NiOQGjhTuGd4eiK1nZ1Zc8fMCmxFK8McFAR5BgG?= =?us-ascii?Q?K4fe6w8AE3CY61BPPWvTHKbojRU5SflfIODfwR67nT0jaZyYQPXncrtSQC09?= =?us-ascii?Q?Wx2L0IW1vXocP+oefoICn1TEfCvvm5bcrsuYsFa5MkcXYMCszPk0QEftQp3T?= =?us-ascii?Q?kX6kzwl/7VTwOn9dZOuoqK1yDXO4lPjYItU2awQuHACXTCroFKeIcruXCYCV?= =?us-ascii?Q?J+ZBF84PZEGqJE8086rngE5LlYLILzBQOfVG2RUhDz5khWM/SYJb0dqTOZei?= =?us-ascii?Q?9vfm6H5LEjnxtnm33t8i7yqSKmLJDZwtLmCq5wmNHQDBzs0AK+BgRurjkIHc?= =?us-ascii?Q?5+W7iDV1Q6aALqOEOMLvbjYBucvnV7RgNWpjV//i+RdESlKUNCG8qlZLWL83?= =?us-ascii?Q?FrTCExsKp3ad3hAQnmKfYzlyamx4K51fAjTAx4UYHZFGChtcICV8eRz0DEl9?= =?us-ascii?Q?BTKz7GxjKBA0f3v5yU/Or6x/9viBm6BAumkCsEz3dIZFiAx9VlUGf1I0h4Bs?= =?us-ascii?Q?WNiZ6DX+1HGCdz/JfmoSv6GJkAdseWg+lKi/lqINEf6SyGzqs4jHYgVOYQQZ?= =?us-ascii?Q?UF1ECVHuqfT59z7uiMg/yGvu4pMp04HDa12lrLIccRXChbMGfg4QGLFfbePa?= =?us-ascii?Q?i5yH/miKwn9ZmtQD6Xf+tpGYcDpWu6MCvb2iVDPAxsxCTY8c4eRZNO/tu5QF?= =?us-ascii?Q?5WyJ0+glUevWi5uDFtG1zHigsvSXqJrfeDT5me0YV+usU8+59xsPcKO3WuFa?= =?us-ascii?Q?oxffXzA/aAcHL+9y2kHgxlyqzfZdK1Mbf2NFqCIWMGlo0IBln1yiqmrZ6bf1?= =?us-ascii?Q?vm+LsiVPM/8QW4F2yjwD/rRCAb2iDzCj8sn4Rel4p1PrL7AoKqbum0mS8xza?= =?us-ascii?Q?zEvIOnaSNIpopz9gyN0LsGm0iy7h4aEOdHdabPlbx2fZPI+cV+C8olwiF7Q4?= =?us-ascii?Q?8Ut4pPKg5IVy98z5krIgvyu+GpK+jlciAJ0sJVHfLQt4pOPgDu/NYMywWdcq?= =?us-ascii?Q?IHtJW86Poyvs7zzYPLKeF1cVlwWblqQ50w/h6H0LqFHVuma2ED+YRF19OanQ?= =?us-ascii?Q?qYI4jjFH5ByDxwKg/w8=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4SPRMB0024.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a30edc64-5fdf-4850-7c5c-08dc7548cf06 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 01:37:55.1109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H3WwP3N3wu6eHNkWyObhzXfL3GFMo3cINXSqcT4tIAGDaagEVQp9jzav93Ps2lyJ0m63a0rq5lSG9xGVaceYHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7944 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 May 2024 18:38:01 -0700 Resent-From: nicklew@nvidia.com Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BVIe1ENOoR8RXyccYRLEYGzpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=WXzPFgSv; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Igor, Abner, > Maybe we should consider moving RedfishBootstrapAccountDxe driver to Redf= ishPkg and have some register mechanism which will be used by interested dr= ivers to notify that they finished their job and after that RedfishBootstra= pAccountDxe driver would delete an account. You are saying the mechanism in runtime, right? In current design, RedfishF= eatureCore driver will send "after provisioning" signal to notify this driv= er to delete bootstrapping account. This makes sure that all feature driver= s are done with their jobs, so this driver is safe to delete bootstrapping = account at BMC. If we move it to RedfishPkg, there is no such centralized Redfish driver ma= naging Redfish stuff. How does a particular driver know that there is no ot= her driver running Redfish stuff after it? The way I can think of now is to= rely on EDK2 ready-to-boot event as the signal to do the notification, sin= ce there is not supposed to have Redfish driver running jobs after this eve= nt... Regards, Nickle > -----Original Message----- > From: Chang, Abner > Sent: Thursday, May 16, 2024 9:06 AM > To: Igor Kulchytskyy ; Nickle Wang ; > devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] > RedfishClientPkg: introduce RedfishBootstrapAccountDxe >=20 > External email: Use caution opening links or attachments >=20 >=20 > [AMD Official Use Only - General] >=20 > HI Igor, > This sounds to me reasonable to me. As you mentioned, RedfishPkg was desi= gned > to support multiple Redfish applications and RedfishClientPkg is just one= of them. I > think we can review the implementation of acquiring/deleting credential. >=20 > Thanks > Abner >=20 >=20 > > -----Original Message----- > > From: Igor Kulchytskyy > > Sent: Wednesday, May 15, 2024 11:02 PM > > To: Nickle Wang ; devel@edk2.groups.io; Chang, > > Abner > > Cc: Nick Ramirez > > Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] > > RedfishClientPkg: introduce RedfishBootstrapAccountDxe > > > > [AMD Official Use Only - General] > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Hi Nickle, > > I have one more question to discuss regarding this driver. > > We have a bootstrap account and creation of this account controlled by > > RedfishCredentialDxe driver in RedfishPkg. > > But deletion of that bootstrap account is moved to RedfishClientPkg. > > What if we have another Redfish Client or some customer service which > > uses RedfishPkg for the communication. > > Architecturally it is allowed. > > But then RedfishBootstrapAccountDxe module would delete account just > > based on the RedfishClientPkg needs. > > Maybe we should consider moving RedfishBootstrapAccountDxe driver to > > RedfishPkg and have some register mechanism which will be used by > > interested drivers to notify that they finished their job and after > > that RedfishBootstrapAccountDxe driver would delete an account. > > What do you think? > > Thank you, > > Igor > > > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, May 14, 2024 8:40 AM > > To: devel@edk2.groups.io; abner.chang@amd.com; Igor Kulchytskyy > > > > Cc: Nick Ramirez > > Subject: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] > > RedfishClientPkg: introduce RedfishBootstrapAccountDxe > > > > > > **CAUTION: The e-mail below is from an external source. Please > > exercise caution before opening attachments, clicking links, or > > following guidance.** > > > > Hi Abner, > > > > > Ok, then I don't have the problem with invoking GetAuthInfo again. > > However, I > > > will suggest to add more description in GetAuthInfo function header, > > mention that > > > we will keep the auth info in EFI variable until exist boot service. > > > Also, give some more descriptions on the code you invoke to GetAuthIn= fo. > > > > Thanks for your comment. I add descriptions to explain above before > > calling GetAuthInfo(). Version 2 path is here: > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk= 2 > > .groups.io%2Fg%2Fdevel%2Fmessage%2F118889&data=3D05%7C02%7Cnicklew > %40nvi > > > dia.com%7C10ec4812a68a434b806008dc75445994%7C43083d15727340c1b7db > 39efd > > > 9ccc17a%7C0%7C0%7C638514183674607956%7CUnknown%7CTWFpbGZsb3d8 > eyJWIjoiM > > > C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7 > C%7C > > > &sdata=3DGNlisCnBmVQRhCLTxICGDsArv%2B64lC%2BkktUMi8Yg%2BJM%3D&rese > rved=3D0 > > > > Regards, > > Nickle > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Chang, > > Abner > > > via groups.io > > > Sent: Tuesday, April 23, 2024 3:42 PM > > > To: Nickle Wang ; Igor Kulchytskyy > > > ; devel@edk2.groups.io > > > Cc: Nick Ramirez > > > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientP= kg: > > > introduce RedfishBootstrapAccountDxe > > > > > > External email: Use caution opening links or attachments > > > > > > > > > [AMD Official Use Only - General] > > > > > > > -----Original Message----- > > > > From: Nickle Wang > > > > Sent: Tuesday, April 23, 2024 3:09 PM > > > > To: Igor Kulchytskyy ; Chang, Abner > > > > ; devel@edk2.groups.io > > > > Cc: Nick Ramirez > > > > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] > > RedfishClientPkg: > > > > introduce RedfishBootstrapAccountDxe > > > > > > > > [AMD Official Use Only - General] > > > > > > > > Caution: This message originated from an External Source. Use > > > > proper caution when opening attachments, clicking links, or respond= ing. > > > > > > > > > > > > Hi Igor, Abner, > > > > > > > > Thanks for your review. Please allow me to answer your questions > > together. > > > > > > > > > 1. We suppose acquire the credential before we start to > > > > > communicate with > > > > Redfish. Will Redfish credential driver create another bootstrap > > > > account here after provisioning? > > > > No, according to the RedfishPlatformCredentialIpmiLib > > > > implementation, Redfish credential driver requests credential from > > > > BMC and will keep it for later use. So only one credential is > > > > requested for BIOS Redfish feature drivers during POST time. > > > Ok, then I don't have the problem with invoking GetAuthInfo again. > > However, I > > > will suggest to add more description in GetAuthInfo function header, > > mention that > > > we will keep the auth info in EFI variable until exist boot service. > > > Also, give some more descriptions on the code you invoke to GetAuthIn= fo. > > > > > > > > > > > > 2. And why do we delete the credential after provisioning? How > > > > > about the > > > > later Redfish property updating process? > > > > In this driver, we listen to "AfterProvisioning" event. And this > > > > is the event triggered after Redfish feature driver finish all jobs= . > > > > There is no feature driver which gets executed after this event. > > > > And since we finished all Redfish operations, we remove this accoun= t on > BMC. > > > Then this makes sense to me now. > > > > > > > > > > > > Why do we need to delete those credentials? According to spec > > > > > BMC should > > > > delete the bootstrap credentials automatically on host or service r= eset. > > > > Yes, bootstrap credentials get deleted on host reset. In practice, > > > > server in datacenter usually takes long time running under OS > > > > before it gets > > > rebooted. > > > > The bootstrap credentials are exposed to end user at > > > > "/redfish/v1/AccountService/Accounts". I got report that there is > > > > concern for end user to see this unused account. > > > This sounds to me reasonable as we will give bootstrap credential a > > > high > > privilege > > > to update Redfish resource. Leave this information in Account > > > service seems > > not a > > > good idea. > > > > > > Thanks > > > Abner > > > > > > > > > > > So, I create this driver to allows us to remove bootstrap account > > > > at BMC after we finish Redfish jobs. And this also release the BMC > > > > account resource since this account won't be used for a long > > > > period of > > time. > > > > > > > > Regards, > > > > Nickle > > > > > > > > > -----Original Message----- > > > > > From: Igor Kulchytskyy > > > > > Sent: Monday, April 22, 2024 11:03 PM > > > > > To: Chang, Abner ; Nickle Wang > > > > > ; devel@edk2.groups.io > > > > > Cc: Nick Ramirez > > > > > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] > > RedfishClientPkg: > > > > > introduce RedfishBootstrapAccountDxe > > > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > Hi Nickle and Abner, > > > > > I also have the same question as Abner. > > > > > Why do we need to delete those credentials? > > > > > According to spec BMC should delete the bootstrap credentials > > > > > automatically > > > > on > > > > > host or service reset. > > > > > Thank you, > > > > > Igor > > > > > > > > > > -----Original Message----- > > > > > From: Chang, Abner > > > > > Sent: Sunday, April 21, 2024 10:25 PM > > > > > To: Nickle Wang ; devel@edk2.groups.io > > > > > Cc: Igor Kulchytskyy ; Nick Ramirez > > > > > > > > > Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClien= tPkg: > > > > > introduce RedfishBootstrapAccountDxe > > > > > > > > > > > > > > > **CAUTION: The e-mail below is from an external source. Please > > > > > exercise caution before opening attachments, clicking links, or > > > > > following guidance.** > > > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > Hi Nickle, > > > > > One comment and few questions, > > > > > > > > > > > -----Original Message----- > > > > > > From: Nickle Wang > > > > > > Sent: Thursday, April 18, 2024 8:28 PM > > > > > > To: devel@edk2.groups.io > > > > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > > > > ; Nick Ramirez > > > > > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: > > > > > > introduce RedfishBootstrapAccountDxe > > > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > > proper caution when opening attachments, clicking links, or > > responding. > > > > > > > > > > > > > > > > > > -Introduce RedfishBootstrapAccountDxe to delete bootstrap > > > > > > account from /redfish/v1/AccountService/Accounts after BIOS > > > > > > finished all Redfish jobs. The bootstrap account won't be > > > > > > available to other > > application. > > > > > > So deleting bootstrap account helps to release resource at BMC. > > > > > > - After bootstrap account is deleted at BMC, the Redfish > > > > > > service instance is no longer usable. Close Redfish service > > > > > > instance to release the HTTP connection between BIOS and BMC. > > > > > > > > > > > > Signed-off-by: Nickle Wang > > > > > > Cc: Abner Chang > > > > > > Cc: Igor Kulchytskyy > > > > > > Cc: Nick Ramirez > > > > > > --- > > > > > > .../RedfishClientComponents.dsc.inc | 1 + > > > > > > .../RedfishBootstrapAccountDxe.inf | 53 +++ > > > > > > .../RedfishBootstrapAccountDxe.h | 58 ++++ > > > > > > .../RedfishBootstrapAccountDxe.c | 328 ++++++++++= ++++++++ > > > > > > RedfishClientPkg/RedfishClient.fdf.inc | 1 + > > > > > > 5 files changed, 441 insertions(+) create mode 100644 > > > > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > > .inf > > > > > > create mode 100644 > > > > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > > .h > > > > > > create mode 100644 > > > > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > > .c > > > > > > > > > > > > diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > > b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > > index 42fc0c299..fe5248b62 100644 > > > > > > --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > > +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > > @@ -20,6 +20,7 @@ > > > > > > > > RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxe.inf > > > > > > RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.inf > > > > > > > > > > > > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxe.inf > > > > > > + > > > > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > > .inf > > > > > > !endif > > > > > > # > > > > > > # Below two modules should be pulled in by build tool. > > > > > > diff --git > > > > > > > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.in > > > > > > f > > > > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.in > > > > > > f > > > > > > new file mode 100644 > > > > > > index 000000000..4073e95f4 > > > > > > --- /dev/null > > > > > > +++ > > > > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.in > > > > > > f > > > > > > @@ -0,0 +1,53 @@ > > > > > > +## @file > > > > > > +# This driver deletes bootstrap account in BMC after BIOS > > > > > > +Redfish finished # all jobs # # (C) Copyright 2021 Hewlett > > > > > > +Packard Enterprise Development LP
# Copyright (c) 2023, > > > > > > +NVIDIA CORPORATION & AFFILIATES. All rights reserved. > > > > > > > > > > > > > > > Not sure if you want to update the copyright to 2024. > > > > > > > > > > > > > > > > +# > > > > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent # ## > > > > > > + > > > > > > +[Defines] > > > > > > + INF_VERSION =3D 0x0001000b > > > > > > + BASE_NAME =3D RedfishBootstrapAccountDxe > > > > > > + FILE_GUID =3D 87555253-2F7E-45FC-B469-FD35B2= E51210 > > > > > > + MODULE_TYPE =3D DXE_DRIVER > > > > > > + VERSION_STRING =3D 1.0 > > > > > > + ENTRY_POINT =3D RedfishBootstrapAccountEntryPo= int > > > > > > + UNLOAD_IMAGE =3D RedfishBootstrapAccountUnload > > > > > > + > > > > > > +[Packages] > > > > > > + MdePkg/MdePkg.dec > > > > > > + MdeModulePkg/MdeModulePkg.dec > > > > > > + RedfishPkg/RedfishPkg.dec > > > > > > + RedfishClientPkg/RedfishClientPkg.dec > > > > > > + > > > > > > +[Sources] > > > > > > + RedfishBootstrapAccountDxe.h > > > > > > + RedfishBootstrapAccountDxe.c > > > > > > + > > > > > > +[LibraryClasses] > > > > > > + BaseLib > > > > > > + BaseMemoryLib > > > > > > + DebugLib > > > > > > + MemoryAllocationLib > > > > > > + PrintLib > > > > > > + RedfishEventLib > > > > > > + RedfishFeatureUtilityLib > > > > > > + RedfishDebugLib > > > > > > + RedfishVersionLib > > > > > > + RedfishHttpLib > > > > > > + UefiLib > > > > > > + UefiBootServicesTableLib > > > > > > + UefiRuntimeServicesTableLib > > > > > > + UefiDriverEntryPoint > > > > > > + > > > > > > +[Protocols] > > > > > > + gEdkIIRedfishConfigHandlerProtocolGuid ## CONSUMES ## > > > > > > + gEdkIIRedfishCredentialProtocolGuid ## CONSUMES ## > > > > > > + gEfiRestExProtocolGuid ## CONSUMES ## > > > > > > + > > > > > > +[Depex] > > > > > > + gEdkIIRedfishCredentialProtocolGuid > > > > > > diff --git > > > > > > > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.h > > > > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.h > > > > > > new file mode 100644 > > > > > > index 000000000..5262f1e6b > > > > > > --- /dev/null > > > > > > +++ > > > > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.h > > > > > > @@ -0,0 +1,58 @@ > > > > > > +/** @file > > > > > > + Common header file for RedfishBootstrapAccountDxe driver. > > > > > > + > > > > > > + (C) Copyright 2021-2022 Hewlett Packard Enterprise > > > > > > + Development LP
Copyright (c) 2023, NVIDIA CORPORATION & > > > > > > + AFFILIATES. All > > > > rights > > > > > reserved. > > > > > > + > > > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > + > > > > > > +**/ > > > > > > + > > > > > > +#ifndef REDFISH_BOOTSTRAP_ACCOUNT_DXE_H_ #define > > > > > > +REDFISH_BOOTSTRAP_ACCOUNT_DXE_H_ > > > > > > + > > > > > > +#include > > > > > > +#include > > > > > > + > > > > > > +// > > > > > > +// Libraries > > > > > > +// > > > > > > +#include > > > > > > +#include #include > > > > > > + > > > > > > + > > > > > > +#include #include > > > > > > + #include > > > > > > +#include > > > > > > +#include #include > > > > > > + #include > > > > > > + #include > > > > > > + > > > > > > +#include #include > > > > > > + #include > > > > > > + > > > > > > + > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > + > > > > > > +#define REDFISH_BOOTSTRAP_ACCOUNT_DEBUG > > DEBUG_VERBOSE > > > > > > +#define REDFISH_MANAGER_ACCOUNT_COLLECTION_URI > > > > > > L"AccountService/Accounts" > > > > > > +#define REDFISH_URI_LENGTH 128 > > > > > > + > > > > > > +// > > > > > > +// Definitions of REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE // > > > > > > +typedef > > > > struct > > > > > > +{ > > > > > > + EFI_HANDLE ImageHandle; > > > > > > + EFI_HANDLE RestExHandle; > > > > > > + REDFISH_SERVICE RedfishService; > > > > > > + EFI_EVENT RedfishEvent; > > > > > > + EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL Protocol; > > > > > > +} REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE; > > > > > > + > > > > > > +#define > > > > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL(This) \ > > > > > > + BASE_CR ((This), REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE, > > > > > > +Protocol) > > > > > > + > > > > > > +#endif > > > > > > diff --git > > > > > > > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.c > > > > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.c > > > > > > new file mode 100644 > > > > > > index 000000000..6fe4856f8 > > > > > > --- /dev/null > > > > > > +++ > > > > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > > xe.c > > > > > > @@ -0,0 +1,328 @@ > > > > > > +/** @file > > > > > > + This driver deletes bootstrap account in BMC after BIOS > > > > > > +Redfish finished > > > > > > + all jobs. > > > > > > + > > > > > > + (C) Copyright 2021-2022 Hewlett Packard Enterprise > > > > > > + Development LP
Copyright (c) 2023, NVIDIA CORPORATION & > > > > > > + AFFILIATES. All > > > > rights > > > > > reserved. > > > > > > + > > > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > + > > > > > > +**/ > > > > > > + > > > > > > +#include "RedfishBootstrapAccountDxe.h" > > > > > > + > > > > > > +REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *mBootstrapPrivate =3D > > NULL; > > > > > > + > > > > > > +/** > > > > > > + Close Redfish service instance by calling RestEx protocol > > > > > > +to release > > > > instance. > > > > > > + > > > > > > + @param[in] RestExHandle Handle of RestEx protocol. > > > > > > + > > > > > > + @retval EFI_SUCCESS The Redfish service is closed = successfully. > > > > > > + @retval EFI_INVALID_PARAMETER RestExHandle is NULL. > > > > > > + @retval Others Error occurs. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +CloseRedfishService ( > > > > > > + IN EFI_HANDLE RestExHandle > > > > > > + ) > > > > > > +{ > > > > > > + EFI_REST_EX_PROTOCOL *RestEx; > > > > > > + EFI_STATUS Status; > > > > > > + > > > > > > + if (RestExHandle =3D=3D NULL) { > > > > > > + return EFI_INVALID_PARAMETER; } > > > > > > + > > > > > > + Status =3D gBS->HandleProtocol ( > > > > > > + RestExHandle, > > > > > > + &gEfiRestExProtocolGuid, > > > > > > + (VOID **)&RestEx > > > > > > + ); > > > > > > + if (!EFI_ERROR (Status)) { > > > > > > + Status =3D RestEx->Configure (RestEx, NULL); > > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: release > > RestEx > > > > > > instance: %r\n", __func__, Status)); > > > > > > + } > > > > > > + > > > > > > + return Status; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Callback function executed when the AfterProvisioning event > > > > > > +group is > > > > > > signaled. > > > > > > + > > > > > > + @param[in] Event Event whose notification function is b= eing > > invoked. > > > > > > + @param[out] Context Pointer to the Context buffer > > > > > > + > > > > > > +**/ > > > > > > +VOID > > > > > > +EFIAPI > > > > > > +RedfishBootstrapAccountOnRedfishAfterProvisioning ( > > > > > > + IN EFI_EVENT Event, > > > > > > + OUT VOID *Context > > > > > > + ) > > > > > > +{ > > > > > > + EFI_STATUS Status; > > > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > > > + EDKII_REDFISH_CREDENTIAL_PROTOCOL *credentialProtocol; > > > > > > + EDKII_REDFISH_AUTH_METHOD AuthMethod; > > > > > > + CHAR8 *AccountName; > > > > > > + CHAR8 *AccountCredential; > > > > > > + CHAR16 TargetUri[REDFISH_URI_LEN= GTH]; > > > > > > + CHAR16 *RedfishVersion; > > > > > > + REDFISH_RESPONSE RedfishResponse; > > > > > > + > > > > > > + RedfishVersion =3D NULL; > > > > > > + > > > > > > + Private =3D (REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *)Context; i= f > > > > > > + ((Private =3D=3D NULL) || (Private->RedfishService =3D=3D NUL= L)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: Redfish service is not > > > > > > + available\n", > > > > > > __func__)); > > > > > > + return; > > > > > > + } > > > > > > + > > > > > > + // > > > > > > + // Locate Redfish Credential Protocol to get credential for > > > > > > + // accessing to Redfish service. > > > > > > + // > > > > > > + Status =3D gBS->LocateProtocol ( > > > > > > + &gEdkIIRedfishCredentialProtocolGuid, > > > > > > + NULL, > > > > > > + (VOID **)&credentialProtocol > > > > > > + ); > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: No Redfish > > > > > > Credential Protocol is installed on system.", __func__)); > > > > > > + return; > > > > > > + } > > > > > > + > > > > > > + Status =3D credentialProtocol->GetAuthInfo ( > > > > > > + credentialProtocol, > > > > > > + &AuthMethod, > > > > > > + &AccountName, > > > > > > + &AccountCredential > > > > > > + ); > > > > > > > > > > HI Nickle, I am not quite understand why do we acquire a > > > > > credential here but delete it from the Redfish account service he= re after > provision. > > > > > 1. We suppose acquire the credential before we start to > > > > > communicate with Redfish. Will Redfish credential driver create > > > > > another bootstrap account here after provisioning? > > > > > 2. And why do we delete the credential after provisioning? How > > > > > about the > > > > later > > > > > Redfish property updating process? > > > > > Or do I misunderstand the code logic? > > > > > > > > > > Regards, > > > > > Abner > > > > > > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not get bootstrap account > > > > information: > > > > > > %r\n", __func__, Status)); > > > > > > + return; > > > > > > + } > > > > > > + > > > > > > + // > > > > > > + // Carving the URI > > > > > > + // > > > > > > + RedfishVersion =3D RedfishGetVersion > > > > > > + (Private->RedfishService); if (RedfishVersion =3D=3D NULL) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not get Redfish version\n", > > > > __func__)); > > > > > > + return; > > > > > > + } > > > > > > + > > > > > > + UnicodeSPrint (TargetUri, (sizeof (CHAR16) * > > > > > > + REDFISH_URI_LENGTH), > > > > > > L"%s%s/%a", RedfishVersion, > > > > > REDFISH_MANAGER_ACCOUNT_COLLECTION_URI, > > > > > > AccountName); > > > > > > + > > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > > account: > > > > > > %a\n", __func__, AccountName)); > > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > > > > credential: %a\n", __func__, AccountCredential)); > > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > URI: > > > > > > %s\n", __func__, TargetUri)); > > > > > > + > > > > > > + // > > > > > > + // Remove bootstrap account at > > > > > > + /redfish/v1/AccountService/Account > > > > > > + // > > > > > > + ZeroMem (&RedfishResponse, sizeof (REDFISH_RESPONSE)); > > > > > > + Status =3D RedfishHttpDeleteResource ( > > > > > > + Private->RedfishService, > > > > > > + TargetUri, > > > > > > + &RedfishResponse > > > > > > + ); > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not remove bootstrap > > > > > > + account at > > > > BMC: > > > > > > %r", __func__, Status)); > > > > > > + DumpRedfishResponse (__func__, DEBUG_ERROR, > > > > &RedfishResponse); } > > > > > > + else { > > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > > > account: > > > > > > %a is removed from: %s\n", __func__, AccountName, > > > > > > REDFISH_MANAGER_ACCOUNT_COLLECTION_URI)); > > > > > > + } > > > > > > + > > > > > > + // > > > > > > + // Clean credential > > > > > > + // > > > > > > + ZeroMem (AccountName, AsciiStrSize (AccountName)); ZeroMem > > > > > > + (AccountCredential, AsciiStrSize (AccountCredential)); > > > > > > + > > > > > > + // > > > > > > + // Since the bootstrap account is deleted at BMC, the > > > > > > + Redfish service instance > > > > > > is no longer usable. > > > > > > + // Close Redfish service instance to release the HTTP > > > > > > + connection between > > > > > > BIOS and BMC. > > > > > > + // > > > > > > + Status =3D CloseRedfishService (Private->RestExHandle); if > > > > > > + (EFI_ERROR (Status)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: cannot close Redfish service ins= tance: > > > > > > + %r\n", > > > > > > __func__, Status)); > > > > > > + } > > > > > > + > > > > > > + RedfishHttpFreeResponse (&RedfishResponse); > > > > > > + > > > > > > + return; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Initialize a Redfish configure handler. > > > > > > + > > > > > > + This function will be called by the Redfish config driver > > > > > > + to initialize each > > > > > > Redfish configure > > > > > > + handler. > > > > > > + > > > > > > + @param[in] This Pointer to > > > > > > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > > > > > > + @param[in] RedfishConfigServiceInfo Redfish service inform= aiton. > > > > > > + > > > > > > + @retval EFI_SUCCESS The handler has been in= itialized > > > > successfully. > > > > > > + @retval EFI_DEVICE_ERROR Failed to create or con= figure the > > REST > > > > EX > > > > > > protocol instance. > > > > > > + @retval EFI_ALREADY_STARTED This handler has alread= y been > > > > > > initialized. > > > > > > + @retval Other Error happens during th= e initialization. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +EFIAPI > > > > > > +RedfishBootstrapAccountInit ( > > > > > > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This, > > > > > > + IN REDFISH_CONFIG_SERVICE_INFORMATION > > > > *RedfishConfigServiceInfo > > > > > > + ) > > > > > > +{ > > > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > > > + > > > > > > + Private =3D > > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL > > > > > > (This); > > > > > > + > > > > > > + Private->RedfishService =3D RedfishCreateService > > > > > > + (RedfishConfigServiceInfo); if (Private->RedfishService =3D= =3D NULL) { > > > > > > + return EFI_DEVICE_ERROR; > > > > > > + } > > > > > > + > > > > > > + Private->RestExHandle =3D RedfishConfigServiceInfo- > > > > > > >RedfishServiceRestExHandle; > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Stop a Redfish configure handler. > > > > > > + > > > > > > + @param[in] This Pointer to > > > > > > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > > > > > > + > > > > > > + @retval EFI_SUCCESS This handler has been stope= d > > successfully. > > > > > > + @retval Others Some error happened. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +EFIAPI > > > > > > +RedfishBootstrapAccountStop ( > > > > > > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This > > > > > > + ) > > > > > > +{ > > > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > > > + > > > > > > + Private =3D > > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL > > > > > > (This); > > > > > > + > > > > > > + if (Private->RedfishService !=3D NULL) { > > > > > > + RedfishCleanupService (Private->RedfishService); > > > > > > + Private->RedfishService =3D NULL; } > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > +EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL > > mRedfishConfigHandler =3D > > > > { > > > > > > + RedfishBootstrapAccountInit, > > > > > > + RedfishBootstrapAccountStop }; > > > > > > + > > > > > > +/** > > > > > > + Unloads an image. > > > > > > + > > > > > > + @param[in] ImageHandle Handle that identifies the= image to > be > > > > > > unloaded. > > > > > > + > > > > > > + @retval EFI_SUCCESS The image has been unloaded. > > > > > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid > > > > > > + image > > > > handle. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +EFIAPI > > > > > > +RedfishBootstrapAccountUnload ( > > > > > > + IN EFI_HANDLE ImageHandle > > > > > > + ) > > > > > > +{ > > > > > > + EFI_STATUS Status; > > > > > > + > > > > > > + if (mBootstrapPrivate =3D=3D NULL) { > > > > > > + return EFI_SUCCESS; > > > > > > + } > > > > > > + > > > > > > + if (mBootstrapPrivate->RedfishEvent !=3D NULL) { > > > > > > + gBS->CloseEvent (mBootstrapPrivate->RedfishEvent); > > > > > > + } > > > > > > + > > > > > > + Status =3D gBS->UninstallProtocolInterface ( > > > > > > + mBootstrapPrivate->ImageHandle, > > > > > > + &gEdkIIRedfishConfigHandlerProtocolGuid, > > > > > > + (VOID *)&mBootstrapPrivate->Protocol > > > > > > + ); > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not uninstall Redfish > > > > > > + config handler > > > > > > protocol: %r\n", __func__, Status)); > > > > > > + } > > > > > > + > > > > > > + FreePool (mBootstrapPrivate); mBootstrapPrivate =3D NULL; > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + This is the declaration of an EFI image entry point. This > > > > > > +entry point is > > > > > > + the same for UEFI Applications, UEFI OS Loaders, and UEFI > > > > > > +Drivers including > > > > > > + both device drivers and bus drivers. > > > > > > + > > > > > > + @param[in] ImageHandle The firmware allocated handle = for the > > UEFI > > > > > > image. > > > > > > + @param[in] SystemTable A pointer to the EFI System Ta= ble. > > > > > > + > > > > > > + @retval EFI_SUCCESS The operation completed succes= sfully. > > > > > > + @retval Others An unexpected error occurred. > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +EFIAPI > > > > > > +RedfishBootstrapAccountEntryPoint ( > > > > > > + IN EFI_HANDLE ImageHandle, > > > > > > + IN EFI_SYSTEM_TABLE *SystemTable > > > > > > + ) > > > > > > +{ > > > > > > + EFI_STATUS Status; > > > > > > + > > > > > > + if (mBootstrapPrivate !=3D NULL) { > > > > > > + return EFI_ALREADY_STARTED; } > > > > > > + > > > > > > + mBootstrapPrivate =3D AllocateZeroPool (sizeof > > > > > > (REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE)); > > > > > > + if (mBootstrapPrivate =3D=3D NULL) { > > > > > > + return EFI_OUT_OF_RESOURCES; } > > > > > > + > > > > > > + CopyMem (&mBootstrapPrivate->Protocol, > > &mRedfishConfigHandler, > > > > > > + sizeof > > > > > > (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); > > > > > > + Status =3D gBS->InstallProtocolInterface ( > > > > > > + &ImageHandle, > > > > > > + &gEdkIIRedfishConfigHandlerProtocolGuid, > > > > > > + EFI_NATIVE_INTERFACE, > > > > > > + &mBootstrapPrivate->Protocol > > > > > > + ); > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not install Redfish config > > > > > > + handler > > > > > > protocol: %r\n", __func__, Status)); > > > > > > + goto ON_ERROR; > > > > > > + } > > > > > > + > > > > > > + // > > > > > > + // Register after provisioning event to remove bootstrap acc= ount. > > > > > > + // > > > > > > + Status =3D CreateAfterProvisioningEvent ( > > > > > > + RedfishBootstrapAccountOnRedfishAfterProvisioning= , > > > > > > + (VOID *)mBootstrapPrivate, > > > > > > + &mBootstrapPrivate->RedfishEvent > > > > > > + ); > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + DEBUG ((DEBUG_ERROR, "%a: failed to register > > > > > > + after-provisioning > > > > event: > > > > > > %r\n", __func__, Status)); > > > > > > + goto ON_ERROR; > > > > > > + } > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > + > > > > > > +ON_ERROR: > > > > > > + > > > > > > + RedfishBootstrapAccountUnload (ImageHandle); > > > > > > + > > > > > > + return Status; > > > > > > +} > > > > > > diff --git a/RedfishClientPkg/RedfishClient.fdf.inc > > > > > > b/RedfishClientPkg/RedfishClient.fdf.inc > > > > > > index 154f641b2..47e5093f2 100644 > > > > > > --- a/RedfishClientPkg/RedfishClient.fdf.inc > > > > > > +++ b/RedfishClientPkg/RedfishClient.fdf.inc > > > > > > @@ -15,6 +15,7 @@ > > > > > > INF > > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.inf > > > > > > INF RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > > > > > > INF > > > > > > > > > > > > RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > > > > > > + INF > > > > > > > > > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > .inf > > > > > > INF > > RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.inf > > > > > > INF > > > > > > > > > > > > RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf > > > > > > INF > > > > > > > > > > > > > > > > > RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemD > > > > xe. > > > > > > i > > > > > > nf > > > > > > -- > > > > > > 2.34.1 > > > > > > > > > > -The information contained in this message may be confidential > > > > > and > > > > proprietary > > > > > to American Megatrends (AMI). This communication is intended to > > > > > be read > > > > only by > > > > > the individual or entity to whom it is addressed or by their > > > > > designee. If the > > > > reader > > > > > of this message is not the intended recipient, you are on notice > > > > > that any distribution of this message, in any form, is strictly > > > > > prohibited. Please > > > > promptly > > > > > notify the sender by reply e-mail or by telephone at > > > > > 770-246-8600, and > > > > then > > > > > delete or destroy all copies of the transmission. > > > > > > > > >=20 > > > > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not > > the intended recipient, you are on notice that any distribution of > > this message, in any form, is strictly prohibited. Please promptly > > notify the sender by reply e-mail or by telephone at 770-246-8600, and = then > delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118940): https://edk2.groups.io/g/devel/message/118940 Mute This Topic: https://groups.io/mt/105596648/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-