* Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
[not found] <173AEF7243293292.25137@groups.io>
@ 2023-01-23 15:51 ` Milosek, Damian
2023-01-23 16:05 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Milosek, Damian @ 2023-01-23 15:51 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: ardb@kernel.org, sami.mujawar@arm.com, Yao, Jiewen,
supreeth.venkatesh@arm.com, Milosek, Damian
[-- Attachment #1: Type: text/plain, Size: 3867 bytes --]
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Milosek, Damian
Sent: Monday, January 16, 2023 2:51 PM
To: devel@edk2.groups.io
Cc: Milosek, Damian <damian.milosek@intel.com>
Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
Enable StandaloneMmMemLib to use longer physical addresses than 36 bits.
According to ARM "Learn the architecture - AArch64 memory management"
since Armv8.2-A physical address size was extended to 52 bits.
https://developer.arm.com/documentation/101811/0102/Address-spaces
Signed-off-by: Damian Milosek <damian.milosek@intel.com<mailto:damian.milosek@intel.com>>
---
.../StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c
index 297cfae916..dff3e0145f 100644
--- a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c
+++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c
@@ -6,7 +6,7 @@
all MMRAM range via MM_ACCESS_PROTOCOL, including the range for firmware (like MM Core
and MM driver) and/or specific dedicated hardware.
- Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2015 - 2023, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -21,7 +21,7 @@
extern EFI_PHYSICAL_ADDRESS mMmMemLibInternalMaximumSupportAddress;
#ifdef MDE_CPU_AARCH64
-#define ARM_PHYSICAL_ADDRESS_BITS 36
+#define ARM_PHYSICAL_ADDRESS_BITS 52
#endif
#ifdef MDE_CPU_ARM
#define ARM_PHYSICAL_ADDRESS_BITS 32
--
2.37.2.windows.2
________________________________
Intel Technology Poland sp. z o.o.
ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.
Spółka oświadcza, że posiada status dużego przedsiębiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdziałaniu nadmiernym opóźnieniom w transakcjach handlowych.
Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
[-- Attachment #2: Type: text/html, Size: 8928 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
2023-01-23 15:51 ` [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size Milosek, Damian
@ 2023-01-23 16:05 ` Ard Biesheuvel
2023-01-23 16:13 ` Milosek, Damian
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2023-01-23 16:05 UTC (permalink / raw)
To: Milosek, Damian; +Cc: devel@edk2.groups.io, sami.mujawar@arm.com, Yao, Jiewen
On Mon, 23 Jan 2023 at 16:51, Milosek, Damian <damian.milosek@intel.com> wrote:
>
>
>
>
>
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Milosek, Damian
> Sent: Monday, January 16, 2023 2:51 PM
> To: devel@edk2.groups.io
> Cc: Milosek, Damian <damian.milosek@intel.com>
> Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
>
>
>
> Enable StandaloneMmMemLib to use longer physical addresses than 36 bits.
>
What is the purpose of this change?
> According to ARM "Learn the architecture - AArch64 memory management"
>
> since Armv8.2-A physical address size was extended to 52 bits.
>
> https://developer.arm.com/documentation/101811/0102/Address-spaces
>
This is an optional extension. Which hardware are you using that
implements this extension?
>
>
> Signed-off-by: Damian Milosek <damian.milosek@intel.com>
>
> ---
>
> .../StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c | 4 ++--
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
>
> diff --git a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c
>
> index 297cfae916..dff3e0145f 100644
>
> --- a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c
>
> +++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c
>
> @@ -6,7 +6,7 @@
>
> all MMRAM range via MM_ACCESS_PROTOCOL, including the range for firmware (like MM Core
>
> and MM driver) and/or specific dedicated hardware.
>
>
>
> - Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
>
> + Copyright (c) 2015 - 2023, Intel Corporation. All rights reserved.<BR>
>
> Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
>
>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -21,7 +21,7 @@
>
> extern EFI_PHYSICAL_ADDRESS mMmMemLibInternalMaximumSupportAddress;
>
>
>
> #ifdef MDE_CPU_AARCH64
>
> -#define ARM_PHYSICAL_ADDRESS_BITS 36
>
> +#define ARM_PHYSICAL_ADDRESS_BITS 52
>
> #endif
>
> #ifdef MDE_CPU_ARM
>
> #define ARM_PHYSICAL_ADDRESS_BITS 32
>
> --
>
> 2.37.2.windows.2
>
> ________________________________
>
> Intel Technology Poland sp. z o.o.
> ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.
> Spółka oświadcza, że posiada status dużego przedsiębiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdziałaniu nadmiernym opóźnieniom w transakcjach handlowych.
>
> Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
>
>
>
>
>
> ________________________________
> Intel Technology Poland sp. z o.o.
> ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.
> Spółka oświadcza, że posiada status dużego przedsiębiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdziałaniu nadmiernym opóźnieniom w transakcjach handlowych.
>
> Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
2023-01-23 16:05 ` Ard Biesheuvel
@ 2023-01-23 16:13 ` Milosek, Damian
2023-01-23 17:46 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Milosek, Damian @ 2023-01-23 16:13 UTC (permalink / raw)
To: devel@edk2.groups.io, Ard Biesheuvel
Cc: sami.mujawar@arm.com, Yao, Jiewen, Milosek, Damian
-----Original Message-----
From: Ard Biesheuvel <ardb@kernel.org>
Sent: Monday, January 23, 2023 5:05 PM
To: Milosek, Damian <damian.milosek@intel.com>
Cc: devel@edk2.groups.io; sami.mujawar@arm.com; Yao, Jiewen <jiewen.yao@intel.com>
Subject: Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
On Mon, 23 Jan 2023 at 16:51, Milosek, Damian <damian.milosek@intel.com> wrote:
>
>
>
>
>
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Milosek, Damian
> Sent: Monday, January 16, 2023 2:51 PM
> To: devel@edk2.groups.io
> Cc: Milosek, Damian <damian.milosek@intel.com>
> Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib:
> Update AARCH64 address size
>
>
>
> Enable StandaloneMmMemLib to use longer physical addresses than 36 bits.
>
What is the purpose of this change?
- Making this Lib working for newer systems that use longer addresses.
> According to ARM "Learn the architecture - AArch64 memory management"
>
> since Armv8.2-A physical address size was extended to 52 bits.
>
> https://developer.arm.com/documentation/101811/0102/Address-spaces
>
This is an optional extension. Which hardware are you using that implements this extension?
- System with Armv9-A Neoverse CPU cores.
>
>
> Signed-off-by: Damian Milosek <damian.milosek@intel.com>
>
> ---
>
> .../StandaloneMmMemLib/ArmStandaloneMmMemLibInternal.c | 4 ++--
>
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
>
> diff --git
> a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInte
> rnal.c
> b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInte
> rnal.c
>
> index 297cfae916..dff3e0145f 100644
>
> ---
> a/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLibInte
> rnal.c
>
> +++ b/StandaloneMmPkg/Library/StandaloneMmMemLib/ArmStandaloneMmMemLib
> +++ Internal.c
>
> @@ -6,7 +6,7 @@
>
> all MMRAM range via MM_ACCESS_PROTOCOL, including the range for
> firmware (like MM Core
>
> and MM driver) and/or specific dedicated hardware.
>
>
>
> - Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
>
> + Copyright (c) 2015 - 2023, Intel Corporation. All rights
> + reserved.<BR>
>
> Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
>
>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -21,7 +21,7 @@
>
> extern EFI_PHYSICAL_ADDRESS mMmMemLibInternalMaximumSupportAddress;
>
>
>
> #ifdef MDE_CPU_AARCH64
>
> -#define ARM_PHYSICAL_ADDRESS_BITS 36
>
> +#define ARM_PHYSICAL_ADDRESS_BITS 52
>
> #endif
>
> #ifdef MDE_CPU_ARM
>
> #define ARM_PHYSICAL_ADDRESS_BITS 32
>
> --
>
> 2.37.2.windows.2
>
> ________________________________
>
> Intel Technology Poland sp. z o.o.
> ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.
> Spółka oświadcza, że posiada status dużego przedsiębiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdziałaniu nadmiernym opóźnieniom w transakcjach handlowych.
>
> Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
>
>
>
>
>
> ________________________________
> Intel Technology Poland sp. z o.o.
> ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gdańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.
> Spółka oświadcza, że posiada status dużego przedsiębiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdziałaniu nadmiernym opóźnieniom w transakcjach handlowych.
>
> Ta wiadomość wraz z załącznikami jest przeznaczona dla określonego adresata i może zawierać informacje poufne. W razie przypadkowego otrzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usunięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
2023-01-23 16:13 ` Milosek, Damian
@ 2023-01-23 17:46 ` Ard Biesheuvel
2023-01-24 12:20 ` [edk2-devel] " Milosek, Damian
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2023-01-23 17:46 UTC (permalink / raw)
To: Milosek, Damian; +Cc: devel@edk2.groups.io, sami.mujawar@arm.com, Yao, Jiewen
On Mon, 23 Jan 2023 at 17:14, Milosek, Damian <damian.milosek@intel.com> wrote:
>
>
>
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Monday, January 23, 2023 5:05 PM
> To: Milosek, Damian <damian.milosek@intel.com>
> Cc: devel@edk2.groups.io; sami.mujawar@arm.com; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
>
> On Mon, 23 Jan 2023 at 16:51, Milosek, Damian <damian.milosek@intel.com> wrote:
> >
> >
> >
> >
> >
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Milosek, Damian
> > Sent: Monday, January 16, 2023 2:51 PM
> > To: devel@edk2.groups.io
> > Cc: Milosek, Damian <damian.milosek@intel.com>
> > Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib:
> > Update AARCH64 address size
> >
> >
> >
> > Enable StandaloneMmMemLib to use longer physical addresses than 36 bits.
> >
>
> What is the purpose of this change?
>
> - Making this Lib working for newer systems that use longer addresses.
>
What is the symptom? How is it failing currently?
> > According to ARM "Learn the architecture - AArch64 memory management"
> >
> > since Armv8.2-A physical address size was extended to 52 bits.
> >
> > https://developer.arm.com/documentation/101811/0102/Address-spaces
> >
>
> This is an optional extension. Which hardware are you using that implements this extension?
>
> - System with Armv9-A Neoverse CPU cores.
>
Which system? What does the memory map look like?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
2023-01-23 17:46 ` Ard Biesheuvel
@ 2023-01-24 12:20 ` Milosek, Damian
2023-01-24 12:32 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Milosek, Damian @ 2023-01-24 12:20 UTC (permalink / raw)
To: devel@edk2.groups.io, ardb@kernel.org
Cc: sami.mujawar@arm.com, Yao, Jiewen, Milosek, Damian
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
Sent: Monday, January 23, 2023 6:46 PM
To: Milosek, Damian <damian.milosek@intel.com>
Cc: devel@edk2.groups.io; sami.mujawar@arm.com; Yao, Jiewen <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
On Mon, 23 Jan 2023 at 17:14, Milosek, Damian <damian.milosek@intel.com> wrote:
>
>
>
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Monday, January 23, 2023 5:05 PM
> To: Milosek, Damian <damian.milosek@intel.com>
> Cc: devel@edk2.groups.io; sami.mujawar@arm.com; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update
> AARCH64 address size
>
> On Mon, 23 Jan 2023 at 16:51, Milosek, Damian <damian.milosek@intel.com> wrote:
> >
> >
> >
> >
> >
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Milosek, Damian
> > Sent: Monday, January 16, 2023 2:51 PM
> > To: devel@edk2.groups.io
> > Cc: Milosek, Damian <damian.milosek@intel.com>
> > Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib:
> > Update AARCH64 address size
> >
> >
> >
> > Enable StandaloneMmMemLib to use longer physical addresses than 36 bits.
> >
>
> What is the purpose of this change?
>
> - Making this Lib working for newer systems that use longer addresses.
>
What is the symptom? How is it failing currently?
- Failure occurs in the first check in MmIsBufferOutsideMmValid () function when using longer address.
> > According to ARM "Learn the architecture - AArch64 memory management"
> >
> > since Armv8.2-A physical address size was extended to 52 bits.
> >
> > https://developer.arm.com/documentation/101811/0102/Address-spaces
> >
>
> This is an optional extension. Which hardware are you using that implements this extension?
>
> - System with Armv9-A Neoverse CPU cores.
>
Which system? What does the memory map look like?
- It is not productized yet so cannot give any more info. However it seems that specific system is not relevant here.
Current definition assumes max 36 bits for AARCH64 which is not the case anymore.
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
2023-01-24 12:20 ` [edk2-devel] " Milosek, Damian
@ 2023-01-24 12:32 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2023-01-24 12:32 UTC (permalink / raw)
To: Milosek, Damian; +Cc: devel@edk2.groups.io, sami.mujawar@arm.com, Yao, Jiewen
On Tue, 24 Jan 2023 at 13:20, Milosek, Damian <damian.milosek@intel.com> wrote:
>
>
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel
> Sent: Monday, January 23, 2023 6:46 PM
> To: Milosek, Damian <damian.milosek@intel.com>
> Cc: devel@edk2.groups.io; sami.mujawar@arm.com; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size
>
> On Mon, 23 Jan 2023 at 17:14, Milosek, Damian <damian.milosek@intel.com> wrote:
> >
> >
> >
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Monday, January 23, 2023 5:05 PM
> > To: Milosek, Damian <damian.milosek@intel.com>
> > Cc: devel@edk2.groups.io; sami.mujawar@arm.com; Yao, Jiewen
> > <jiewen.yao@intel.com>
> > Subject: Re: [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update
> > AARCH64 address size
> >
> > On Mon, 23 Jan 2023 at 16:51, Milosek, Damian <damian.milosek@intel.com> wrote:
> > >
> > >
> > >
> > >
> > >
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Milosek, Damian
> > > Sent: Monday, January 16, 2023 2:51 PM
> > > To: devel@edk2.groups.io
> > > Cc: Milosek, Damian <damian.milosek@intel.com>
> > > Subject: [edk2-devel] [PATCH] StandaloneMmPkg/StandaloneMmMemLib:
> > > Update AARCH64 address size
> > >
> > >
> > >
> > > Enable StandaloneMmMemLib to use longer physical addresses than 36 bits.
> > >
> >
> > What is the purpose of this change?
> >
> > - Making this Lib working for newer systems that use longer addresses.
> >
>
> What is the symptom? How is it failing currently?
>
> - Failure occurs in the first check in MmIsBufferOutsideMmValid () function when using longer address.
>
> > > According to ARM "Learn the architecture - AArch64 memory management"
> > >
> > > since Armv8.2-A physical address size was extended to 52 bits.
> > >
> > > https://developer.arm.com/documentation/101811/0102/Address-spaces
> > >
> >
> > This is an optional extension. Which hardware are you using that implements this extension?
> >
> > - System with Armv9-A Neoverse CPU cores.
> >
>
> Which system? What does the memory map look like?
>
> - It is not productized yet so cannot give any more info. However it seems that specific system is not relevant here.
> Current definition assumes max 36 bits for AARCH64 which is not the case anymore.
>
Fair enough.
The problem with 52 bit support is that when using 4k pages (which is
the only page size supported by EFI), the page table entry layout is
different, and the shareability of a region is derived in a different
manner. None of this is implemented in the MMU library, and I would
actually prefer to avoid this if possible.
We can increase this to 48 without any problems, though.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-24 12:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <173AEF7243293292.25137@groups.io>
2023-01-23 15:51 ` [PATCH] StandaloneMmPkg/StandaloneMmMemLib: Update AARCH64 address size Milosek, Damian
2023-01-23 16:05 ` Ard Biesheuvel
2023-01-23 16:13 ` Milosek, Damian
2023-01-23 17:46 ` Ard Biesheuvel
2023-01-24 12:20 ` [edk2-devel] " Milosek, Damian
2023-01-24 12:32 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox