public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Donald Kuo" <donald.kuo@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	"Wang, William2" <william2.wang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>,
	"Kumar, Chandana C" <chandana.c.kumar@intel.com>
Subject: Re: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM.
Date: Mon, 16 Jan 2023 09:23:29 +0000	[thread overview]
Message-ID: <MW5PR11MB590537D315FD35AE591424C29CC19@MW5PR11MB5905.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN6PR11MB8244964195C96D6AD1BDA8638CC19@MN6PR11MB8244.namprd11.prod.outlook.com>

Thanks Ray to clarify.

@Wang, William2 let's follow the EDK2 recommendation.   

Thanks,

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Monday, January 16, 2023 5:19 PM
To: Kuo, Donald <donald.kuo@intel.com>; Wang, William2 <william2.wang@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kumar, Chandana C <chandana.c.kumar@intel.com>
Subject: RE: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM.

Donald,
Old code might reference existing Reserved field in the structure definition.
So, to avoid old code assigning value to different bits if using same field name but for different bits position,
edk2 recommends to change the field name from ReservedX to ReservedY when the bits covered by ReservedX are changed. Y is the next unused index.

So comments as below:

> 
> -    UINT32    Reserved5                              : 11;
> 
> +    UINT32    Reserved4                              : 2;
We should rename Reserved5 to Reserved6.


> 
> +    UINT32    IA32_THERM_INTERRUPT                   : 1;
> 
> +    UINT32    Reserved5                              : 7;
Reserved7.


  reply	other threads:[~2023-01-16  9:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  8:25 [PATCH v2] Update CPUID Leaf 06H to follow latest SDM william2.wang
2023-01-16  8:40 ` Donald Kuo
2023-01-16  9:19   ` Ni, Ray
2023-01-16  9:23     ` Donald Kuo [this message]
2023-01-17  3:53       ` william2.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW5PR11MB590537D315FD35AE591424C29CC19@MW5PR11MB5905.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox