From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.162664.1673861015561927228 for ; Mon, 16 Jan 2023 01:23:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HJVJwmJq; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: donald.kuo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673861015; x=1705397015; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vjeCJzszzuLycPxoTRNiki3sVingLKbO1d/5GQy1INc=; b=HJVJwmJqwgHyP+Tcfygex7GrNJHapBUOtkN8tq32qsYrF2Xjj//HSIRO KY8fcpArTlKDC5WG+J9auitzaVpDYB9fczToyN+rTNjoNjGr7msU9kKRT IQ7j8562q0iGqdQlt/Xoe/HySLn3X+RMZPJauu+4sOI8gQg03rrb2oSWc dP91eWq+FAdcd8VDKGVkg1Un/k9fT3JJCR1zKXgaCP669ujnMQrGdFQsQ Syi1ykgA5dhDHq6teRM1jvmtFIq7j27HTNwdnXJvWCkoR7WjDf9kEgCia 6Z3jGNpLEIWlmrYdeCBy4Wf+2LFxRhPIxMoMdksiwLCGKJFpuWJPQ0MJV A==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="324481961" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="324481961" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 01:23:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="658954554" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="658954554" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 16 Jan 2023 01:23:34 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 01:23:32 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 01:23:31 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 01:23:31 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 01:23:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjN6hRyw8EatQi2aN4QkE+B7Ymf+eKUIBY8iFuOYGdzFs6pKjhQGD1PUgx2WUnNFb6FUdTbxpNMdDNEp+zO3LeSvcmLfjAYC25wpp5eJYWnT+5lLgAo+OwA77srtTkicq0DVTh2iZBelnyD66LLq2uCTwn2b0x0HXevEj8p3UQi5tZeVpSRwPvjGf6xxCIfx3sPzi0A8iFzygK9pwap77PeF8Qkt9B3jaZMmU9hTj2j3zakEAkM6G+RCg1c83/Lot+8E95GG7NI1Ov4LjhxVx3P4NZodscWKa+NVVBGEDY5PEZswNYxiyZ2MAa2hAMlRjP2Hnhgw9onoPHaGYm2YhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43mzXBCIkdeVWNBX9laWnZwN8kPYP84/U0oO1tMUTOw=; b=aMAEYb9e1OSjtXO6u99zeDH3z4ngd2srv+A8IxIppSS6fTuCgzQCI3e0y+JsQS8eOlFuw7CiriYppNwu1kI4rMGUgS3iZwB5VKu1QbWYQOZ2gh0dlNfosl0u4kPHSTJ2K7qjfWY0wZsj7I5TUXKKyA2XrySMMBDcPA4jTmQNpaq5w6iuudrOHYpx95lyZ1Hkl5FyIXWTAlfukiD4yXcwAccqLQN6EKh++Y+uiBACkyY4CAHcGdTvKbcF/9OG+lL56dltOYnjDQyTUGazd/jLA2Zwcmhj2Ju5qtdC1ARIyuGbdhbN9ufxEE0VDRdBC/WeEHUda+WzTvzas/BbzAEvjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5905.namprd11.prod.outlook.com (2603:10b6:303:19f::7) by MW4PR11MB5871.namprd11.prod.outlook.com (2603:10b6:303:188::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Mon, 16 Jan 2023 09:23:29 +0000 Received: from MW5PR11MB5905.namprd11.prod.outlook.com ([fe80::3dee:1760:e5aa:7d67]) by MW5PR11MB5905.namprd11.prod.outlook.com ([fe80::3dee:1760:e5aa:7d67%5]) with mapi id 15.20.5986.022; Mon, 16 Jan 2023 09:23:29 +0000 From: "Donald Kuo" To: "Ni, Ray" , "Wang, William2" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Kumar, Chandana C" Subject: Re: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Topic: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Index: AQHZJyiup9QKfnIHvE+w8Ghov/QA1K6guvwAgAAN7wCAAAB28A== Date: Mon, 16 Jan 2023 09:23:29 +0000 Message-ID: References: <20230113082551.685-1-william2.wang@intel.com> In-Reply-To: Accept-Language: zh-TW, en-US X-Mentions: william2.wang@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5905:EE_|MW4PR11MB5871:EE_ x-ms-office365-filtering-correlation-id: e1135911-9f26-4819-38e1-08daf7a3546e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gqylDM78pSDNbymkmHUj1ZSx6Ks/4SgWVKe8Iy5dDgX/t4yZmt2/SuvGtt1z6ItUiQFI3mRDz/b//CQ6Jz9CoxKdS/N86z5rJYPi00HVH7A6q9kwdGHtXPA/FG1AuF09ovMONRRVjDhsnaO3X8I1AgHWuLHFh2Knoqlg/nZVYzy9SFaRat+MeraUMmAHzJWnPERsplJKma26SQMD4U6vHcMv0rbSOfxVp5sGtZ7rnOFg8Km80IoyjMT5WwColLq66H1d708IMRfQeKksnOeEOnDGK7uKUKYcwIaUfsDrH1jsO9v6WYql2iCXr+uC/SN4ncxM0Qsbc4s+znELysQ8GF0J2TyVEmLaAppqjkp3vZ68MhSIcgQx5FY3bbHZfECo+pPI8Y3ROZskTAK5eauK3h/i0UW0Nms9rM5BsN3nM7LqLpO651kEC5eXW2+qdwck6I3/4VUrRHhpS6Qr4b26dR0MOIGASY0ykdXBl4W//B3xhbVm98iH+D9jlwP6GGJ5oe/sGycMR2vtefYJg7Pk/tG+69SMdVYfp4Cx9VW5JO4foEvOza4MDEGVcXGKfwJWE/SGWdmuUTJa+Ks3k5u9ybrgaWitU1CvlCfHq0cOxiDSM2FGjgPcWyn/4UjBouf4AHgeklT+3hscKjFQUdKKIBKz/eo3xF+h8nFsHLbNkG6/EXGUwSwjEP8ooTb4bBHw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5905.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39850400004)(346002)(396003)(136003)(366004)(376002)(451199015)(64756008)(54906003)(8676002)(76116006)(66946007)(66476007)(66446008)(316002)(66556008)(4326008)(38070700005)(110136005)(15650500001)(33656002)(2906002)(4744005)(55016003)(5660300002)(38100700002)(41300700001)(82960400001)(83380400001)(52536014)(122000001)(8936002)(7696005)(71200400001)(26005)(186003)(478600001)(9686003)(86362001)(6506007)(53546011)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Nm39SMWhaB6O8uoSM1ySooxhPjU6ZMsj7cXSyde8NUQpCJ/j8/gixOr9fe/c?= =?us-ascii?Q?JpKHNC9n3hTsi2hP/RjkB6vqM9Auc0BadVb4oox7EAwu+wHo5BUwAxSCvSwn?= =?us-ascii?Q?htp6mxH8uxrJKaM+SAciuTGAaBrk7/blcmBjJ1vAKvpwGagVTBdfZWXLh8Qw?= =?us-ascii?Q?R2l4KlDdNafNkBcxYZcTGL7wqrSHIJdyjJnQ2T/kAb7g0gQ0cO+fsqIxCIQB?= =?us-ascii?Q?hDTyCq7Y+d25P3IWHZH1zUjMd0jDbqCfKF2viZ6nFDPic/U3q/pAqyml4OC4?= =?us-ascii?Q?no66DyHWhDWOEIsACy4ywsz+Xzmv9rJJ4wKFOxa160A4stIuu2bojEKbHz9C?= =?us-ascii?Q?XFxXR4k0u9iGZjWDJK1BV8KndLgxS1OfIkFsYCsjLmjKPaWI5wRy95mwUUpL?= =?us-ascii?Q?wOYFsOOh9boltezNclBRgb6PUCuQJ2rMT9AIiiEdZYxg4j80+KjO4ZLlLRai?= =?us-ascii?Q?GOTgYbIEdPD6BGluchCgKYG6LwE3ZFBwdDCncgaeyO25Ieg5geAcCXaZOKFp?= =?us-ascii?Q?oR7mxn3yGifNy82qPQRv/Lm76BQvPubM2DSxWFRCHdrSEKI1QIAIcwHAafwU?= =?us-ascii?Q?M2MUYPsqYiJJVxiq4x7oLN0x7gAoCBKLvDnwQTE2313wFyzeGfERFwb7VFaH?= =?us-ascii?Q?z8lRPL03EJttdvEF6aZiPG/0tdcOat//ozMRo/0YwgpJHJcnxIK97tx4qTyQ?= =?us-ascii?Q?0T/hD52LI+YGLmvOW4+vbuAW4r0kAg+RRuTFeFlgCe3HcwCZhUsyhQT6CTRQ?= =?us-ascii?Q?bj2/Fx2wE6jEH/GVO5kwa6dG8XbaCL4tzCkS/2zNE1RbIn4sYD7OOpzp7S4+?= =?us-ascii?Q?gOKG0P1kXA2QUWh3n6NjDZqFZEWWZtF7mRRQfUyibf5KnZVnrx0SNH9dXgfi?= =?us-ascii?Q?gaJXVMOVyRbisPaqabVLMWaup0tsAZUVu3YfeapGWBYUVVMSKlHl4YVkNUYM?= =?us-ascii?Q?0nPL1V+kIep0gIXRi6CBt22vqIXWUGGIFJZSH7FGpWtlbf6I9kXQeYNgYnCp?= =?us-ascii?Q?dVBLYOw+YANgcDCyLSWUbyx0itxpCjKVA4TmGpiFKbqaisg8z2u1W0/HTh1v?= =?us-ascii?Q?N4/dCPQ0jisQQumwNCKvSxNzjg2beRFdPvxlvvter2BjW99zugR2DzPbZGZR?= =?us-ascii?Q?JBEPDrHYnztDhPlV4jxtIpVxbcMgT4sc+YdvZiU9ZWuXIyzI7yCK23L2niQG?= =?us-ascii?Q?lFA9m5ag/aXcK7B8RO2OnQ4mbfR/UDlEwLfBdS6PXIHOS8ICB1XtG1f2BlUY?= =?us-ascii?Q?44Jik4W4cz23ha4vTk64QEvt3WeCggVVbhWfJo3euSQmLCnDFzuFawyf+3kP?= =?us-ascii?Q?zovym6cAgQH7fboQgvM+5rAljy1QKg+w2zu++LcfU1lul4lT7p/5mNg86CDr?= =?us-ascii?Q?0S7K9QfZ+VlIiv2K3bFpbjsvaOygPlC0VSP+1AUcxnBKadmBznS9NHBdOrSE?= =?us-ascii?Q?NFpTimQmHejXMNXzX6nukRlg/R0thiI9u6Ur8uZ+jpOg4uPlbrbbCI35/sx9?= =?us-ascii?Q?3C6Z18Uao0SRUE11uzunoqpbxvwQ/BhlFu01JhdkjPPMbYLk/VtTASVXNXbl?= =?us-ascii?Q?Qw+bgTmc9Y2Kl3V+FJfsoxo6wwx2qjZN/OBiu8Mg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5905.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1135911-9f26-4819-38e1-08daf7a3546e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 09:23:29.4429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /pK2m+gl95vR+NE9Fk2trEMqkcu8J3RGgYa+SchvO0bKLK2+BX5ac5jQekoLzR8gkR5guZGm3CFtO2+F5TLMzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5871 Return-Path: donald.kuo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ray to clarify. @Wang, William2 let's follow the EDK2 recommendation. =20 Thanks, -----Original Message----- From: Ni, Ray =20 Sent: Monday, January 16, 2023 5:19 PM To: Kuo, Donald ; Wang, William2 ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Kumar, Chandana C Subject: RE: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Donald, Old code might reference existing Reserved field in the structure definitio= n. So, to avoid old code assigning value to different bits if using same field= name but for different bits position, edk2 recommends to change the field name from ReservedX to ReservedY when t= he bits covered by ReservedX are changed. Y is the next unused index. So comments as below: >=20 > - UINT32 Reserved5 : 11; >=20 > + UINT32 Reserved4 : 2; We should rename Reserved5 to Reserved6. >=20 > + UINT32 IA32_THERM_INTERRUPT : 1; >=20 > + UINT32 Reserved5 : 7; Reserved7.