From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.162170.1673858450644190116 for ; Mon, 16 Jan 2023 00:40:50 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hoecTpbU; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: donald.kuo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673858450; x=1705394450; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Z9XnMAUV+nlFRfZK6JcrG1xjpCubRGPa0kkpCSPrpXc=; b=hoecTpbUknzw5wzMOA6IdadJST1jdWZBReHRFlmfzoG5yNEGFj6aOEtD mt4N/RM2zvKJyugx/QiczChTwwcZOj5XXkyn2ry7JvVU7TpRuuTk8X8Vk gdlwR90rDNy6HnOYwwx8/5Qh6POmLUuLOK7NnXKlHCpQXVDI31CHA88LW rXd44l8juqiIjKxBesVOuzU9P1elCXKgQXx/9+7viBp7ff7NIOPOvEFNi UtHGwq+vdMjodkPy/AJP9IFiL3N0TRFY749M26CfCx75Y3YxGJezJctCK 0awxrC84CzrHdQSqTIDvZam5/6prl82PhYUTaqk4Va5UsUXzrm2ziGHPU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="324474541" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="324474541" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 00:40:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="766809909" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="766809909" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 16 Jan 2023 00:40:50 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 00:40:49 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 00:40:49 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 00:40:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M0XBfjDra2Tf5Q9Uf88v8cAveMYo0YVTY4YEBpwhvLYC2WUebd9Lp2dqk4NYsbvF83iz5+1SEfwiibSDd+qhLOsa88OzFUgUdYTQ1HltxTQ/fXgXoCSsNj6ETMv78RwAJnIjV+9Kdj3x7IezCysGbbBzzFdej1dnoAp3EiV9YP08BiXEClUb7UnM9FUWdGVC2RFrDr1fYD8tUPyRLuWZxTRzni3PhGgz09Apz3bGPuu5xo+SXBc4lhfQTvT41t3rfoiiQ5W5wuouBeG4GHloZQLEFP3W4mfs1UWAJfyfbZDuz37UoRm7UWJXW8EnHydGfpqB9M18XTB9UekeZB9Itg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLKZNa20D+QYGUsAB8AI+1y4B8ILOxgB9R0vxlwNiNY=; b=PeI8jtyn1pHBkSoZaRkbCJW4EFfnMImjhDLWh+yUuHFKEDUeSGhBvV9GwVnPj6DX2ZVivs/fbckuEeUcnHFl6gp0Jac0mTDlE3Ot1fILpU0uNgWUjpxFqDf5gqdmJ8LRJFg6RHjPvNPD1x1cVKUVRIw3JMWIGm1sH1wqqUfDSWzNHq62/Qv+B5eLlfZjvjPXYGz+ux9mqDLIM4Qn1TnGS/2RZTgAnHY0+zO25H+MJacowDnEuSM2LVN8WulonkLRsg4kuvdJhUYcMAlx5ZAiKG3iFgXGhuOI8+l+L4yiD1ZwHYJ/trnZbfPGMSQUL6D5TT0zYqACWOHO5l0PbQwrsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5905.namprd11.prod.outlook.com (2603:10b6:303:19f::7) by SA1PR11MB5801.namprd11.prod.outlook.com (2603:10b6:806:23d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Mon, 16 Jan 2023 08:40:46 +0000 Received: from MW5PR11MB5905.namprd11.prod.outlook.com ([fe80::3dee:1760:e5aa:7d67]) by MW5PR11MB5905.namprd11.prod.outlook.com ([fe80::3dee:1760:e5aa:7d67%5]) with mapi id 15.20.5986.022; Mon, 16 Jan 2023 08:40:46 +0000 From: "Donald Kuo" To: "Wang, William2" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Ni, Ray" , "Kumar, Chandana C" Subject: Re: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Topic: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. Thread-Index: AQHZJyiup9QKfnIHvE+w8Ghov/QA1K6guvwA Date: Mon, 16 Jan 2023 08:40:46 +0000 Message-ID: References: <20230113082551.685-1-william2.wang@intel.com> In-Reply-To: <20230113082551.685-1-william2.wang@intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5905:EE_|SA1PR11MB5801:EE_ x-ms-office365-filtering-correlation-id: 39ae7c42-9828-4db1-8884-08daf79d5ce6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YxmZcXXDA7FtdMzkO3797ZlYynniNbcGxN5pXp0r6dxwM6Awbaf2kZyvsLccYdlRQ1dq1wD+1eEVbzbNdRYPcOawAtzMEphygSZrBtEz6z1zTQJVUPmGdnzgsotSA5iYDTVU4bWG7kwM66BalvInog+HqfOMZdUMf0TLPgRIZAhcZZNxHZs8k7LApPmMajvr895AZaAQApZOWBpmOzqma6dza7CWiQSWJaPd1LklhHqL82l+7BMIfFFQyyEDnBFzpBVE6gGNgd6kgFZqHdZRPXIyaKpHWVbsFYS5ggfHIW/jNaNTJl6MKtHPccf1Ti8k2E5c+bwEF4lXgU4tQELpuiXB5bw+Rvjawm5nKoIy+SJPJYz6Bu1OQwxhpW2QjdCWr7+Lzs/iB9KPTLXUPG5U6G9oLlnWQpFTEKLXfCDzTzeJjGHKAP2vmP6gi+fihHjWIzqafUXrs1YiDWjo1ziob9iVwIsKYaGWeB7gCBFZB8ghZc5YOYfEGLxEJ3EIItGrwN0n+2cXQgJNT/8q4LRxvgiaanACfXOam8pR4lxTD+R4ZvxJZbx7u1p8DSqfRzjG/HMKIFsUVXzsIj96RJWnUWmSiBzelJfEFaeeIqyR7Mg8NuVOExk5AWets8l6XICdebM29QoPbEBldVUiIJ+NUV4mjp+9SNDOknGoqkCdysYSMl9W5n770etIKI2TxirRzIU83+5TNp3YrqBiKWY+RvbpgwqvXhWgh4hY9TtXYkc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5905.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199015)(2906002)(8936002)(53546011)(33656002)(186003)(26005)(9686003)(52536014)(15650500001)(41300700001)(5660300002)(76116006)(66556008)(38070700005)(55016003)(4326008)(66476007)(8676002)(86362001)(66446008)(82960400001)(71200400001)(38100700002)(7696005)(122000001)(83380400001)(107886003)(6506007)(966005)(64756008)(66946007)(478600001)(110136005)(316002)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K6nsyrncsZGaIfoC7MuM4dP2XhvM4wZ10KvBlygcBt9SFtPi8+MJxkwPYS0d?= =?us-ascii?Q?v17FYCcgTiKWEVOFXI/3tIMW+vt92HL56FZ0kW2zEZ35tqcQFqN8KfkCUC/K?= =?us-ascii?Q?8YwdqTiD5m8xKhGIoM2K1C9ba3qsZxdzfeFy5Xn26gmMqN/jk/FFjhZ8iJlO?= =?us-ascii?Q?4Rcr7u7F+xkW6JG0w6KlrsBLTQwR6zL40eaCtINRXXJ+9OBMr8t+Bh49IIvd?= =?us-ascii?Q?fEsUfQT0RIP2vbls6n0SYrCNsJCJ1wUC1hO108WHEU3bHSFlP53IfCoaBx/D?= =?us-ascii?Q?nI6B91+HMIlhkeQmp3YAFEarRrIiDp0PzkI+09m67BArc66/hK+NcX5JiKe5?= =?us-ascii?Q?czKIniLoZp6oMQP85X85HGnqRjorKACRIg4qAXda7w9Swip0jB+jVVlRBMQA?= =?us-ascii?Q?bdiW8ArPqqTwfVoLQuzcgsAHBHVVo3truolp64w/8L4APjSBbEI2f8U5QrLr?= =?us-ascii?Q?zDWS52kb0jRY+iMHOXEnJfIXfvs9EHVO8SYH2W7BdpYAw2Xg+HT6bPxQ8PZl?= =?us-ascii?Q?qMe4JAbYp9sZ6/fcHsLitjioEO0dkGoDnEq72TnIdX8ArCgZlFEdHGnc8Y4E?= =?us-ascii?Q?I3fyCmjvvEYx5mmZayeGi7G3MzF9Fpt5/Fa3RemDdFl5nfJgB/xj16FwPPjK?= =?us-ascii?Q?RaubH0ecG4MJ+EIC4fMquJ132Pc6m4IDev55i1MTArU0tB6s+dKEcKebPf06?= =?us-ascii?Q?qLT0waqR58Bgkf7vR6BtqA9msE+NlBxHfos/JACoKV2nPRO0ayGnhXs8AaBs?= =?us-ascii?Q?coEGDK7hlj2k1A97igSUVPKn0xUHxxrcuP/BkpOSombDDlLwKrw2t3CheNe1?= =?us-ascii?Q?67qVHKhuylupeQlaFcdu8HewgdFe5tKaLalBMRevEMVuSVQOTfrn6xjvh4R4?= =?us-ascii?Q?WyLBcjupGgTVG/3u3UhRytKEi0vb4gpkf2aMq/ImC/vadoOJ6f3HOs6ZORFK?= =?us-ascii?Q?j24VTXxuIKAUFvNYwlRVxV0DDnxcO9qlaFDIUcR3tBk0v8LAVwZ7wBib1FMr?= =?us-ascii?Q?sr7DmwyqcTsUbHtOknyYNSAuvQcpabVFOAEcl0h+byEs08h+CRZ2gBZNHy14?= =?us-ascii?Q?9ir+0s4/a2K25McTErEcIsys8F2oRf+KVunFIc7f1WJE2NPpSRtmdlQsRIim?= =?us-ascii?Q?tgCS8gOBVZuWG+jqyoieSsgA8Wj/U7ZGNI4/hoOT2X9ypD9KtP+gfXz9WtTj?= =?us-ascii?Q?1jwbk88CMk2w/rRAAsa/Fdpa+q07f6NHu8SDM/pA6VaywxQiPFOecXfrKoXm?= =?us-ascii?Q?JCiyNj2YgsnAJBJrcAoFrPE0CFlLXpjeOhA7w8V9chP3hk49MRIlLK6fM+oF?= =?us-ascii?Q?Q12OILXEEgnFd+Tp7cBGuX1/biSQeQtQ1iBzhN3ZVpgGa/meCCxsvndeBNDP?= =?us-ascii?Q?qiDXJHFaj+q4zbOOU9Z0NdPPBIOqIkZ4uyE4L4R5R8pyhdy2LsuwNcjdguDk?= =?us-ascii?Q?BMNTGkpN/Q6VzZUlfCX2Q/WX0VSzLwveHr709HzNDL3f1VGAOdFVRZCCB4pz?= =?us-ascii?Q?06gHc9v4zazFE+o1zAlvqiGoUs791NkN1M349w490y6shvyGjzNDC3HE4LIz?= =?us-ascii?Q?PBhGssAbHlDjUQnrfsGYgJG4vS3B4EcFdqx7LsQY?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5905.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39ae7c42-9828-4db1-8884-08daf79d5ce6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 08:40:46.6728 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xHdB0P0jsnvq8uKf33ToF0g99TkZcRfDd4VoZB8btOjdeD74kM7zcXHmM33PN7iSpLPSXBNpeY+t+sdAHUhnEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5801 Return-Path: donald.kuo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi William Overall looks good to me. 1. For EAX: Can we change Reserved4 & 5 to Reserved3 & 4, since only 4 rese= rved. 2. For EDX: Bits [7:0], how about to add more detail description for BIT0 a= nd BIT1, and BIT [7:2] =3D Reserved to align with SDM + /// {Bits 7:0] Bitmap of supported hardware feedback interface capabil= ities. + /// + UINT32 InterfaceCapability : 8; Thanks, =09 -----Original Message----- From: Wang, William2 =20 Sent: Friday, January 13, 2023 4:26 PM To: devel@edk2.groups.io Cc: Wang, William2 ; Kinney, Michael D ; Gao, Liming ; Ni, Ray ; Kuo, Donald ; Kumar, Chandana C Subject: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM. From: William2 Wang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4262 Update CPUID Leaf 06H to follow latest SDM. Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni Cc: Donald Kuo Cc: Chandana C Kumar --- MdePkg/Include/Register/Intel/Cpuid.h | 56 ++++++++++++++++++-- 1 file changed, 53 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Register/Intel/Cpuid.h b/MdePkg/Include/Registe= r/Intel/Cpuid.h index 350bf60252..46cdb827e2 100644 --- a/MdePkg/Include/Register/Intel/Cpuid.h +++ b/MdePkg/Include/Register/Intel/Cpuid.h @@ -1195,12 +1195,24 @@ typedef union { /// [Bit 18] Fast access mode for the IA32_HWP_REQUEST MSR is supporte= d if set. /// UINT32 FastAccessMode : 1; - UINT32 Reserved4 : 1; + /// + /// [Bit 19] IA32_HW_FEEDBACK_PTR MSR, IA32_HW_FEEDBACK_CONFIG MSR, + /// IA32_PACKAGE_THERM_STATUS MSR bit 26, and IA32_PACKAGE_THERM_INTER= RUPT MSR bit 25 are supported if set. + UINT32 HW_FEEDBACK : 1; /// /// [Bit 20] Ignoring Idle Logical Processor HWP request is supported = if set. /// UINT32 IgnoringIdleLogicalProcessorHWPRequest : 1; - UINT32 Reserved5 : 11; + UINT32 Reserved4 : 2; + /// + /// [Bit 23] Intel Thread Director supported if set. IA32_HW_FEEDBACK_= CHAR and + /// IA32_HW_FEEDBACK_THREAD_CONFIG MSRs are supported if set. + UINT32 ThreadDirector : 1; + /// + /// [Bit 24] IA32_THERM_INTERRUPT MSR bit 25 is supported if set. + /// + UINT32 IA32_THERM_INTERRUPT : 1; + UINT32 Reserved5 : 7; } Bits; /// /// All bit fields as a 32-bit value @@ -1252,7 +1264,13 @@ typedef union { /// (1B0H). /// UINT32 PerformanceEnergyBias : 1; - UINT32 Reserved2 : 28; + UINT32 Reserved2 : 4; + /// + /// {Bit 15:8] Number of Intel Thread Director classes supported by th= e processor. Information for that + /// many classes is written into the Intel Thread Director Table by th= e hardware. + /// + UINT32 ThreadDirectorClasses : 8; + UINT32 Reserved3 : 16; } Bits; /// /// All bit fields as a 32-bit value @@ -1260,6 +1278,38 @@ typedef union { UINT32 Uint32; } CPUID_THERMAL_POWER_MANAGEMENT_ECX; =20 +/** + CPUID Thermal and Power Management Information returned in EDX for CPUID= leaf + #CPUID_THERMAL_POWER_MANAGEMENT. +**/ +typedef union { + /// + /// Individual bit fields + /// + struct { + /// + /// {Bits 7:0] Bitmap of supported hardware feedback interface capabil= ities. + /// + UINT32 InterfaceCapability : 8; + /// + /// {Bits 11:8] Enumerates the size of the hardware feedback interface= structure in number of 4 KB pages; + /// add one to the return value to get the result. + /// + UINT32 InterfaceStructureSize : 4; + UINT32 Reserved : 4; + /// + /// {Bits 31:16] : Index (starting at 0) of this logical processor's r= ow in the hardware feedback interface structure. + /// Note that on some parts the index may be same for multiple logical= processors. On some parts the + /// indices may not be contiguous, i.e., there may be unused rows in t= he hardware feedback interface structure. + /// + UINT32 LogicalProcessorRowIndex : 16; + } Bits; + /// + /// All bit fields as a 32-bit value + /// + UINT32 Uint32; +} CPUID_THERMAL_POWER_MANAGEMENT_EDX; + /** CPUID Structured Extended Feature Flags Enumeration =20 --=20 2.34.1.windows.1