Re: [PATCH v2 6/6] BaseTools: Upgrade the version of NASM tool

["Yuwei Chen" <yuwei.chen@intel.com>]

This patch looks good to me.

Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>

> -----Original Message-----
> From: Lou, Yun <yun.lou@intel.com>
> Sent: Monday, January 10, 2022 11:13 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun <yun.lou@intel.com>; Feng, Bob C <bob.c.feng@intel.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine
> <yuwei.chen@intel.com>
> Subject: [PATCH v2 6/6] BaseTools: Upgrade the version of NASM tool
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790
> 
> Upgrade the version of NASM tool to avoid compilation errors when
> compiling NASM code change.
> 
> Signed-off-by: Jason Lou <yun.lou@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
>  BaseTools/Conf/tools_def.template | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 2e6b382ab6..0133860fc3 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -1,5 +1,5 @@
>  #-#  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>+#
> Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR> #
> Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> #
> Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.<BR> #
> Copyright (c) 2015, Hewlett-Packard Development Company, L.P.<BR>@@ -
> 368,8 +368,8 @@ DEFINE DTC_BIN                 = ENV(DTC_PREFIX)dtc
>  # Other Supported Tools # ===================== #   NASM --
> http://www.nasm.us/-#   - NASM 2.10 or later for use with the GCC toolchain
> family-#   - NASM 2.12.01 or later for use with all other toolchain families+#
> - NASM 2.15.05 or later for use with the GCC toolchain family+#   - NASM
> 2.15.05 or later for use with all other toolchain families #
> ################################################################
> ####################
> ################################################################
> ####################--
> 2.28.0.windows.1