From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "Lou, Yun" <yun.lou@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v2 6/6] BaseTools: Upgrade the version of NASM tool
Date: Mon, 17 Jan 2022 00:49:29 +0000 [thread overview]
Message-ID: <MW5PR11MB59060851895D5598C5E3D41296579@MW5PR11MB5906.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220110151253.3848-6-yun.lou@intel.com>
This patch looks good to me.
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: Lou, Yun <yun.lou@intel.com>
> Sent: Monday, January 10, 2022 11:13 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun <yun.lou@intel.com>; Feng, Bob C <bob.c.feng@intel.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine
> <yuwei.chen@intel.com>
> Subject: [PATCH v2 6/6] BaseTools: Upgrade the version of NASM tool
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3790
>
> Upgrade the version of NASM tool to avoid compilation errors when
> compiling NASM code change.
>
> Signed-off-by: Jason Lou <yun.lou@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 2e6b382ab6..0133860fc3 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -1,5 +1,5 @@
> #-# Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>+#
> Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR> #
> Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR> #
> Portions copyright (c) 2011 - 2019, ARM Ltd. All rights reserved.<BR> #
> Copyright (c) 2015, Hewlett-Packard Development Company, L.P.<BR>@@ -
> 368,8 +368,8 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc
> # Other Supported Tools # ===================== # NASM --
> http://www.nasm.us/-# - NASM 2.10 or later for use with the GCC toolchain
> family-# - NASM 2.12.01 or later for use with all other toolchain families+#
> - NASM 2.15.05 or later for use with the GCC toolchain family+# - NASM
> 2.15.05 or later for use with all other toolchain families #
> ################################################################
> ####################
> ################################################################
> ####################--
> 2.28.0.windows.1
next prev parent reply other threads:[~2022-01-17 0:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 15:12 [PATCH v2 1/6] MdeModulePkg: Replace Opcode with the corresponding instructions Jason Lou
2022-01-10 15:12 ` [PATCH v2 2/6] MdePkg: " Jason Lou
2022-01-11 0:55 ` 回复: [edk2-devel] " gaoliming
2022-01-10 15:12 ` [PATCH v2 3/6] SourceLevelDebugPkg: " Jason Lou
2022-01-11 1:03 ` Wu, Hao A
2022-01-10 15:12 ` [PATCH v2 4/6] UefiCpuPkg: " Jason Lou
2022-02-10 5:35 ` Ni, Ray
2022-01-10 15:12 ` [PATCH v2 5/6] MdePkg: Remove the macro definitions regarding Opcode Jason Lou
2022-01-10 15:12 ` [PATCH v2 6/6] BaseTools: Upgrade the version of NASM tool Jason Lou
2022-01-17 0:49 ` Yuwei Chen [this message]
2022-02-10 5:36 ` [PATCH v2 1/6] MdeModulePkg: Replace Opcode with the corresponding instructions Ni, Ray
2022-02-10 7:44 ` 回复: [edk2-devel] " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB59060851895D5598C5E3D41296579@MW5PR11MB5906.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox