From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "Feng, Bob C" <bob.c.feng@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [Patch] BaseTools: Fix the bug of --cmd-len build option
Date: Tue, 28 Dec 2021 07:20:28 +0000 [thread overview]
Message-ID: <MW5PR11MB590609952FEB31B6C1CBED9F96439@MW5PR11MB5906.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211224145008.18872-1-bob.c.feng@intel.com>
This patch looks good to me.
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: Feng, Bob C <bob.c.feng@intel.com>
> Sent: Friday, December 24, 2021 10:50 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
> Subject: [Patch] BaseTools: Fix the bug of --cmd-len build option
>
> currently the --cmd-len build option does not work.
> This patch is going to fix this bug.
>
> Signed-off-by: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 1 +
> BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> index 0425f1ab0b..eea15239d4 100755
> --- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
> @@ -196,10 +196,11 @@ class AutoGenWorkerInProcess(mp.Process):
> workspacedir,active_p,target,toolchain,archlist
> )
> self.Wa._SrcTimeStamp =
> self.data_pipe.Get("Workspace_timestamp")
> GlobalData.gGlobalDefines = self.data_pipe.Get("G_defines")
> GlobalData.gCommandLineDefines = self.data_pipe.Get("CL_defines")
> + GlobalData.gCommandMaxLength =
> self.data_pipe.Get('gCommandMaxLength')
> os.environ._data = self.data_pipe.Get("Env_Var")
> GlobalData.gWorkspace = workspacedir
> GlobalData.gDisableIncludePathCheck = False
> GlobalData.gFdfParser = self.data_pipe.Get("FdfParser")
> GlobalData.gDatabasePath = self.data_pipe.Get("DatabasePath")
> diff --git a/BaseTools/Source/Python/AutoGen/DataPipe.py
> b/BaseTools/Source/Python/AutoGen/DataPipe.py
> index 86ac2b928d..41af343f62 100755
> --- a/BaseTools/Source/Python/AutoGen/DataPipe.py
> +++ b/BaseTools/Source/Python/AutoGen/DataPipe.py
> @@ -146,10 +146,12 @@ class MemoryDataPipe(DataPipe):
>
> self.DataContainer = {"G_defines": GlobalData.gGlobalDefines}
>
> self.DataContainer = {"CL_defines": GlobalData.gCommandLineDefines}
>
> + self.DataContainer = {"gCommandMaxLength":
> GlobalData.gCommandMaxLength}
> +
> self.DataContainer = {"Env_Var": {k:v for k, v in os.environ.items()}}
>
> self.DataContainer = {"PackageList": [(dec.MetaFile,dec.Arch) for dec in
> PlatformInfo.PackageList]}
>
> self.DataContainer = {"GuidDict": PlatformInfo.Platform._GuidDict}
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2021-12-28 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 14:50 [Patch] BaseTools: Fix the bug of --cmd-len build option Bob Feng
2021-12-28 7:20 ` Yuwei Chen [this message]
2022-01-04 3:22 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB590609952FEB31B6C1CBED9F96439@MW5PR11MB5906.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox