Hi Liming,

 

I know your point. Would you like to start reviewing it and give us more feedbacks? We really hope it can be merged as soon as possible.

We can do the merging after the stable tag, but just like you said, maybe we need to review it firstly.

 

Looking forward to your feedbacks, and I think this one is a very big step for BaseTools. Thanks a lot for your help and contribution on this.

I have created a BZ for this feature: https://bugzilla.tianocore.org/show_bug.cgi?id=4596

Will update the patch with Bugzilla link. (This step should not influence the reviewing)

 

Thanks,

Christine

 

 

Christine:

 I can’t directly reply to the original mail because it is too large. This is a new feature to add python version VfrCompiler. I don’t think we have enough time to review the design and implementation. Although it has no real impact, its code may have many change in future. So, I suggest to merge it after this stable tag.

 

Thanks

Liming

 

Below is your request.

 

Hi Liming and Cran,

 

Could you help on quick reviewing this new VfrCompiler python tool, it has the same functions with origin C version VfrCompiler, meanwhile it supports more new features such as generated Vfr files config info into Yaml format.

 

This feature is urgent for us to use, and we really hope it can be merged into this stable tag. This patch is linked to the edk2-basetools PR: https://github.com/tianocore/edk2-basetools/pull/109. We list all the known issues which will be enhanced in the ReadMe file. And will enhance them one by one after the patch merged.

 

For the code quality, in this patch, the new tool is not enabled in build process, it just saves in the basetools python folder, which will not influence the current edk2 behaviors. We will enable it with a new patch when everything is ready.

 

Many thanks~

 

Hi Vincent, please help add more information if necessary~ Thanks a lot~

 

Thanks,

Christine