From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3E145D802C8 for ; Mon, 13 Nov 2023 00:32:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QWaWacU6/4hZqgvVarHbYZ5xEx2ZMc7QffBedkru/Sc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1699835541; v=1; b=r5u5Ick0R/G6rVfSG1U5zaU2oUCChU3ANYHK4pV8yCaDnVTYQXmD93qGcd5RPSYKXa5KRFta aINXpobLv6X7y6ZPEFnwz8PnmXllGe8FLE0V9Xhhlanhy68PQ67nYvNNK4iElpEI4rUq2l2ou0e I7qjxG0dO7xmTvD+z6qXgTGw= X-Received: by 127.0.0.2 with SMTP id poZRYY7687511xC4oT4H4zQi; Sun, 12 Nov 2023 16:32:21 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.27349.1699835541384909261 for ; Sun, 12 Nov 2023 16:32:21 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="454662737" X-IronPort-AV: E=Sophos;i="6.03,298,1694761200"; d="scan'208,217";a="454662737" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 16:32:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="830102259" X-IronPort-AV: E=Sophos;i="6.03,298,1694761200"; d="scan'208,217";a="830102259" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Nov 2023 16:32:20 -0800 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 12 Nov 2023 16:32:19 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Sun, 12 Nov 2023 16:32:19 -0800 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Sun, 12 Nov 2023 16:32:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gXJTEnB1N6P5DyN5SFbJdikWlwWCT3t89JSM0Akvps1sZYKW08r7Fft/beTBTziQOHO1cIxxS4qrZmlAf23XfD1SozYh2TlfbbbW3fSIvYXUddNemebbpfoDMntS3eYEjdJJPvxlaE9JJDhOcUW3aPgs2gVeXcNuKVHPrd6EKESomoZ+OKpeDJ9gOjN6NumxlLAlXq965046fZPM12tFJqmXriWm080VZC/hTP818NGpJ6RCBKU1uyD9hX+qMQCVbnCjuq9DjwxMjPkAFRbymOkQzgtM0l9q4jirnC2PsTUMRixfTNRqxlAu9TKph6VmroaGGZjGOVNJLdoSO6VciA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VKqobIVvC1mWV2khY8NwNVyUny43v2wZsZ5gIB1YuQY=; b=BK+zkIZ4GiOp2mRgxL00XU42lBcaaStbCQWxCM0molzwtdqgNfdkoJF9guuOCvBnfQYv8/OoJPwUL3PNJ/a9IWmO+mQxn7Us+14z5llGVLpvcpdUVBB3LoWiGkkOcSjTyLRpplh0v1b4fyugICBvir2flp28P4Xm9iD3f3xlYQ3qNE7UTamZVH45FZH2iQ9dBHHoP9kow92moXsQZKfSKHwy8RTgn+tlfTwuUQQi/0ikkU1w8PfYU7j/UoW33abxv76Q1jEUZUmmo50Uau+68dSDfWTv7iildJGi0Frd25zxG0esoLkJiDgxiMO1GFlnD8zeAbJ5zLvPIhyaly1FwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by SA2PR11MB4905.namprd11.prod.outlook.com (2603:10b6:806:117::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Mon, 13 Nov 2023 00:32:15 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::5cfe:c156:aa65:75e]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::5cfe:c156:aa65:75e%3]) with mapi id 15.20.6977.028; Mon, 13 Nov 2023 00:32:15 +0000 From: "Yuwei Chen" To: "Gao, Liming" , 'Rebecca Cran' , "Gao, Liming" , "Zimmer, Vincent" , "Kinney, Michael D" , 'Leif Lindholm' , 'Andrew Fish' CC: "Feng, Bob C" , "Yang, Yuting2" , "devel@edk2.groups.io" , "Hartung, Stephen" Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation Thread-Topic: [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler implementation Thread-Index: AdoTFrHyrunoe9acRQSuUxcGn6URWQCsWJMg Date: Mon, 13 Nov 2023 00:32:15 +0000 Message-ID: References: <000001da1317$b227a890$1676f9b0$@byosoft.com.cn> In-Reply-To: <000001da1317$b227a890$1676f9b0$@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|SA2PR11MB4905:EE_ x-ms-office365-filtering-correlation-id: 3a88fb45-8964-4e85-f06b-08dbe3dffc46 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: zj7HCFQYN87zdLdzAz7IbX0bWjZ3EAoA6r8sFthddcKAhTwyODDZwipTXAXGaHAeZiyoDrTbhed4vrQGr0epyeBHBHVdoCdls4TyONPf/PNeYWJghu44k7e7rSq9vRhp21yhT5Dx63HGKQ0CCE88XQp+bZlMR61dJyv2Luqgy5AfXoUYXzty95/ft8vyok5NkfGsDpLPn89ksclzXLU9NbulHpk5VDdqf66lQN+O6OQ+rdZTzdqM+6avrQYQcEtHL8ShDaajodj7gXtSXwSbEs4bQ4RsUrmbjXNvzSaARnWd4MAoxYFJ8PzVh0vJtVt7ujx17lu8GZbW/uWv2EDH3GDRe36rDNHOOK+rrhMJp1JxuSStyOgPnBqMh8fIPmgcz60hzs4dZPDp1KyG/v7cjn6y2Dy5fP3CXU5azdqdj3ehgzDQq9Hf8aKZz6PevGEuF7jma4P4UE+EX6wnBGGJ3HuKc7pKAkmtDfI+ByadsRPveqzw6bUpO0gfH+BYXjPAixdgy8zGiB5enNDervje7I4xAId3223cs9Ij+xbXSh/QKLL+NXBQVBhKzLpd+riQ7Ppa6uRYmX/DzT0dIhBSz4NmHXWjKSNufiL6z+3CtORRCeL86VkQ7b0ArXjbAkk2KykwJA201IG3Bwa2p00nYSk+1CshnB5H0ZJbSEGNO0s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ok7ZzYgrOtoBoKAH8+sEVnF+jTYJmQeAyxPn+IvdKW2oDxiWLlqnUuRRx7oA?= =?us-ascii?Q?YznTE7huQNpSxWdfGwCzFLB4zf0d4JYsd1SbRcuFa3Nqzdfy9LtrjSh1O/9D?= =?us-ascii?Q?boOnFhHwn8OuQTgL72/h5NQA2RxUm2muR4o1XL1DUJ5PaCALvX7dltnYpVhI?= =?us-ascii?Q?WEWlyzIQsUlwxa+NuHRpZ9FIwssRBRDfVquMgTRFhoHu2FEAbU6CQoMF+mGs?= =?us-ascii?Q?pfJ7REbCmaEtdycs+L1bHXNKy00McXn5PlZ8i/agsxmlFjG6AxizAJyFxFTt?= =?us-ascii?Q?5K+eamrwzhqtnjw/7fYrBtrSUvIBU+2TogsRWZ4YXtC+61dLjry6SwSuhbte?= =?us-ascii?Q?jUGIWEERW5SHGlSUQWDlqVdcbhscPok3earoBI44HpataS6OJLm1d/9vuc89?= =?us-ascii?Q?gcjSg284z+52q4R8SasKapgXc/LZjPvgdG9EzY87+2laktbaC5XENRAU4e1Y?= =?us-ascii?Q?4oaOBZ42ZPxG51ssY+YkoDi76YZVh8b/OLYsRIeWmw97gzTR3z3rxRy5kAFw?= =?us-ascii?Q?ihPMvduu3vhW6xJYKhCHN6g/QFQh63NEkIQhG3ODHllFgqrv84J6dTeZROsZ?= =?us-ascii?Q?SkJA/xbur7c7YJUyukBcTK3tSVISuF5yLp6QEL1DxUxB6u/QKEpb7t0tNpHd?= =?us-ascii?Q?/Iq3n4RGo8Mjm1zU6dSvg4NjvWRcuSjwrML7JIaisJKkNdyP3xzSaVFF2PPw?= =?us-ascii?Q?b92R75Dhu/bFVX2TaxtGZ3zHDZkdb0qdSmW/LWnKpNivQ9BHMh93dwStXHn7?= =?us-ascii?Q?yQuxGbi1iWR2V56sUP8pMVwyEGR74YoNP3EBv+oPv95hz9XQEYNizfX+MWg0?= =?us-ascii?Q?YeTQ5Kds+J7uTxLmKnNoQrtL+0R0gF/uqrSeY5PASDDX/yy903ZjCGBDP21w?= =?us-ascii?Q?VRgw2LG5c9zuyPks1eOLVNxEcHbNe/H9STKbI5feHLd5iwXnEmUAJCrOIvx0?= =?us-ascii?Q?sHvlR+h/stdZl6Kqe2M+Tjkca9cYjp8cU6vLK6z2uswF401Ta9Za8UfxRPFN?= =?us-ascii?Q?LGraBQN2qeWBBJYcpbF1+W/ZzNj4TTjdSh6kpfIe0XKmhCX0qe84gWrkayrx?= =?us-ascii?Q?oR3soFM595WwiOYMxdxrSU0tuNsvGUsudZKOlr+oKohB7+jxmxy0zJenRDOI?= =?us-ascii?Q?eCcp9gLkw9RAuEBGFyPKfdiRX0AX4VAr0IbGgOWq7tq7AG1xjdbkghts+1QF?= =?us-ascii?Q?T2OQK4ba2P7qhmAU4uhDp1p4uf9tBS0v8PMYmcqCrTMC64BsjYibHf1sHj25?= =?us-ascii?Q?o7gq7lI8i0d6mRTPqYwXvmTAhLeoBKx9oBmsdlAplkm+B4ZjSEoBabrjOgKR?= =?us-ascii?Q?Kq/2Ab14ligGus/iQ2hWj8vmSSVMkcass0nDvSoeS50dM7KJJHDlRqR0Gho2?= =?us-ascii?Q?LiTtLKG6IorJ8pWFHknn8Cm131+cIcWEEV+6G+zwdRNSoqztXVYsRVPTkHrq?= =?us-ascii?Q?1YUhrQ6bQP4LZfGmeeQwZj7du5ovFJoVGTElW5s/nFwd59AM+BiGFQ14dekQ?= =?us-ascii?Q?BLfO+S3QLEVc0OPgO3UoLJAEdeFi4AVb/qrzNfQTI8aY+AUKv6h6IzTvzasi?= =?us-ascii?Q?B/9ZfxxHVh+VSTTXKrulccNqyZTYxDisep5u4Dbx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a88fb45-8964-4e85-f06b-08dbe3dffc46 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 00:32:15.2642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 15OXIlzNjfFRuhAMWJl2drkUfOT0o7PZCg/6oP2AM1eHy7Ij3wDfqp7pFKDSn6OTEGoYlDYOJJv5MWATFz7o2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4905 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yubzE7BJnAEiIhO6r5YYyqq6x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW5PR11MB59062EB77C3F89A2F2A12B0A96B3AMW5PR11MB5906namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r5u5Ick0; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_MW5PR11MB59062EB77C3F89A2F2A12B0A96B3AMW5PR11MB5906namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, I know your point. Would you like to start reviewing it and give us more fe= edbacks? We really hope it can be merged as soon as possible. We can do the merging after the stable tag, but just like you said, maybe w= e need to review it firstly. Looking forward to your feedbacks, and I think this one is a very big step = for BaseTools. Thanks a lot for your help and contribution on this. I have created a BZ for this feature: https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D4596 Will update the patch with Bugzilla link. (This step should not influence t= he reviewing) Thanks, Christine From: gaoliming Sent: Thursday, November 9, 2023 10:19 PM To: 'Rebecca Cran' ; Gao, Liming ; Zimmer, Vincent ; Chen, Christine ; Kinney, Michael D ; 'Leif Lindhol= m' ; 'Andrew Fish' Cc: Feng, Bob C ; Yang, Yuting2 ; devel@edk2.groups.io; Hartung, Stephen Subject: RE: [edk2-stable202311][PATCH] BaseTools: Python VfrCompiler imple= mentation Christine: I can't directly reply to the original mail because it is too large. This = is a new feature to add python version VfrCompiler. I don't think we have e= nough time to review the design and implementation. Although it has no real= impact, its code may have many change in future. So, I suggest to merge it= after this stable tag. Thanks Liming Below is your request. Hi Liming and Cran, Could you help on quick reviewing this new VfrCompiler python tool, it has = the same functions with origin C version VfrCompiler, meanwhile it supports= more new features such as generated Vfr files config info into Yaml format= . This feature is urgent for us to use, and we really hope it can be merged i= nto this stable tag. This patch is linked to the edk2-basetools PR: https:/= /github.com/tianocore/edk2-basetools/pull/109. We list all the known issues= which will be enhanced in the ReadMe file. And will enhance them one by on= e after the patch merged. For the code quality, in this patch, the new tool is not enabled in build p= rocess, it just saves in the basetools python folder, which will not influe= nce the current edk2 behaviors. We will enable it with a new patch when eve= rything is ready. Many thanks~ Hi Vincent, please help add more information if necessary~ Thanks a lot~ Thanks, Christine -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111115): https://edk2.groups.io/g/devel/message/111115 Mute This Topic: https://groups.io/mt/102486097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW5PR11MB59062EB77C3F89A2F2A12B0A96B3AMW5PR11MB5906namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Liming,

 

I know your point. Would you like to start reviewin= g it and give us more feedbacks? We really hope it can be merged as soon as= possible.

We can do the merging after the stable tag, but jus= t like you said, maybe we need to review it firstly.

 

Looking forward to your feedbacks, and I think this= one is a very big step for BaseTools. Thanks a lot for your help and contr= ibution on this.

I have created a BZ for this feature: https://b= ugzilla.tianocore.org/show_bug.cgi?id=3D4596

Will update the patch with Bugzilla link. (This ste= p should not influence the reviewing)

 

Thanks,

Christine

 

From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Thursday, November 9, 2023 10:19 PM
To: 'Rebecca Cran' <rebecca@bsdio.com>; Gao, Liming <gaolim= ing@byosoft.com.cn>; Zimmer, Vincent <vincent.zimmer@intel.com>; C= hen, Christine <yuwei.chen@intel.com>; Kinney, Michael D <michael.= d.kinney@intel.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>; 'Andrew Fish' <afish@apple.com>
Cc: Feng, Bob C <bob.c.feng@intel.com>; Yang, Yuting2 <yuti= ng2.yang@intel.com>; devel@edk2.groups.io; Hartung, Stephen <stephen.= hartung@intel.com>
Subject: RE: [edk2-stable202311][PATCH] BaseTools: Python VfrCompile= r implementation

 =

Christine:

 I can’t directly reply to the original mail because i= t is too large. This is a new feature to add python version VfrCompiler. I = don’t thin= k we have enough time to review the design and implementation. Although it h= as no real impact, its code may have many change in future. So, I suggest t= o merge it after this stable tag.

 

Thanks

Liming

 

Below is your request.

 

Hi Liming and Cran,

 

Could you help on quick reviewing this new VfrCom= piler python tool, it has the same functions with origin C version VfrCompi= ler, meanwhile it supports more new features such as generated Vfr files co= nfig info into Yaml format.

 

This feature is urgent for us to use, and we real= ly hope it can be merged into this stable tag. This patch is linked to the = edk2-basetools PR: https://gi= thub.com/tianocore/edk2-basetools/pull/109. We list all the known issue= s which will be enhanced in the ReadMe file. And will enhance them one by o= ne after the patch merged.

 

For the code quality, in this patch, the new tool= is not enabled in build process, it just saves in the basetools python fol= der, which will not influence the current edk2 behaviors. We will enable it= with a new patch when everything is ready.

 

Many thanks~

 

Hi Vincent, please help add more information if n= ecessary~ Thanks a lot~

 

Thanks,

Christine

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#111115) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW5PR11MB59062EB77C3F89A2F2A12B0A96B3AMW5PR11MB5906namp_--