From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 37C3674003E for ; Thu, 8 Feb 2024 06:38:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=r8SctUDUGK+jCc8VneupbHpyuK4YP9zN6UylsrqjZsc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707374323; v=1; b=M8CyXTOpUJeNvKV6r3yfa1RirxkbroTZUkjeFPPo6u6XoA6a4VvfaONQ6+5C6dvGjDGIfu9o awlPro2knnujPXx4svtnOcASo9PxjsZ/b1UCD9wgDV3WHiWfanEkna4IHjQHCzaUEHXIWEPKVu+ yR81HP0QyOBimVopKcUkpNIc= X-Received: by 127.0.0.2 with SMTP id XWQ1YY7687511xXnGUM4rxhN; Wed, 07 Feb 2024 22:38:43 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web11.12529.1707374323064001841 for ; Wed, 07 Feb 2024 22:38:43 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="11734947" X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="11734947" X-Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 22:38:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,252,1701158400"; d="scan'208";a="6231664" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Feb 2024 22:38:43 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 7 Feb 2024 22:38:41 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 7 Feb 2024 22:38:41 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 7 Feb 2024 22:38:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bTJHLqPaOAdtz9Xdh/3vO+347XqSbeP2cJTTB7RVUMACN7YaZ6JmoKmvTXVtO2+h4H4AExl0y1eS1c2GB0rLwhOZDZcTJ0wpG/0rvMfAEBODv8cy89//oNivsrOujjh648a4NCgdOuW6q3jkDCLc2hRL2ubROw7Fr3o09AANE2fx+/PO4YNmi/MyvrH/iKSrEwNpY4gzOXcwKahZILYBkahtEg4xunfDQG87ef9iKBXyzSufcfFmVsTe0CAIZobaDsfaqCQQ3oBdZaaFMIg4+yGuYaE5srPTSUjrR/EqYHWKM6g+OX5gn9l28ZgTrAOCmSfni7ahKYeZLJgBEIbegQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mFtp3aWUcHiNfbWInu6LwLV2AhsiBLcNUCSzDQtpvqc=; b=n+1dOdF9zEX58H0JaecFIJxON3KZigF+I/qK6ImtZIjvaaphx72a6yFI/X+kvu6CkZVXCrnGv//3wcIxXm5BvOCOAlPMP9ETg3bfs+l2s8TPhGL/JtpnFHov74UqPwRYzLZE69wGqE80IOqMwnfXbPWo+5f32VVET6Vo7ghSRdXIi/aZn4Qy/DzerFFhtg5wgpFM7e0qH8z62SW6DENI4xrKKIPLfZDyEsk64RsmJKuH+GGNS1oYRYj+9Cu2rr4lnvHeB+cFX7LY+cUwt3yi4CW1IgjoHGt6xc1Jj5rkaOMDhI08tiBGEXEISZzcyv1vMJpT0AJPCoBQ3I6yEMqUVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by SA1PR11MB6872.namprd11.prod.outlook.com (2603:10b6:806:2b2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Thu, 8 Feb 2024 06:38:39 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::295d:9865:fc32:12d1]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::295d:9865:fc32:12d1%7]) with mapi id 15.20.7249.038; Thu, 8 Feb 2024 06:38:39 +0000 From: "Yuwei Chen" To: "Kinney, Michael D" , "S, Ashraf Ali" , "Feng, Bob C" , "Chan, Amy" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaN0b/Myl0Fv1MCEWFVxeagzOOtLDPJOGAgAA5NICAItTpgIAOA6oAgAABMICAAAsA4A== Date: Thu, 8 Feb 2024 06:38:38 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|SA1PR11MB6872:EE_ x-ms-office365-filtering-correlation-id: 48b59f62-85b3-4f48-4891-08dc28709572 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SshkltAq27gYC0gMsksdb7JuWS6EoTBbizbavSl8KLD6bnjAM5mxbTaq++6qlmN4gM2DhglANGJKpvjB0fVe77saR0BZtnZ/osYCSIsjrnZYV9PXn/dkHM9zIliJf/FtcZ5g3lvlZuDJzDyW0483te9u2wS5puGChlBmWnM+ztxd+fwYtgQllma5CZ0cCDcdtf04mOonxs6Bk7EAOQLlQ54DyzE1cifJgVlnsCc4kcgYcsxY35rqZPuo1Akyv4fWClptTuZGrEaRINzQCLcGuOPWp6YEqU5R/1FhDmjjUROyoTdZDSb2JwTndd5Xgy5hH7a46I7FMEAPFhGwKqUU8H+zUBfojON5vOtuZH4iN7S0tQS+b57oGtjqvq1KCKyNhJXrApL2TWwCETH4eT0k5lkgHvk+iEZtU/D2hTbR9dqTvt868qVmd97rhSsq89IoXPB9Cx2I62kCco2AeZYDdiTFeNQf29Ynw9g0m2+gRA4YVLJqCAJIXRMl9oyGGtdmCqPoI9+i3vSYJJX5LXVWkQzdoPupE0TvyDOZaTN/1qRvyBySx0ksx/euQpkUhGDZKCAgc/xVSqgLh9AkG3RpD5SMUER5O20yMz0CVS8kYEY= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3aQoZ7KHR2GcOZ9r8bhhBvkQm1A+7Q9nDq6WNgIrj6tijtFdKtUuge7ow7bu?= =?us-ascii?Q?iAPQw2CxBwtGUNqt8+VfpjRFxwogwXGN01HG9BvXQB+qqQVTCzmf8TEhkMV+?= =?us-ascii?Q?tnraTVzGjtBYlqlwbIngvsbKa+qZkvnE7TeW9DQinqLyLURQTHxvZRp0BqFe?= =?us-ascii?Q?2RTvg9+TpX+UGtYstpP+IDaeMjVUHsMqlfN894eYNeNu5qTT5YEIklgIkFPQ?= =?us-ascii?Q?wi3VVhVVxYnpjyTyUDFnTDn/0MdQkSvQq0QPrAt+Xh7cY4qWrtEljsLB69bZ?= =?us-ascii?Q?PdRivjUW4unjHwrY79C/TSXJYKkiRI9MP+WvEBIgnGHTof/2Vt7htxvwThHp?= =?us-ascii?Q?wlCZZRArkU50+2xrNJdqfbWb+WcgLSPUKY2OMKvPsgEouF5Yk5tLo8op4lpa?= =?us-ascii?Q?B5OKmeh3duhqGm2/3DQqKZLuAs6/LhpMINeVKpye6kQqf9jDJ1demAjHZA78?= =?us-ascii?Q?vqKt8myiB3cOeANaBl12o9bpUOqbRPigLh4/MDgex/SyoylWm2qVcBXldca/?= =?us-ascii?Q?1C5mN3yPMdoYublx0hWgPg1mAepZ40K3v6em9iFSAgyoCh5IzhXfumZzKrQ5?= =?us-ascii?Q?swn7KYxgv/Tr94QlH9wOR64KoMjBEZLu1b+Ma9EGARem+1HyCyqESe/k8eL/?= =?us-ascii?Q?HVmFw4XjzWAIGrCQN0rLzPxGHdJBbzq/4qtIv68tTtpIu6WBV7FZfXRUYIb0?= =?us-ascii?Q?krLcFJjCv9cMsFw4FTEdVEpCUJNabFnk9VSVSgI/Ib27QZu3Z/UUWxY4QmYv?= =?us-ascii?Q?eaSSkTa9ZoLCM/s2yirCpbgoMAoC0rgnkCBh2/rGDq66bZIjn0QaxO09w6e/?= =?us-ascii?Q?EkYudYXws73q2ZBTw5xmO6sNqj7dc0TZMlfXm63IOwwiSAfhILj+2eQowTbU?= =?us-ascii?Q?eZJFIDVk66dkfiB2rlLJVgaiw2OyGRt7BwqPcgBAHaoHCPZ8NWfHKWyj026b?= =?us-ascii?Q?S5QFWZp8m2iXQUKKKWHtyQs9NeUdUPChNA6iVdaBhpnQtkVtJQgrLeWUYYF1?= =?us-ascii?Q?X83rseH+QLnS8IhYQg9nbGfmrJE6U62APYyPfknbxdcU/ZLaqyEyMeETBMnD?= =?us-ascii?Q?whFVRfuL969xg2oBgeiLYW+7B4eXsWSHF/lXQc2XiC/5fZo0Tj5kNfaopG4+?= =?us-ascii?Q?f6AzSnYBc0MQLnytwg2sno9coOxFgnf/YiMgkgkKapOSTIfDN8YcYGHe1+mR?= =?us-ascii?Q?EiH5VpxuWrn6u59P47N7yfQEsrfOhVfqTJUFXzf2haMXfyz4pOaJ0d+VEhQF?= =?us-ascii?Q?b7c+112AGbw1U60WpCnlqg5BvfWFEZHTL78vVJF4k8Piyccuy3BnbiuGly3F?= =?us-ascii?Q?qxV1sRJzOwhVtVtWEGp+pJV+TF811KwI31MfPpGgLtaFHhLlcVafSWombjol?= =?us-ascii?Q?eHGfwwhz2uk221dw64fWvUFgyJzap+r14bEEYSOVFPrkVnQaJxasSBIUQrNa?= =?us-ascii?Q?X/u62rz85hj56UtTYFMa1Hqwee5w0/fHnycJI5QqPPkjKJmhJn9PhKzIrUa+?= =?us-ascii?Q?TcdHqYsEIE/wPDvwk4a45WWbWi0+vFr3O+DHtmXBzPtcdoUvDYTxDA32K7ao?= =?us-ascii?Q?grV+PxyddUtPtjym04dXxNrInMLNTIaMftcTR8LE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48b59f62-85b3-4f48-4891-08dc28709572 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 06:38:38.7911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3H6il5mXLhtDAyT4cLWp9EAVm9YrVd+As3gitzpkjEk6swOXKp8abre1HR1T52CtSa7L4JoWFdEHjbe7uGgqmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6872 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vGwVTMhEKmDDSDgpJNoUvEhox7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=M8CyXTOp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Mike, We checked the PR Gate -Ubuntu / Windows log, and seems the error is not ra= ised by patch itself. In order to prove it, we submit a new PR with exactly= no changes(only and empty lines), and the tests are still failure: https:/= /github.com/tianocore/edk2-basetools/pull/114 Could you help confirm that? If it is not the code issue, can we merge the code directly or fix the pipe= line issue first? =20 Thanks, Christine > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, February 8, 2024 1:54 PM > To: S, Ashraf Ali ; Feng, Bob C > ; Chan, Amy ; Chen, Christine > ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Chaganty, Rangasai V > ; Kinney, Michael D > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuI= d > from allskuset >=20 > I will merge it soon. >=20 > Please work with Christine to get edk2-basetools CI working correctly. >=20 > Mike >=20 > > -----Original Message----- > > From: S, Ashraf Ali > > Sent: Wednesday, February 7, 2024 9:50 PM > > To: Feng, Bob C ; Chan, Amy > > ; Chen, Christine ; > > devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Chaganty, Rangasai V > > ; Kinney, Michael D > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > SkuId from allskuset > > > > Hi > > > > Is this patch merged! > > PR under base-tools repo : https://github.com/tianocore/edk2- > > basetools/pull/112 > > > > Builds are failing, looks like it's not due to these changes. > > > > Thanks., > > S, Ashraf Ali > > > > -----Original Message----- > > From: Feng, Bob C > > Sent: Tuesday, January 30, 2024 1:19 PM > > To: Chan, Amy ; Chen, Christine > > ; S, Ashraf Ali ; > > devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Chaganty, Rangasai V > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > SkuId from allskuset > > > > Reviewed-by: Bob Feng > > > > -----Original Message----- > > From: Chan, Amy > > Sent: Monday, January 8, 2024 11:54 AM > > To: Chen, Christine ; S, Ashraf Ali > > ; devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Feng, Bob C ; > > Chaganty, Rangasai V > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > SkuId from allskuset > > > > Reviewed-by: Amy Chan > > > > > -----Original Message----- > > > From: Chen, Christine > > > Sent: Monday, January 8, 2024 8:29 AM > > > To: S, Ashraf Ali ; devel@edk2.groups.io > > > Cc: Rebecca Cran ; Gao, Liming > > > ; Feng, Bob C ; > > > Chan, Amy ; Chaganty, Rangasai V > > > > > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > > SkuId from allskuset > > > > > > Reviewed-by: Yuwei Chen > > > > > > > -----Original Message----- > > > > From: S, Ashraf Ali > > > > Sent: Monday, December 25, 2023 11:28 PM > > > > To: devel@edk2.groups.io > > > > Cc: S, Ashraf Ali ; Chen, Christine > > > > ; Rebecca Cran ; Gao, > > > Liming > > > > ; Feng, Bob C ; > > > > Chan, Amy ; Chaganty, Rangasai V > > > > > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and > > > > SkuId from allskuset > > > > > > > > Currently when the platform has many SKUs then allskuset will be > > > > having so many duplicate. and while parsing the allskuset will > > > > take longer time while assing Pcd.SkuInfoList. > > > > This patch is to eliminate those duplicate entires to reduce the > > > > build time > > > > > > > > Cc: Yuwei Chen > > > > Cc: Rebecca Cran > > > > Cc: Liming Gao > > > > Cc: Bob Feng > > > > Cc: Amy Chan > > > > Cc: Sai Chaganty > > > > Signed-off-by: Ashraf Ali S > > > > --- > > > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > index 592d4824a4..dac81454a9 100644 > > > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > > > self._DynamicPcdList.sort() > > > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in > > > > self._DynamicPcdList for (SkuName, Sku) in > > > > pcd.SkuInfoList.items()] > > > > + # Remove duplicate sets in the list > > > > + allskuset =3D list(set(allskuset)) > > > > for pcd in self._DynamicPcdList: > > > > if len(pcd.SkuInfoList) =3D=3D 1: > > > > for (SkuName, SkuId) in allskuset: > > > > -- > > > > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115266): https://edk2.groups.io/g/devel/message/115266 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-