From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B46EE740051 for ; Tue, 29 Aug 2023 09:10:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DM/8CGUMy7k1EMX/0NPlPkQfXNGxbSOZnmCZAyUDBAk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693300245; v=1; b=FIDv0Je+qwEjjEkQwHlFaUQFZS2rMaZNmPhLi1/f8aizNZCgvt9CXEOd3FUe9M9DbXpTI+6/ I28CPV/0xZIYwhRqImL8Qyk0JNW5W6K+Y4+Dg4h34p56ZxtQ0n6o9v2skQv7kfbaKzs0Ggmc6hd cl5WzV9A9Z7rU7FU5qvOL4xU= X-Received: by 127.0.0.2 with SMTP id 8B3wYY7687511x4wJ0JVwAIA; Tue, 29 Aug 2023 02:10:45 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.13331.1693300244173002147 for ; Tue, 29 Aug 2023 02:10:44 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="441669552" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="441669552" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 02:10:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="741740957" X-IronPort-AV: E=Sophos;i="6.02,210,1688454000"; d="scan'208";a="741740957" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 29 Aug 2023 02:10:36 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 02:10:32 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 02:10:32 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 29 Aug 2023 02:10:32 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 29 Aug 2023 02:10:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LcOKphoydKjz1Uq9EkEUZDl8Qf1uCEbfIJo524Zj6PFrWkv8J7BqMaoR5QoR0GHvVAChZYflTU/cHa69p4hq5tSJOU6SaExTEzNiTiyR2iJ0YWvG5Dr1V7nkxli7/kd1jUnsErjPsDuhafEG/Km5Kdco8PoyszujHQiHBjRr7c+RXAkeHFMD6Y7vbgYqcwJ3Usy4ZoSoAyCpWtTcEm2RN/pLnV6oQcag3Dfo46GHs8q3ENr7Jx4p5FIN9sExt00Sl5QVI3dIWJT4YwfMJupyrHcUcbU1wVc7SglXJHb0aLcPHowrtbBbyqP9X1VfcPvj+6JWK0MgnZQVUQurXDoy2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vL4CFuPAVjES9sWH1tzydHhxTsqKdXb/BHj/uQwdmZE=; b=BUR127QhtoMxTkupkWXOq6+etGt8GiAojQLIK7AzwyWn+L3+EDoinCFlWviNXC0D4DvhTa9GPEwOd9E17J9NBHiwjBVlyywwrmEG/wW1q4j8b8NCVzGWZhuUyWEhNZcJ+Of9KR6rK9E8uDjRKVLC6vTQPZyiaipYay8/TWmJJ0kgDQRi1xbdWz62/YSvYmcpkGIOeEnv3GYJ1HWlUiAjDFEmdUhQBm2xLlhx/3znWFSwwiKR+s7ef60HXnW5x6iIm7xNW4GaXIi3TlxtFVz/mDtlSyum1CmEOjy4+Gg7WUfeI/dYerze7lKTy2ngq/4sJJvrA673SyGw33ZFv2h2/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by CY8PR11MB7779.namprd11.prod.outlook.com (2603:10b6:930:77::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Tue, 29 Aug 2023 09:10:28 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::ff39:a24b:fc9e:d8e5]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::ff39:a24b:fc9e:d8e5%6]) with mapi id 15.20.6699.022; Tue, 29 Aug 2023 09:10:28 +0000 From: "Yuwei Chen" To: "Srinivasan, ManickamX" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" , "T V, Krishnamoorthy" Subject: Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Topic: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Index: AQHZ1ZOlBuI1jBnWcUmkPXs2IiDbYbABBfxQ Date: Tue, 29 Aug 2023 09:10:28 +0000 Message-ID: References: <20230823072919.23372-1-manickamx.srinivasan@intel.com> In-Reply-To: <20230823072919.23372-1-manickamx.srinivasan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|CY8PR11MB7779:EE_ x-ms-office365-filtering-correlation-id: 52f91314-7707-45a9-c71d-08dba86fca01 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: KsIoA9ILFExlS03ZoOb+HEmsiVxb1cXXAGXi6sRCx3QZS5yqZyo7GViAKVhmHxnbDRWNU7Hv8COKGyKXVaD9KNNPZHWWET7FY8qxBw9g0aWVePSKPO7MqOd+TUBY70ms1iliPZxPdi/itq729XMo6X3044yMjrhP1t13L5kazYh+kCiA4KtwUEWYddr1w2Cn9RD50YUbOUCQpVIUhFngQb54xWZp7ttYCjiiEOkzIo0JUvrENGD6SGh3PdwjxLD4efWUEHJFhXE4SlpFvKCt6cS5DpYsSuzLFhUwPi4KwSi3J7eFhI+dHIj2hJL5jY53deD9bJjyvg90ZGCqlqRCYnS21ILruuhmVMdpPZx8vjslqn9BQBQi2cWUsE101s7kD1mie6s817je4Bf01/63Ii+WCeaefFJ0WvFisYv7y2NSetp3bizYcdORqBZLgc1185AW9e0vRfUBs3Sem20CQ8/2NkG+D7ZrHYaHK77TCQ65dFMoaxZwrr3Obic/Vz3mq9b7Jq6/XoZG5W1auVp+wF35zlhpMEj25hl/SQee42m9dfgB/aAWfUPar9/9LitjR15X6WY5MlwN1I2AnyApifZANV4u4eRv3US6LJBgJjpinyEVFTaRN7eFoHYUmWB56OJOPBCSMjI1f/iXsjx4GA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PYyw79C3ov3YkeOzA/fXq8m4ZqZBL7HWMILBOklMD7djQQJT9leeiO38h0qr?= =?us-ascii?Q?lIK2/L8McV1s3RHYN4U1EMqL5toh/Geh54G+gLz2AsiD5yaXhlDaR8So69h8?= =?us-ascii?Q?4AEmnL6dVyvnjytmqez/POJn0LBeFh+qRhT8AK92aunjT2E9G99qcu27kVJ+?= =?us-ascii?Q?SJRGAF2uLEAmcBwluQaWxx4iE4FaGHJ1bFLPeJzS92Wn7EZMMjcMsH9N7ji1?= =?us-ascii?Q?ttPHPTg4LyIKZgYOJqLQJMCXL9cNU8FUeklsQwYNIt2heviDgnqX1zETwsAO?= =?us-ascii?Q?ueuNTQt/bejezeEWf720CifiZYKC/REi+B8Ez5iCbiYhyJZ4K4INgISppJkg?= =?us-ascii?Q?xCATCHlYp6Ic/FHWeGkg7fJYAqKZJs2eK2Eyzt4O1r/v6VtBnM8lpW4h06eF?= =?us-ascii?Q?5x/AIgn9kaw4dpqzvV3bk/wCZStMbXBhwf2MnsMUT/AkhQkUXFeJ33Ub6OKD?= =?us-ascii?Q?7/amptF5+1xNMY1BxHoZuQP/dh4aSAhtEUZmymTYlYOZ9iD4E0PNCYHihUJT?= =?us-ascii?Q?HM4Mre/jmd+2VZGos2f4mhBisb3H+RFks08KWxDtalN4NDWQQlCKBguPJR2t?= =?us-ascii?Q?SYJZId4xIpE7bOxM6rAeDzDA8NoBp6+mVczavKiJZ82Hp1HnW1I0Xu1OWdFj?= =?us-ascii?Q?7N8JQrlgNZjq5//Iu45y/BgIgFS7NjlRE/s7KYniHNdgkwSDmfAsZnBwnRh7?= =?us-ascii?Q?0caLwhLRlmbeRsj51xyRSp4SQjzvmjKklgum1z/g6D94AaJaZq3BYW+UnvxZ?= =?us-ascii?Q?eAi/E45XmIz1wdzLgbvFPQwWGDPpm87IPmXhgVvckb/orDPkKeG1lLL2lA11?= =?us-ascii?Q?EMlzD2Rpm9AuJ2ZC3nQ/eU+UivPudUSfuGmrvvGio3wUEWH0rSlvEA2eFC2g?= =?us-ascii?Q?4lurBwUhCMiFETq2Q5gTUHeEhUvkNakxC6Vm23Y5/FG/cj9ctYEBl6GbR00r?= =?us-ascii?Q?AuteWgpA5ai43xK0DVACVaEKhMbbIF6a/PTstnRK0+RNj5tg4UzqqBhqtLtj?= =?us-ascii?Q?JsgXvdHdeQE2ROxWF1/xWdm+jcXcsOr370ODoVfCijZf9uSQ/9LrJ+hElxof?= =?us-ascii?Q?6wcxSKgJonZGIC4HETB2WG6QfIUslE1zR4z3viSBMuBwxAEjH+vAcy6TXMcn?= =?us-ascii?Q?UVshCg53KrKe7CyAncQb621AftzLe6tdDSkyysy1IuO6TAlivKPskf+Air4B?= =?us-ascii?Q?F6FmdjBEeNalRiCpnwqXG+Fpt/Vbf8t6PPl4vqaEcmZWOqibZLN6IEfQud5y?= =?us-ascii?Q?mTJgkmIDWRJ+tWrcDl/fTEkaQ2tGCpPGRYBVwwODts1ncnLfQzutw6cuq7Fm?= =?us-ascii?Q?jWh8UKAFFmon9wb0+tiL/Qm+vhB5sTGMJcPb450Aa+DvIKtrCio3BlEzhfzj?= =?us-ascii?Q?aO9xFF2T1X4vpx/6QQ6wm5yn0V3WZDI4sQkbhwk9loC2tM3LG3lzR+ToZmSm?= =?us-ascii?Q?FDcHV06AImqAdKurYyIxwXAwg+jLRQE6ZOJX613ESB87iWZeppjW5kjO+QQP?= =?us-ascii?Q?2PvkikvvqccvhDXO4pDXk+/n9gNmb4fO5LER5GiHHwIHguuvh71aXwI8Q2Aq?= =?us-ascii?Q?VHtCOOJTfgznFyREJRlOagWG+nfH+vAIHa6/XAwK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52f91314-7707-45a9-c71d-08dba86fca01 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2023 09:10:28.6856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +BSmSQ4saPa3PHQiOaizovNsgt0+biJ9vY3LRmR82F321f6C5JQTyr7i2M19xdNTQjcMtZq/3zn+I4f5pH6leA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7779 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oWBmuDWYMWhTvG4l8wF6YTsxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FIDv0Je+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Yuwei Chen > -----Original Message----- > From: Srinivasan, ManickamX > Sent: Wednesday, August 23, 2023 3:29 PM > To: devel@edk2.groups.io > Cc: Srinivasan, ManickamX ; Feng, Bob C > ; Gao, Liming ; Chen, > Christine ; T V, Krishnamoorthy > > Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE > support >=20 > The length of the Board ID is being updated based on the BOARD_ID string.= If > the PCH_TYPE is empty space/single quotes(''), removing the empty > space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT > and BUILD flag strings. >=20 > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: T V Krishnamoorthy > Signed-off-by: ManickamX Srinivasan > --- > Platform/Intel/Tools/GenBiosId/GenBiosId.py | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > index f823fdcad..fa3689867 100644 > --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > @@ -142,7 +142,13 @@ def ParserInputFile(InputDict, NoTimestamp): > EdkLogger("GenBiosId", FORMAT_INVALID, > ExtraData=3D_ConfigItemInvalid % Item) > _ConfigItem[Item]['Value'] =3D InputDict[Item] > if len(_ConfigItem[Item]['Value']) !=3D _ConfigItem[Item]['Lengt= h']: > - EdkLogger("GenBiosId", FORMAT_INVALID, > ExtraData=3D_ConfigLenInvalid % Item) > + # The length of the Board ID is being updated based on the > BOARD_ID string > + #If the PCH_TYPE is empty space/single quotes(''), removing = the > empty space/single quotes('') and concatenating the > TARGET_PLATFORM_SHORT and BUILD flag strings > + if(_ConfigItem["BOARD_ID"]['Value'][3:5] =3D=3D "\'\'"): > + > _ConfigItem["BOARD_ID"]['Value']=3D_ConfigItem["BOARD_ID"]['Value'][0:3]+= _ > ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])] > + > _ConfigItem["BOARD_ID"]['Length']=3Dlen(_ConfigItem["BOARD_ID"]['Value']) > + else: > + EdkLogger("GenBiosId", FORMAT_INVALID, > + ExtraData=3D_ConfigLenInvalid % Item) > for Item in _ConfigItem: > if not _ConfigItem[Item]['Value']: > EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, > ExtraData=3D"Item %s is missing" % Item) > -- > 2.30.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108086): https://edk2.groups.io/g/devel/message/108086 Mute This Topic: https://groups.io/mt/100916084/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-