From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@bsdio.com" <rebecca@bsdio.com>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file
Date: Wed, 21 Jun 2023 12:12:54 +0000 [thread overview]
Message-ID: <MW5PR11MB590659E2C650D9FDF5837C22965DA@MW5PR11MB5906.namprd11.prod.outlook.com> (raw)
In-Reply-To: <117dda45-f4e3-b4be-aa91-a1ed08e6b40f@bsdio.com>
Hi Rebecca,
Thanks for reminder. Will update the patch later.
Thanks,
Christine
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Saturday, June 10, 2023 9:04 AM
> To: Chen, Christine <yuwei.chen@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Feng, Bob C
> <bob.c.feng@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select
> Config file
>
> That won't work on Unix, where the separator is ':', not ';'.
>
>
> --
>
> Rebecca Cran
>
>
> On 6/5/23 02:12, Yuwei Chen wrote:
> > Currently, Python FMMT tool does not support automatically select
> > FMMTConf.ini file which saves GuidTool settings.
> > This patch support this features.
> >
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> > ---
> > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > index a25681709bc8..671d77c47de9 100644
> > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > @@ -110,7 +110,7 @@ class GUIDTools:
> > if os.environ['FmmtConfPath']:
> > self.tooldef_file = os.path.join(os.environ['FmmtConfPath'],
> 'FmmtConf.ini')
> > else:
> > - PathList = os.environ['PATH']
> > + PathList = os.environ['PATH'].split(';')
> > for CurrentPath in PathList:
> > if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
> > self.tooldef_file = os.path.join(CurrentPath,
> > 'FmmtConf.ini')
>
>
>
>
prev parent reply other threads:[~2023-06-21 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 8:12 [PATCH 1/1] BaseTools: FMMT GuidTool Auto Select Config file Yuwei Chen
2023-06-10 1:04 ` Rebecca Cran
2023-06-21 12:12 ` Yuwei Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB590659E2C650D9FDF5837C22965DA@MW5PR11MB5906.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox