From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"quic_rcran@quicinc.com" <quic_rcran@quicinc.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message
Date: Fri, 24 Jun 2022 01:24:55 +0000 [thread overview]
Message-ID: <MW5PR11MB59066AD486F78F4D72D4A85F96B49@MW5PR11MB5906.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220619220709.9665-1-quic_rcran@quicinc.com>
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Monday, June 20, 2022 6:07 AM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
> Cc: Rebecca Cran <quic_rcran@quicinc.com>
> Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error
> message
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
> BaseTools/Source/Python/Ecc/c.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Ecc/c.py
> b/BaseTools/Source/Python/Ecc/c.py
> index 4a82e5e76003..61ad084fcc5b 100644
> --- a/BaseTools/Source/Python/Ecc/c.py
> +++ b/BaseTools/Source/Python/Ecc/c.py
> @@ -2612,8 +2612,8 @@ def
> CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier,
> FuncHeader, Fu
>
>
> if Tag.find(ParamName) == -1 and ParamName != 'VOID' and
> ParamName != 'void':
> - ErrorMsgList.append('Line %d : in Comment, <%s> does NOT
> consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
> ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> - PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> does NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
> ParamName), TableName, CommentId)
> + ErrorMsgList.append('Line %d : in Comment, <%s> is NOT
> consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
> ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
> + PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
> Comment, <%s> is NOT consistent with parameter name %s ' %
> ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
> ParamName), TableName, CommentId)
> Index += 1
>
> if Index < ParamNumber:
> --
> 2.35.3
>
>
>
>
>
next prev parent reply other threads:[~2022-06-24 1:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 22:07 [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Rebecca Cran
2022-06-24 1:24 ` Yuwei Chen [this message]
2022-06-27 0:38 ` [edk2-devel] " Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB59066AD486F78F4D72D4A85F96B49@MW5PR11MB5906.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox