From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.2536.1656033899422927268 for ; Thu, 23 Jun 2022 18:24:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Nyqw11fE; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: yuwei.chen@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656033899; x=1687569899; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=uxG0xnDIt5ElAFe9FVFiJJJ2/+BV0Qe1VrR6p/3+6dw=; b=Nyqw11fE64Q9Jx2WNg5wBb3eJ0Nw0+Ddc8d8G+ffNMb8jF9SQNRa8xyx hMRlzXeASjoDIzz9I+k6eZNnx40owCXSdsZTdwV8hEvU5eFXdTzMufL6x 17lVegFdNdXdexOaFLhVUQ30Iv721n/nOVncBlK+DzG6i5aiKOczChdoK Vv2uJCKT03yXgHfu3kjJ0wKiXlzKk025AWGqmsEcKkPVzAEyFLw+R4eWV glT26td4MVzyrbcRNKxaLm+of3dpLSDkOeg867jty/0MPxJgb2xqaalMt YZmFNP7Xc9WJOpu6kO3FMYvUmQv+HOGHFC4Q8/6EbUxgSkN7IotKxPOq4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="344883824" X-IronPort-AV: E=Sophos;i="5.92,217,1650956400"; d="scan'208";a="344883824" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 18:24:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,217,1650956400"; d="scan'208";a="691303595" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 23 Jun 2022 18:24:58 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 23 Jun 2022 18:24:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 23 Jun 2022 18:24:57 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 23 Jun 2022 18:24:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QLOq80uBINszdKoztlrJxxaTnccJvBjiCm8lj3izfDSRHj++t8sviP4PDqyn0ifizsuez0T1juVN8wuW4gdtHNAcGeVSLQ5u6nwvHtCpEJgcJ/kWP5bUbvrSZ5vK6L9SCLgkfS+yTi2X29LNzMtEFeijKeauATDnuPd8njnGyZ0HeUcYjQ8jebrib6hhPa73zGkaoLALcNEThjTVBqTIaGb9DlwYRSvKt422uisT/REMc2dt/ijID82XP6IwU0+DDeZkDxb5HYoGnZW43zh+SFzYZVpPLdBrfV0MSL5ytA0OtGRlYDLBhoXbSpF0Zc/mnQDvgg0CIOZS3S6C7ZKwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gb6UYkT2w2g5/4CWRS4yxUMvjvb7x1d4q9THzFeEYtk=; b=Cdc+kKQG0A1FBVowTsieT80uliBGQg/c9+K0nucAEpqOBT5ExOovPQqHqUNh43snmK1Go7it6+sOnSnNT3IOslrA2pD7PUJmKZ55M/3oxOMRF4XeEcpuVCObMbZ8LMFbRyEV9GJ+eMdw0Xbjd0+hH4mRVBC2VUKV9UTs7dwN2eDKBF+iYNhf1Ry4hnP45iqNjYg7m6Z/BQr3t8qjiw+T/rBqPiwI/KEJMuD2H+K0Yp69bnWYhOH8fGHOURtJdz92988iKnpGjVg3fqmeB0PejgAtEHPIfDC2xGSDpn0HjHoRvGJ1W9g7IkR0OW8F1RMYRVd2EtHQgFmXvAApUICgHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by SA2PR11MB5098.namprd11.prod.outlook.com (2603:10b6:806:11c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 24 Jun 2022 01:24:56 +0000 Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::2d9a:578f:afd5:462d]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::2d9a:578f:afd5:462d%6]) with mapi id 15.20.5353.018; Fri, 24 Jun 2022 01:24:55 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "quic_rcran@quicinc.com" , "Feng, Bob C" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message Thread-Index: AQHYhCj7cxt6rAVlmkKC5KuK1i9vMa1dycaw Date: Fri, 24 Jun 2022 01:24:55 +0000 Message-ID: References: <20220619220709.9665-1-quic_rcran@quicinc.com> In-Reply-To: <20220619220709.9665-1-quic_rcran@quicinc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 615d16d4-1ff9-4c5f-3e39-08da558058bc x-ms-traffictypediagnostic: SA2PR11MB5098:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iHS1agsBDZRC2O2mtok+QWAH7C66JyZiQSYmLQRFqmkaTXHz1PD3+YrpgYCgX9cxqN8eaMwVmYtIkU6djPTmNUt4ZbQ2zwKRPr6qIKwjgVX8z24PGmdOPhMi7oA08e06XJ+BdCDaQd6CK3KzGMfRMrgRvsv79qIn1aSkv28+CauX1bdm7asSQD7aexNFKplhC6/wTXYpyD/Qm6eOdRp77E5LWW2AVoWWAEeobKx/6a1TXVPuMEMF10ziOsMR7XzXLAYqrZsTjsxKIA/dw7hHkq8eOrhWNbPKJoATNhsRtkTRbF9dxO2ovw1Sv9XgmAKZ4SEf3Ak7IS9tbCzsY1h3ovqANkwwassZ0TvFOaVviUrJyRHRVQW/vKmV+pAE7MeHjP52oz+NfmIir9JPLhTd8eZrmbynpxkrnJna7XRwf6tqXx+pNPLu58iUNKzD3fuIZE4q9/eXAdieNQZVUcF1J80fA3tCsgi7EIqHnbFn/Ej3FWNZSd7cPNmUFOfacu1nGO0HZ/10OFT9liPnHuDY1r4q1pQCzWli6tY2SxzNxukP1RDNn4qbYD91WV6mWqSBoRhnWSIrSxZX7AO5ffpa7KvEc5bKr2vUtPZ22VoJD91G+R8LiWBOriQnbNyhQC0SzuXNnFdMkrW7vQ6+MPZUshMOk4dBaANDOusWQcz6Hl6uV8tMPD+N+I1JX8QJzCOeC12GpS2WCS7fz95qjNCz0ADiR2k2zHLoE7BCwOfz7ISYr0wO+149xSVZA3dJud4IuN1SQEuGqWG2ziIMrZvQCmgtmSsl0owWKi8fkHCjMdW4wRruMGSxQkUwhidcJdxca57KstReN/5u4DXClH9400fBXlhMmsSDhCoW70vfEsGsu+80IHwzFGBsHIF9zIIf x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5906.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(376002)(346002)(136003)(66476007)(66446008)(64756008)(66946007)(76116006)(8676002)(66556008)(71200400001)(4744005)(86362001)(38070700005)(55016003)(110136005)(5660300002)(82960400001)(122000001)(186003)(52536014)(8936002)(7696005)(6506007)(53546011)(83380400001)(38100700002)(9686003)(41300700001)(26005)(33656002)(2906002)(316002)(478600001)(15650500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b4QLQzjukWOLRssxN16nOQyLcSLT6BSZusAPx+tbXaQgFq+dLoS3nyw4iYzT?= =?us-ascii?Q?NbPzADDTDqeaqSiFwAYNiZCES9wy7BqduJgwGRWZKqezTwqdAzxtWlPim/l7?= =?us-ascii?Q?UAPpoSOA4zvzN8Uv1qLmY6YDvlZRTRPwYDtXtGm1jggBj+ku3GA9SV649Tg5?= =?us-ascii?Q?o2+K26yNschIyQNp5C+eN85gfrEBkJm4Luf+w7wmvTycQdXPfjV6xQ7WgL5a?= =?us-ascii?Q?gqjhtk2OevMW335JbobWUoG9AkQjBf0JTbG8v/8CJPYAmkDVhO30XoSad3yW?= =?us-ascii?Q?JvNNZ3fL7wgi/aVZ8ST7jxjf2uyqW/9KxZI97W8uSX2K9v8zGasmBKPlJKqP?= =?us-ascii?Q?tlH+4w50414fySzkCPsrM7k+v5+t8nruapfktK3QNQfSqgQqmKt9huKr6JrI?= =?us-ascii?Q?734LQ6jKySmzArxGoBdCCJEBm2Gh58MDsDgTjMucx8TZ/Lm9NgZzid1Gc4UA?= =?us-ascii?Q?mDBl0Qrht3epf4As8Mg4ltRXLToEvGwvZm3//lypk6TTHydICI97rdE73xoj?= =?us-ascii?Q?Q0BWeBBuS4GXfoy4jTGM6afhZBQZ4op2NPpIxfUcmS7UzqDUK1cWMoaHlkll?= =?us-ascii?Q?MDgS7HBYaqGyhdChvR3EguxfkT2GX6ugXjLlkhz6J9f5Q7ERM4ko3ST3pcXm?= =?us-ascii?Q?lfOptM8ugda59h63amUi6uf17+55I3Lqewng949IjE8ovXW9RcQ0g54Ijjs4?= =?us-ascii?Q?bIr4kIE4MotLkKPa1J55bWJrmSXh//GJF2CCQIDQidaUYmdJzpuME0gZtAaF?= =?us-ascii?Q?IfPnzvia0f3H6ioufF7d0q+5FzgsW8hNy2Cw7sI3vPshJkg2JKR7Kvwv8KkP?= =?us-ascii?Q?d9EdegyqAL3zm1ocxWusqwzaMYNV1n/tNvhiAKS6++SuT2peSR9qNQKZ4UQ6?= =?us-ascii?Q?xeA7Un2VItTAmZmzP+E1ixPWSJPcszWEre5AB0hyJL8mx0YW4ZFe/L4FfwPA?= =?us-ascii?Q?GDsQqFX5ZQJJE/fzjzq9TlFwx2bgE/coNtktogD/Q/hYb3TdduTz29xLKyUI?= =?us-ascii?Q?OGK9Q2ZGx2a2vxv7qL/n6q6Dh6tTUl26YsxDij2cesksk6lBuWr8TeXrSkU1?= =?us-ascii?Q?LML0tYWOheDOR6fLLM7jxEl9oEdGX0aZBMnR9VXZoJz05Y6CPzZ6rglMwLaV?= =?us-ascii?Q?Nl1cYuFguuJFqkf2caQefrEgZ7zzNzekyOid/zB6aJ64JXocJdI2Acak/dUA?= =?us-ascii?Q?yr/awEhaliasc4MnPkJc8fANsjawy/C/cFvsXq/djeLjaqVB3B/+MEMD3Uyp?= =?us-ascii?Q?s99jXSi5NlTHTBQKNa8lIkIgqomxbW7nVjYnaNW4B4oAc8YKPry6WlKGnea1?= =?us-ascii?Q?fUXT20TN4ZMJWajdPRGof9L3wZsyoBwj2T5i6EfM4ov7sM/osEg9BJu0yuXp?= =?us-ascii?Q?sVO+WoQdct6mruhsnBHekiI9qd4rqgwUg7caJHa6jLvqVMdsfkrInLXOVxB/?= =?us-ascii?Q?YSisDN6tRwypIoPFkbwmZAA0vXqwL+KaX5y2FrBy2ZgwANfroT3sE2oqepzu?= =?us-ascii?Q?fyQyEItDz20ED9/E4SUz2pOvbJKD9Ll8FZ4HkIz0XEpMe6t91byFeqKQw3WQ?= =?us-ascii?Q?Phr8v0sOIzXWjfQyLWYJBmEZdSeN9gaWpYdItKGh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 615d16d4-1ff9-4c5f-3e39-08da558058bc X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2022 01:24:55.9096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jke16oqGPGTW/wxmV1S/53oFoa/BFv7ujo28G2jE8tTddI+FCZrD50Y62aaUW50Pegr1nGCKrWtfhnnAVtwVtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5098 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Monday, June 20, 2022 6:07 AM > To: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming > ; Chen, Christine > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error > message >=20 > Signed-off-by: Rebecca Cran > --- > BaseTools/Source/Python/Ecc/c.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/Ecc/c.py > b/BaseTools/Source/Python/Ecc/c.py > index 4a82e5e76003..61ad084fcc5b 100644 > --- a/BaseTools/Source/Python/Ecc/c.py > +++ b/BaseTools/Source/Python/Ecc/c.py > @@ -2612,8 +2612,8 @@ def > CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier, > FuncHeader, Fu >=20 >=20 > if Tag.find(ParamName) =3D=3D -1 and ParamName !=3D 'VOID' a= nd > ParamName !=3D 'void': > - ErrorMsgList.append('Line %d : in Comment, <%s> does NOT > consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] = + > ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName)) > - PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in > Comment, <%s> does NOT consistent with parameter name %s ' % > ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', = ''), > ParamName), TableName, CommentId) > + ErrorMsgList.append('Line %d : in Comment, <%s> is NOT > consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] = + > ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName)) > + PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in > Comment, <%s> is NOT consistent with parameter name %s ' % > ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', = ''), > ParamName), TableName, CommentId) > Index +=3D 1 >=20 > if Index < ParamNumber: > -- > 2.35.3 >=20 >=20 >=20 >=20 >=20