public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yuwei Chen" <yuwei.chen@intel.com>
To: Konstantin Aladyshev <aladyshev22@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH] BaseTools/VolInfo: Increase define for highest section value
Date: Fri, 22 Jul 2022 06:47:07 +0000	[thread overview]
Message-ID: <MW5PR11MB59066DDD1A7700C3F939FF0596909@MW5PR11MB5906.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220718125553.17945-1-aladyshev22@gmail.com>

Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>

> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Monday, July 18, 2022 8:56 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>;
> Konstantin Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH] BaseTools/VolInfo: Increase define for highest section
> value
> 
> Currently sections with unknown types are displayed as
> `EFI_SECTION_SMM_DEPEX` which is wrong.
> Increase the highest value for the section type to 0x1C for correct parsing.
> 
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h
> b/BaseTools/Source/C/VolInfo/VolInfo.h
> index 624ac38f0e..377cde80f7 100644
> --- a/BaseTools/Source/C/VolInfo/VolInfo.h
> +++ b/BaseTools/Source/C/VolInfo/VolInfo.h
> @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #define EFI_DEP_END       0x08 #define EFI_DEP_SOR       0x09 -#define
> EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1B-#define
> EFI_SECTION_LAST_SECTION_TYPE       0x1B+#define
> EFI_SECTION_LAST_LEAF_SECTION_TYPE  0x1C+#define
> EFI_SECTION_LAST_SECTION_TYPE       0x1C  #define
> OPENSSL_COMMAND_FORMAT_STRING       "%s sha1 -out %s %s" #define
> EXTRACT_COMMAND_FORMAT_STRING       "%s -d -o %s %s"--
> 2.25.1


  reply	other threads:[~2022-07-22  6:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 12:55 [PATCH] BaseTools/VolInfo: Increase define for highest section value Konstantin Aladyshev
2022-07-22  6:47 ` Yuwei Chen [this message]
2022-07-24  5:31 ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW5PR11MB59066DDD1A7700C3F939FF0596909@MW5PR11MB5906.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox