* [PATCH] BaseTools/VolInfo: Increase define for highest section value
@ 2022-07-18 12:55 Konstantin Aladyshev
2022-07-22 6:47 ` Yuwei Chen
2022-07-24 5:31 ` Bob Feng
0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Aladyshev @ 2022-07-18 12:55 UTC (permalink / raw)
To: devel; +Cc: bob.c.feng, gaoliming, yuwei.chen, Konstantin Aladyshev
Currently sections with unknown types are displayed as
`EFI_SECTION_SMM_DEPEX` which is wrong.
Increase the highest value for the section type to 0x1C
for correct parsing.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h b/BaseTools/Source/C/VolInfo/VolInfo.h
index 624ac38f0e..377cde80f7 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.h
+++ b/BaseTools/Source/C/VolInfo/VolInfo.h
@@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define EFI_DEP_END 0x08
#define EFI_DEP_SOR 0x09
-#define EFI_SECTION_LAST_LEAF_SECTION_TYPE 0x1B
-#define EFI_SECTION_LAST_SECTION_TYPE 0x1B
+#define EFI_SECTION_LAST_LEAF_SECTION_TYPE 0x1C
+#define EFI_SECTION_LAST_SECTION_TYPE 0x1C
#define OPENSSL_COMMAND_FORMAT_STRING "%s sha1 -out %s %s"
#define EXTRACT_COMMAND_FORMAT_STRING "%s -d -o %s %s"
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] BaseTools/VolInfo: Increase define for highest section value
2022-07-18 12:55 [PATCH] BaseTools/VolInfo: Increase define for highest section value Konstantin Aladyshev
@ 2022-07-22 6:47 ` Yuwei Chen
2022-07-24 5:31 ` Bob Feng
1 sibling, 0 replies; 3+ messages in thread
From: Yuwei Chen @ 2022-07-22 6:47 UTC (permalink / raw)
To: Konstantin Aladyshev, devel@edk2.groups.io; +Cc: Feng, Bob C, Gao, Liming
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Monday, July 18, 2022 8:56 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>;
> Konstantin Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH] BaseTools/VolInfo: Increase define for highest section
> value
>
> Currently sections with unknown types are displayed as
> `EFI_SECTION_SMM_DEPEX` which is wrong.
> Increase the highest value for the section type to 0x1C for correct parsing.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h
> b/BaseTools/Source/C/VolInfo/VolInfo.h
> index 624ac38f0e..377cde80f7 100644
> --- a/BaseTools/Source/C/VolInfo/VolInfo.h
> +++ b/BaseTools/Source/C/VolInfo/VolInfo.h
> @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #define EFI_DEP_END 0x08 #define EFI_DEP_SOR 0x09 -#define
> EFI_SECTION_LAST_LEAF_SECTION_TYPE 0x1B-#define
> EFI_SECTION_LAST_SECTION_TYPE 0x1B+#define
> EFI_SECTION_LAST_LEAF_SECTION_TYPE 0x1C+#define
> EFI_SECTION_LAST_SECTION_TYPE 0x1C #define
> OPENSSL_COMMAND_FORMAT_STRING "%s sha1 -out %s %s" #define
> EXTRACT_COMMAND_FORMAT_STRING "%s -d -o %s %s"--
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] BaseTools/VolInfo: Increase define for highest section value
2022-07-18 12:55 [PATCH] BaseTools/VolInfo: Increase define for highest section value Konstantin Aladyshev
2022-07-22 6:47 ` Yuwei Chen
@ 2022-07-24 5:31 ` Bob Feng
1 sibling, 0 replies; 3+ messages in thread
From: Bob Feng @ 2022-07-24 5:31 UTC (permalink / raw)
To: Konstantin Aladyshev, devel@edk2.groups.io; +Cc: Gao, Liming, Chen, Christine
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Konstantin Aladyshev <aladyshev22@gmail.com>
Sent: Monday, July 18, 2022 8:56 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; Konstantin Aladyshev <aladyshev22@gmail.com>
Subject: [PATCH] BaseTools/VolInfo: Increase define for highest section value
Currently sections with unknown types are displayed as `EFI_SECTION_SMM_DEPEX` which is wrong.
Increase the highest value for the section type to 0x1C for correct parsing.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
BaseTools/Source/C/VolInfo/VolInfo.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/VolInfo/VolInfo.h b/BaseTools/Source/C/VolInfo/VolInfo.h
index 624ac38f0e..377cde80f7 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.h
+++ b/BaseTools/Source/C/VolInfo/VolInfo.h
@@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define EFI_DEP_END 0x08 #define EFI_DEP_SOR 0x09 -#define EFI_SECTION_LAST_LEAF_SECTION_TYPE 0x1B-#define EFI_SECTION_LAST_SECTION_TYPE 0x1B+#define EFI_SECTION_LAST_LEAF_SECTION_TYPE 0x1C+#define EFI_SECTION_LAST_SECTION_TYPE 0x1C #define OPENSSL_COMMAND_FORMAT_STRING "%s sha1 -out %s %s" #define EXTRACT_COMMAND_FORMAT_STRING "%s -d -o %s %s"--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-24 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-18 12:55 [PATCH] BaseTools/VolInfo: Increase define for highest section value Konstantin Aladyshev
2022-07-22 6:47 ` Yuwei Chen
2022-07-24 5:31 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox