From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 32DAF7803CD for ; Mon, 8 Jan 2024 00:29:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8i354Vl2acyGSnIQrJ9t0STsgeqSZ6UlChDQJVOfb/g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704673771; v=1; b=FZaLPa1bFRNirXlkfBbHpeseNs7UyBN/BK2Bzjb812YpANmsr24IdEWG3u+AYQSvvjnyAo77 2GzgdnMFoZ2SLOb+g5I7WxcF9PD0397AlKR5kjNgDMotk0yC52TgZvHbVHTbRwpPdQgxDp9U/Al hHsHejbrlwKdghF50PVJFgMI= X-Received: by 127.0.0.2 with SMTP id p4KkYY7687511x1PCV8ywrFp; Sun, 07 Jan 2024 16:29:31 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.28877.1704673770419978758 for ; Sun, 07 Jan 2024 16:29:31 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="397488717" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="397488717" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 16:29:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="900211507" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="900211507" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Jan 2024 16:29:29 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Jan 2024 16:29:29 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Jan 2024 16:29:29 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 7 Jan 2024 16:29:29 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Jan 2024 16:29:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEBmXs90C1dDWQS0cI/xzFWXBb717Cf5Wm5u4lDjz71BUhdq4FtBtWklZdF0/HE4BAhuK1iW6TurVAmNQ4W2F6wghbvYe6/aLlURj7BnBeGHcWJloZ0MntGsjAc5UWqB1d+0UIs7ahFxMLuBaFzkBkXjTc+iTPtmj52rcd/V6HYjM8ynVK/XuLdlho4lt57jUAUzEemMet16SBVXE7kSPdl+/69oNOpIM5NRtkq108/IN6Vr99hcSxurt0u6gc+kgHYu/v4vbeAo7zx0UQ+e9w5eWzbMd5lS5L2lLxnmoSO8lfAXAKQIU/rUT0jANS1WlR8qNf5vPEGNbA5JrtPVjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S8PHf3I03ANZFHj1LLsN4qbGChlTSF9J87UrQBcCeag=; b=brwJRzum32JgFl2Kmq4W4/RDTI1O0oeWt1aZgo1oSyEPbZkfbkMhWgQOORStZBbfsa/zawJh+wU9YLVY6gyrVF2EIdtKVlIiSteEV0DYJ/4HuOk8AY2oFJRwGdyTx3WtZtKjnPZYCvd9bF42wI3lcDF59H2w8eSALYJVMa3XGfozkOx4bZ6Q1iKVV4CKoNdYMWI4am69Ggmw4xewkxd1lFuWWWNY3IMFx5ERjejNpl5XGtCXii3m5Ub56Cl5Hnjdz64U6TP0Hh2PCiBbZh5wuqBnKK6tV1LEppWcNdwEx2eS/bSHRjHw7HWpPQbKFYJfnklj8m6y/ap7FSMignH30w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by PH7PR11MB8480.namprd11.prod.outlook.com (2603:10b6:510:2fe::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 00:29:26 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::75a3:d66d:5791:3b7b]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::75a3:d66d:5791:3b7b%5]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 00:29:26 +0000 From: "Yuwei Chen" To: "S, Ashraf Ali" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , "Chan, Amy" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaN0b/Myl0Fv1MCEWFVxeagzOOtLDPJOGA Date: Mon, 8 Jan 2024 00:29:25 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|PH7PR11MB8480:EE_ x-ms-office365-filtering-correlation-id: 73e42ed2-66ac-404a-4421-08dc0fe0de89 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: IDSMmYm1G+QYowCn2VcDglLDgUL+CXXTBsG3ZVWxAncwtQzcc5KCJR7vx21Gk9GrKG1lFP5zu1pzqXvpTN35keW02RPU/5QK2gfKT7K6NywIj3bUkNVQWexYOx5iu0hy3EMo+USU0plv2630Y4gWzNNdloNySVB7kJnM7VucbSbsnUhyHL2+Cq5oD57JNpN+hXg8dZawSFhTeviV1eh6KMm7SlGF6jnE8pVxSWRyLwPMJNqNgzMHFGILfctZEqaomKS4QP81QFpqLjyfKFMZUWCwOlzk8oGOKUA1k+aNinjMeBKR1h8ZdaY7miTinexTmuCGc4O4GdfkGHcYpDS+bl0xFwd4R0aQcFk4CIX8jb/3bcVq6Ts/8TGSEMzcRRoQ4qMM5S3D7AYOjwvEf/Xzyf3ajBxYqckZOZAAERlRE/1UgtqFII9gHiJCNABvxcf/irPw94sV/e/ltVMB/xzSqOIoK9AfCmhfW51eWrTwYYz3uxwSEDkKDm9LyZmLQ/WnzS+CZz1C4/gWQ+GtsFIwq+thZrEI5vjrZMaXL0CqClHQlw/Fh0pr+c6I0UnbyyOBazmywO/CcBblWQqyIyxf6XSy8k6iyclPnwgTC6utpT47qo3WTMWNF82uQtMLQCah x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iENaRygSpQz+m1t+E78pahIGlvvRqAxpuY34DAsMzlGYCPBilZQGw8N1NqqU?= =?us-ascii?Q?vHNS7jCKUcR0oJwImIu087nYX3inzsAVTIkZ+wUtoga/ejeykm4H/ACxDb/Y?= =?us-ascii?Q?nRjuIbspRRfQaaScqKf+JdWF28dRv7N3l26ChUc9AWqswwSqlP4DPudG1mrU?= =?us-ascii?Q?huKGMNNZ3TjS0KefuDjoyDaY/PgGtzAOgxHL0gm38CaH8izn156sCfZkp8Qh?= =?us-ascii?Q?bwkCd0HMzJh0+vKRLGK/a2yiA/PfPjEdb/bKY6vM1UT1BUEPXki1YQoXff3W?= =?us-ascii?Q?tys7r81qyLDmb8W0kNDYV/Q6sts45xtiMCWdsiLA8NFZn2xjL0YpwqUJRobY?= =?us-ascii?Q?WvYBGjg6OCH3B8srCFi+r7Bbw6K/eW1G9XfpI99JI83WPTYBGuwHOWCCewCF?= =?us-ascii?Q?vtH9o7+6sEJIpInWEEcNFU+d6T/c+lsBfb5GjvEqSYp8CXPP3VvmrYJQzJg/?= =?us-ascii?Q?c/gp3DhGnKnjt+8OnHYwZC35rsTRgSDdJdg1estmRLCCl42wQ4a0m/Y9W5Me?= =?us-ascii?Q?rLAYI2ibpo3nYVXAjToZIEPNqokxg0XAhZGD7hjA1Mqx/e7IgjwW1jVd3zk6?= =?us-ascii?Q?AASy7U4TQc4RgyG/rmVFbaS8KyBXzcvKmDYkdSoYSDvXeUIZXHXfbwQRePYJ?= =?us-ascii?Q?5lF7MO4Ye9VIf5DfRHYSakCZgfeaYW124V2scErpsac8tAFcHCzUWi65Dq+r?= =?us-ascii?Q?66kOqmVBWI/4aOAjnf3f+oH7eRw9KrAJ25ynQowlQAhUmTkiTnSq0iWVKXHN?= =?us-ascii?Q?21nY59T7c4lURV3YkwHS7J3q2ngmDW4ZQi7pW6xuyXtV5uMzBFpG6Zbu73iS?= =?us-ascii?Q?mQhl9DVG8WTvEaW2O7hG3ecp2raQhtK0YmnzO3FBy3Q6zRYYZYCTjg9yXbql?= =?us-ascii?Q?J0e2W3MS1Go/Co6AnQVcY7AHkKMtLqgpP5WrvBdHlpJ4e9qkl1XA4qFkyYgD?= =?us-ascii?Q?g8zacl42QGXlZgih7w47IBZF9A1WazOzcBkMSChV54NJQ7hChVSBU5Km6C/H?= =?us-ascii?Q?Ku1xIXvvmN0G2wUmr9t/VNmgD3kNbuZ6mX2STH9Nde0NUaOmA89RdFBCXfoY?= =?us-ascii?Q?NmTMZPSFEmDvEfilZaMDjFF+P7fofScguq0N0RgbqPdsxc8QY74cTELUPdUa?= =?us-ascii?Q?tCfAkKnmbtPvnUkoGbGqlHD4rhe2670wxIPNMImRcChMFCYBgiky3+XoBEuT?= =?us-ascii?Q?Zv8Y0/QeIYN1fGrv1UYUJhBZ09btcJToeskgN9Y2IFAQyk5ox9mRmBTxKrFN?= =?us-ascii?Q?aK+nX0kJx3rTg1EsBCJ9YdFMlIUlnqcPrR90Esh2E/dSISjDOrfCO2h6b6d4?= =?us-ascii?Q?98q7tIgmfr90AToJmW6Ib7XX+0lYiPL0YxSCE3lr8MQkKzOqSH8U0wt+QNHv?= =?us-ascii?Q?CM0v4g6fkIIGbLhd1Spoc6k6EC3VLelUHHy94lMws1yjNl3I3oKrjEtfrblP?= =?us-ascii?Q?TcQblDUF22R1lUDgGeaCmrJzWHIcYFdIHBThn2lF663KnJ8AOrWN7mpgVgrS?= =?us-ascii?Q?Kht2agmFnlf/xh8aHMtbnpjS5T6VcCkuLLGcQDAGhw6mWOBAlUcPxutg2Foj?= =?us-ascii?Q?VaHwJVyBgU9fBTga3iZnkKrGFDeqt6L0cuf+VyZl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73e42ed2-66ac-404a-4421-08dc0fe0de89 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 00:29:25.9957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tAKvy92rfGwzuSGu4tde9fxk4OInuDPP4vzZr+m/BBOlnHMuGrCGSunCdc3+YmkKhdababusp2U+2yWzJ7Ciew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8480 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sIk1kt48bnVgHUkxWGoB8Yw6x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FZaLPa1b; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Yuwei Chen > -----Original Message----- > From: S, Ashraf Ali > Sent: Monday, December 25, 2023 11:28 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Chen, Christine > ; Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chan, > Amy ; Chaganty, Rangasai V > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId > from allskuset >=20 > Currently when the platform has many SKUs then allskuset will be having s= o > many duplicate. and while parsing the allskuset will take longer time whi= le > assing Pcd.SkuInfoList. > This patch is to eliminate those duplicate entires to reduce the build ti= me >=20 > Cc: Yuwei Chen > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Amy Chan > Cc: Sai Chaganty > Signed-off-by: Ashraf Ali S > --- > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > index 592d4824a4..dac81454a9 100644 > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > self._DynamicPcdList.extend(list(OtherPcdArray)) > self._DynamicPcdList.sort() > allskuset =3D [(SkuName, Sku.SkuId) for pcd in self._DynamicPcdL= ist for > (SkuName, Sku) in pcd.SkuInfoList.items()] > + # Remove duplicate sets in the list > + allskuset =3D list(set(allskuset)) > for pcd in self._DynamicPcdList: > if len(pcd.SkuInfoList) =3D=3D 1: > for (SkuName, SkuId) in allskuset: > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113334): https://edk2.groups.io/g/devel/message/113334 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-