From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.25474.1649646895318002247 for ; Sun, 10 Apr 2022 20:14:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FYOO6H2a; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: yuwei.chen@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649646895; x=1681182895; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FEhn2JTfzJrXLIPdrPPxsiqjnFojQVze0sE5Il36q0A=; b=FYOO6H2a+tuEY1fb6qyxwKiqi/gJ352dSp5h7aF7cObXLfNlFGkDHtRO bSLFXdrycRLxV+gQ8fkIIZRzzrsZYf0n4XvNYiGN5qoZNgfWdz2Y00XvM c8SYsItgquZ281AmenvqV9R3DUjGyO25XOAuX1oP78QJ31H6fq9c+20ZF 27WLr+pp8sIZi7GMEnkhOdaYUHcU7H/SOApQbpe/UANmZ+WBEJdezj3OK aYjQlICrwQR9CHUG6357k1WzpN7XqDXpJ4WoF99qdZu+ty15czo6Vg7FE MGwbHfuQc9pjtHJ06fWwr4BwW/KXpAFj/T8jAH9vmHxwXtZwOFsiLVnmO g==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="243906207" X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="243906207" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2022 20:14:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="550941982" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 10 Apr 2022 20:14:54 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 10 Apr 2022 20:14:53 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 10 Apr 2022 20:14:53 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 10 Apr 2022 20:14:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCxHirhMtDuFN55obdHVSN5cZylz37wnaBAycsox8m/bODByGd5TjwqsskcmKGMcGGtsxEROb1LnEIJRptEhHgNtddrA/QMV62K0w+sC7VtkEf4oimMOJfjc2x7SGinChUtp8t0NfQaAodL5hq+2zi7l+GZ9KyRTzhgfjXmruTlJcfwpbVywGKuHXRL3gxm+6mZuQF0FVHLJ/uaxUpEf3ylt6t5GxxA7VGYBVzKZspbZk9jYpn03rTYBzqtT4goje2savsPH8OogtpxWDVE8ufQKB2qB29ibGz/OgnAOryLzdfIQmNgFDqrnMUBIzulQ0/8J2PpbymVRN+e3MDkXQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MgMHmElreOK6AGrtH/wMUawuxYpcJ60mB/NGqbYQ09M=; b=XfROdvETRUgPG3DX23uxY1jeOqT1IFQbyVK92lmbkGnqhY9ZPL6k9YAuOyJliaj8RHfj5ZGm3geKPk1uE1MTZy4KRZW3aD1VRcw8cJwfFX5YNRFjqMyuEcKiIwdQvk/G1nR/oknliMab5A6tSwS8h3GqA7rAjEfMcpXTw2c/3v1LbWiz5+W7Iab0wekXuk5BnSRAOYwJAKBtGnAMj0e2IFZJWWseZQTl75MNSdq0UhfDmj2zvh7E/bY+WD6HpFpwVzPDhm+fuwC16VNjbesdb8somRlhhxdJMEWQv+4Qg5ps6FPtPaTnBNaRv9+fGwDAHwt7zRHmD+FbqwC+loa6rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by MN2PR11MB3823.namprd11.prod.outlook.com (2603:10b6:208:f9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 03:14:46 +0000 Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::75e1:bb26:1040:90d1]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::75e1:bb26:1040:90d1%6]) with mapi id 15.20.5144.028; Mon, 11 Apr 2022 03:14:46 +0000 From: "Yuwei Chen" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: Rebecca Cran , Gerd Hoffmann , "Gao, Liming" Subject: Re: [Patch V2] BaseTools: Fix DevicePath tool build failure issue Thread-Topic: [Patch V2] BaseTools: Fix DevicePath tool build failure issue Thread-Index: AQHYR9absPw33HJUv0WoARAYLAvtKazqFIgg Date: Mon, 11 Apr 2022 03:14:46 +0000 Message-ID: References: <20220404034621.167-1-bob.c.feng@intel.com> In-Reply-To: <20220404034621.167-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69b71b7a-221f-42d8-a94b-08da1b696e62 x-ms-traffictypediagnostic: MN2PR11MB3823:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qh4lZMqrgXLvERMbw5ocmB4og5Z/m1GPpwsXvuhC9c7niklG7JMoEWImsFpELe3AKgCxRqshoWQxkhtB7Cq3eB6DFptkUJ7Gl/rp9I2cm7133OtaeDGoIk0fFapcSsQuGvz+4SERFKaSstSIKNGeRFaoLb8IVM+dIZwZRnZjJqxJKJeUckeaZNSQQO4ognk+qYpXuym5WC4/tpgHT843DP6MHAitJKtUbmWhuHCjqSKvVkLrMEPt0OBlNbpz4WP5Stvs3TEGhJq/0FmtA2iaEfiRWctvmP6AiBoom+twXr27Mn/GJKAkYMoMieMrwPdk+yqrvuS8+4MovDXSvIVUQIzsZ4HEC3kIMhUbp7+csHZg+C/zhnCpKhFJBdxarEtYkPhQL/iLbOX02ESwibb9dQ7ttS5EFX1ddSBEu2t4bz+4N2p7GONlDwYZJ3DXbLuUy4X7yDrddHrXhPwbhAozcLbnChHwETmuB/ItZdJ0vXhhCLfkL7mmoa6tpeBMAJZuhd+Kn7g2zzjJS6xoRRIw5WnRb5i1dyKEwMt0RcvfUhy/hbudjZgg2DF/zjmo0CBoi1WfVUBnIFeIkiPjUyS9/owNu46TtUbzPGnjZmbhOgoZOFaFbEI8+/dFCmFOWoaUYMNeCxlKrJrYzRVU7bj/mZjmHg4/Icc0Midw97n+isnh6E43aIxFpDVCAGFJvobOjWmlz1WaZuk3oZKZnGc+fw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5906.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(82960400001)(110136005)(122000001)(55016003)(38070700005)(83380400001)(316002)(66556008)(52536014)(53546011)(66446008)(76116006)(64756008)(71200400001)(6506007)(7696005)(66946007)(66476007)(5660300002)(33656002)(186003)(2906002)(38100700002)(8676002)(26005)(86362001)(4326008)(9686003)(508600001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yshaytMXP8Vj16XEXduXHoA0a9EzxmtkVNrIWRCzPzpdUne8wWDFiSSPJA47?= =?us-ascii?Q?CoSMGXeBjnVscSlkBnILrQ9oYgN6ox3pvMbDeLCc23y8DJEaB4V2Ri2N8scv?= =?us-ascii?Q?fkI93+2V+M+OOiHsl0LVDScGYlh/Bsm4c7TGycwaRhU+9s7pRSaCiAlM5r/d?= =?us-ascii?Q?CBzhxvYymi+aeTISt4CFwhDjj3dqe86ZM0ANf3QdQtJ96O/oqQ+3b22Lu1sQ?= =?us-ascii?Q?ZUc1/mZl/599osns8yjnoVo31RowPzJRhuGx7qBsAu3gbDJes49TqlNV3ivP?= =?us-ascii?Q?ZUvxWbRMdgBNJkrD9k8rhRS/p0qsYA29z8IfmDUu4xhdWuurTyDWEbUOiOh/?= =?us-ascii?Q?8vRtPHxXQH/PKvRGthtCqzSDhYtAnba6xccMeuj4b7sXBbJqWZr+5I+JRsMF?= =?us-ascii?Q?J2MoOrTpLAnHawQJAK/Lq0//WzM7vz7ovjyyvUApaJUBp/CPr9K0hREe+IyH?= =?us-ascii?Q?prVpIv+QVDQiTC1Mf1BTzbXO4TdO/44UaQkVcBUuGBb9An9FT3p49F9X+hDc?= =?us-ascii?Q?xdNsfb1dDaBKelLr6rpTPs3c4gUnW4bcamRCcBlRQO8jlNJtmjdHvFHsZnpD?= =?us-ascii?Q?tsM2LoXm8LoN1TYve3N8loWJa3UguhT9km8H+mx9XsjfqkJjpVeZRXsyYS1g?= =?us-ascii?Q?GqLMOIC1bzIzt9pv6NcszRQVG77ltD4vsGqouz5CHabjSZRSx0hMi87tZkJW?= =?us-ascii?Q?8m0zLez4GlXxYwH46X54xjJ68hWubpNlEKvfEGhMxWyjNG0Y00PCRkKYPxvP?= =?us-ascii?Q?jctv7FBP4p8Sr6KNM1UUwZ72F3Nn7OCwn3Lt8DzfGALYsPbPah3Tj8Zo2x//?= =?us-ascii?Q?7kLVe9ovqdcQMPR/OpypnWXJ34qChdGpqdzVyGRi2JMkgoo6O0B+OusNtZQ2?= =?us-ascii?Q?cIjcgjr2hJP3wSJ67XsPYD/mRsTjoRnTf2zHyZXelmCwP69HtMeok4lGo919?= =?us-ascii?Q?YuKHmEQiW7JJF1vnwSwIVXlCvOEgiHqsi+qaSMrYYAgoyEUr0SUku4W2LqKu?= =?us-ascii?Q?TvxUH8slYYK1h4IUCYGcYD4l6RrSNtTN1UFvxPqfrFz0/S3kazBbN/jArDhs?= =?us-ascii?Q?F7u+cdRrc5UPONeVCSWRndPTGXW/HaCqPvDmU4ATy53q6FYTSXs4dFlHT7Qq?= =?us-ascii?Q?EOCju8ChxO0i65FcLNKtBRcCXCPw4BH5iGCTJfSj6tP4G+uWIapFbVd8T92V?= =?us-ascii?Q?7y3j6P8kv1NgcOSq/JH31+7eke69U65GCiORu2wxRebYXa4iiaKme44F8yff?= =?us-ascii?Q?TVSel+QTBQJuIcAwIBT4Xx7px47QeKo4aWdq5IKaTN2oBL4lI62i0aSVTGfg?= =?us-ascii?Q?Rtx/hQMWtlrVSIuJ9iVzDyqONkZa5x+q9COr915rs1seUaR8Nw0VVz46xpLN?= =?us-ascii?Q?EDIf7FldD5YSvZga43SF4oJi+qq1tUv4MGXMIswIBE/DEnghwbYzIQL5OKHc?= =?us-ascii?Q?OMSbZYkNJylc3g3hsLpVlvux3KFYN4+sCibe26HCdK6m0aZsbLpMwHOZKy58?= =?us-ascii?Q?p4L7A4S1KlSdeVX4ts1fQZE2/t0Owh3NNIprN4Hdk7bFIKumxjBTBzH97Aiz?= =?us-ascii?Q?MDW3x596GFKIGWylXKedNXrTUD7xQd6o7Eqy+1CIYrMB3HzKvFFNNnbm2C2e?= =?us-ascii?Q?xHTCKFMqts14Ery3QaX4H7pQPf2LUABb/9BFLrVlDInqT6EhVJmBuObbfP+6?= =?us-ascii?Q?oTvQ5vSeQr2L9QHVo3IWun1/1+57IHSEqg61DxOL5Wh7QB/oZtza49a3POFi?= =?us-ascii?Q?wsFFEbPaVA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b71b7a-221f-42d8-a94b-08da1b696e62 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 03:14:46.3041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cQD2Z6aTEPft0vNdLCOsLDcHzV8z6VA2lvFykgRBfAHfcSDdJ4Q9f+5+Vu9olXI9g80cXDE+skRGJ0jGXI8ddQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3823 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch looks good to me.=20 Reviewed-by: Yuwei Chen > -----Original Message----- > From: Feng, Bob C > Sent: Monday, April 4, 2022 11:46 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Rebecca Cran > ; Chen, Christine ; Gerd > Hoffmann ; Gao, Liming > Subject: [Patch V2] BaseTools: Fix DevicePath tool build failure issue >=20 > From: "Feng, Bob C" >=20 > Fix the DevicePath tool build failure that was introduced by the fixes: > 22130dcd98b4 ("Basetools: turn off gcc12 warning"). > Failure cases are: > 1. clang 13.1.6 on macOS > 2. gcc5.4 >=20 > Reported-by: Rebecca Cran > Reported-by: Yuwei Chen > Signed-off-by: Gerd Hoffmann > Signed-off-by: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Rebecca Cran > ---V2 update the method to get gcc version > BaseTools/Source/C/DevicePath/GNUmakefile | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile > index b05d2bddfa..c217674345 100644 > --- a/BaseTools/Source/C/DevicePath/GNUmakefile > +++ b/BaseTools/Source/C/DevicePath/GNUmakefile > @@ -11,12 +11,17 @@ APPNAME =3D DevicePath > OBJECTS =3D DevicePath.o UefiDevicePathLib.o DevicePathFromText.o > DevicePathUtilities.o include $(MAKEROOT)/Makefiles/app.makefile > +GCCVERSION =3D $(shell gcc -dumpversion | awk -F'.' '{print $$1}')+ifneq > ("$(GCCVERSION)", "5")+ifneq ($(CXX), llvm) # gcc 12 trips over device pa= th > handling BUILD_CFLAGS +=3D -Wno-error=3Dstringop-overflow+endif+endif LI= BS > =3D -lCommon ifeq ($(CYGWIN), CYGWIN) LIBS +=3D -L/lib/e2fsprogs -luuid > endif-- > 2.29.1.windows.1