From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11796740039 for ; Fri, 15 Sep 2023 12:05:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=R2MzH0WrwoS7IMu1ZJX7yGulxgqDrHzB3wflP+WT6o4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694779544; v=1; b=eMUw/TP+4+RCfRYnNQVNOQdfa1+hvdtNWn/ketf/yKOfeYPZrH8prdMlnpovuzfY5RpMAYPM Nq6tFhxBvoUiA4QbcotwXng8+Fn/yZ58XnN8+nPXxoIuAOsEgFGeMlviIfGpa7urThmp4PhF7I+ 0cvziMKq0KINHHR551IUudY0= X-Received: by 127.0.0.2 with SMTP id nZsyYY7687511x9xUGem1FuU; Fri, 15 Sep 2023 05:05:44 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.18808.1694779543571815719 for ; Fri, 15 Sep 2023 05:05:43 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="358646396" X-IronPort-AV: E=Sophos;i="6.02,149,1688454000"; d="scan'208";a="358646396" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 05:05:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="721658486" X-IronPort-AV: E=Sophos;i="6.02,149,1688454000"; d="scan'208";a="721658486" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Sep 2023 05:05:41 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Fri, 15 Sep 2023 05:05:41 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Fri, 15 Sep 2023 05:05:41 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Fri, 15 Sep 2023 05:05:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HZ+CYea249npmwJLPdNBWfkFwZ+dJj41P4wyJ7cGA7cLzsQqqVqbXD30hqr1T6DQmHZ+lThRu47/j33H7JbG5RqEG8n7R2hho1HPPigaFHTU4pWip0Ezef4+6c9fGDNxwbWhB9ufTqTb0p6BHPOoA3AOUsQqabVMxt599AIMUAafmwAf8zk/58OBhtkP0n4Z+H2F8RAjlRIAHH59k9gGOO00BkIi4/Q6HIUcHXQdUAv6TCCaWjQRRfb3YIKwMqBP2HL68/7tVIBgdEVly2dZUfwFfZ1dFYMN39RALKTON/R6ekQUAhayiaug5t27YzWyFo8QLhNh3Z5D9oyCQOUimg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cxktPw0c8BTW7ve2IigLBzi4mzbMBtwfRJDgcAJGftg=; b=R7aUS/YHJUKeCJVPc6jp6Wh+AkMJ4Hz0U9C3nCUA4WNQXIn26U4FZ+mChu3GFcjZM9njCCaC6b6O6n4sYSsqhQJpLykKA8atCNMeWW6e7S5qXZBxwCf1Vmxbhp/I6EZNCLGCoTHAZCAETI4Abu5Zl69g2+wC5hFN5RIfEO9QTclICr1GhzmW+uVdzfFTV3hj+0DBLLS8knLW2r/VM3m38A+DMzynfEPweey5HOEF/+NQGus/YsAOqmXM39QwwA2LZwlzcH+fJyQ+UC51t8jBC0aQAxcl/xKlvAwqpPWt5jNrY5vghGWiMvhINdRwMw7kiQxBq3My3nF+yIC09NhFLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by SN7PR11MB6876.namprd11.prod.outlook.com (2603:10b6:806:2a7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Fri, 15 Sep 2023 12:05:38 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::73d9:ad83:d356:f316]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::73d9:ad83:d356:f316%3]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 12:05:38 +0000 From: "Yuwei Chen" To: "Srinivasan, ManickamX" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Gao, Liming" , "T V, Krishnamoorthy" Subject: Re: [edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Topic: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support Thread-Index: AQHZ5iL2z7SxO8u5okeS85FgVDASp7AbzXqA Date: Fri, 15 Sep 2023 12:05:38 +0000 Message-ID: References: <20230913085628.22913-1-manickamx.srinivasan@intel.com> In-Reply-To: <20230913085628.22913-1-manickamx.srinivasan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|SN7PR11MB6876:EE_ x-ms-office365-filtering-correlation-id: 4c8476ae-482a-4bd6-e1fd-08dbb5e4133e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 8d1MQBbYCjz2i8GgmA7D0eQnEauv+4jkidXiv0LB7OAGDCrrSEwo+sN+3/1Yjz+eygK7DiPr9uhrSngZsLibGWL429y+/YOQePp9/xB+ber0H/eE31mRJ7pSXtn/MXsN1TVwQhY1Czk/UJICq1fouY1YJozX3b+5tgCF2xuIQe/tw8/DD7/MdNCV8zz2F783tdeS1qtKUiR6xoVvr7lhh+eJa+U5G+Pjy9y9qBXNb4mHOphbMd8NXZbHbYKowR7UJabruVugKgKQ9T+1dLhbSnPnKehHFuatvkasqt3vAu2F+wC30XKT5QIMPYViY6a8SJsU7MwInQeQjq/lP8T6Iw/eRcGYGzuU2l6Ha3IBzJb4FeZ5E6DglmuwhXdMci28akqlfzRygrrimIu39AEmhCspv9zaOGtVkBn/+Gpm9uNjj21ZeP4tI1ufIGWpDLNpRoxyXkvWG8yQ/5nB+k68zENHFAwRxO6235orkJnLdx3pFkjO6J9qmJLutFsoViVGllggo83XHjIi9nDfl6F/+Ao5Zt2svzOa16BAs5GC3fwS8LdZzmrveX9IaLmf7qGUgcDpDZeOitlN5f2vtzi+BCCUnnReR9zUyy3C78W90bDC/8poToz/0g/AFpp0S4+V5IaCt8dtxkkLQm/3otc3kQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7D1yjUDENUoeG9DWIxK4jti5Pq1VPSS7tGv6UPanfhNct3sFw58Rt56eMwzy?= =?us-ascii?Q?Lojp/9ih/FSQrKPmmrWCOgDy2CcsKG4pCqf+lKsJHfiL19Xa1RkkQ+R08CxP?= =?us-ascii?Q?flV9tZ181nZCRmQcV/mh7zGdHkBBZtSwxZcmFSMrpV3nJlIAHuzQQSRH+QyY?= =?us-ascii?Q?w/0B04Zlm94mhgKmc93VJ5YSFqx39NEWQxKMKFUUpZvhnzMZGfHpvvHlpWI/?= =?us-ascii?Q?VPE4UMnd4nvdp3JZSylxcM2RJqrmYvGHhbjnmHGJFOmuLBmJxuVstmpgZJyC?= =?us-ascii?Q?IoQoVQ+1V3T5mquat5+hcCYOAa7nVlp1qGTtCm3ebVIB8JGL+jZAhtZmEdOf?= =?us-ascii?Q?iPHoReMehN2ggH1lydzVQ96tPpJTzL+r33N/yLXApoYi4kHO3haoDyt3fufL?= =?us-ascii?Q?ycPdnPrjxM2WcqL+eXhp8OpaX1BUnw9UOwhOONXqcrJ1Ni7j0/RBYyGFPTMu?= =?us-ascii?Q?/PLNg6My2EADNQMF2SFrmPJFfsMwdWZDs8c+P7R4CoA0z3iNkZe3FM+pv1SD?= =?us-ascii?Q?LTT+KIAGaMMMnMMIy79dJLvub5sR9Qf3mip8i7SF0luBVfVeNs9BlFKXSB5p?= =?us-ascii?Q?qVWOv+JyjHQzy8wF2HVKZRoLvdnR0dOXh0JPPOLdOIOO49AOVURM7DuwyWUh?= =?us-ascii?Q?SJ8g+MobhWbhr6UKSfXlQsOgBg36xvdEALwyrT5XDk1IZEr5qVzNSuvkwyA4?= =?us-ascii?Q?Plv1QgTCPkDh3ItKzWY/Fk7q48KK1pr6d0hOl1LOUF9KsigklUOichGxYyMR?= =?us-ascii?Q?sLrQYXp61AaBUZM08qp9HE9sE0j8UZWmmy2ZX+NQIe/MNYroJl6ePue9SQ4T?= =?us-ascii?Q?J9v/zKvx9YT6d4J1wHXLhfcNRF4d0FVH9Vz8PxjjufM11UKL1RE/ass9g/nz?= =?us-ascii?Q?uL4ry2SGdiBRHthGe5gai1eY8SUh9sUj/OVuWKeT6AVU29G45HSgZcSIpWIm?= =?us-ascii?Q?Qlq7wLmU5CMU3cgmrwyCPMKBwDEAqt3NNCq3R4ByDmKc97RDCMUWXAbtgMAt?= =?us-ascii?Q?zQ8Eu6dpoRzZtC494i/CukveFclRmAJlGCIpXIN57v9LqLzT2GLDIqWWXtla?= =?us-ascii?Q?j+ikXATqliI5QSmq9Nake+holryGesLlTDvOiabYdhd+mgq2I3xlFTM2kiU8?= =?us-ascii?Q?oQvPFXJ9RhgG4kcNQ5U1dGn1SCSc/+p30PN06BTpzHa2MlrQA8mzZR8Nfouv?= =?us-ascii?Q?+o3e4LoR8UiXGjSnDFiNF3a+o+pbswUmb8HXMgshygg9VxNWL8/OMt6RZEUw?= =?us-ascii?Q?tqQ6um+ACXp9ba8ewP4DQSWx5MqN41fJdc/gA/YagJmzbP27ASCKz2A3Ukz2?= =?us-ascii?Q?qv912cHt36ti981qxq8nMnHQRPKUHDDBIWTY3xLUqKflGes++Y6yqzig7lQz?= =?us-ascii?Q?3wO4Bqinf2DqEUBPnsFw/SnClXBUx0zGbsNJD0KE6g3ZX+9CcBy0AN7FYC+M?= =?us-ascii?Q?IuTqROqt4LiPqGIiJdtOKlRf0aIBpg5UCx2iBPHB4AL4Z/PotW7WX9A6NCpe?= =?us-ascii?Q?a99j+Bs1wCgG7BJAtUHzP+G/7mTd8UjnGTsAcoTeJFzwiC7BPE235A6cJl+3?= =?us-ascii?Q?BuYpb/b8CE5lzJK8NeOiL9NR41PwqOZDls6+FG8y?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c8476ae-482a-4bd6-e1fd-08dbb5e4133e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2023 12:05:38.2687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l095oofYPq5UY+/3KagE36RpfLbsL//2E6Y8AXZp21moTIYtlEs7NdJB+vOjjfMOwPwu63QqDHoFFTjSq7Uo7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6876 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AWYB18RIlZouGxCAEfRo15Lrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="eMUw/TP+"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Yuwei Chen > -----Original Message----- > From: Srinivasan, ManickamX > Sent: Wednesday, September 13, 2023 4:56 PM > To: devel@edk2.groups.io > Cc: Srinivasan, ManickamX ; Feng, Bob C > ; Gao, Liming ; Chen, > Christine ; T V, Krishnamoorthy > > Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE > support >=20 > The length of the Board ID is being updated based on the BOARD_ID string.= If > the PCH_TYPE is empty space/single quotes(''), removing the empty > space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT > and BUILD flag strings. >=20 > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: T V Krishnamoorthy > Signed-off-by: ManickamX Srinivasan > --- > Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > index fa3689867..54503fdfc 100644 > --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > @@ -141,14 +141,16 @@ def ParserInputFile(InputDict, NoTimestamp): > if Item not in _ConfigItem: > EdkLogger("GenBiosId", FORMAT_INVALID, > ExtraData=3D_ConfigItemInvalid % Item) > _ConfigItem[Item]['Value'] =3D InputDict[Item] > - if len(_ConfigItem[Item]['Value']) !=3D _ConfigItem[Item]['Lengt= h']: > + if ((len(_ConfigItem[Item]['Value']) !=3D > _ConfigItem[Item]['Length'])|(_ConfigItem["BOARD_ID"]['Value'][3:4] =3D= =3D " ")): > # The length of the Board ID is being updated based on the B= OARD_ID > string > #If the PCH_TYPE is empty space/single quotes(''), removing = the empty > space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT > and BUILD flag strings > if(_ConfigItem["BOARD_ID"]['Value'][3:5] =3D=3D "\'\'"): >=20 > _ConfigItem["BOARD_ID"]['Value']=3D_ConfigItem["BOARD_ID"]['Value'][0:3]+= _ > ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])] > - > _ConfigItem["BOARD_ID"]['Length']=3Dlen(_ConfigItem["BOARD_ID"]['Value']) > + elif (_ConfigItem["BOARD_ID"]['Value'][3:4] =3D=3D " "): > + > + _ConfigItem["BOARD_ID"]['Value']=3D_ConfigItem["BOARD_ID"]['Value'][0:3= ] > + +_ConfigItem["BOARD_ID"]['Value'][4:len(_ConfigItem["BOARD_ID"]['Value > + '])] > else: > EdkLogger("GenBiosId", FORMAT_INVALID, > ExtraData=3D_ConfigLenInvalid % Item) > + > + _ConfigItem["BOARD_ID"]['Length']=3Dlen(_ConfigItem["BOARD_ID"]['Value'= ] > + ) > for Item in _ConfigItem: > if not _ConfigItem[Item]['Value']: > EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, > ExtraData=3D"Item %s is missing" % Item) > -- > 2.30.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108713): https://edk2.groups.io/g/devel/message/108713 Mute This Topic: https://groups.io/mt/101333312/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-