From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4A27494079E for ; Wed, 29 Nov 2023 00:23:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AlFTon6dAhRYNLGJRVzOHU3JLb94P8/RMs9o+rmZNQA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701217403; v=1; b=q98rFiRima/Sp0tagBHME3lWCmKhXaWzNX5vKvqSTfwko5tIXpfua8NxhOWAneiSoEemiQf+ 0f8Bc2XNMVXTwkq7skhwHfqX2OqYc6AoOa5LBer8QNJEkF01xV3MxieX8MnUrXsqnz+MJMS00pt R5KP9kDE4Jdag9t2OrFravU8= X-Received: by 127.0.0.2 with SMTP id ghMEYY7687511xELlP1s4IBV; Tue, 28 Nov 2023 16:23:23 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.15457.1701217402623283508 for ; Tue, 28 Nov 2023 16:23:23 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="383451506" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="383451506" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 16:23:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="859608996" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="859608996" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Nov 2023 16:23:20 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 28 Nov 2023 16:23:19 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 28 Nov 2023 16:23:19 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 28 Nov 2023 16:23:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RpFNlhC2l+R3fGCY+at7ZvJbsiwq6uHgn1H+OuRkDEdOJ7au+Y5eTqagO2AfABmcOeVFUHkcF0YdM5EFX1hKOGTn5AJux5CfMkwK75010oxVZlOiYfWqAWF5oIufIX8A2ocBCQxZio3prDT8ee9GhTHA9/V/VQSJ64/C9ZgzvymNTnd5qkqYDwuMykFJa59t9MjdZb1ga6TzGczHGAreOA1dwyerzYl2A+7Mt/ri4xEmhccHGjvoj1WN74wp8dYNqlIDUF50ggVZpSxVrAZqVXX61a/mx1zHldVEvHsfoOCBPaiCv8KGzvq0/jUZ+2DNbGxx82k0X4tHht6JPK+oJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/JNogC0inZyaWghoEdRCutu/Qa/IUzRINV97D00sQY=; b=B5//1WehNFMwO+liUvBHK9i2Z2z43JpjddmPV+Q+7CKSzQYfwmtaQnPSw8GD8yIaNS1y3mQr93blUJaQ6PdviG6u21GNhB3LlWbnDobUITr1XGzpdl5SNSOzGT+nTPm08W2V4LlgQCCXZSTc19VJlPqDR+ifqro27seqkdwu9YgfDsEYN4D8S3BU/dBoo+ewSqovAFJTjh2MVuhtLWxdCpEjIqbhl8rSk4UpcztwB6TMFQ7zYvzX9+1iyxYqKIVaQn34dmozVna4QttfMB98MzsHRpfjQkk7yRSPHD7EsCzSvFW6R/BvxNKR6A8CZzcuQlPOu7BFPW4N4eE8p0S18g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by IA0PR11MB8302.namprd11.prod.outlook.com (2603:10b6:208:482::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Wed, 29 Nov 2023 00:23:16 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::5cfe:c156:aa65:75e]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::5cfe:c156:aa65:75e%3]) with mapi id 15.20.7025.022; Wed, 29 Nov 2023 00:23:16 +0000 From: "Yuwei Chen" To: Pierre Gondois , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , "Sami Mujawar" , "YeoReum.Yun@arm.com" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id Thread-Topic: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id Thread-Index: AQHaHUX6R90cOPpYI06lsg1OvlL1C7CQeZow Date: Wed, 29 Nov 2023 00:23:16 +0000 Message-ID: References: <20231122131444.1885823-1-pierre.gondois@arm.com> In-Reply-To: <20231122131444.1885823-1-pierre.gondois@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|IA0PR11MB8302:EE_ x-ms-office365-filtering-correlation-id: cd458558-99d3-4327-d281-08dbf07161ef x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pa08D7SI89e08NiE1hHFYpW2UgGia2vFNjF8fIw0djvKJChYbQvGn6EtHDo/Yl68rnF79tQJl405Z8zniTOoypPDgZd1pYs7d2oJEEoJjd15PBiwVF2pvYSsmTHwk1nOck9D9+2TYJAIOHoAx/33RUrCeKCCJwLRH7+kd7Doi0tAH37ezk0AG2EmIRe2gggNSRfT6MzTlEq8EcF/cW1N9SJpcs7FnYc+AqsTGJjMiiCZSpOV8/1VTPp3i7AS7PqHQCG4Unzp3Q1y6wzr3cap3TiSopED6YnM6FhtiXE2TG1EuFj1kKNGcAeQZhmzXqOlRMIO6841gL6UglEG7b5Qm38sC4w3c33ulMPdEa+Z7xtFhN48bO5EeVwTEA7D8K4052nIJSPWZki7Rz1P2O8chSkCZm1ssXAmlj2WAOp5sp0sKws1U9S3NL1lIDzRPjYh02DFXISNOcuckwCFYUEkU1bJDzRHwaRP4LWPA277hHQjFsi3rkae7usJdrD/3mKlO7BwQxd5EqEDz8BlP3JXgjttXl+1jEvYS2JLD4YQ0K11RdaS1jtKDmPqJ+z9hia/nnQNHJgj8iaiIWxA7H3LEARQ5K4PmPyrktD0YdSgGZs= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S8UN+1U5d/ifkNrVB+vW9gL3+2uryD+dBacMp3SRr4Vdg1dNuAJLlLUNbAum?= =?us-ascii?Q?j1ynPbLnU/2VSGdV5OF/oXUBJvmjNHhiHuWWkjutPE+ogqgRIiI9khreOZoi?= =?us-ascii?Q?lBVy24RsXZslvZNr+S7IkYR2G9lF6boXNvr3XOOQYIwmWNUBZABfBuoXxLB9?= =?us-ascii?Q?ETgAKohgZeWO/7FXwDC5USlQ9JK5QCDrqeT00qjs8KEe+tZ2w96DTffxRxET?= =?us-ascii?Q?HhLmG8xIr9JBlOqw9R5LCKuKXT47BcTqD4y9QnNzqC9FOgnRYVAXV7TAMmZs?= =?us-ascii?Q?P7DRCVT2c6MRNAeru5wMXLMvz6h0uu90S+8HBIRURrAvFu+zcMT0dCG9fPsG?= =?us-ascii?Q?Z6ofLUMIPcenVobzAd2+XM0x0UKap2izRJw7F7jIkWJotX4HTGoC+C4R36et?= =?us-ascii?Q?NCLrFOY8DBQ7ZDCdSaaUk6fCJQHoOf4blGNjAEAxP5e2pk7af+L9MO/v4oSy?= =?us-ascii?Q?PNByjESn6ZNQ5/zslXj8b6tl/nGVvtOF0kRdfKZ3mB2fFoLSLZq9Opa56XPM?= =?us-ascii?Q?Qm8jFZ19II9eKtjtbZKYIbsmYb9MJ7Lahs+T5NfXsgP0AslETBB42ATBeITz?= =?us-ascii?Q?LJV3RUzD9EapNqPXQ+MFKSARa8ZBQvjZyYOBEy7bUoZSkjqfDMnf7DXQSxzp?= =?us-ascii?Q?Jph5knKTuu/JHelvtmzuNEHnl5AY01W0SMN51GQA1UsbJbDZ1cYquAEwlt5w?= =?us-ascii?Q?SAAx87Gde9/hMm/HT639xVkZFO8diQrHnhs1cZNCOKC/3D+7GGv/yBraRPlr?= =?us-ascii?Q?zI15yELOwBxDIOX+lUm/TWABAaUupRiVieagOTp6zQjuMrhjsMwhBy1btNxf?= =?us-ascii?Q?YUWcbgjpK6ZdTZGMpHQHMQHeZwck6Z2tcXbrsTZVp5JxCuMScvfYWis81yJw?= =?us-ascii?Q?7Ypt5nfr82d+FCaQU6xDwh7Pzqf7QztywUTzG8iUT3D6J9PDsAF55ILdTBFQ?= =?us-ascii?Q?m33SMr/YXfh4FKSQ4PZBIWcKIX0V/IQ1gLrRILdVeFODsr1u9mpJHOezAsO6?= =?us-ascii?Q?vkWST4rRQUon6kptglAS/mhBb8cnGrGCYis5aVj7XN7N8JlFnOybMflhbIeK?= =?us-ascii?Q?3akP4LfTaY43LgkpzC5ZF7EsIrLz6d891j2bVpZJ+9Tj6YUvgUk44asCgDz+?= =?us-ascii?Q?yptvpXQ+vIQ7Dg9FSzYO+4HlDkStkZdjf95BDe0PcgTtV+acO66WpU1pIrsH?= =?us-ascii?Q?ZGPmk4HZmmwQncB9E+Vma2/ydPQIdd+cZoHliWzrCoTjrbjsYI8ChyDWwGBU?= =?us-ascii?Q?/nRtbruTCDeWVEj3mA7hU4llaylMWiKtVDVmUB5TMtO0I882XconlXkND+FS?= =?us-ascii?Q?AjcoH8jWlg7AK8gS1oNAGHZ933crZSP3kegj8BJ9mZu1ubPR6cMkzPnbGSk1?= =?us-ascii?Q?cAK4YuaYokHOGNXXNFTOlW521Ld2vTAoJJ1pnXbSGcMI58XT/PQOPkaRy8Ww?= =?us-ascii?Q?djZWCWyP7lVpxZFziThnq6cEIcPHF4Q7k6RGyun31dvhU1uvBEs3GeJDZ4A4?= =?us-ascii?Q?Pq3wwa73n1+AWUThMF0pCuZfIaPfeqGfyh/159kxtk/K7/33gqKcGdR7abgM?= =?us-ascii?Q?ZZkLRN1OadsexyKqU7It56+6DkAo9TYxBvUiBvYB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd458558-99d3-4327-d281-08dbf07161ef X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2023 00:23:16.7754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QG3EH4YSXnrnd2MQR4bCA0J2PXdqg+pbD0FZVdCWlRKoMXs/P+ezXpjdhhp3NCatre+JT9ysWkdHYlDxAVt8sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8302 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4KGns0At2S30bgzXwfx2KZwOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=q98rFiRi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io The patch is good for me. Reviewed-by: Yuwei Chen > -----Original Message----- > From: Pierre Gondois > Sent: Wednesday, November 22, 2023 9:15 PM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chen, > Christine ; Sami Mujawar > ; YeoReum.Yun@arm.com > Subject: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id >=20 > Code review tools like gerrit might use a 'Change-id' tag to track the ev= olution > of patches. This tag should be removed before submitting a patch to the > mailing-list. > It has been observed that contributors sometimes forget to remove this ta= g. > Add a check in PatchCheck.py to automate this. >=20 > Also add a '--ignore-change-id' command line parameter to ignore the abov= e > check. >=20 > Signed-off-by: Pierre Gondois > --- > BaseTools/Scripts/PatchCheck.py | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 7f372d40b570..7770d1e37318 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -3,7 +3,7 @@ > # # Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.<= BR> # > Copyright (C) 2020, Red Hat, Inc.
-# Copyright (c) 2020, ARM Ltd. All= rights > reserved.
+# Copyright (c) 2020 - 2023, Arm Limited. All rights > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -26,6 > +26,9 @@ class Verbose: > SILENT, ONELINE, NORMAL =3D range(3) level =3D NORMAL +class > PatchCheckConf:+ ignore_change_id =3D False+ class EmailAddressCheck: > """Checks an email address.""" @@ -111,6 +114,8 @@ class > CommitMessageCheck: > self.check_signed_off_by() self.check_misc_signa= tures() > self.check_overall_format()+ if not PatchCheckConf.ignore_chan= ge_id:+ > self.check_change_id_format() self.report_message_result() u= rl =3D > 'https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > Format'@@ -307,6 +312,12 @@ class CommitMessageCheck: > break last_sig_line =3D line.strip() + de= f > check_change_id_format(self):+ cid=3D'Change-Id:'+ if > self.msg.find(cid) !=3D -1:+ self.error('\"%s\" found in commi= t message:' % > cid)+ return+ (START, PRE_PATCH, PATCH) =3D range(3) class > GitDiffCheck:@@ -780,11 +791,16 @@ class PatchCheckApp: > group.add_argument("--silent", action= =3D"store_true", > help=3D"Print nothing")+ group.add_argument("--ignore-change-id",+ > action=3D"store_true",+ help=3D"Ignore the pres= ence of 'Change- > id:' tags in commit message") self.args =3D parser.parse_args() = if > self.args.oneline: Verbose.level =3D Verbose.ONELINE = if > self.args.silent: Verbose.level =3D Verbose.SILENT+ if > self.args.ignore_change_id:+ PatchCheckConf.ignore_change_id = =3D True > if __name__ =3D=3D "__main__": sys.exit(PatchCheckApp().retval)-- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111830): https://edk2.groups.io/g/devel/message/111830 Mute This Topic: https://groups.io/mt/102748141/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-