From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1E33C7803CC for ; Mon, 11 Mar 2024 07:52:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Vjg3/IwH38lC/nFN9t4pJ0XPqYx8blYQEeDrKK2/+QI=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710143521; v=1; b=C4Ime3heBSoiadsRnRMkCus1bHPXoRI1zIUKMK1/NKLRAzVPeIpPwYwR+6g5C9JQ0P6aDh+M FvmxdJBYEs6C7vQ7vQ0beRXKgVA/Qh20zGeIpTDTOyCEqt47pwQfGTuQCBVa0XLMvt1/h1V+9ev UEm7qCT30OPPGKL8sGoA4dtk8RbeofO7F8+23tv9uU/jjXryzws2/4+KE2LfKVy3bhg6y9wHIN2 Vgavnp6o4cpW3vsnTGNHo9PZZRZS3xJcoeV5ls0q6dnM89rl553+bmNUBMZQEE2bgTXIhoUGelI R3poFCNlXTpXD9ZR2xXaIXIN+VvjS/oSDb4Ct+Yamh2Lw== X-Received: by 127.0.0.2 with SMTP id bPHgYY7687511xhRc5DY0kBy; Mon, 11 Mar 2024 00:52:01 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web11.57260.1710143520435669794 for ; Mon, 11 Mar 2024 00:52:00 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11009"; a="4650430" X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="4650430" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 00:51:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,116,1708416000"; d="scan'208";a="11168874" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Mar 2024 00:51:59 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 00:51:59 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Mar 2024 00:51:59 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Mar 2024 00:51:58 -0700 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by SJ2PR11MB8514.namprd11.prod.outlook.com (2603:10b6:a03:56b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.16; Mon, 11 Mar 2024 07:51:56 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::1903:9756:14f5:ed08]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::1903:9756:14f5:ed08%5]) with mapi id 15.20.7386.013; Mon, 11 Mar 2024 07:51:56 +0000 From: "Yuwei Chen" To: "S, Ashraf Ali" , "devel@edk2.groups.io" CC: Rebecca Cran , Liming Gao , "Feng, Bob C" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Thread-Topic: [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Thread-Index: AQHaaiylJ/LSraCWmEKDsVu896c2kbEyPYRg Date: Mon, 11 Mar 2024 00:52:00 -0700 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|SJ2PR11MB8514:EE_ x-ms-office365-filtering-correlation-id: e99be979-1bf2-453b-fdb7-08dc41a02004 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: bC3tGeyWF75ETekJm4+m9mSjrxGG/f+HVN3XLMp+PdvgUac1bII5Mug3ReZehSklD8OKMtpFVrzkLWvgYzEXABApoOzlteGBig+hbTi3JyDfwWZ1WerG06Q6eE2ZTeItOd7YnwE+/I7ns8Vw7yPoSZLr9AF0o8O/VhFqQcw7t3+MYN/h9LiXjWcuTs2JNlMHmIOrTTX4fag1gxii6rBDArDuru7wjPA2g6C77y7ze8mzHkyx3x68f3tOjlyfd3+x36wiFFoYm6M18StZ7YRYgGnHPgHSWhYBNgX45Dlmiwli1cE6JZ0+ScPvslLwwN7ptdh8r3JPEwucZF+qK3mKsLu/58y1i9HRpSGUF8/5Bq/I5D/9dpSMAdHWW6o69l0vsGW9ckiMas+I00eNE5YY/xu963X49NDeB7f0EOXFFHqWeIDphhGeCuATwmRe8fupcZPsdH76pVsUSLKhYvQtQcB9o8KhhqmM97Jo75xIqTH/q7JR2WrjsS2ZjpDu/3C5o8wjA16fcAl/gXk1EcLPyQRi5Dq899f5Rto4on7ABISBQ2s9cHK5CMSHANsuik/P/SNqymO2/+nsRfq0ld0+eLVQ0wKDyTYABIf+jhZZ7AOhQxfTzktqr2q+9iooYW4AZb9/5FrDrSxDyKJTTkvh1snb/HS9/CGPEPRHITgH8lWYVWMaQvws9CucwLZWCcyFiPKEjvBngKxpK4NAaPnykw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?luMw0vhB2oorYaJ4tDsKBC1zeboO/Rhl7eDOySWah/+t5u8MhxvCrh+NnpnC?= =?us-ascii?Q?81aS6CTIcsiDKQiOf1AHaPzEHRm+Q1UWfHi3IMbq349lh7KsCM/tnbAG1U/Z?= =?us-ascii?Q?X+dvZdKDeA79qh6aTbTuw4ctzQmZHnZaJ7SQiqP7gOxzOlAAls+aeGAcoCt5?= =?us-ascii?Q?NVG9Xn4Revq+MIcLY8LPXRu2W0bZQ98yGimfQc5IFIpOz397z4ICXRfhmG+y?= =?us-ascii?Q?E3jCfFlMuV5XCTv59C+LUjtohIwN+8IpnVpQottHc0JwCiW1Mhn0T7N9rewT?= =?us-ascii?Q?M/NqMNWw9z6Je6q7Nn/JbiR+SY4/X2E2/dH8RMJvTU76iiUN4SWa8KwHp6bf?= =?us-ascii?Q?meXoBJcLncLXUi+GrxXfZdFiXeO3+RAHYOad2Xhq84HQ+5SINvQ8IIYhHwT7?= =?us-ascii?Q?byNxlrCcaj3O42W76S9/oHtQr/TdeVZPGcDgGmrgrt4dRzD5FtV9np+Gindt?= =?us-ascii?Q?juko9CAOY3bOfiKllp+R7Z48F27qqT6bUUCaT/K37Z4OQYCB4w4n3+9P3h0r?= =?us-ascii?Q?tyRoc1l4R7RAmpXdSYU21UHaOanMfqkl2faggApVbNPf+8iYPZCJKB7Ap7+T?= =?us-ascii?Q?EkFw+RQI2ZavV9eT2AEIJxR29vHshFftmp/YeRWzW/Kclly5UxYl3B8gHcMJ?= =?us-ascii?Q?BUZ38dq6js+udIxAkV8S3TnU6DxpHArSszK0FL+DNiHgOWax82m5Zv8NPsBn?= =?us-ascii?Q?slPpZbKFxHJG9TeDUuaQ7CPMSvFAKDNa1hxwWq4iT4YTUk/tsrP5SJ+268O3?= =?us-ascii?Q?UB/sPhobK3y3HqQ4o2cJwCjeeRiI0f12ChjcICiaE3lWF/2z8g5DrXCvrn72?= =?us-ascii?Q?BNjjOg6Q/lXHPdvnN9xPAuPJ8d5uoVCHvEW6vwteb5zxh9Hwv3eIAX01teID?= =?us-ascii?Q?ZpSCDM9IwYw8WssC0QF839TWCdT72OtzlCKNGAFQL0uGfHl64eAXTG+dNmjT?= =?us-ascii?Q?qCG186OJR43TYj2+HjaPb6sA9FviRjC1KqDnDrIdoz1AGX3P4sVL4q3d+8JP?= =?us-ascii?Q?0L56p46E0I6752FlfH1leV+yqafK1tVOJrPJFAJv4JEqpFMORvnA5cGPI9c+?= =?us-ascii?Q?dVw3UiOJSCF6AqQ6Doa7t7mExRn62CoDAcxR0pA7CKHPsg8z5tiuSXMT4qwp?= =?us-ascii?Q?9KqHV7o3zUTqzXcC5kLIcybUQW3ApuRgTkI0/nrUF5Jo0FW+2BNAfkvM0Zg6?= =?us-ascii?Q?08sw7zspPASBnepp5KaxJGuGFthnMKB+57UaV85rC1LS3cN7rx6jSVS7dDkN?= =?us-ascii?Q?DMMzfsBp6+N7cYQrWTzdSL0uX4jjmflivRtR3EYEgSjIYmafQFgeugUa9Pk2?= =?us-ascii?Q?aFKBXbfA+oPPnyKIQRUELA+m3UMHw6sQzqKFSMTWeSwDXTWlRcahz/bjzBiS?= =?us-ascii?Q?bPgXM9U2vLtcTMoYoaZ0jkbEDRhILw2JsF96vpyVyZpYgjptOK/WaZy91LMQ?= =?us-ascii?Q?Yqe751+Wi7221/mmQ6g9eMnMvmsSCAdm9ioOCt/+hHyKdQyMro6aPkMh+YkP?= =?us-ascii?Q?aWkLV8jadGQ5Ndt52klQetcR+iVReVJJz6CyOoF4YFQL5/iPGKTkk1h/8iTa?= =?us-ascii?Q?IwVy1k5vwNo2Fg3MeXYsXR6tE+rx2F+zM7yuRBsa?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e99be979-1bf2-453b-fdb7-08dc41a02004 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 07:51:56.7241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qqp6k/sUgqQaqUL10DheAYbu1gRge/zhniYs3/lOVKqUIygOrF0Fstmhq0oh7xZ705f8pi1PFogOLgn3znfyiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8514 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PB3MFJJuEC5yM6eczJI7rbtax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=C4Ime3he; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Ali, please also create PR in BaseTools repo. Reviewed-by: Yuwei Chen > -----Original Message----- > From: S, Ashraf Ali > Sent: Wednesday, February 28, 2024 5:57 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Rebecca Cran > ; Liming Gao ; Feng, Bob > C ; Chen, Christine ; > Chaganty, Rangasai V > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing > FMMTConfig.ini >=20 > When the FMMTConf.ini file has empty lines then it used to throw errors > GuidTool load error!, this patch is to skip checking for empty lines in t= he ini > file >=20 > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Chen Christine > Cc: Chaganty Rangasai V >=20 > Signed-off-by: Ashraf Ali > --- > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py > b/BaseTools/Source/Python/FMMT/core/GuidTools.py > index f6bdeffa50..f9cfd4ead0 100644 > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py > @@ -153,7 +153,7 @@ class GUIDTools: > config_data =3D fd.readlines() > for line in config_data: > try: > - if not line.startswith("#"): > + if not line.startswith("#") and line.strip(): > guid, short_name, command =3D line.split() > new_format_guid =3D > struct2stream(ModifyGuidFormat(guid.strip())) > self.tooldef[new_format_guid] =3D GUIDTool( > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116582): https://edk2.groups.io/g/devel/message/116582 Mute This Topic: https://groups.io/mt/104620514/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-