From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 848A4D8066D for ; Wed, 29 Nov 2023 01:10:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=B2jEWqbSyHa+3Y7NhnX5Y/H9n52A2Q8kWmAyaxpVa3w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701220251; v=1; b=bMzdzE84dYwdCOSXaKpFRqpVqnN4YymAt36znqYQxzMcvb7EK5NKDbRvMMW/2UstswrIxRsy qNgpSUgi7Ma7Ms5p0SSjlgiFgIEfnOhxMAy53JZ+igCPpXgvvdFRx2OCwzDxgXAJtJGihCm8Sxr x1pI3T+DjHpvdv/14jeGjkVk= X-Received: by 127.0.0.2 with SMTP id DvUnYY7687511x0pY2g1tyZB; Tue, 28 Nov 2023 17:10:51 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.16112.1701220250252300014 for ; Tue, 28 Nov 2023 17:10:50 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="378092305" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="378092305" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 17:10:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="912646750" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="912646750" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Nov 2023 17:10:49 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 28 Nov 2023 17:10:48 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 28 Nov 2023 17:10:48 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 28 Nov 2023 17:10:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZyACejaClhnKaVXuLAsNTaUC2y893iIeLedQtdgQ+hnXF0paz1M3ipbLUXNiDcTdbqXsxCVlJoxXXxOGCIEoRdKyJLgfjWFyf/tvuNMt/+y5Dh1oIummtKcMbg7ozhlCGP9vg4Xwg/RRv0HSdhMElKtd8z1XQrId4GMXNESb9ax4QyGIFuS1/UWLFplxmNrFG1hwiaksLL6WrDphZ7AHJQtV/akXS+h/6diqbosEix6yJL5dlMPktavn7fEsuaMt5ZwChnJsRq+uAJaS5FJM6avUAh1IeH+r8iDHmbUBHTN4A2fzdCx8ltCqWrD3HMGHoQb/k56lDV7HOkEO1aG0pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yzIyu7u+4b5Q8Hh2gwbDKpxSceugMSUfFyQrNsxKKuM=; b=Eg8TN943EXX83ukoghEVtcFUAU4y3nD/sSbJZCJvCmXZ29dcJwAIVB6q3KwRislWlcQONZKkmciZzRkUxZhCCL5LQOJKS+DngeroOKCoQurs7DeXWhpF0RxxJjUstRYquzSX40Tiiw5902JM5Mm/sbursveUdzfptewjFAlF6uv9NePdgwT9d1yqRuQJ5zveJ0xLXK4Fa7yAkuU32R63EyY6EcCvYAa7JhJw1c8mFqJD/094TR9Uafnn3CUCSyzC2Ouxka5aZiOl52fVA45qCofwqhcAHdKvsHm5vltJJTF999Xstl/sq0NWN7ZLB7MjbINvZwJMlyFADgy8W5Nx1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com (2603:10b6:303:1a0::21) by IA1PR11MB8199.namprd11.prod.outlook.com (2603:10b6:208:455::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Wed, 29 Nov 2023 01:10:46 +0000 X-Received: from MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::5cfe:c156:aa65:75e]) by MW5PR11MB5906.namprd11.prod.outlook.com ([fe80::5cfe:c156:aa65:75e%3]) with mapi id 15.20.7025.022; Wed, 29 Nov 2023 01:10:46 +0000 From: "Yuwei Chen" To: "Ni, Ray" , "devel@edk2.groups.io" , Pierre Gondois CC: Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , "Sami Mujawar" , "YeoReum.Yun@arm.com" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id Thread-Index: AQHaHUX6R90cOPpYI06lsg1OvlL1C7CQeZowgAAJiQCAAAO0gA== Date: Wed, 29 Nov 2023 01:10:46 +0000 Message-ID: References: <20231122131444.1885823-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5906:EE_|IA1PR11MB8199:EE_ x-ms-office365-filtering-correlation-id: 70264acf-7df6-4d38-e74d-08dbf078044c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mq1s+Y65wHkeFPicGKQxGiviG5jhNl4pFImmFrldE8s2FV6k+69KLDovu5Uhd2clhxNMtu3VAvXyW8QnDUXgaixbW2KIo1UKuZBJ9mlqRKuntyrlrHlq4c4FrDMjLw0icGCojJIaOqh/9tmX25E+dVmvNOoee44mI2Sb+NwYhpwTnursRXgJb6QG77eR1VIls72LQ08CMuI+NtJYgTKoo2kazTi4elV9ReJnHKd/LXX13Zvb6N8F6TV294gp0JNJ6l7nj9Dccfqej/SWoVT9E22U835+kaRmUpmd5boz/XqfHJ1V//C5UEhYzLKfIlv7E29HhfjaAgKyGYrEsg5cwpm7cIYoKGv7gZqYzRFwLi9tSXRqUNGRwHCY90Oo1qnI+OsFNv3AwgcFvV2v2cO+0ugKndCNKIpOVi5eCmt/bby0gFJjCmGnZ6mBeZ8eJXEnVeLBOj/i/KbX7rdcMY95MwoaTV9R3mia8jW0l+C63HVn07P0GjfZzDm91Lc112IE4309dzuc8d82ZFbYh063p8pGDjfXhQNIfdNi9TTnmPUU5F2vsh8JTGH+ejaXQ3ijqk9L7nb2MUeofbUc7gsBrJZl5cHV9ZoeE+wMg10TRdefNh91Mi4w1g8qTVycJkBbDIcyfEDXhK3kuO/pH2NZMg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?edeIsJPbmc0n5rDcl/g6SZXIX/bX7a51N2pCbaytG7wnM0EuIjmKprOj0hcS?= =?us-ascii?Q?FjWojMh5meSWsPLlf4NDeGlF0kapeb3+8DfOzE7YGtBEf1w6arGelCd3sG99?= =?us-ascii?Q?m3KfrFzbGZ79GFToSjT5+MNS9obQBhZxZS1iMUTsxc+muyp+qJGxBV8nWtol?= =?us-ascii?Q?yUr8RAwX7e1rFKS63uyCMeFkmye4FqVlTOyRk2OyzGyX/W4SymRgsyUaKSMs?= =?us-ascii?Q?TICPR4uQBLEPRVVmsARJno+tWGap0uJ6tar9oYoCCOQbYbS+PSZX8AhtK8LG?= =?us-ascii?Q?u3ZkDX4pPox/db1/mjnIWzl4ADxaX9p2KeWRvESorOUkLjx3QWzDbIyX7nsA?= =?us-ascii?Q?8BiUJ3nQan+FAgDFuod6mCZ+PDeLO4oVA4iKcXqedfyOqBOHdGHunScPhXuC?= =?us-ascii?Q?d2jV/gs0/PYoLJ+uFLUpYHk4ey7FM0jg6QTrFmTToDRzgGurClDoM+VuJ7VY?= =?us-ascii?Q?Vlh78QqKZxzJ2z6j/CO9iLC81o6qC0Ht0A9QWtLsDfYWVUEi/l6de2uNNJIZ?= =?us-ascii?Q?fb8RGWwa8azW94EK6qjN4aDooMSBx8GL+rBsuAQHUOT/DTF1T91slNeHm3/L?= =?us-ascii?Q?BC7e5VNNfaqdFFvc+0z0nbJqrUp1IM6vSYUOpAx+tz2jybUw6zCz3p0miZgF?= =?us-ascii?Q?k9fvHLVeiFoeCqKE0WyZfAxUR0SB9nSqGdO3pwkirtnMi2xl0xury+5e8pYn?= =?us-ascii?Q?tNfAdCkkDn+uPVU6UTjeVYNzDzpbrseU14Psh4tz82ps3KGG+0qaMt9Tj0xl?= =?us-ascii?Q?VhK3AE46IaFAUYXTLNdPHTBf/HCAlDZ0MomjXyFvV1GTlypbsGtMppYGvSAq?= =?us-ascii?Q?KJpvO5MGg4bINb2GrvvcDSWL0PgxpkskytCM1salrW7+GNs19jLlED4W8nMB?= =?us-ascii?Q?japBcIn6522BKYRey0lNqO/r7ebp+zgaLfrmF1qKsodl3dbOg+HZN4sPvSxR?= =?us-ascii?Q?HKzST/IdiRXl0YvBxx5zJwONEXluLwl0HeX36KV8xHyjEQRv3GXbMgqDRYQ3?= =?us-ascii?Q?S3eMhJ0la/uapNjOswApnhfxIhYvarEIqSd5D3hRiNH++Agfy9WUXwYWW9BG?= =?us-ascii?Q?xiQpc4L7I4gfThaJJw+SSQaymATaduPnwXQXMrMwL6ZsfzFeyOR2p5ZKrlwu?= =?us-ascii?Q?6JFe9JOpLqDlMDHihh9KRFsat/QP6FyohGPZIuRpWB+BN6xocF1RKpiMMpVx?= =?us-ascii?Q?wAsZnc9dJZuzOUKPMvylDdWFo0O/7Wpvf1oea22Yq25cHdMGJRa3EMJkZgPn?= =?us-ascii?Q?LlEBTqDMvOWs8yRgnboa2T820a+1+bVLXo7CytEogW06l4FSmeSBiJCRRPaY?= =?us-ascii?Q?cDUdOqDvTrWzCVTEsmYuJVgg3eevYSBIsDhAHtpvT2rwnEfwVS3a03pFtoyy?= =?us-ascii?Q?t1votaTP7ob+mdB0ZjDKRQH63igCbX8ruuSXBl4M5ZqNf1Basg1/Sps2yI5r?= =?us-ascii?Q?3ED5ZF63/pmbk7u+lLR4UkGiQqs05GHauAM4ra5N3mdskLDXfHPcuU6n9oYZ?= =?us-ascii?Q?r98up47E4aHO/EIMhjND969vL/MHh33gE5qCHdfY2ObDim3BVFGSQgKvD6HM?= =?us-ascii?Q?bQCdfF+/An/ujUAzDG+3wp61MUp8Wv1AYR7eCUbt?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5906.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70264acf-7df6-4d38-e74d-08dbf078044c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2023 01:10:46.1593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VI13IgOBkNXS8xd/xUVRBsteDyMir5GLP7U7YMkyBYRDibS2sJW7uxI4Nzp0DKe0xMLrOvoiEo6/+NlOJlGNvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8199 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuwei.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: woXG38zbiRGxvzfQZXbkigrKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bMzdzE84; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Ray do you mean set it as default checking? It is a good point. > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, November 29, 2023 8:56 AM > To: devel@edk2.groups.io; Chen, Christine ; Pierre > Gondois > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Sami > Mujawar ; YeoReum.Yun@arm.com > Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Ch= eck > for Change-id >=20 > It's good. But I am curious why --ignore-change-id is needed? >=20 > Thanks, > Ray > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Yuwei > > Chen > > Sent: Wednesday, November 29, 2023 8:23 AM > > To: Pierre Gondois ; devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Feng, Bob C ; Sami > > Mujawar ; YeoReum.Yun@arm.com > > Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: > > Check for Change-id > > > > The patch is good for me. > > > > Reviewed-by: Yuwei Chen > > > > > -----Original Message----- > > > From: Pierre Gondois > > > Sent: Wednesday, November 22, 2023 9:15 PM > > > To: devel@edk2.groups.io > > > Cc: Rebecca Cran ; Gao, Liming > > > ; Feng, Bob C ; > > > Chen, Christine ; Sami Mujawar > > > ; YeoReum.Yun@arm.com > > > Subject: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for > > > Change-id > > > > > > Code review tools like gerrit might use a 'Change-id' tag to track > > > the evolution of patches. This tag should be removed before > > > submitting a patch to the mailing-list. > > > It has been observed that contributors sometimes forget to remove thi= s > tag. > > > Add a check in PatchCheck.py to automate this. > > > > > > Also add a '--ignore-change-id' command line parameter to ignore the > > > above check. > > > > > > Signed-off-by: Pierre Gondois > > > --- > > > BaseTools/Scripts/PatchCheck.py | 18 +++++++++++++++++- > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/BaseTools/Scripts/PatchCheck.py > > > b/BaseTools/Scripts/PatchCheck.py index 7f372d40b570..7770d1e37318 > > > 100755 > > > --- a/BaseTools/Scripts/PatchCheck.py > > > +++ b/BaseTools/Scripts/PatchCheck.py > > > @@ -3,7 +3,7 @@ > > > # # Copyright (c) 2015 - 2021, Intel Corporation. All rights > > > reserved.
# Copyright (C) 2020, Red Hat, Inc.
-# Copyright > > > (c) 2020, ARM Ltd. All > > rights > > > reserved.
+# Copyright (c) 2020 - 2023, Arm Limited. All rights > > > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ > > > -26,6 > > > +26,9 @@ class Verbose: > > > SILENT, ONELINE, NORMAL =3D range(3) level =3D NORMAL +class > > > PatchCheckConf:+ ignore_change_id =3D False+ class EmailAddressChe= ck: > > > """Checks an email address.""" @@ -111,6 +114,8 @@ class > > > CommitMessageCheck: > > > self.check_signed_off_by() self.check_misc_s= ignatures() > > > self.check_overall_format()+ if not > PatchCheckConf.ignore_change_id:+ > > > self.check_change_id_format() self.report_message_result() = url =3D > > > 'https://github.com/tianocore/tianocore.github.io/wiki/Commit-Messag > > > e- Format'@@ -307,6 +312,12 @@ class CommitMessageCheck: > > > break last_sig_line =3D line.strip() + = def > > > check_change_id_format(self):+ cid=3D'Change-Id:'+ if > > > self.msg.find(cid) !=3D -1:+ self.error('\"%s\" found in c= ommit > > message:' % > > > cid)+ return+ (START, PRE_PATCH, PATCH) =3D range(3) clas= s > > > GitDiffCheck:@@ -780,11 +791,16 @@ class PatchCheckApp: > > > group.add_argument("--silent", ac= tion=3D"store_true", > > > help=3D"Print nothing")+ group.add_argument("--ignore-change-i= d",+ > > > action=3D"store_true",+ help=3D"Ignore the = presence of > 'Change- > > > id:' tags in commit message") self.args =3D parser.parse_args= () if > > > self.args.oneline: Verbose.level =3D Verbose.ONELINE = if > > > self.args.silent: Verbose.level =3D Verbose.SILENT+ = if > > > self.args.ignore_change_id:+ PatchCheckConf.ignore_change_= id =3D > True > > > if __name__ =3D=3D "__main__": sys.exit(PatchCheckApp().retval)-- > > > 2.25.1 > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111833): https://edk2.groups.io/g/devel/message/111833 Mute This Topic: https://groups.io/mt/102748141/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-