From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.1662.1663004624112796325 for ; Mon, 12 Sep 2022 10:43:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XlMHhUE/; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663004624; x=1694540624; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lyCs/j6kLTMlB3jSM/QGg5rp8Zbx73fThcKF21lFTm8=; b=XlMHhUE/zXCF4MFbD5q6bQGeMUu6AJHDSZHcmU20tzUNQjKz85YlPpXp Hnit7E+NexgdSQvKoka8m8ORab4wojiv9ukYD7bOR3cyHik35KS/YpHC6 ObwNpearfBWS/mBCK5MRDSyJOlx7Kur97SvjK14oKRi0oQZrTuvIoOzE0 wM1bPrK2QtS/gDVUu+GuaPRGio80BaPm3s3GfOEGo6OEFwUqPXzaWNz0Z TSNtp+ruesRQKNlch74uT+eMcmJDcgUsk6pjMy2bwhfHbcmwjob5yfixR vQyrgHy4XKRLyzwZdfTQS41xj8SLbV7iUw+zI8RXePhOkv0wBkfEmjpJa A==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="324166452" X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="324166452" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 10:43:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="684523741" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 12 Sep 2022 10:43:43 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 10:43:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 12 Sep 2022 10:43:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 12 Sep 2022 10:43:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhauQt5J59lLp+MGf7SwaClnVx6zaHb+0TBlWPUgjEGK0ZNcAcds3y5ZDMfPBohRAsSB2ifK9JOOGzqW+tduQ52XyldyCmw4g5ZzPsxwnyE6OX7pcJeqB9qjZHkbuVM8ZiI5lQ4+fZeLvQWOGIsnCVMAv76SXveFIRw9pe3vDc/peEfiC8ZMuyG/PGKimHo+IDZYsY05Gjrfk6wfTyF32iqufQaDk8Hwg4d+w5T4z/O0iwNtnx7uzAnz32dwUX9QzdhhY8sEvgA1T0GNyTOd2TODiUs+IuEjNgK1Hu4Mack2toMVRres8K3y2RVJcfVjjAXKBNgJGYcY+i/VScKTFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gEibb3rrenwGW36lQ2zbIL9uM5P2YR4aZ0QpJHnr2Bk=; b=DhhL0tNxf3B6Qvigt1ytFU/LLYZQ5deaelrzo3pNVM5asfU10afJ+UReRz+S78NO8t4IZRiGFPuLHheWJFCN86Bxm83fMt5CZk72uAoGir5gXQMKnzt1zmJfb+8hg+dDAUQxuzbZmnRXN1i3+3SgkeMb0t3P9fLYp4DRpOClWU+FL7rGBpcZOTLiZaZQuBEv00buQBDOa9xXDCfLXh0peiZrZfqovagRoMi0G6pMkZz2+IB8GuI0Ip2dqicE584phVSkqwy8Zo6lEOQETwrB7lZrgPhPSYA2/4p7n4/eUgCJawvLYaAsW3dKpbK7OC8m7Pj+r6/M7ajk1/h04bTGRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SJ0PR11MB5183.namprd11.prod.outlook.com (2603:10b6:a03:2d9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.19; Mon, 12 Sep 2022 17:43:39 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::6c6b:8816:2b3:dad6]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::6c6b:8816:2b3:dad6%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 17:43:39 +0000 From: "Ankit Sinha" To: "devel@edk2.groups.io" , "imammedo@redhat.com" , "Chen, Aryeh" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Topic: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Index: AQHYxmcFd3upObUbMkKPrgjB8RZwra3bd50AgACWYVA= Date: Mon, 12 Sep 2022 17:43:39 +0000 Message-ID: References: <20220912051745.1539-1-aryeh.chen@intel.com> <20220912103236.7eff2e35@redhat.com> In-Reply-To: <20220912103236.7eff2e35@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SJ0PR11MB5183:EE_ x-ms-office365-filtering-correlation-id: 1ce93ecf-983c-4783-d5f8-08da94e653e1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sn5uUpLFip0QZ2dEMG9iXajvEPuSI4jbb3J5m1nch1kGbPWhdDxsUXhk+2BwKE+PWkTBX9vIsl1erR6EQggUTt8TvrA99FVjAZw0v5kTZ6b3emXl/HWRSuzznCLigH+X9oIHsiVP6viKcX8RrwKZyvgIUmpsnci8ETCdgUPzkqwTV+c8dlnTcGJSKDR5jfscJyfBqluJ7teRxGClHyPuNy5MGBhuWQEbzpNatWuxdTuQ+9En8JGCjkTTcAU2E3WXEJINWncwGYnNoaTQSvpkSMjMm3zU2g53OsXtYRMi0t7WdmD4Ilnt/T2rry5u6I/JPqQ9xCXl4wufgFCXN1TVuomzdIgKPNrFU64CIko/v5vknVwaWc5fVBLXhtsWNtVqj1Hdrs5wzBQa57t6QYsAtfCLF2NDwJW4fRHoUPVFpk/4dCWSuPlzv2DLw7bp8Q87ceIBghj9telf3NiNHGsdfSudI9T++c6RYFxAGIjEucJm8GLfEdDGY2AI40Uxlw2MbFq5BaK1lrTPhs9XO10XoYNPx8ujMcGRyGU3PEBLZb6OXk8sKjsv1qYjGK+cbjDitOlf4UjMo+9fBH3a9EaF+8rkEjgOKsxWUrnkYpDSqqeqDRLmvws4N4iuLErJrMPEio+Mc+PK/wUHvcVRDFfi7hs9TjQx5PnkpWguOD6302qFz0xJQAr2vHUj/hqxZ44xHA1PYiBvMHW4tIpOBX7cbsyRN9ibHJ0utfD29FKsCxwJp+JZSuk8Hb8auJICR5edm+SfaA7HfAkVoKEajcDQoNH+6/KhjBnc1wsLfsuzOECzaJVfP7u3cFUCuxK4dz8ERHlm+kMbgDAR5alVwQbI5A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(376002)(136003)(396003)(366004)(451199015)(66476007)(8676002)(2906002)(38070700005)(55016003)(86362001)(316002)(41300700001)(53546011)(9686003)(966005)(107886003)(186003)(6636002)(4326008)(82960400001)(71200400001)(6506007)(26005)(66946007)(5660300002)(122000001)(83380400001)(478600001)(54906003)(64756008)(8936002)(33656002)(7696005)(110136005)(66446008)(52536014)(66556008)(76116006)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l/jVJR2sQ3WVdabKZTFNXBc/LjL8IV5LdY7CeZ+DS5U/pQmd5+FkbKa0MJSo?= =?us-ascii?Q?+LJWb8DrqAsWxDPSXYLsUZNMvv5ezf+LoopkPc/N+Ctb9eem3wcvgU+byyfI?= =?us-ascii?Q?MMCtyfT41X7xGBalQDNvR6ln3DFqiQc++b3d0F8SUDKP2WUvJunsLOUywHGX?= =?us-ascii?Q?KTBE+bUjVUBnd5OYHwH867USl4FXmJqieKzyuixHzQVglKuFkGZEiSCj/Z2c?= =?us-ascii?Q?p3i+x3fp7D2xnk8OwHC9UUKnWT0rNnc7elNGYotvMkg6F9Pc4iadSbVjdf+g?= =?us-ascii?Q?efcOJAVqwcCVVmkkWyorPiCq14oWzbgyZXWQx7qsFm228c5l1sHC4mgAZN+R?= =?us-ascii?Q?9+9dQUQ1VDfR5LDrKTYMJ6GqyCtuXJ9yURO3QI1Z3pp34IhNQgtxvwCdpUiw?= =?us-ascii?Q?OyUH8tHq3WoeBRaHA4MJcTGuMGLVY+W+Mo8xY/T/ph8jNIkL57EvsMAJOPx0?= =?us-ascii?Q?vlRr9Haa95cDqqNbDbcCfhmgguxiBKIxh7nZcSSkAsnMOtd7MCZKfs2eD6Qs?= =?us-ascii?Q?zpGyAHtDkuvuQrXnh57Le2tK5PCom86aNMXbmzkyhmRYIPPl1Mb1pMe7aklb?= =?us-ascii?Q?xsyqWGpijzV7dgBfcTUlF6c5HV360YJFR8BdKPKpiUdBLh7wHrgpp/g6J4KI?= =?us-ascii?Q?snhQS3uVo5Ub8HDvI+4ecieNtcnLFaZa4ie1oieKEqoexTP42PsrVIzOxkDa?= =?us-ascii?Q?kTs68T0tjivC5hMzIwPun90aL8UFZDJf8p/44hTdlk8bC9Kpgh/S1x9m/Q02?= =?us-ascii?Q?5WGE9SZkQu7Ox4b29hVeztT/ZAss4VGQX2E1074dyB4LdDja2Uo6svl+1qWU?= =?us-ascii?Q?BN+2KVgjlz7eT1Kz7oW2YxZ9XPqZOXRqKLF6S0s2qkx+0zk8Vosnp1nCNip9?= =?us-ascii?Q?7Z0efRmv4eup62CHDq4GbXshNmOa/HO0Tl7ZjQ3ZXOnwPjeEynWhArPXxWR/?= =?us-ascii?Q?WYVpIwz2WOuYnui20RvPOfKJNbOkWT8w7MJHKysTXMLwIA9QHyYsNSFikmqm?= =?us-ascii?Q?l7wMICiuTStgwDPkpDRdeNWplB2oLBlMrztAQbfW7+usbJ+V+YnJ2rYFK3zO?= =?us-ascii?Q?klelGffdBDrjGvHu/6WPQIzfknc009VlQWhI4WLh15XfnHLc7a9MkWafFufO?= =?us-ascii?Q?mjZKLqE6ZmVg8772T7zJ07ja8kc6E8tDsrcf2cBmN3kvdpPRU5QjiaL3rRDH?= =?us-ascii?Q?4qCO4j9VSeDb3NhsqYaBjvwiBpVzIsYkg2eTAyI3KzzmLCqCet6YnWctv48R?= =?us-ascii?Q?PHR+ndm+dRGZaocqNXsRGxbb1wo4i92gbwBPtk/3Zn00jLSDmqY+pqu/Gtkc?= =?us-ascii?Q?NEryuteLcwuSZ01lfhGkFgmEn8PKh9Js45OmCj7zClQOp2FWKZzoY1cKVdqA?= =?us-ascii?Q?4T6a6I15Gb/5UUR+EVLUPyMdIEFPKrIPyeqXdOAW7FmULrznzKFF2RXZuB3K?= =?us-ascii?Q?m16E2kdtaajZ6g9PERTGeuJ9+q5/gencAv7A+JN4iMSimvkbSk9Gt/sUSG40?= =?us-ascii?Q?RwRQ3YxasQ+Ag6cBiKqWMQTbJxGD1GoDW9TDNrWErApu8yq3wSp3YTx+nKh/?= =?us-ascii?Q?ZvjF0wJ6zp85nTMCMn6KhrUMb7ZaL5Trr2kPpHGl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce93ecf-983c-4783-d5f8-08da94e653e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2022 17:43:39.6888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: is2F9tRRoY73GbhSr8YDTkephur2C1k6p2nIFHEy3Uf4T3c60NNRYrN6f2aZf6zbdig5znk1RPba452CB6UN1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5183 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Igor, Section 6.1 of the ACPI specification describes this (Last line of the par= agraph below states what Aryeh was saying): For any device that is on a non-enumerable type of bus (for example, an ISA= bus), OSPM enumerates the devices' identifier(s) and the ACPI system firmw= are must supply an _HID object (plus one or more optional objects such as _= CID, _CLS, _HRV, _SUB) for each device to enable OSPM to do that. For devic= es on an enumerable type of bus, such as a PCI bus, the ACPI system must id= entify which device on the enumerable bus is identified by a particular add= ress; the ACPI system firmware must supply an _ADR object for each device t= o enable this. A device object must contain either an _HID object or an _AD= R object, but must not contain both. Thank you, Ankit > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Igor > Mammedov > Sent: Monday, September 12, 2022 1:33 AM > To: Chen, Aryeh > Cc: devel@edk2.groups.io; Chiu, Chasel ; Desimone, > Nathaniel L ; Oram, Isaac W > ; Sinha, Ankit ; Gao, > Liming ; Dong, Eric > Subject: Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from > MinDsdt.asl >=20 > On Mon, 12 Sep 2022 13:17:45 +0800 > aryeh.chen@intel.com wrote: >=20 > > From: Aryeh Chen > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 > > > > According to ASL Coding Guidelines - Device Identifiers "A Device > > should contain either an _ADR or a _HID object, never both." > > , so remove _ADR due to _HID exist. >=20 > I'm curious where exactly in ACPI spec it's said... >=20 > > Signed-off-by: Aryeh Chen > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > > Cc: Ankit Sinha > > Cc: Liming Gao > > Cc: Eric Dong > > --- > > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > index 0d94472450..4efb8709ac 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > @@ -27,7 +27,6 @@ DefinitionBlock ( > > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mod= e2 > host hierarchy > > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn= 't > understand the new HID > > Name(_SEG, 0) > > - Name(_ADR, 0x00000000) > Spec also says > v6.3 > 6.1.1 _ADR (Address) > An _ADR object must be used when specifying the address of any device on > a bus that has a standard enumeration algorithm >=20 > > Method(^BN00, 0){ return(0x0000) } // Returns default Bus numbe= r for > Peer PCI busses. Name can be overriden with control method placed directl= y > under Device scope > > Method(_BBN, 0){ return(BN00()) } // Bus number, optional for th= e > Root PCI Bus > > Name(_UID, 0x0000) // Unique Bus ID, optional >=20 >=20 >=20 >=20 >=20