From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.1507.1652814124202776307 for ; Tue, 17 May 2022 12:02:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DYFRrwWt; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652814124; x=1684350124; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zxGy44GUIhsT7/rmiLW2UwkPjjm0BkAV3PnZE6cNs0g=; b=DYFRrwWtqAj5yvBSlHj1zdjg1Gf97aMux43EBNAsrza77xQnZ5Ts4wXl k8OaL9DC7nNg+UpTcOgudsfbTU0JJ//tqzD3uqQ5fH7ZwRHgpwBDIdZLU nDfxeg9sDH8+e/DEOMflhfRC29aCG8CEoQpLTq0Grkhx0ijJOyTsxB/d/ pc2F50UyI2E1A/rd6UmVaAq5IsyRaIhsDsfdBctxdOsykRjcq9P/z0G1+ TjjkHfxbPcB935oKK+MUIChm0QrJYt9DGalfF8yg4bDRBW9P2PZWJCt+/ Edu1BxnZe+Su2jNQyihGD6CY9NF0SnPbmzTHvWRR1pLMadXNruU7gg/gd A==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="270982751" X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="270982751" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 12:02:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,233,1647327600"; d="scan'208";a="638890151" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 17 May 2022 12:02:00 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 12:01:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 12:01:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 12:01:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FoWvgYPEWzpTVswH5ar0Mi7FbMt7+LxhHYfmzvGjyGyVSR8JgvMg5vEtvgZQuXOVrGUixD/jVT+7AuEn4drlUjOc9EKCWn+0wVzOkPt8SGlyXay7EzrqSFuvja4pVejFQtrg/qqpUxSHOi4jJ4syMzreUyp2f9R1v+y2EgoDNbopb1V3/GY4bu4Kp78UW5HK/ns9VbidnWjrPEP3f7PTcsqgah6zIrIdjSZYXclPfMZGboOoRWHeWyfSD8saQFMP76mgghJ/pFg9qkB+yWh3dKKMY4eEOBibg9IrTzRwwHbOuCni/K5aWPh2eiU6QixiDbvwgk58fudOzqjGKW7CGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZeRLbUMwRfH2UWSbuivgqGopk7O4K/b1yVsPc1r6zts=; b=hGlqARDelk6X0bK4EUkqm/ecJzKmqUZx43lfAzkamecd7GtvhWE2DFIZATPLOXzgzEZax/GNpB6uD3/wDtEVRbmIRKyTVO2GwiVt3c+jo5nbocQp69f4+/kngLJiUqC4Ai2GPIY6oUxgdtvu0acMuBiA0/91zLO/HXCr9tumQJyvzUDWElFiAxtJ6/XH5KJ/Ac94Vbg2wmeW+gRjGDAaRng+D2e20Y+fV5Hoy1cshTBjxjUudK5EdXrX+cvZpjFewUk6OMOqHvS3xAYkiUCqdlj4SA81YIh3rmT1S9hVdIjPZgp/+xq7joiBGET7awT8+z3OZY9/jRfDxxAS38p59w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by MN2PR11MB4159.namprd11.prod.outlook.com (2603:10b6:208:13a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Tue, 17 May 2022 19:01:51 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::c5f4:1b74:1a8f:4c0c]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::c5f4:1b74:1a8f:4c0c%9]) with mapi id 15.20.5250.018; Tue, 17 May 2022 19:01:51 +0000 From: "Sinha, Ankit" To: "Ni, Ray" , "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package Thread-Topic: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package Thread-Index: AQHYaZzZ+oT2pZ3KZ0mPT7WTHKSXqK0jHJ0AgABP63A= Date: Tue, 17 May 2022 19:01:51 +0000 Message-ID: References: <20220517031830.1520-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c3fd9e9-95e0-4f98-ace1-08da3837b3b3 x-ms-traffictypediagnostic: MN2PR11MB4159:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rGgpNP9AIwfGIfx3agwVScea/tTsLyje5GscPRP6T7FtG12WFlFqvKgIMFx8RLN1tPYCh9x+3ZDzm+jYDEPbtaSPfsNLBT1dO4hLwHa3t2wQvQQP7bRi41nqKmaW2M1TO9gFZ53qWJouyeQQYTedwcTZdXPo7T9GHUIsihM5hkqcqhdPU28ruhHjxiZ2Fpg3MTCOqGJbWjZ5arDUp1LsofJDQL4MUnRJIB/4bh8ZPO5PWFYcv3ODj5VKGG90UDSbjrJAaMDeTL9Xx8g+02eRTdwcr4UIJLMmd5Wi7Y21iegmjNoOZ0z3h9W25jfDAI4jv9ediRNqCXp86h1q1pzzavpjPjASDgKEMCgMpLt36JUS7NFa0g+84LO8DDi61vdnTJ7NXGuynYYK6aZW9/Ps9kyxxkXLgJXlRGIIr35Rl1wXxyWmgZF7zCurvGox1nWtPxMCSTQSGPZ/i07p97iy2HXjF9wH9qRbGvtYIDbQur/UInOSLmV+QP2Ac+JJbkMcp2UkQ7OSewGY5pfNcYVLvE8Lq0nnUA68DGtk5c5w4M4QSeJLUnLAzcISFeCQfeWcZ+nWAwSIU07TaLCYW2fEBubxxsyhAGhszxIQVLytf8HMgh6FpM7lVz9HAwpCECoJysc8Zq1mm0i+0HZRkqO6/nTh/xGBxEM889QUzJDKUTn/U/aCdE8/u/teBgEvuCdoF0oIxSHFI7Txd3fkjaPHo6mCuQIwjpjmyFhxA5ZT1f6dNVudw7JhePEN7YuS6aK/gokVSvHer5lTJ7F+xQpK8jLaUhpc/W/EUtTemzkvQjmeuYZBJALTfIckhWoY4SedimxLPYpjIeKOVoyYFR1RyQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(122000001)(83380400001)(316002)(19627235002)(107886003)(9686003)(6506007)(2906002)(8676002)(52536014)(508600001)(71200400001)(53546011)(8936002)(26005)(66556008)(66946007)(64756008)(66476007)(76116006)(86362001)(4326008)(66446008)(82960400001)(186003)(6636002)(7696005)(15650500001)(54906003)(110136005)(30864003)(33656002)(38100700002)(55016003)(5660300002)(966005)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B/lICBZ0p6oVQOUI2ruEZSCGWVzxdGw82lD57ZUExxA51EPB9e5irRfU+SNA?= =?us-ascii?Q?uDq5/ihTvpNrxvLBFuAE6i+AUom2Kuy4hup7U7akhJoG4rYK9iCerFG1LkKX?= =?us-ascii?Q?KOO/0FNMnNjNOi60lvKKwE69IPEOmvZOpJKHk/AEZaot9dOetILudGs77nOD?= =?us-ascii?Q?p4bX3JMonEpoKSYrpWH4OWopTKidAXM9SwLlfxr8mx5PZOh9Ln7F/Q0leQkN?= =?us-ascii?Q?ZCjCum4qOXEcBvZ4wSrAsHtct2IV7YYg0amgk8izDBDE2AN8nQbd+meoibkd?= =?us-ascii?Q?rQ01BLpqrn0LSVzBPZnQY8vARsU6KzetHv7Mp2QEMiE0lD/xFa56V29crwX+?= =?us-ascii?Q?Q9misjx2oexfkrdWkp/q8Nly/7ffhdgcX1AICl8xv3jZ3qK/S4nqWp/zJtV2?= =?us-ascii?Q?Us6x12RI3Ku8Z4Z118oyo9e1Exj+Z0WDMMqWO6anFnuvSVc2lP14mJ/uQSWN?= =?us-ascii?Q?TAjyD/j/V+r6hU95dpMV90aiJnh3SlzbkG+E3fyzmKRXMBtZUGTRk1wHwUzi?= =?us-ascii?Q?7Rjf2HV1DhxUso4hNoOlyw5pjweTSyxJNr5JXL02+RHIE4yd9U3M216QBdub?= =?us-ascii?Q?niTPHrjliZIPY0L0QGfn73SoB6dSCU6D6lOr5K8OpmvEmJm9PVfQLiNSkCeE?= =?us-ascii?Q?q625ZT/uj9beRDhDqMjbbUJGlbNJNdBSwH0IGWaqsxHd6/Ld5eXfRZBO2+2+?= =?us-ascii?Q?en46MCVZnw7NYScbKmsko7P3pKZG//PFy4VzDLWHatUWhU5n9qT2BEAI1aJp?= =?us-ascii?Q?2KLbddPz2dbOBOSUfUPcmTB2S8/3Xu9OReiPUCmfPX6+ptcOefXWcKbkQNJv?= =?us-ascii?Q?mBY0SteLiTIFTYotGVGVvS3iPats/P3VcJK90ObRG3sTyHlxDc8vqVMSWuGU?= =?us-ascii?Q?EbH4aWOY1uQDmNTyGXSEanMVM49SG+0NQAuy0XAS2UAE/0DlcL7QjUglVzqV?= =?us-ascii?Q?sb2zWTc7sDCLekDZS2fw52kpjaUEYbh8gbrPP7oX5fqXicPWkkn+RZyVBXmi?= =?us-ascii?Q?nFycZRzNZbb1AAI0EXNeRWwESoCZ5Vf808TYQ2g5ykRBM7uzqNIro+jTBbyJ?= =?us-ascii?Q?JCOyxS4xhW1mMuaBWMFHONk1LY7D/Dn/d56BVn8HaDFrOzcyUhcSuK+X3h4q?= =?us-ascii?Q?Jr4Ba4y/imt0tU6EcVdk8mh3dug9QZgb2LReI6YQvuPQo7Xmp18hkc9IRZdx?= =?us-ascii?Q?LRHSGYk4c84K4DGtop+edGvOat33tqeyPG2oJeoOOWrltV9+bGlQMMKWS7e3?= =?us-ascii?Q?03Im3UzBaz64/WPnD/K+IZtXTpJWCafs9KRbjm2ZVSIEBqRrBDhuwXd56dri?= =?us-ascii?Q?DQnd8V3/dtcF/4Cshso44zfCTlKwtjJ0xmrGZTK1M8CkpNVGkOctDjskEniI?= =?us-ascii?Q?8vUm+61ihUGIuygiB3OQo+6WAnIlp81zvAcQgsCya4TSt7qS/lKblw0/QMv7?= =?us-ascii?Q?bfdy3gjN3mN7Yxj/BqpKzJnHoBJnJLze4PJMMcj5+9eeaefumogZFq25ZIPc?= =?us-ascii?Q?wlcf+JmPkqYhGmS1oDDXe3FyAn8W7mUbFaLZzNov6RxxxX9I1w/X6YwM03C3?= =?us-ascii?Q?WPJhY1nyzatxN6ZHG+zylpLkHDI9JyTXP1jg6TeG7vb7BojJuKDwQvUHCYuc?= =?us-ascii?Q?eDCFrpmYl9GD0IhsNy77Z22Z/76NJQ29ysdMW6djCs6RSU6lZPYXkDQ75Iep?= =?us-ascii?Q?MxDtaoMrJxWy5WGlPnv7I31ajQ+7TIvvtmVjHni/ac8T+U7CgPNQCJVLZWmp?= =?us-ascii?Q?MoiGK//BYw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c3fd9e9-95e0-4f98-ace1-08da3837b3b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2022 19:01:51.5131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rQ24obhrQ9KQ4QG52kidmpKJFl6IveuG/AziS0cIpEFuXODxPGHRS+dGb4BfqpWKvHIKOKk41r9pv7rKxC0nxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4159 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, That is a good feedback. However, since FADT is a mandatory table to boot a= n ACPI compliant OS, we have placed it in the implementation of MinPlatform= Pkg. If we move this to be a board responsibility then we will need to impl= ement a check in the boot process to make sure FADT is published correctly = before booting to OS. Thank you, Ankit > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, May 17, 2022 7:11 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject: RE: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to > update FADT entries from board package >=20 > I am thinking if most of FADT fields are configurable through PCD from > BoardPkg. > Then why not remove the FADT from this open-source driver but let some > code in BoardPkg produces the FADT? >=20 > It helps to remove the PCD layer and simplifies the data flow from PCD- > >FADT to FADT. >=20 > Thanks, > Ray >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chiu, > > Chasel > > Sent: Tuesday, May 17, 2022 11:19 AM > > To: devel@edk2.groups.io > > Cc: Sinha, Ankit ; Chiu, Chasel > > ; Desimone, Nathaniel L > > ; Gao, Liming > > ; Dong, Eric > > Subject: [edk2-devel] [PATCH V1 1/1] MinPlatformPkg: Add PCDs to > > update FADT entries from board package > > > > From: Ankit Sinha > > > > Adds new PCDs to allow entries in FADT to be customized during > > platform integration. Board packages will can update these PCDs during > boot. > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Liming Gao > > Cc: Eric Dong > > > > Signed-off-by: Ankit Sinha > > --- > > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 85 > ++++++++++++-------- > > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 24 > ++++++ > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 36 ++= +++++- > - > > 3 files changed, 105 insertions(+), 40 deletions(-) > > > > diff --git > > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > index 05fc7799fb13..b3d067def3fa 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > > @@ -1165,6 +1165,11 @@ PlatformUpdateTables ( > > // Update the creator revision > > > > // > > > > TableHeader->CreatorRevision =3D > > PcdGet32(PcdAcpiDefaultCreatorRevision); > > > > + > > > > + // > > > > + // Update the oem revision > > > > + // > > > > + TableHeader->OemRevision =3D PcdGet32(PcdAcpiDefaultOemRevision)= ; > > > > } > > > > } > > > > > > > > @@ -1187,44 +1192,54 @@ PlatformUpdateTables ( > > case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE: > > > > FadtHeader =3D (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) > Table; > > > > > > > > - FadtHeader->PreferredPmProfile =3D PcdGet8 > (PcdFadtPreferredPmProfile); > > > > - FadtHeader->IaPcBootArch =3D PcdGet16 (PcdFadtIaPcBootArch); > > > > - FadtHeader->Flags =3D PcdGet32 (PcdFadtFlags); > > > > + FadtHeader->PreferredPmProfile =3D PcdGet8 > (PcdFadtPreferredPmProfile); > > > > + FadtHeader->IaPcBootArch =3D PcdGet16 > (PcdFadtIaPcBootArch); > > > > + FadtHeader->Flags =3D PcdGet32 (PcdFad= tFlags); > > > > + FadtHeader->AcpiEnable =3D PcdGet8 (PcdAcpi= EnableSwSmi); > > > > + FadtHeader->AcpiDisable =3D PcdGet8 (PcdAcpi= DisableSwSmi); > > > > + FadtHeader->Pm1aEvtBlk =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); > > > > + FadtHeader->Pm1bEvtBlk =3D PcdGet16 > (PcdAcpiPm1BEventBlockAddress); > > > > + FadtHeader->Pm1aCntBlk =3D PcdGet16 > (PcdAcpiPm1AControlBlockAddress); > > > > + FadtHeader->Pm1bCntBlk =3D PcdGet16 > (PcdAcpiPm1BControlBlockAddress); > > > > + FadtHeader->Pm2CntBlk =3D PcdGet16 > (PcdAcpiPm2ControlBlockAddress); > > > > + FadtHeader->PmTmrBlk =3D PcdGet16 > (PcdAcpiPmTimerBlockAddress); > > > > + FadtHeader->Gpe0Blk =3D PcdGet16 > (PcdAcpiGpe0BlockAddress); > > > > + FadtHeader->Gpe0BlkLen =3D PcdGet8 > (PcdAcpiGpe0BlockLength); > > > > + FadtHeader->Gpe1Blk =3D PcdGet16 > (PcdAcpiGpe1BlockAddress); > > > > + FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpi= Gpe1Base); > > > > + FadtHeader->DutyWidth =3D PcdGet8 (PcdAcpi= DutyWidth); > > > > > > > > - FadtHeader->AcpiEnable =3D PcdGet8 (PcdAcpiEnableSwSmi); > > > > - FadtHeader->AcpiDisable =3D PcdGet8 (PcdAcpiDisableSwSmi); > > > > + FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); > > > > + FadtHeader->XPm1aCntBlk.Address =3D PcdGet16 > (PcdAcpiPm1AControlBlockAddress); > > > > + FadtHeader->XPm1bCntBlk.Address =3D PcdGet16 > (PcdAcpiPm1BControlBlockAddress); > > > > + FadtHeader->XPm2CntBlk.Address =3D PcdGet16 > (PcdAcpiPm2ControlBlockAddress); > > > > + FadtHeader->XPmTmrBlk.Address =3D PcdGet16 > (PcdAcpiPmTimerBlockAddress); > > > > + FadtHeader->XGpe0Blk.Address =3D PcdGet16 > (PcdAcpiGpe0BlockAddress); > > > > + FadtHeader->XGpe1Blk.Address =3D PcdGet16 > (PcdAcpiGpe1BlockAddress); > > > > > > > > - FadtHeader->Pm1aEvtBlk =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); > > > > - FadtHeader->Pm1bEvtBlk =3D PcdGet16 > (PcdAcpiPm1BEventBlockAddress); > > > > - FadtHeader->Pm1aCntBlk =3D PcdGet16 > (PcdAcpiPm1AControlBlockAddress); > > > > - FadtHeader->Pm1bCntBlk =3D PcdGet16 > (PcdAcpiPm1BControlBlockAddress); > > > > - FadtHeader->Pm2CntBlk =3D PcdGet16 > (PcdAcpiPm2ControlBlockAddress); > > > > - FadtHeader->PmTmrBlk =3D PcdGet16 (PcdAcpiPmTimerBlockAddress); > > > > - FadtHeader->Gpe0Blk =3D PcdGet16 (PcdAcpiGpe0BlockAddress); > > > > - FadtHeader->Gpe0BlkLen =3D 0x20; > > > > - FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiGpe1BlockAddress); > > > > + FadtHeader->ResetReg.AccessSize =3D PcdGet8 > (PcdAcpiResetRegAccessSize); > > > > + FadtHeader->XPm1aEvtBlk.AccessSize =3D PcdGet8 > (PcdAcpiXPm1aEvtBlkAccessSize); > > > > + FadtHeader->XPm1bEvtBlk.AccessSize =3D PcdGet8 > (PcdAcpiXPm1bEvtBlkAccessSize); > > > > + FadtHeader->XPm1aCntBlk.AccessSize =3D PcdGet8 > (PcdAcpiXPm1aCntBlkAccessSize); > > > > + FadtHeader->XPm1bCntBlk.AccessSize =3D PcdGet8 > (PcdAcpiXPm1bCntBlkAccessSize); > > > > + FadtHeader->XPm2CntBlk.AccessSize =3D PcdGet8 > (PcdAcpiXPm2CntBlkAccessSize); > > > > + FadtHeader->XPmTmrBlk.AccessSize =3D PcdGet8 > (PcdAcpiXPmTmrBlkAccessSize); > > > > + FadtHeader->XGpe0Blk.AccessSize =3D PcdGet8 > (PcdAcpiXGpe0BlkAccessSize); > > > > + FadtHeader->XGpe1Blk.AccessSize =3D PcdGet8 > (PcdAcpiXGpe1BlkAccessSize); > > > > > > > > - FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); > > > > - FadtHeader->XPm1bEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1BEventBlockAddress); > > > > - if (FadtHeader->XPm1bEvtBlk.Address =3D=3D 0) { > > > > - FadtHeader->XPm1bEvtBlk.AccessSize =3D 0; > > > > - } > > > > - FadtHeader->XPm1aCntBlk.Address =3D PcdGet16 > (PcdAcpiPm1AControlBlockAddress); > > > > - FadtHeader->XPm1bCntBlk.Address =3D PcdGet16 > (PcdAcpiPm1BControlBlockAddress); > > > > - if (FadtHeader->XPm1bCntBlk.Address =3D=3D 0) { > > > > - FadtHeader->XPm1bCntBlk.AccessSize =3D 0; > > > > - } > > > > - FadtHeader->XPm2CntBlk.Address =3D PcdGet16 > (PcdAcpiPm2ControlBlockAddress); > > > > - //if (FadtHeader->XPm2CntBlk.Address =3D=3D 0) { > > > > - FadtHeader->XPm2CntBlk.AccessSize =3D 0; > > > > - //} > > > > - FadtHeader->XPmTmrBlk.Address =3D PcdGet16 > (PcdAcpiPmTimerBlockAddress); > > > > - FadtHeader->XGpe0Blk.Address =3D PcdGet16 > (PcdAcpiGpe0BlockAddress); > > > > - FadtHeader->XGpe1Blk.Address =3D PcdGet16 > (PcdAcpiGpe1BlockAddress); > > > > - if (FadtHeader->XGpe1Blk.Address =3D=3D 0) { > > > > - FadtHeader->XGpe1Blk.AddressSpaceId =3D 0; > > > > - FadtHeader->XGpe1Blk.AccessSize =3D 0; > > > > - } > > > > + FadtHeader->SleepControlReg.AddressSpaceId =3D PcdGet8 > (PcdAcpiSleepControlRegAddressSpaceId); > > > > + FadtHeader->SleepControlReg.RegisterBitOffset =3D PcdGet8 > > + (PcdAcpiSleepControlRegRegisterBitOffset); > > > > + FadtHeader->SleepControlReg.AccessSize =3D PcdGet8 > (PcdAcpiSleepControlRegAccessSize); > > > > + FadtHeader->SleepControlReg.Address =3D PcdGet64 > (PcdAcpiSleepControlRegAddress); > > > > + FadtHeader->SleepStatusReg.AddressSpaceId =3D PcdGet8 > (PcdAcpiSleepStatusRegAddressSpaceId); > > > > + FadtHeader->SleepStatusReg.RegisterBitWidth =3D PcdGet8 > (PcdAcpiSleepStatusRegRegisterBitWidth); > > > > + FadtHeader->SleepStatusReg.RegisterBitOffset =3D PcdGet8 > > + (PcdAcpiSleepStatusRegRegisterBitOffset); > > > > + FadtHeader->SleepStatusReg.AccessSize =3D PcdGet8 > (PcdAcpiSleepStatusRegAccessSize); > > > > + FadtHeader->SleepStatusReg.Address =3D PcdGet64 > (PcdAcpiSleepStatusRegAddress); > > > > + > > > > + FadtHeader->S4BiosReq =3D PcdGet8 (PcdAcpi= S4BiosReq); > > > > + FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); > > > > + FadtHeader->XPm1bEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1BEventBlockAddress); > > > > > > > > DEBUG ((DEBUG_INFO, "ACPI FADT table @ address 0x%x\n", Table)); > > > > DEBUG ((DEBUG_INFO, " IaPcBootArch 0x%x\n", > > FadtHeader->IaPcBootArch)); > > > > diff --git > > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > index 99adf9c381c9..9d91e418d4ca 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > > @@ -62,6 +62,8 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiDutyWidth > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch > > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags > > > > > > > > @@ -77,7 +79,29 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize > > > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitWidth > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitOffse > > + t > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddress > > > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddressSpaceId > > > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitWidth > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitOffset > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAccessSize > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddress > > > > + gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq > > > > + > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdLocalApicAddress > > > > gMinPlatformPkgTokenSpaceGuid.PcdIoApicAddress > > > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > index e38617ce20fd..bfc50565144f 100644 > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > @@ -112,10 +112,6 @@ > > > > > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuCoreCount|8|UINT32|0x9000 > 0022 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuSocketCount|4|UINT32|0x90 > 000023 > > > > > > > > - > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8| > 0x9 > > 0000025 > > > > - > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x > 9000 > > 0026 > > > > - > > > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x900 > 0002 > > 7 > > > > - > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize|0 > x65 > > |UINT32|0x20000500 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize|0x30 > |UIN > > T32|0x20000501 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiReservedMemorySize|0x4 > 02|U > > INT32|0x20000502 > > > > @@ -245,6 +241,10 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdPciSegmentCount |0x1 > |UINT8|0x4001004E > > > > gMinPlatformPkgTokenSpaceGuid.PcdRandomizePlatformHierarchy > |TRUE > > |BOOLEAN|0x4001004F > > > > > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8| > 0 > > + x90000025 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x > 90 > > + 000026 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x900 > 00 > > + 027 > > > > + > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1AEventBlockAddress|0x1800| > UINT > > 16|0x00010035 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1BEventBlockAddress|0x0000| > UINT > > 16|0x00010036 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm1AControlBlockAddress|0x180 > 4|UI > > NT16|0x0001037 > > > > @@ -252,7 +252,33 @@ > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850 > |UIN > > T16|0x00010039 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UI > NT16 > > |0x0001003A > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT1 > 6|0x > > 0001003B > > > > - > > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT1 > 6|0x > > 0001003C > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x > 00 > > + 01003C > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT1 > 6| > > + 0x0001003D > > > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x000100 > 40 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiDutyWidth|0x00|UINT8|0x000100 > 41 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8 > |0 > > + x00010042 > > > > + > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UI > NT > > + 8|0x00010043 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UI > NT > > + 8|0x00010044 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x00|UI > NT > > + 8|0x00010045 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize|0x00|UI > NT > > + 8|0x00010046 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize|0x00|UIN > T8 > > + |0x00010047 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT > 8| > > + 0x00010048 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8 > |0 > > + x00010049 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8 > |0 > > + x0001004A > > > > + > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId| > 0 > > + x00|UINT8|0x0001004B > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitWidth > > + |0x00|UINT8|0x0001004C > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegRegisterBitOffse > > + t|0x00|UINT8|0x0001004D > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAccessSize|0x00| > > + UINT8|0x0001004E > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddress|0x00000 > 0 > > + 0000000000|UINT64|0x0001004F > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddressSpaceId|0 > x > > + 00|UINT8|0x00010050 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitWidth| > > + 0x00|UINT8|0x00010051 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegRegisterBitOffset > > + |0x00|UINT8|0x00010052 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAccessSize|0x00| > U > > + INT8|0x00010053 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepStatusRegAddress|0x000000 > 0 > > + 000000000|UINT64|0x00010054 > > > > + > > + > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x0001 > 00 > > + 55 > > > > + > > > > > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000| > UIN > > T32|0x0010004 > > > > > > > gMinPlatformPkgTokenSpaceGuid.PcdFspCpuPeiApWakeupBufferAddr|0x9f > 000|U > > INT32|0x30000008 > > > > -- > > 2.33.0.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#89792): > > https://edk2.groups.io/g/devel/message/89792 > > Mute This Topic: https://groups.io/mt/91156600/1712937 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > >