Re: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

["Ankit Sinha" <ankit.sinha@intel.com>]

Hi Aryeh,

Can you please post the test results for this change. It would be good to note that there is no change in behavior in the OS.

Thank you,
Ankit

> -----Original Message-----
> From: Chen, Aryeh <aryeh.chen@intel.com>
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh <aryeh.chen@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Gao,
> Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> 
> From: Aryeh Chen <aryeh.chen@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> 
> According to ASL Coding Guidelines - Device Identifiers "A Device should
> contain either an _ADR or a _HID object, never both."
> , so remove _ADR due to _HID exist.
> 
> Signed-off-by: Aryeh Chen <aryeh.chen@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 0d94472450..4efb8709ac 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -27,7 +27,6 @@ DefinitionBlock (
>        Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy       Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> that doesn't understand the new HID       Name(_SEG, 0)-      Name(_ADR,
> 0x00000000)       Method(^BN00, 0){ return(0x0000) }  // Returns default Bus
> number for Peer PCI busses. Name can be overriden with control method
> placed directly under Device scope       Method(_BBN, 0){ return(BN00()) } //
> Bus number, optional for the Root PCI Bus       Name(_UID, 0x0000)  // Unique
> Bus ID, optional--
> 2.26.2.windows.1