From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.1307.1663016025158525777 for ; Mon, 12 Sep 2022 13:53:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NMmc4Ggi; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663016025; x=1694552025; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qlQ/L1WoLS8af/hRP2yf/1HdG9uMg+WrUpX2mBu7bd4=; b=NMmc4GgiSkooqZEGHXo+C+3N7pIiu/AUmVTdFdZZHTyCXEn3GwPShIin +TRU13nvaRTYTGsXMwm38sN75o6CKrzTw561UWjvYW7+CT0sevTD0QWUV weecS397SKeHdiQS5BbN1USQGW1n/8r16KNbBKzcBcyVesqT5JU4ucmSf zLIy42R0EjGhO3b22UhjRddeSXFFvFl6tbmiF2tPZRzfv+gz93Od9iMQJ YsMtGCr6ZqImF9iQZhiH1LK91i14+o0lHL0gZkVKDrs8i0kvdl1HV7HXL Gqzajmo5fEyVzyakCfxwsUw0iYp0XS8oEav2msOnpf3Bzf2bBRSXVS1H9 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="295554491" X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="295554491" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 13:53:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,310,1654585200"; d="scan'208";a="567315478" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 12 Sep 2022 13:53:44 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 12 Sep 2022 13:53:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 12 Sep 2022 13:53:43 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 12 Sep 2022 13:53:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ELuZF4QwNxbmw2/iGSaJRXOT9KmAcrOvg2/E9S2skTTcfpSbHVivD61rR9lc8i7DURxD7XxO5GZyVwBh3pnXWYOgp30ZwiDEREmgeWaUuxY2vtJAJcPRZFOHvrlZzrnkxtHpArRz+yrRO1tmd8LlKUwtMIzYDmU8wO9LIGc7Iyi6slZQs9budYVPY9PJjuiMAiHFVugKaBJcf/DqIiWDeu764Y0AUxE3z7m//ju0tQmlvURZehLYS0hFbWHygrT2U0DY1jOUqFPnut3JsoNZQXlrieOI9LUKHEN89ruNLm/xz0E20WyFH5fEGLFz660WN0REffpg1jn8FYUfBOowcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aYaa8KGKQOJ/2/ZyEytBg9euAcbAoJoDlRHlCX0dkz4=; b=S+l8Z7SOeX3Xk/1zdXgtpa/Ye8qTF9SnRetyOj3eLLmZp64MqzJckugbkeBvfmT9DdxpK4JNoGkeAI6FfCGjLvSjB8Wq/hb+zj08XlgRtb7CVfxWK0EUDpHQUSOPIg8A5I1lZ8BavpcblpYCwwffQ5C4Kn65Os7WWMq32i155fC08YmYlINSPm895JVbyAPVLMvAFMAK2BSt1XQxPOBkYmRewZCmLQHAiDNKfW8DMwhvMJJnkcK+TNzMYHW+Uf1ilJ9fraAH03bsHw+lY01ADdSDp7+Ty11NcUT6EvWWaGomzBGLCP5033fDOMg9LMQlCu+zGhwgKiMisJvFl/nUug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by CH0PR11MB5564.namprd11.prod.outlook.com (2603:10b6:610:d7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Mon, 12 Sep 2022 20:53:39 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::6c6b:8816:2b3:dad6]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::6c6b:8816:2b3:dad6%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 20:53:39 +0000 From: "Ankit Sinha" To: "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Topic: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Index: AQHYxmcFd3upObUbMkKPrgjB8RZwra3cRArQ Date: Mon, 12 Sep 2022 20:53:39 +0000 Message-ID: References: <20220912051745.1539-1-aryeh.chen@intel.com> In-Reply-To: <20220912051745.1539-1-aryeh.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|CH0PR11MB5564:EE_ x-ms-office365-filtering-correlation-id: c67d80f6-f83c-4648-9500-08da9500ded6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q9sSBF+VcbTsWaQZcUizP0qZ+fdTLtpfKiARkrxiowjJvQOfKkyBsfNsNiMH7WZT94IewGcOorgmlpRoRAKkWYFROHuuz+hPJEvTV2ddAiwrPjsBlskZQC5gLJardsImUNPfwDC5qoR4q0FZmrhjX52VtcTbJcmfCbzTtee5iD9cUC3WjTyzZwMxm2iOx71wrGuj43ra5+tFtjmUZ4hbS4O4wFvQB0WHEr+yw1oIjbuF1xaTv6RJa3+gzP6NQKkal8o3Dd5jcf7jLacbit4WZMiKud5exuBvCdYOzFynECoTY0SxxtPCVgHlpYer2e+DqTii+JPKlpInSJ8kGrRh8ypMdFhi0Gsf9GPkmCupnPtNFPkgDybd5vcy1qs+cDpuKc7dmYGaV6pi9YxIeU6pqTCJ0Mi0gh7XXQdNHanSMUcNV4lQ3JXS6my4lFmalDaaEZgWt0u8T671P72TFegyLtBDtIevpajkbFICJYczY5OeRNGukKoy4AFAwYBZ5n4REjMsmVhIddUxb6WobJ/GdBGo+LbMaVgmvXrHDwMjxVUkf82ISiFI7J6fwEGYRQ2r3LB3uBoVVAh8qKjj9IgjyuChGa25sBUHK7w3eqrMWON9rB2jWRzE+gzdeK8ZZd2KwAP19TWIyDIokWQNPxwEUxLsTsHVg7dy1gR/krLA19AWuS3Pj1IwWQMfG0nz8kInaLE8aumTdXKDVXnrmfa+/Q+5RLRkNxC3AfhG/fzOQLcjl3fyG3HMorIL/C8WxjYKTJW+DhJZvtBghyKhx7SrfECdEd0mfFhLnY71S7+XoH0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199015)(9686003)(55016003)(316002)(2906002)(76116006)(66446008)(64756008)(8676002)(107886003)(110136005)(966005)(186003)(38070700005)(26005)(7696005)(53546011)(83380400001)(478600001)(66476007)(54906003)(38100700002)(41300700001)(71200400001)(86362001)(33656002)(6506007)(66556008)(66946007)(122000001)(4326008)(5660300002)(82960400001)(52536014)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kBT4t9c3KVav00QnfFeCHoHzbkjNELAurrAyZ/Jfft+Mgx+Jt9dcUVn67zvB?= =?us-ascii?Q?l8x6CAvk6OeR2rx35TtaSnLHvDdxz66zaHp33SqArXFB13//vxwgGohoo8Ta?= =?us-ascii?Q?WCu/WyPj6EnspfdlaK1ye7aU056WMCUm7VTtj9CoE68/eXO4djnGNxZhy6ul?= =?us-ascii?Q?xOPiAvsAVoPsFAA0YiNOb5kGCpBuZomNyYrWU58RGFPOwolY2OJ57/I6jEJj?= =?us-ascii?Q?qYIRR9fecMtZMV10HMRRO1ptLCs0TvgRXmSEs458b+W+RQE2Lj4mA4tBX2Bk?= =?us-ascii?Q?geNimUocCmSD6dUWAbFiOXaTQBIvspBxDtB/+zUKOfsgOKgc3YnB18tIFlyz?= =?us-ascii?Q?9IDJnDWp29vbl56VcvjzwfiAbEJJcexCbmkQ3tQpd6DAci/wmj+65fud/gq0?= =?us-ascii?Q?QxHTS0v54InGgFQikbehl6ApblcJARPxWJg+itgbx+evAHUT+K2nY0HQL4qC?= =?us-ascii?Q?eJchAvBoNtVwHmMIJaLBFHxK8WNi+JclsyXLzJCpSi/K06Fy6PoqSfJeanuw?= =?us-ascii?Q?7qD6V9YuyZcwDa9lkp2g4ZDfz4Vt7mRjhbM4aNPVImdQrmKuqj/gpBWSZYFj?= =?us-ascii?Q?c1GhNtdA1irUj07VGaqvV3kDG7AsO5LIEmdJfRcX6Skg/fYkCQrmjvQC7D8B?= =?us-ascii?Q?W5N/VVTovW8wDTe07S9plPw/FcgsiE0nlVOPm1tOXSQ4NB+BoUfDIZsczWhQ?= =?us-ascii?Q?TB6Lv4QIBqSZ4ZsokPtsMorOfGCHNmR8T3kq5pB3fWhpi/XgcB1iNwXwGPUD?= =?us-ascii?Q?ILwuA98FsTbxPFp2waGhxncb3MSapd3YozXnuyM2g0SNY0hrdvSYEDonGaZz?= =?us-ascii?Q?93QkVblSC5UQ8klWc+/FKMwjwasdJUB5pqWQJVUY39oUFUF7UdWjztMrV4M6?= =?us-ascii?Q?xmhejRsljyMp4M0Y+k10pBmZqKdYTDWmFEO4Zqtqv93mmJws1Lq+/eR515iS?= =?us-ascii?Q?6NJlDtEbKtNx+qnin1OZlKMePWH+UJlN7XRx43qW3qFGFMlUZHTPECvcK34N?= =?us-ascii?Q?RSp/s/wGDfVO1ajKG0ub6RvtHpFKjw4CO107u80onBkmJX4i9rn6t9SYifwD?= =?us-ascii?Q?Wibnh+mH6Pz6meH0d+fwLs4+6MBl6/wLzSUE9R6auh+c+W+AEAKyUstM2dmW?= =?us-ascii?Q?x4J1RITOdi8z4CQv5hEUDGsho1aidIUvsglS7MOgbZv9L7ETDg7ApnQnBFJB?= =?us-ascii?Q?HjVm4FWAsMk7wiG6pnxXz/ODdYLfOrWt7rWpVSBKYx6aTxYKt8l48VfRMqXa?= =?us-ascii?Q?D3jvsofFP1+37fLEQtY9ocnlcJtoNnIRDjWgyhweesl+qVxCYJb4gvpQ9Tob?= =?us-ascii?Q?AGQL8D9OIs1HevPp35saJ3tg7+XneGgw6zkp69pYgtVw7/WTenrDj+nbCoKB?= =?us-ascii?Q?XIQlW1Wz+tGRj0t8VtZhKTjj61FsiMQnY7yMrJLsSF2EQDUWnbCtmIbWYMGa?= =?us-ascii?Q?Qvb1gmEnjE6BwQjvRyzdtS+tOKzYtAjcd6qFsblQZSAtnIU9kCHVdXRR63R3?= =?us-ascii?Q?OjoCEGQBnD/JUW44TbBAglbkk2EZY2qC9udjkKsEE0CNgjD4jpNQvMe/MY/f?= =?us-ascii?Q?r8x4wPq+9304UivRKDHoxU2007B+txfdMDtfC9t/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c67d80f6-f83c-4648-9500-08da9500ded6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2022 20:53:39.7333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l5TrTrzwSBtkFiMISgkOqcheHIbpu9MO3Q+hwtXPVtNW63UB/iTqpe04qk/IYEJWBggpq/SfFuaw25tsHYipOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5564 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Aryeh, Can you please post the test results for this change. It would be good to n= ote that there is no change in behavior in the OS. Thank you, Ankit > -----Original Message----- > From: Chen, Aryeh > Sent: Sunday, September 11, 2022 10:18 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Sinha, Ankit ; Gao, > Liming ; Dong, Eric > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl >=20 > From: Aryeh Chen >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 >=20 > According to ASL Coding Guidelines - Device Identifiers "A Device should > contain either an _ADR or a _HID object, never both." > , so remove _ADR due to _HID exist. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Ankit Sinha > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 0d94472450..4efb8709ac 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -27,7 +27,6 @@ DefinitionBlock ( > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 > host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy O= S > that doesn't understand the new HID Name(_SEG, 0)- Name(_ADR, > 0x00000000) Method(^BN00, 0){ return(0x0000) } // Returns default = Bus > number for Peer PCI busses. Name can be overriden with control method > placed directly under Device scope Method(_BBN, 0){ return(BN00()) = } // > Bus number, optional for the Root PCI Bus Name(_UID, 0x0000) // Un= ique > Bus ID, optional-- > 2.26.2.windows.1