From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.4885.1664409469519649311 for ; Wed, 28 Sep 2022 16:57:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OEn2yzS9; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664409469; x=1695945469; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yBI50smHeJiiPqX08K6EM+xMZjn2X006SvB/Zcw9mlM=; b=OEn2yzS9H7mYYK18/LxZcumpxItNElq4XHyi1McixfMdjsA7oKP2RL28 HwBdYVzI+hzAkcQ3vfJQJ4wr11a3qcrZbXSTn3AA6iOrgCG/aUtKxDBSj A5VPRLdJPjUWbJ9sJw7PAfLm2HkfS7zR1dAtNbpJfxm3MdLDSIVPQqwah I9U8Ka0ewEUmImCaV0U8kTbLfTcWefOlRrwZ+O4w83rg1HXJA/1WG1n7a UxzeTYVpPc9TeIeUIM/jkdgFJ/wwueNM4LJRjqZhR2wHdZH1pOdmKmnC7 dUrhQWg3gLwGICcFLgs+GNZ8DUEhhTpA9hpaYeVfuv2x0kA8i6vicnQg8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="303233568" X-IronPort-AV: E=Sophos;i="5.93,353,1654585200"; d="scan'208";a="303233568" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2022 16:56:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10484"; a="624345963" X-IronPort-AV: E=Sophos;i="5.93,353,1654585200"; d="scan'208";a="624345963" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 28 Sep 2022 16:56:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 16:56:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 28 Sep 2022 16:56:23 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 28 Sep 2022 16:56:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 28 Sep 2022 16:56:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oCeRK2Fy6mHpOci5XNVced5OwEN0tGJk/pKBeMxSVJwC8Fc0YXGetLAKxbDqaVa60MgAgUu2Z0QxVNzvFNTtvMqzYwq3o0rz9ExvKAq/gL5sfN2P8wgodsecvYZCTY0tCtddLS6VwiqekEvZBgXx9/rjB/pqYe2nlaTdvW1OIjUd7wUb42UEKV3fjuTXEK5sHFA0zWbhXH5mFV21M3BAfJmkSiXAiacGshy3m8biewn73acMQ8d+j12IoeQQcprhyc1kkHG5a6TEhMUyNYrJkniwSKdpxsQBUBivzJuv+7VMwlu9SUkFpBEqFgnbk44b4GAxKV8m1pTHeTfNCLKPag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jadIwqM3y3Jfpf1aRtkjYi4NX5CXyw6fm5mpY8pCcmw=; b=P7GNZkqoaT2iM4zTZFokje1Sn+nS3LXQ5xRp/EYX+F9o85r9djh/nTlLTGOYKqAwztKg9Z65X9y6yz22M4w/A5Ih2qyMetS3cNzTB8gu8lspGE0bj9dKKwo0empfVB4gJv/uL3KqXpyksDdVTvEcVsDkuQ0Ow5uUvij5zegL7BHN8QfEsRrs3WPOWEkXZjpD1w+v3kuHrix12TAwFFS0xrq9IgveUc+hz6J6qtCs7Otv/BUwfINHOLKivaXWM+k0jrkJqPypJ5UV7WQ/3rCfalrjRfIfe3/5Uv5+X9+hNlm++g4KEMt9GhkAwfpnYx7Nlcb1kwo0eYYhnm6zEVKTpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SA1PR11MB6783.namprd11.prod.outlook.com (2603:10b6:806:25f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Wed, 28 Sep 2022 23:56:17 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::8cc2:5872:5488:909e]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::8cc2:5872:5488:909e%5]) with mapi id 15.20.5654.025; Wed, 28 Sep 2022 23:56:17 +0000 From: "Ankit Sinha" To: "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Topic: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Index: AQHYxmcFd3upObUbMkKPrgjB8RZwra3cRArQgA1IDgCADBIqkA== Date: Wed, 28 Sep 2022 23:56:16 +0000 Message-ID: References: <20220912051745.1539-1-aryeh.chen@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|SA1PR11MB6783:EE_ x-ms-office365-filtering-correlation-id: 17f9364e-190b-44dd-6bec-08daa1ad086c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zJThW/wEkULfk8MK+POD7W/9NU9a/c9OPIKBfDcxquodH80Xff0ZhG0ruUPDq2205Ar5bNusGzVI9dTPTJjbvzDQmGimIi9z7d2GYo2f0oQ70GZP0pCEXFlDmBqxf65evz2vl3z/m7pr3lBFEVmR30teFOfwXyzN6W71sGTvg8IO6LTpr355b2gC5W6DggSroD08wYDOguFbk4kpQe+jhLglSimVM4LRKn4MrsppL+1xFYfdLOXq7MePYDFOcFLXZ9PM+hbCf+aNeXlp/fAIZnd+kO3fKBD9YEQm8tjyJ7A5dfcr9VtszXHax6cn9phfQxLRBvkqg3U1UyCWItzdS8lxSVG2w/AiTavFADVWpW2zAX9e7G8hcFwFTwa9Qg8+j6NIz5MZI9gJzfFWaHOg5PKPbKHetIjmAi5xtemaNw1UAvyFgwzPZMcY/PwHsRIT6C1PmXQcHsHR4gK1Nl1i8lYz0ODAiyRJC68IVqr4NE7+HyVm0qVLcSsJ7OwQroijglOLzalgLHZP9Cf35wRfq40pi6HCHKyfLtCiHzJojc7OHDs2zGmLYGDuWEE6q4mdX6OxWx44K97Nx+3YPEblPh2HgxHY+RFys1xfHhYs1bFw4Xc3rbu8MOeS1tqczcoy7wg/+00iLUquFC1EEWRBhByCH8fw5Q1alNrdeNT+doShe5omMGl+FhmdI0B9MmXnMsD7h7JnzUX1r1OdUqLVWJstqaTXF4/sWIoGA+O4u3fsRQstE/SClywXTPooV6bCwrfNQHTc7CsqoP366JouII95NZ0jEPCnPP0cxQ8c8gI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199015)(54906003)(33656002)(110136005)(86362001)(316002)(9686003)(122000001)(83380400001)(186003)(38100700002)(82960400001)(55016003)(26005)(6506007)(7696005)(8676002)(966005)(478600001)(71200400001)(53546011)(64756008)(76116006)(107886003)(66446008)(52536014)(66556008)(66476007)(5660300002)(8936002)(41300700001)(2906002)(38070700005)(4326008)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FVUv3GKN9CgymX4UoyjKrwiGOsj8OufeMHQvbRtGPYS0+KPhskOBFk7vtGpa?= =?us-ascii?Q?PHtFS+WPoUE6oBwXKj31YHl//egPSmk1ueo4JsAAhiNvOkjbAEaGYx5so0Cn?= =?us-ascii?Q?wm2b6GQShYprzFR8MWshkmFJeLAslYjGr9k14qiARKd+LoFOrgrh8e0d8HjG?= =?us-ascii?Q?iG4DR/rX/xsz7gK+g3KMt6qRbe1WZs50kc5Y6sklNkYQ5ljWzFCyJGb3ve1k?= =?us-ascii?Q?PEY6f+tLu9cksZo0bM9OHkLTO6cCXAx/EAiPd2S9xHPt7b06ZrgVtmVP7tI3?= =?us-ascii?Q?s4dVsIWC2XXnp+DqDu5vdOIoAkXYNh+JeDuDYxKzAWChxnA2YFGn8Fax+xLQ?= =?us-ascii?Q?HFrBT4aLnDkw+LWvwFa7Hn9rR0p8h1eiC1eCPoT6Ku+ydtHvniJQH22DPp3g?= =?us-ascii?Q?9Ug5zkz7+vEdIOqA27LNZSW6hWjrVRYHmhs1kkxo3PVsKiilrj+1CLqYP1d7?= =?us-ascii?Q?zNce26z1tbQ7siy/K9Zd1n9NAVEHYmPbYwgeZYjm/Nf4tz5EyoHoME9Uh/U4?= =?us-ascii?Q?P1aZeIWHCA3SEA+5lTVjgWnfe7QbiFPJW7XZ5/gpBRpqdRKV/3EpG/dJwJVZ?= =?us-ascii?Q?WNV848m0zZkwxuTVOZXVEcL5Lbyx3XiXzfmfJK6KDOLY1dKFvkDC7sZDC1S3?= =?us-ascii?Q?FIz/sEGm8giraue3vuVobzchp0boYSFfm4YaKycT6f4epviJ+4ToMjnbTiwj?= =?us-ascii?Q?XrTiCqSFjvivmtvS5rTeu1W/Nm3X0/n71cl0rJYas8zH1UXF674nT3HEjYaL?= =?us-ascii?Q?75DGaWi147hOvoOd06HbRKtsuN1Djs1unOdBBGYljxvTqeoSEYFOHCnZI7FS?= =?us-ascii?Q?rXoLFg48vAvrPynArCEtsDQ/5rtiuvFp6SoDTULXxyl3Y3FoukOnwV9PPjYD?= =?us-ascii?Q?N36uXmIb26zEgKmXW4wgCxXYSnl+kmVyvX8oOsGhpIUWnRHe9W3ecSBLkoxF?= =?us-ascii?Q?3HURzdoQJgQKjScjH217dfJDnUafu4rTdo/qIuBKClWo8NdX9nL1KU+l2dax?= =?us-ascii?Q?5UOQnQwWpOJ7T5Io4WWHhDwfbKJxxeR3sUashRAADLBp7vVhtF7Ev2NVLcio?= =?us-ascii?Q?Vta4CKIOz9ru+LmeB28rWRPAxI2902tF2Ja9GUpZBDcqtDBi3Pc9oc46T0yn?= =?us-ascii?Q?xH5iUWcouxEblabs8bWI+BwozaG7AhPUjNagf+dxQL2AI9JSOOfPnZMHNMHw?= =?us-ascii?Q?4DCrRzIy4I+KZDaGdY+xEXbiWGTzMGle5GoLts9l6waQOmOZoMp2vPpr7k9O?= =?us-ascii?Q?YX+zd2rRqQgp8w2itj4ir/NdOzELkpxfAAkpZcgH1aMrh8rAwgXNiKf5xk2s?= =?us-ascii?Q?qHyrMMCHzxRwWrynjdxRdgydHUDfzWiSfNKUwOzghdx7clGS+n7yUYCE6qFT?= =?us-ascii?Q?u08Nz2VweZgf75zfeWlr3W9NhrGBf5YQFSkQjnt+83qG2Xxt4jnCyVo+PMe6?= =?us-ascii?Q?Dlunq5N2rs45F5GsGzRCdoJEBi4dYOYGmGok5QOLGckkzgiNr/sGxGdhNKWe?= =?us-ascii?Q?OwDdnw4u6ZdTdSGnORouiHYasbx+eOwFTWrbtx4a7yFBmo/THm+zdx5x5q1t?= =?us-ascii?Q?TTuyC60pLVWuwojeeKjNWx6uSBND7ayghLJz0ZzG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17f9364e-190b-44dd-6bec-08daa1ad086c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2022 23:56:16.8927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1G0Fa4Rs4qR755R6/VDbPPH/mOO7wJ3jE0u8MLQyumsn3aQJLwhS3LHgx8ylLXoADoxyty32Qjqv1Ong2zx79g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6783 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Aryeh, Thank you for testing. Reviewed-by: Ankit Sinha > -----Original Message----- > From: Chen, Aryeh > Sent: Wednesday, September 21, 2022 12:34 AM > To: Sinha, Ankit ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric > Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl >=20 > Hi Ankit, >=20 > Add a change to remove Name(_ADR, 0x00000000) from edk2- > platforms\Platform\Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl > It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU > openboard bios. >=20 > =3D=3D=3D Acpidump =3D=3D=3D > Signature "DSDT" > Length 0x000000FD (253) > Revision 0x01 (1) > Checksum 0x33 (51) > OEM ID "INTEL " > OEM Table ID "MIN " > OEM Revision 0x00000000 (0) > Creator ID "INTL" > Creator Revision 0x20210930 (539035952) > DefinitionBlock ("DSDT.AML", "DSDT", 0x01, "INTEL ", "MIN ", 0x000000= 00) > { > Scope(_SB) > { > Device(PCI0) > { > Name(_HID, EISAID("PNP0A08")) > Name(_CID, EISAID("PNP0A03")) > Name(_SEG, Zero) > Method(^BN00, 0, NotSerialized) > { > Return(Zero) > } >=20 > =3D=3D=3D Original mindsdt.asl =3D=3D=3D > Scope(\_SB) { > //---------------------------------------------------------------------= ------ > // Begin PCI tree object scope > //---------------------------------------------------------------------= ------ > Device(PCI0) { // PCI Bridge "Host Bridge" > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2 > host hierarchy > Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't > understand the new HID > Name(_SEG, 0) > Name(_ADR, 0x00000000) > Method(^BN00, 0){ return(0x0000) } // Returns default Bus number f= or > Peer PCI busses. Name can be overriden with control method placed directl= y > under Device scope > Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the R= oot > PCI Bus >=20 > Thanks, > Aryeh >=20 > -----Original Message----- > From: Sinha, Ankit > Sent: Tuesday, September 13, 2022 4:54 AM > To: Chen, Aryeh ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric > Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl >=20 > Hi Aryeh, >=20 > Can you please post the test results for this change. It would be good to= note > that there is no change in behavior in the OS. >=20 > Thank you, > Ankit >=20 > > -----Original Message----- > > From: Chen, Aryeh > > Sent: Sunday, September 11, 2022 10:18 PM > > To: devel@edk2.groups.io > > Cc: Chen, Aryeh ; Chiu, Chasel > > ; Desimone, Nathaniel L > > ; Oram, Isaac W > > ; Sinha, Ankit ; Gao, > > Liming ; Dong, Eric > > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl > > > > From: Aryeh Chen > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 > > > > According to ASL Coding Guidelines - Device Identifiers "A Device > > should contain either an _ADR or a _HID object, never both." > > , so remove _ADR due to _HID exist. > > > > Signed-off-by: Aryeh Chen > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > > Cc: Ankit Sinha > > Cc: Liming Gao > > Cc: Eric Dong > > --- > > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > index 0d94472450..4efb8709ac 100644 > > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > > @@ -27,7 +27,6 @@ DefinitionBlock ( > > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mod= e2 > > host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy= OS > > that doesn't understand the new HID Name(_SEG, 0)- Name(_ADR= , > > 0x00000000) Method(^BN00, 0){ return(0x0000) } // Returns defaul= t Bus > > number for Peer PCI busses. Name can be overriden with control method > > placed directly under Device scope Method(_BBN, 0){ return(BN00()= ) } > // > > Bus number, optional for the Root PCI Bus Name(_UID, 0x0000) // > Unique > > Bus ID, optional-- > > 2.26.2.windows.1