From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.5386.1654557364249812405 for ; Mon, 06 Jun 2022 16:16:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=llEtP/ZL; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654557364; x=1686093364; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dC7pBAkGGA+CSv7Ex55PEhCwaoUwILP6xat9M/ozIg8=; b=llEtP/ZLRYENOYKQMxR9jQ3I6wbNDhvVwAvW7SqpBXfPClMplpwSaKD3 1b84EPh+5BFEU5p/Nav4ddDHpUGLGuk83gpOdVb0m1J1c2126hF0CA8Rc yFIeL6lo0mX+bE/Eg3zdNuUg1Jo3IlRIQ7jDbUmCDuD5pHs+8/LqC4kY3 GjCKJDehsK4x0h5Jip1vcnnTiyOEgUQb87iipecberZXAlZJllIlogz0T Zeg9WBNnL8bCJrviUbpkCuMbHpjiSzIl4a1LxYptEINCTcEArWn6T1XQ5 K8usl22wxu11AQiTdYC9HZgtUuUEw5hIf3YaHIETx0mbspg+s0wo1vdbk g==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="276741173" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="276741173" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 16:16:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="647780867" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP; 06 Jun 2022 16:16:01 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 6 Jun 2022 16:16:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 6 Jun 2022 16:16:01 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 6 Jun 2022 16:16:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hd+27UZZXD/dPrLAYQufZOxweURha0rFB7pC5Y/AEkQanbyEl5Ig2zqEFh1giuyumTZdBJoEddZX5nkxt7lS4OkbZYiWnB3XZJzmPB6Krv144Zhss8YgcsKMJ8ULUBB3jfAuN/PhaK6lud34NWOlYpRwR+E4nQkS+Et0qIH2UYoxa0WyD6ypjrIDIHgBQglusR6B3vHMS46UqYB23tEOTFB4CkWsdnPEP310E6SQSq6MizLi7ctuCmI8XS5juR3i6e1CNk33C1Qx8U3BePyiM+Dv43rnYU4hp4a/R+hy+6jaoCsIFyZsu0PJzLNbzagA4zgmPQ0hdA9dh0CupuEtaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4lw0L/QMfAaLv7bE/yoEaGQ/9mLJPaQSeoivoowH8Ys=; b=B5XWVYxUp86o9y1fFvqLT4vgIr8pqslMhakfwKz09dHJ0Rw7w70xK2ScghK3ayj8qpV0+sFkH+fltFAHws3ORlxQ9t8FxPItgIAWU9HRGXrFkOvFGyz9WlzIVxqJDyQw9r5A34gmnzvuOFS9wMs19juGIThelURQTMkSZYmOgVUHjAczmDGmAX2FRgWVwKZRYhrO2bNf7GjHIziZyM03yhxhBjCUEUUIbQpe5qQlApidFzAJfYxoGkk7TLADdNV3v/HFq2+1HLdoBmjaDfLrOzm63lX753p9lU3GItmREt+LiscEZb2CllI0IGGQ9Xd7VhOhjHL41QAhYDZAadoxVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by SN6PR11MB3454.namprd11.prod.outlook.com (2603:10b6:805:c1::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.18; Mon, 6 Jun 2022 23:15:58 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::c5f4:1b74:1a8f:4c0c]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::c5f4:1b74:1a8f:4c0c%9]) with mapi id 15.20.5314.018; Mon, 6 Jun 2022 23:15:58 +0000 From: "Sinha, Ankit" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Kubacki, Michael" , "Soller, Jeremy" Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs Thread-Topic: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs Thread-Index: AQHYefqDMoOF9PJJ806dFsgwfKrCra1DAsRQ Date: Mon, 6 Jun 2022 23:15:58 +0000 Message-ID: References: <20220606230925.3706-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20220606230925.3706-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1472064-45a4-415e-d99f-08da48128403 x-ms-traffictypediagnostic: SN6PR11MB3454:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SpltxpB5RqraXiVM7YgLW3n6EpZIqsMrfbZZqTAuR3mB2XJ3zwNrNhV6JPbUyDhTXh/7NFkzRHL+ncXpRkUvkKIKVPWrdyI/UmNCtTHQVQVTewzhoxNWxJhKHd5t/N7f+QCVMJqoacOWCwuKBIrXUE0J1A9qeLIGw6JPsRJaBDthNDTch8w1r49llUKSXj0zP6d0lUOZwnQCfT2Axl8fcZ50X8I991tt+Fy0Ibbr6CUPwb0HwdARuusSo0XIKFuik5mUzJRt+4ymRdMgPoq6XgpfhaLaZQSx/fGUA9xek8LW/3Zn9bKh81/HYAeKimd4TWGDEfExevrpsOvrZ3OHK2vy2pZgdBzjQhFRd6cbEUsYmggTtVGY/hRxhYP1CrZY+woUSmpocURsrUcnDvPRIgOz1YAUFJq8wkF0BzdIGlTCfAGyOkbB6GcC3FNbnwk+vpJ9f++i/7LiYs+neBIFKDZSdeX5vWKibWHWHs4/UIflNlQgHB+aI34Mt2iux0BdNc+KjcnH2kE7KTcDLhUNcZizr/TwJvbfWbvDfO/4jsQp0nOU1sHnozP5zRk95I1DJLyhxsailKTUaGaVwCe8kHZAeDrk5L/VaJKABOelCmaeUgaV3LGrE954IuT7l7Hdt/4bRBOm2qokLgty/a2W7OZWqhfjX0NAmsq8Hdmek8FHOaKJi2qNxJdlCwDHq/4tXyiyvZfBwfQPtWc4JpOERA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(8936002)(5660300002)(110136005)(54906003)(38070700005)(66946007)(52536014)(66556008)(66446008)(64756008)(66476007)(8676002)(76116006)(4326008)(508600001)(38100700002)(186003)(19627235002)(71200400001)(316002)(55016003)(33656002)(86362001)(122000001)(53546011)(82960400001)(26005)(6506007)(2906002)(9686003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gFvz0aknKkPcFSrsBK/DW68Rn4LKrrA0gDJUvv2CkzxQjjp5MqTlGXL6d5B5?= =?us-ascii?Q?bGj5ULrzOVDYcNxXPFYjAHxbGciiJ4hdIy6zXWJsK61lKXjWf68bveWtVDLb?= =?us-ascii?Q?UxVDyVlRes8bpBhMENDxB2DMjYXjNFXdwukFXQubgSOkXO41dovuxmV87d6x?= =?us-ascii?Q?5zBhV/ZZ8fjNN5xxVg5LEEflYxsEe/fxrpE9btDS8+EJT/icQdA51l/5V6eF?= =?us-ascii?Q?XvbMal3bnSL1Ojb8s/q/NV5cGN2NDTqvbF+q60uYguGNeRX94ZO10CKSuuZ+?= =?us-ascii?Q?mMnMSZftKL82ljCfOFLJOx3B6GkhuOtfbs3XjowrbytJ/ylwsSU2ZcGct+GE?= =?us-ascii?Q?2wYgm0VQMfIUWICLTFbPCBAFZVaCpgECMJuDiL+LGQVAiW8+BECuAHniV0tK?= =?us-ascii?Q?Fd7z17WWf1xeMqrue8EdIUB8zOeIbT9Qj3w9apbgJXvsegjcdKRpWtEfquYP?= =?us-ascii?Q?ml7Kebn/UVoZnBq5hKUyBvofUsTSx+1nX6xI8Znmu4Hafgbttki/CDj6fN0a?= =?us-ascii?Q?fB2kegEtv+/CmA+ykNEpX3GezUxp7Gztq21Zty68VBUg5lcuUA33++92I55f?= =?us-ascii?Q?JqaZcQ9q8IDlP5vGDl5oIEB3Ip9jhuo6YEnf5ywPOMbAza9Rq4q7OKGaeOKd?= =?us-ascii?Q?wE+B5Daxu6fZ5TK1oB3DJr/3p3w0W5gL0h8JYThaSNOcWD8hKwj8eV06eXzJ?= =?us-ascii?Q?gziUuwZIYqorr1DwyPIUvUxZfaXMEeRjA7o5ONMKiwjsCGrEtn6v4KLCQnYW?= =?us-ascii?Q?NjIs2oVo4Y36cy8DNf4vjN01IWf1UaWUFPuQqy/u/7wQdEYVouHlwy+RdBQM?= =?us-ascii?Q?j73J5m1aUys+7Hi8skXagEh8xXec8PhnkeZkOY3YYTrV0YNPEbzBzfNhwLV/?= =?us-ascii?Q?21EZ6jOn1UeFwZc1TkIdatDLyCf9ITRmA9p/syl5hdNto7OTs4wnZ9cdb6O0?= =?us-ascii?Q?mMynPeUIfldDqCWPp5n3TWDS67O1w/YOUKhvc9KTsL7t3aRAnyEK/9dIpGqI?= =?us-ascii?Q?sLHE7GouL59ceuFhbGS+oh6o8s/QC4G2mdw7dZU0k8POs8Cbv60XbAySzxje?= =?us-ascii?Q?HOrH779XskAEZo3R72VirMX8c3VjeydxjRMSa32Xea5/JTS6AA0DScXje3Ei?= =?us-ascii?Q?4KVw+zjf08wL1kalvz4ydeoiZCRy/tf+9uL/X8ki89vy6x6OFGIJeKAF1e6I?= =?us-ascii?Q?v9NLp5t8/w4UHFUy6FCPpuuB46sdAuLBZjWMI/UFjgLHord837dTyM+3UZw2?= =?us-ascii?Q?T5z9wdml+7qzvmfpHgTFyxyZXIeJp7D6PmXpGqAnLDVBgnjoAs8ArAxA+0fa?= =?us-ascii?Q?NZDAsJAmQvZzulBnEYULDtt/cIMHJkUFCrW6o848LRhSuHoK3gOr1+Sa183H?= =?us-ascii?Q?1FjskArn7wZeCep+l4ps9jSUfTy0NrIp302pViLNOL26XeQDuRusYHlGkzQM?= =?us-ascii?Q?gzgVVKKIUOIlnddck3xoEzhdSH2Oa9/MQ9R/e+y45IYCF1l4DdoYgnc6Ek6V?= =?us-ascii?Q?4lpvV+9kLwGvwrBh0boiDQwTxjaPWjp/rro6pf6cTF6nNbScWn9dZsuihWcS?= =?us-ascii?Q?AGGop70b6V+0LxUbGRJ1q0o66NXIVtYZB48mg6GdASwcSyDY5fgTGDsiujwo?= =?us-ascii?Q?TwvAasMAVYst4aCrgJvEYvx2eJWLlScPdIzjyokQge3F/hzaJvxl6oyTC8xO?= =?us-ascii?Q?dGC14fsJxBoo/jEVvsXoo5WT25oGHHSlTwQhelkg+XeDCNlUcr0A7KnfeX8C?= =?us-ascii?Q?NiroCx3xyA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1472064-45a4-415e-d99f-08da48128403 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2022 23:15:58.7333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ncsiH+19xB20N5fK/VLVhv0w5NTnnNvyM9BXfG9mhz/VUK2fAy0SZDvR3guh1+PwJtIb0Gwkq/CK23KPKtgq1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3454 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ankit Sinha > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Monday, June 6, 2022 4:09 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Sinha, Ankit > ; Kubacki, Michael > ; Soller, Jeremy > > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: > Add FSP Dispatch Mode PCDs >=20 > Adds missing FSP dispatch mode PCDs to the Galago Pro 3. >=20 > Cc: Chasel Chiu > Cc: Ankit Sinha > Cc: Michael Kubacki > Cc: Jeremy Soller > Signed-off-by: Nate DeSimone > --- > .../GalagoPro3/OpenBoardPkgPcd.dsc | 46 +++++++++++++++++-- > 1 file changed, 42 insertions(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > index 44dacdf082..28f044df5e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > @@ -1,7 +1,7 @@ > ## @file > # PCD configuration build description file for the GalagoPro3 board. > # > -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2022, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -40,6 +40,26 @@ > # > gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode|TRUE >=20 > + # > + # FALSE: The PEI Main included in FvPreMemory is used to dispatch all > PEIMs > + # (both inside FSP and outside FSP). > + # Pros: > + # * PEI Main is re-built from source and is always the latest= version > + # * Platform code can link any desired LibraryClass to PEI Ma= in > + # (Ex: Custom DebugLib instance, SerialPortLib, etc.) > + # Cons: > + # * The PEI Main being used to execute FSP PEIMs is not the P= EI Main > + # that the FSP PEIMs were tested with, adding risk of break= age. > + # * Two copies of PEI Main will exist in the final binary, > + # #1 in FSP-M, #2 in FvPreMemory. The copy in FSP-M is neve= r > + # executed, wasting space. > + # > + # TRUE: The PEI Main included in FSP is used to dispatch all P= EIMs > + # (both inside FSP and outside FSP). PEI Main will not be inclu= ded in > + # FvPreMemory. This is the default and is the recommended choic= e. > + # > + > gMinPlatformPkgTokenSpaceGuid.PcdFspDispatchModeUseFspPeiMain|TR > UE > + > # > # FSP Base address PCD will be updated in FDF basing on flash map. > # > @@ -52,6 +72,7 @@ > gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x00040000 > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 >=20 > +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1 > # > # FSP API mode does not share stack with the boot loader, > # so FSP needs more temporary memory for FSP heap + stack size. > @@ -63,6 +84,24 @@ > # since the stacks are separate. > # > gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > +!else > + # > + # In FSP Dispatch mode boot loader stack size must be large > + # enough for executing both boot loader and FSP. > + # > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 > +!endif > + > +!if (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) > || > +(gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) > + > +gSiPkgTokenSpaceGuid.PcdSiPciExpressBaseAddress|gEfiMdePkgTokenSpa > ceGui > +d.PcdPciExpressBaseAddress > + > +gSiPkgTokenSpaceGuid.PcdSiPciExpressRegionLength|gMinPlatformPkgTok > enSp > +aceGuid.PcdPciExpressRegionLength > +!else > + # > + # FSP Dispatch mode requires more platform memory as boot loader and > +FSP sharing the same > + # platform memory. > + # > + gSiPkgTokenSpaceGuid.PcdPeiMinMemorySize|0x5500000 > +!endif >=20 > [PcdsFeatureFlag.common] > ###################################### > @@ -222,7 +261,7 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|1000 > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmApSyncTimeout|10000 > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x20000 > - > +!if (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) > || > +(gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) > # > # In non-FSP build (EDK2 build) or FSP API mode below PCD are > FixedAtBuild > # (They will be DynamicEx in FSP Dispatch mode) @@ -242,6 +281,7 @@ > # 3: Place AP in the Run-Loop state. > # @Prompt The AP wait loop state. > gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|2 > +!endif >=20 > ###################################### > # Silicon Configuration > @@ -251,8 +291,6 @@ > gSiPkgTokenSpaceGuid.PcdHstiIhvFeature1|0xF2 > gSiPkgTokenSpaceGuid.PcdHstiIhvFeature2|0x07 >=20 > - > gSiPkgTokenSpaceGuid.PcdSiPciExpressBaseAddress|gEfiMdePkgTokenSpac > eGuid.PcdPciExpressBaseAddress > - > gSiPkgTokenSpaceGuid.PcdSiPciExpressRegionLength|gMinPlatformPkgToke > nSpaceGuid.PcdPciExpressRegionLength >=20 > ###################################### > # Platform Configuration > -- > 2.27.0.windows.1