From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.2866.1675191633670485328 for ; Tue, 31 Jan 2023 11:00:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=F30QXnFD; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675191633; x=1706727633; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Vb0x4cyjXLT4+vNLmW24jWcC6MOFBBbHb8jZvbs+0R0=; b=F30QXnFDuecAwghE1nHbSauwKqK6Hj6Q/KQXVUOV2RwbkiwPfV6D8xNv hypolQUwcFST4Cyqj4hiiQoXCMZa4OuRbJZ5OIdpCzihkOluJpFo2Sgja B6godcO20sfWhiQtTZYFYGcBdBUxhcbIs+0sIH4Hh+vI4DpkCTt+/eqyM IY9gA9gyFKQzMFS8ZH0TBK+B6gFtsiMXsu4P4g7ME5S9izJAQZawgk0oZ LCcAujbrlvZj22Ne/trG0I8wElPEml1v/pJbn21YyNMSfXrNlnFJn/arh 0kC+239YG/oeFBW2z3r5Aa1aCFHsm1ySvredMbUoQHBWgA7a4zh1h+peK A==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="392479229" X-IronPort-AV: E=Sophos;i="5.97,261,1669104000"; d="scan'208";a="392479229" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 11:00:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="614566545" X-IronPort-AV: E=Sophos;i="5.97,261,1669104000"; d="scan'208";a="614566545" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 31 Jan 2023 11:00:33 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 11:00:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 31 Jan 2023 11:00:32 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 31 Jan 2023 11:00:32 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 31 Jan 2023 11:00:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JTc4gYe1+nAWYnc8BAqsaAL/LK0v45DcDn35vqiU+ilmboPhFl+SwC6L7BadbrThoLtLw+rZgDw8XUgLh6biU0wTVB2nTt9sC5Y6GuIw3kdmOWBm3ltqSUKNvDCtjJrpUwLvs0zssoZC3QJ/1Nhs3DI+dp2OOKBvqceQyv+UcYg1NGAU1VOpSh8ArPA+naB1/tME2I8P19MRbFR9YSleull4tr4RD8jpQ3kOlN57VAvI/o8HcLgK7sEVlJASDNq1nuffNLHBH+VFzu4nPl62UEdfpmnWLYBP6c00v/sSJl10BB6nNBkC2FUtsp533iXtPMbsbYLikVh7wBQy5IQziQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bc1SVQg9jv/1uL5H+r2i4LWo72/UPbRq7ZwLHWwemG8=; b=bZyMfg5SjH93vw78a+0iJfCnMTX6U1en8I9DeUFF0IyOlg5jSVUdshizqHnNcbnE5wtOXvSN33qF2BJcWYORlMHW9u48IjvIxykxZhpyHN7JEG1RM1Ash+DmarK/JvKvmY4Z862Or2OpPoDph5eHinpCXowvTa/DZsSWf2mdSpKFtdcbJwSJ3xBF/ehxFWrkZ+Kja2pO9fZ4bxByJSgNrQDLOPDEj1M9JXA5VAORW7a6l+ebQO/8lFbTn3Kw4YBazVHI7vyoQRiKdkPCdJDxcjGdxGgkRJOn1h9CgIxk6jUwpsHYpXtFMVk7GZlMAxzCOnpXdagDL1YnqDEUyWVx/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by DS7PR11MB7908.namprd11.prod.outlook.com (2603:10b6:8:ea::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 19:00:27 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::cb81:40a2:223a:f7]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::cb81:40a2:223a:f7%4]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 19:00:27 +0000 From: "Ankit Sinha" To: "devel@edk2.groups.io" , "Chen, Aryeh" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 Thread-Topic: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 Thread-Index: AQHZNTdWEQlOieTmuU2Rvlw2k9HODK644M2A Date: Tue, 31 Jan 2023 19:00:27 +0000 Message-ID: References: <20230131054518.1576-1-aryeh.chen@intel.com> In-Reply-To: <20230131054518.1576-1-aryeh.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW5PR11MB5908:EE_|DS7PR11MB7908:EE_ x-ms-office365-filtering-correlation-id: 6c2dadcf-a462-40e4-6ab9-08db03bd6a6c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UWrQy6h4w5rRLnqlDDuHFP/iLMC+oKbgYpWtiNbz3+Ylsk91kxBi/9XCl4pALpFDoXyRG9KLADyd8mZrvRcbLWNxWG0kQifghUXldxU3RIBjjK9E4FdnFc5+xusvDUZyqQi28wI7hkD/RUsvL2bAYiXT9l2Qi8CHZGjrblu4/CUTaZfl3ZKsbw4fYbzNUY+5AUG9atVL2kInS78OWXGrznQX8LIAC3hSyrrXVTpVKH59DRIcylW5lW9kQuvBuBeYk+uvLiduI6ClpNDDvQ8upLOcCAcVkiuh/Vfxi13ZFfGA6rrUg/MxOlO/r4yCTYoOUybi8f7EKkkqGUlpSC5KjHi4ZlHUNetSXo12e/jirmWSQODAU095MXsDFm9VeM4Sa+VuY30CjUYcO1huqhIAEXY/59z4pPpcR+r2i6k9aCZD28O1jY/iUBV1uG3/DU9eNfFq1xlL49kOL+NgpoOfAwKFIJKAhs3mWx1u3q5zAioV9OcnsJx6MT3riY8ado8Asu4/7RqP243HDkWFdIOXUFszJGtGdWAaXwKbc9OI2p414VdcrVXuaLNYew/YnJDEsDH1p5N4TBuosj2TIlf2ITbV2HgnVOOGUiNzvOo4qd94+MCi1DDwEAj6xlhM/9jW8NpSRnv/UBDlW/DjcfObsDs0XDv9TwemMDCfD911UOBoXQIVA2ixDvlQNqGooHrNGT5bXS0yRf1bZban+hrSiMWZZaZPFxPyrgI7fhxjgJvv3bMiJDQD3tLCkqhyxU5mWzzeMfO3kZJtg76E4t9Pjw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199018)(110136005)(54906003)(5660300002)(6636002)(316002)(8936002)(122000001)(38100700002)(82960400001)(83380400001)(19627235002)(55016003)(52536014)(33656002)(7696005)(71200400001)(2906002)(53546011)(9686003)(26005)(6506007)(38070700005)(186003)(86362001)(478600001)(107886003)(966005)(66899018)(41300700001)(66946007)(66556008)(76116006)(66446008)(64756008)(4326008)(8676002)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SxGGfBhGQ/D6z3Oxg4JVIfTi90pxnGhib0fFc2R85gKgDtW3llKLkTOyNSsr?= =?us-ascii?Q?JE7bkedtoyYpaACFTCOYqkwenaMTia2+a//gLCkjBMY3rrpGNk/NT+98k9g5?= =?us-ascii?Q?YVXzFbHVmCIhCGCasG1/xw7xZLkN5tnG1qPjRUGgeLFXs9LeOPLV1IhYFBsl?= =?us-ascii?Q?szcE7J805/ES+qbXJG3mW9cYVtRIrHiUwkheOYey/kQNwVZxrv35gIeYd1fJ?= =?us-ascii?Q?fHlfjFsIP/MFtankqWTIU7Fek56q72sUBgbA+j+isGNAFJkzZoo8L8Y/R35L?= =?us-ascii?Q?/+5OOHAsBbT6meH6RCIgck7A0KlRXnjNgXdfZDPHI9C2r7MTbVGr2VG6xRgR?= =?us-ascii?Q?VZMN3IE2csm3bgDDndM1LKNb8exXRMhFVUYijV3mux5nic5e+bGaMramn28v?= =?us-ascii?Q?fMEIl/SYQWKLC7Kc9SG4OGdaanQ+HGRWDxdT9k1TXNv+DjG5zDvxypq/XkkO?= =?us-ascii?Q?wmuEP91/B8rRqUPk04a0aOuCqbFts51IftCpoLUDcr8qpC5IYtPqYDi9Ei2X?= =?us-ascii?Q?ARYL2mtGh22jgpxali6Vmw0OD/VlZ6Ex3cu2eDmgI/8o2JBnYfnKqb/DfiMO?= =?us-ascii?Q?Y8Dav8FvHunSGZoxqZM48Y4c9VKlxNbNRONO+S037lb5P8mLwFPKLos+FNzE?= =?us-ascii?Q?pRVlSEIqZekqcvSLIjuozOlgn3Vzocz3OqI9C0EfyOWyhx4ONPnq9bl3QmOX?= =?us-ascii?Q?wcb0plVfzxMWluKdnFVIXvExGbZpzCaPmMChsQIaQKjfDw1TTHCPpkhi6CpC?= =?us-ascii?Q?lLkBot8Wnbpy6wvL6bDkLal22T+uHYQ+BMCmDA4e4BZbRHx1V5iyJ8F+DtLb?= =?us-ascii?Q?PZPM6G7S+0BPUfoO0WtithfKgS48PtEK6FidWosfEcHWS0uSzZx8tG4QgUzz?= =?us-ascii?Q?AGR4q4xt5Pm93Wg2PvV9cwvWb/YjlGAdUi4symQqrr0qD7+wkX4ahR+bkCfW?= =?us-ascii?Q?YvJWq/8NmBr1cFhzJpG/cWYFh1JKp65itNYxpMM0RXqnuztuFSiIWHXhbIzN?= =?us-ascii?Q?rzaObAT6/a+Oqj9B699N/dCl42TlQF9KtkAedB549Nr+UC/Y7y1o8S4wj/tz?= =?us-ascii?Q?f7lpDx/hNA/d0exOIEmkfh6MzPWr1NR6FJY8T/37CmTYX6Uq9rDQ5yFmopiY?= =?us-ascii?Q?TPq6GXcFVkAt34aJYvmaVc5XMLNVkw0uF2o8Qc/VwE18JBmDj0wKDR6ukW96?= =?us-ascii?Q?W5HvX6YcJtdCyIxInSupL7PeWD/AoX2AxZTWYtz/IbApajxPQpNgj2w3xaao?= =?us-ascii?Q?QcVVZ8sQOqp54MLCpfhuZsw2gsam/EaBs6+c6w722VF7khfMBAuj/sovdJAl?= =?us-ascii?Q?TXnjnBCc+vwTtSprY9i3Vh8mI8h8CiV7YmB9leAp72oWopbE595heHyk1g70?= =?us-ascii?Q?zlfSvkJ9UKqS/4Hsbz6VgJ+i4YNUQTlMqxI7a4yCQqMXBShvpO6OxQ9bCHjH?= =?us-ascii?Q?8eyU5YkIhRHn6txcuJsTDZWvSeGu+9e1YygWPyE/j3C6utHCleID7OBcIjUH?= =?us-ascii?Q?d75xFy+0CDc8xkBzBEDfbnMT0x3D0cPTqHj34cAUSicXZ3SS+7I7TBNC9Q9f?= =?us-ascii?Q?ahiNg2g/ufBoLHJLL2gSIfLW4mcgBncgFSCRaRtP?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2dadcf-a462-40e4-6ab9-08db03bd6a6c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 19:00:27.1624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cver87uZmGtKwUyYeqYsQG+QznXT6l/Bw+OYBg5tEb1Zn2PQ9awq0fUEDrSbQpR93k7B7n+6xzoMT30p9zSusw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7908 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Aryeh, Is it possible to use a FixedPCD for "PCI0"/"PC00" string itself? That way = we don't have to keep adding conditional statements for future changes. It = will scale better. Declare in MinPlatformPkg.dec and provide the value in OpenBoardP= kg.dsc.=20 Thank you, Ankit > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chen, > Aryeh > Sent: Monday, January 30, 2023 9:45 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric > Subject: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD > PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 >=20 > From: Aryeh Chen >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4329 >=20 > To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on > MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to > \_SB.PC00 since Client ADL platform. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4 ++++ > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 + > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++ > 3 files changed, 8 insertions(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 4efb8709ac..b7361b6d44 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -23,7 +23,11 @@ DefinitionBlock ( > //--------------------------------------------------------------------= ------- // Begin PCI > tree object scope //---------------------------------------------------= ---------------------- > --+#if FixedPcdGetBool (PcdMinPciBridgePC00) =3D=3D 1+ Device(PC00) { = // PCI > Bridge "Host Bridge"+#else Device(PCI0) { // PCI Bridge "Host > Bridge"+#endif Name(_HID, EISAID("PNP0A08")) // Indicates PCI > Express/PCI-X Mode2 host hierarchy Name(_CID, EISAID("PNP0A03")) // > To support legacy OS that doesn't understand the new HID Name(_SEG, > 0)diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > index 3437bc489c..b3b45039cc 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf > @@ -40,6 +40,7 @@ > [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase > gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit+ > gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 [Depex] > gEfiAcpiTableProtocolGuid ANDdiff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..68a76db4de 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -139,6 +139,9 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|U > INT8|0x00010056 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x0000|UINT8|0x0001 > 0055 + # The PCD controls MinDsdt PciBridge+ > gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x > 00010057+ # # FADT Duty Offset - The zero-based index of where the > processor's duty cycle # setting is within the processor's P_CNT regist= er.-- > 2.26.2.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#99338): https://edk2.groups.io/g/devel/message/99338 > Mute This Topic: https://groups.io/mt/96647478/1772825 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20