From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.8703.1655319284385167652 for ; Wed, 15 Jun 2022 11:54:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GJu8crlo; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ankit.sinha@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655319284; x=1686855284; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NT9Jq5nWWJNhShfjaMEMz8X33QpJpCxlM6HghB7X6z4=; b=GJu8crloqry3D3DCCPodlAuSebBk9/wux7WgR9PUIDlAPZZrzTdS+mCD RpyeY5wMBfbhnrkENndLkjBg36Y4+G3z7OENgcjBqmxLn1xkhNlLHpnfA qntZheuO5jZAiKVn4ZS72fHmmhdyZkSXjeQEDjfZBdZQ6saTXSNQ2Xx/R fjoh3EIX0X8STdYM6RCDKI23ISY9FpcsfYmJG7kiCUUyqrVl6+SSbgwhM v8FYYIWZxAI0AnS06qQmCSgpcvitQWltIeHuVfpcuwtfeECCNkULjaFD5 KTfv5nKFElQAnpyzbEvt5RRMPtzX545ycu9vK2LYVUIuu8Eate8MddJy+ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10379"; a="262097009" X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="262097009" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2022 11:54:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,302,1647327600"; d="scan'208";a="831211675" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 15 Jun 2022 11:54:22 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 15 Jun 2022 11:54:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 15 Jun 2022 11:54:22 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 15 Jun 2022 11:54:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dcs2q29XaYPRrL+KdWtAi5MhaXvVazxGZME2u1Be/9RuGZIhW8SRKsBG6osASRoYjfejJT+UfP0mW9pAIVjTcjCMmqeOfjten4LwlAaDZOKSwEks0XWC/k7tzQAieoQUiQA7sLS7KVfAsNLe7QITUvsJ6V3nJOj8viGRih4YJ9s+SM6vBzTPhFT/IYE72xdGgMm2ZOK82AAu84eFkoJGu7mSB0beDCXrmPwJlxmlPBjhYKJXs0t8oEB6L1bDuVyOFI9SuxXZBUzvEgpQMVnvc5OCa/E92S957elshYYhJho08qaqZd2zY5lhgSZB1knCUG7pYWj4SFDSzurKsTLW9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tJyiJvv0arhlJjtr2cK1V+hnmUi2gZbp+QmMfR9oDGk=; b=A4neIVyvrC6QJp1BmoNa1S4PWf4+7B95dHXGlFj4FBDQDMzztnpwDwTwr1bAdJNUpN98rQmp3w402G0We+BtfcbQhJwU2Ny7vM/A8zIDQs9DIgZspkkaGx1NeTRP16B6qkd3/qAG4hcLlZ0udZeFMnKDlDYSPYgzLsaxTADnSwG9u7q9C1zJYWVDfnBxk52+IWZ8f69r3flUF/DOdZzcGIfh0C+DJzdmDOy+dw+Gsjk5Z7E3JRfxdug7vB0Qr8sE6I5c9Us7SEEXyJ1JxsgmyhO7gKsAIiYKX6h5CTbMxkDXi0X2EFXT7mfyIbTaP/HzsGP/4hWlYGLiSy8HWmE0/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5908.namprd11.prod.outlook.com (2603:10b6:303:194::10) by DM4PR11MB5278.namprd11.prod.outlook.com (2603:10b6:5:389::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Wed, 15 Jun 2022 18:54:19 +0000 Received: from MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::c5f4:1b74:1a8f:4c0c]) by MW5PR11MB5908.namprd11.prod.outlook.com ([fe80::c5f4:1b74:1a8f:4c0c%9]) with mapi id 15.20.5353.014; Wed, 15 Jun 2022 18:54:19 +0000 From: "Sinha, Ankit" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update FADT-related PCD defaults to restore behaviour Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update FADT-related PCD defaults to restore behaviour Thread-Index: AQHYgN9bUFLTaJwWpUmjGEZTojPvIa1Q0KNg Date: Wed, 15 Jun 2022 18:54:19 +0000 Message-ID: References: <20220615174154.417436-1-benjamin.doron00@gmail.com> In-Reply-To: <20220615174154.417436-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 79d2cf22-e1c6-4281-5f1f-08da4f007466 x-ms-traffictypediagnostic: DM4PR11MB5278:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U2lwBkhizjyk3tE1CUia1jIzEcbTqOsNHfHH6Sdqsy595xIZ5oUjsitvLMmWJwvoXmDAl53iehAVW0N5HktC38UAQPRxl4Oqk1nOZks8i3Wf+f4kSGxqTgKNb4r+cuD2eG+HTkrS+UkXUCO+MTZWWAo2Hv8rmThogEleB79SwzVnpnwle/2MN7/5AZd1lyufTCrype31O+5iRG6g7TB4uk9e9vaeiAKAEHEgTmzHiKx7eFExA4h+uq3udVCsNWi6advHKu6yIzAK2An8Fqz6NTgHoyZG5d4OfPpJYT3vUTcNB1ovg5WP2vXy2nbU1OnJtfMbN1ZM2W/dj0WhHHh90aV4Xm5qSaFX/ke7WsOaGbmWEpNDki7fAQSfQFmV6cN5PDtgHC6mXA8dQSOLsxsl/ktncD8hyzbew8anVBRFvI0ixDg/ZmySBtfGXwuTdxoWYlEvJ2b+9lpTYeU3B6y+2sKTf1ZtAKBMu6K3h0IOrfro0hiKVS1VqxdsW5+VMHnYappqgfBcV1zEYTGpDMwEiMdsUlZ0sEjbEV/LhTE9corsPXoNz+NUMlceBMV087wmUWNIl8mFLJsCgPGiOlgooa9uWL/Sc3JYS9udTPKASc//cJGC3eWola4aauiHddm4+GGChEhCFXDkXipJxx/5R3+2/2FyRHfLtfH7iHI9IPL+dC+uQRXGkCDJVtclEizosF1Ec0kVgna89+xR6yE0rIFWiMfzCt+yBy18g22X64w/mluTCDhpVRorzhCEs+s6jqYKPLiw9AjvDI8gKppIhufV5CfTlH0WvzrhwHK/a9N0YzJv29Ph5Vog3kEuGJXqp+4kiuJrBBZ6LUO+HuGPDw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5908.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(38070700005)(966005)(71200400001)(122000001)(66556008)(66446008)(66946007)(4326008)(82960400001)(8676002)(76116006)(508600001)(86362001)(64756008)(66476007)(316002)(54906003)(110136005)(38100700002)(7696005)(186003)(6506007)(5660300002)(26005)(53546011)(107886003)(9686003)(83380400001)(15650500001)(2906002)(55016003)(52536014)(8936002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VLCvfHHaDv9w81UA0IhCHwGvoFR+/JmDC9OGMjascJaDEv2Y+AR6LcyCyyGA?= =?us-ascii?Q?eyqY7/dNh0oNgXCNfbd2BevsbSEcAjGDswB1VYa8xrk4FmSIalploDo8L+CS?= =?us-ascii?Q?T2W5gkBioNivag5TXMEZfoK1LgOL7d3P5NFg5R39jAoSo0ztRfAfKPn4C6ls?= =?us-ascii?Q?jTzkPQnMqh9wHuLCeAMiqZxgw/cgnAX3sIWL9KbIhA7Mwpq0NbnoV0pkN7ga?= =?us-ascii?Q?3D+IB8wod5KKY4c8HM00wBpz3/jSYPTly4ql65MVtZxh7mgKgxQ1oaG84LKO?= =?us-ascii?Q?3WCHe2GXjFogbP1ro+6MCrnI9Ge37pF1cQTvcwxWqn90mPyEXFwRVcqfjYKs?= =?us-ascii?Q?zqG0rR3Np414BjtVqouWi8ocRqjcYRcMHFCzYNaGmsy5Hn3t63MBrsLtwA9z?= =?us-ascii?Q?b6todscSmhOrLXc4HKz/43CySlZu2QcgbfDwVc4W1pKoSx6QFE9apEuzX7rk?= =?us-ascii?Q?SoRQeX7MyrQNwIVk/i9XZy/q/mqBUtZXNPiephxQK0fUDolSVBayXBzWniTn?= =?us-ascii?Q?MVG1XhhycgJEF1xMQn8v2x2S9ZUTwavyrSIAzSnGEc8eoFo7S92dNVyhAL5l?= =?us-ascii?Q?fCifGLhIo+KmdwbdGSXUDm2g0mrcS92W9UVAH9AbH/YIVvrR/gdZyRjJI17u?= =?us-ascii?Q?lkgNlmQIE46TloUwK36WjXqOcJA9DJJwiZp6ye0simkSVH59lNyhDzdQKU99?= =?us-ascii?Q?pgsyHNbVjN/5KBZTvL/QtNy7oxicDRBus1vA0H21qWi3BOrU65BfTAsrl9Tn?= =?us-ascii?Q?TkpHVVe2/gwSUq4ND6MF8hGZZGFOJKPixC8lgnv5fzcAFvO+wunsL2B33m93?= =?us-ascii?Q?HgaGGws/E+C7tJK2IJ9BdixSELVsmrsvxTdEvA+w3bkUXbGxWB23ugKBsyG9?= =?us-ascii?Q?/QTs8NXiyYoJ/ts+OKhE9x/6y7fNYZB9TsiA/UFVOencdw3h9BFi0j0h4DJq?= =?us-ascii?Q?q3Nffqp0cVSupBLNdPwJG0hvFp1AeYlbRcj+kwUkkuUSqdohMAgJJvgsBuv4?= =?us-ascii?Q?AEkqcFzuabWfEbrehQ4vzY2IshHtUlWVM2FLUROy12c9809nKPSoij2wRFfF?= =?us-ascii?Q?3/mjcTMYEp7b+uiW6gGliOKE7qmWg5zgUPKsV9Vv7brVP8mr7D5yQHo2bR/W?= =?us-ascii?Q?GtxBbezsSGMF04lqiybcnxTQzLUJIuIasFvMzDauxx/0w3EMPtELNLMgqoXU?= =?us-ascii?Q?57cDFjnrRIW+eBzgX8HhE1wMMtFK6wCvciFPzGbe5Emm8sHxNe9OXPd3iQEN?= =?us-ascii?Q?zJZUfJhK/UirW/lVihlQ38JNND0Lmf/1pXxeHtSvIr9B7FR/gjqpdUtnXsCt?= =?us-ascii?Q?srqDyTRZujYy7nBPOhB9Vf+aoQ58VIrQz1M9UWJn53wbkymb78SZ7up89kEG?= =?us-ascii?Q?lW2tiNqRakbIRBIrxqBBmzbWDHJp49aH4Y72QQr3tnpgXRQrztQjh9y/LItK?= =?us-ascii?Q?7iQNk6B+hNiHNOe0xNxVQBipzIPlREJ7EVucozqWOI0ZtGpwbZuHS/CIFLR4?= =?us-ascii?Q?u8jIDOmI1yuj/4GYtFtRedWvcJs2z0N4Ke1TmXhPmanTRdK8qw9HWW3z6hr8?= =?us-ascii?Q?3r7dqqYfSHgaBZP0vZmQd1FjmrnmGPU2QB7Mtr/e+we47xv+LgkpGj5S3GQ/?= =?us-ascii?Q?Ezn7pX4iiPSNSEDdJxJ+2o9wqrIXyEvcm+goG32GQiC+8p0n/EjotNAdvyni?= =?us-ascii?Q?j++VnyqDT2I3YAw0nOLhZ2r/QujjcXjLzmnyYGpGpYXFvDq5QhaqLF0cB/eG?= =?us-ascii?Q?jo3ezZu7KA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5908.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79d2cf22-e1c6-4281-5f1f-08da4f007466 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 18:54:19.7181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3WmeT+NNuKQThgrAK9khYYtruQt6HPfDIMTmzHX6AFFpAfxM39N3JpfV2bXaAAn0LsF3zEDBjJ27n0BYs4I3BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5278 Return-Path: ankit.sinha@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you for taking care of the follow up Benjamin. Reviewed-by: Ankit Sinha > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Benjamin Doron > Sent: Wednesday, June 15, 2022 10:42 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric ; Sinha, Ankit > Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update > FADT-related PCD defaults to restore behaviour >=20 > Commit f427247 (MinPlatformPkg: Add PCDs to update FADT entries from > board package) modified AcpiPlatform flow, altering the FADT for all > platforms. Now, because `FadtHeader->Gpe0BlkLen =3D=3D 0`, the Linux kern= el > prints "irq 9: nobody cared ..." - GPE status cannot be retrieved and at = least > ACPI SCIs cannot be handled correctly. As the size of this register is th= e same > on Skylake/Kabylake and TigerLake, update the PCD default value. >=20 > Several FADT register block AccessSize PCDs are updated as well. These fi= elds > too are the same between Skylake/Kabylake and TigerLake. However, other > fields differ between platforms, such as GPE0 address and the removal of > PM{1,2}* addresses, which should be handled in a follow-up. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > Cc: Ankit Sinha > Signed-off-by: Benjamin Doron > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 68ab1d702d6a..9549c355b122 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -123,18 +123,18 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850 > |UINT16|0x00010039 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UI > NT16|0x0001003A > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT1 > 6|0x0001003B- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x > 0001003C+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x20|UINT8|0x > 0001003C > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT1 > 6|0x0001003D > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x000100 > 40- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8 > |0x00010042+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x01|UINT8 > |0x00010042 - > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UI > NT8|0x00010043+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x02|UI > NT8|0x00010043 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UI > NT8|0x00010044- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x00|UI > NT8|0x00010045+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x02|UI > NT8|0x00010045 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize|0x00|UI > NT8|0x00010046 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize|0x00|UIN > T8|0x00010047- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT > 8|0x00010048- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8 > |0x00010049+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x03|UINT > 8|0x00010048+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x01|UINT8 > |0x00010049 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8 > |0x0001004A > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId| > 0x00|UINT8|0x0001004B-- > 2.36.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#90537): https://edk2.groups.io/g/devel/message/90537 > Mute This Topic: https://groups.io/mt/91781863/1772825 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20