[edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
(board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (3):
  MinPlatformPkg: Add FADT duty offset and duty width PCDs
  MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
  SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
 7 files changed, 29 insertions(+), 4 deletions(-)

-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 1/3] MinPlatformPkg: Add FADT duty offset and duty width PCDs

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds new PCDs to allow the duty width and duty offset values in the
FADT to be customized during package integration.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
index e38617ce20fd..22f371ee1ec8 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
@@ -115,6 +115,21 @@ [PcdsFixedAtBuild, PcdsPatchableInModule]
   gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x90000025
   gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x90000026
   gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000027
+  #
+  # FADT Duty Offset - The zero-based index of where the processor's duty cycle
+  # setting is within the processor's P_CNT register.
+  #
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset|0x01|UINT8|0x90000028
+  #
+  # FADT Duty Width - The bit width of the processor's duty cycle setting value in the P_CNT
+  # register. Each processor's duty cycle setting allows the software to select a nominal
+  # processor frequency below its absolute frequency. A duty width value of zero indicates
+  # the processor continuously runs at its base frequency.
+  #
+  # For more details about how the frequency is calculated, refer to the Fixed ACPI Description
+  # Table (FADT) section of the ACPI Specification.
+  #
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth|0x00|UINT8|0x90000029
 
   gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize|0x65|UINT32|0x20000500
   gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize|0x30|UINT32|0x20000501
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 2/3] MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Updates the FADT DUTY_OFFSET and DUTY_WIDTH values during boot in the
function PlatformUpdateTables() along with other previously updated
values in the FADT.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c   | 3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c      | 4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 05fc7799fb13..508de9101306 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -1226,6 +1226,9 @@ PlatformUpdateTables (
       FadtHeader->XGpe1Blk.AccessSize     = 0;
     }
 
+    FadtHeader->DutyOffset = PcdGet8 (PcdFadtDutyOffset);
+    FadtHeader->DutyWidth = PcdGet8 (PcdFadtDutyWidth);
+
     DEBUG ((DEBUG_INFO, "ACPI FADT table @ address 0x%x\n", Table));
     DEBUG ((DEBUG_INFO, "  IaPcBootArch 0x%x\n", FadtHeader->IaPcBootArch));
     DEBUG ((DEBUG_INFO, "  Flags 0x%x\n", FadtHeader->Flags));
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
index 3418e960972f..70b769b84693 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
@@ -35,8 +35,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_ACPI_P_LVL3_LAT           0x03E9 // 1001
 #define EFI_ACPI_FLUSH_SIZE 0x0000
 #define EFI_ACPI_FLUSH_STRIDE 0x0000
-#define EFI_ACPI_DUTY_OFFSET  0x01
-#define EFI_ACPI_DUTY_WIDTH 0x00
+#define EFI_ACPI_DUTY_OFFSET          0x00  // To be fixed during boot
+#define EFI_ACPI_DUTY_WIDTH           0x00  // To be fixed during boot
 
 #define EFI_ACPI_DAY_ALRM   0x0D
 #define EFI_ACPI_MON_ALRM   0x00
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
index 99adf9c381c9..59ef5e2e544e 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
@@ -64,6 +64,8 @@ [Pcd]
   gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile
   gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch
   gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth
 
   gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
-- 
2.28.0.windows.1

[edk2-platforms][PATCH v1 3/3] SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Updates the FADT DUTY_OFFSET and DUTY_WIDTH values during boot in the
function PlatformUpdateTables() along with other previously updated
values in the FADT.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   | 3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      | 4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf | 2 ++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c
index 1edac89240fa..b06119f5eae7 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c
@@ -1328,6 +1328,9 @@ PlatformUpdateTables (
       FadtHeader->XGpe1Blk.AccessSize = 0;
     }
 
+    FadtHeader->DutyOffset = PcdGet8 (PcdFadtDutyOffset);
+    FadtHeader->DutyWidth = PcdGet8 (PcdFadtDutyWidth);
+
     DEBUG(( EFI_D_ERROR, "ACPI FADT table @ address 0x%x\n", Table ));
     DEBUG(( EFI_D_ERROR, "  IaPcBootArch 0x%x\n", FadtHeader->IaPcBootArch ));
     DEBUG(( EFI_D_ERROR, "  Flags 0x%x\n", FadtHeader->Flags ));
diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c
index d1fe98e24bc7..652f1f2e87af 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c
@@ -34,8 +34,8 @@
 #define EFI_ACPI_P_LVL3_LAT           0x03E9 // 1001
 #define EFI_ACPI_FLUSH_SIZE           0x0000
 #define EFI_ACPI_FLUSH_STRIDE         0x0000
-#define EFI_ACPI_DUTY_OFFSET          0x01
-#define EFI_ACPI_DUTY_WIDTH           0x00
+#define EFI_ACPI_DUTY_OFFSET          0x00  // To be fixed during boot
+#define EFI_ACPI_DUTY_WIDTH           0x00  // To be fixed during boot
 
 #define EFI_ACPI_DAY_ALRM             0x0D
 #define EFI_ACPI_MON_ALRM             0x00
diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf
index 7dfd0832a308..c6198fb76307 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf
+++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf
@@ -61,6 +61,8 @@ [Pcd]
   gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile
   gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch
   gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset
+  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth
 
   gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
-- 
2.28.0.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Sinha, Ankit]

Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Monday, April 11, 2022 1:58 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add
> FADT duty offset and width PCDs
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in
> their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the
> change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>   MinPlatformPkg: Add FADT duty offset and duty width PCDs
>   MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>   SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> |  3 +++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |
> 4 ++--
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Acp
> iPlatform.c   |  3 +++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fad
> t/Fadt.c      |  4 ++--
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> |  2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15
> +++++++++++++++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Acp
> iPlatform.inf |  2 ++
>  7 files changed, 29 insertions(+), 4 deletions(-)
> 
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#88721): https://edk2.groups.io/g/devel/message/88721
> Mute This Topic: https://groups.io/mt/90405218/1772825
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.sinha@intel.com]
> -=-=-=-=-=-=
> 

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Reminder to review this series.

Ankit Sinha has reviewed it but need a maintainer to review and merge.

On 4/11/2022 4:58 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
> values in their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
> keep the change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
>   Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
>   Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
>   Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
>   7 files changed, 29 insertions(+), 4 deletions(-)
> 

Re: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Chiu, Chasel]

Thanks Michael!
For this patch series: Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, April 12, 2022 4:58 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty
> offset and width PCDs
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
> 
> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values
> in their build files.
> 
> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep
> the change in sync with the source MinPlatformPkg module.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Michael Kubacki (3):
>   MinPlatformPkg: Add FADT duty offset and duty width PCDs
>   MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>   SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
> 
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> |  3 +++
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
> |  4 ++--
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
> piPlatform.c   |  3 +++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa
> dt/Fadt.c      |  4 ++--
>  Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
> |  2 ++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    |
> 15 +++++++++++++++
> 
> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
> piPlatform.inf |  2 ++
>  7 files changed, 29 insertions(+), 4 deletions(-)
> 
> --
> 2.28.0.windows.1

Re: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Thanks Chasel. I pushed a branch rebased on the latest master branch 
with R-b tags here in case that helps with merging:

https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Regards,
Michael

On 4/25/2022 12:08 AM, Chiu, Chasel wrote:
> 
> Thanks Michael!
> For this patch series: Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> 
>> -----Original Message-----
>> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
>> Sent: Tuesday, April 12, 2022 4:58 AM
>> To: devel@edk2.groups.io
>> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
>> <nathaniel.l.desimone@intel.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
>> Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty
>> offset and width PCDs
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>
>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values
>> in their build files.
>>
>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep
>> the change in sync with the source MinPlatformPkg module.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (3):
>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>
>>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
>> |  3 +++
>>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
>> |  4 ++--
>>
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
>> piPlatform.c   |  3 +++
>>
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa
>> dt/Fadt.c      |  4 ++--
>>   Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf
>> |  2 ++
>>   Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    |
>> 15 +++++++++++++++
>>
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac
>> piPlatform.inf |  2 ++
>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>
>> --
>> 2.28.0.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Another reminder to merge this series. Chasel has added his review and 
that is in this branch:

https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Thanks,
Michael

On 4/22/2022 10:04 AM, Michael Kubacki wrote:
> Reminder to review this series.
> 
> Ankit Sinha has reviewed it but need a maintainer to review and merge.
> 
> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>
>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>> values in their build files.
>>
>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>> keep the change in sync with the source MinPlatformPkg module.
>>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Michael Kubacki (3):
>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>
>>   
>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        
>> |  3 +++
>>   
>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           
>> |  4 ++--
>>   
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   
>> |  3 +++
>>   
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      
>> |  4 ++--
>>   
>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      
>> |  2 ++
>>   
>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    
>> | 15 +++++++++++++++
>>   
>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>> |  2 ++
>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Another reminder to look at this patch.

Thanks,
Michael


On 4/29/2022 4:07 PM, Michael Kubacki wrote:
> Another reminder to merge this series. Chasel has added his review and 
> that is in this branch:
> 
> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
> 
> 
> Thanks,
> Michael
> 
> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>> Reminder to review this series.
>>
>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>
>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>
>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>> values in their build files.
>>>
>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>> keep the change in sync with the source MinPlatformPkg module.
>>>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Eric Dong <eric.dong@intel.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> Michael Kubacki (3):
>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>
>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>> |  3 +++
>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>> |  4 ++--
>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>> |  2 ++
>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Reminder

On 5/10/2022 1:34 PM, Michael Kubacki wrote:
> Another reminder to look at this patch.
> 
> Thanks,
> Michael
> 
> 
> On 4/29/2022 4:07 PM, Michael Kubacki wrote:
>> Another reminder to merge this series. Chasel has added his review and 
>> that is in this branch:
>>
>> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
>>
>>
>> Thanks,
>> Michael
>>
>> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>>> Reminder to review this series.
>>>
>>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>>
>>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>>
>>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>>> values in their build files.
>>>>
>>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>>> keep the change in sync with the source MinPlatformPkg module.
>>>>
>>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>
>>>> Michael Kubacki (3):
>>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>
>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>>> |  3 +++
>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>>> |  4 ++--
>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>>> |  2 ++
>>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>>

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Michael Kubacki]

Can someone seriously respond?

This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit 
now has a similar change out but I'd like to see if this can get in and 
that be rebased on it since this has been out for so long and has the 
primary change needed for our integration.

Thanks,
Michael

On 5/13/2022 1:42 PM, Michael Kubacki wrote:
> Reminder
> 
> On 5/10/2022 1:34 PM, Michael Kubacki wrote:
>> Another reminder to look at this patch.
>>
>> Thanks,
>> Michael
>>
>>
>> On 4/29/2022 4:07 PM, Michael Kubacki wrote:
>>> Another reminder to merge this series. Chasel has added his review 
>>> and that is in this branch:
>>>
>>> https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 
>>>
>>>
>>> Thanks,
>>> Michael
>>>
>>> On 4/22/2022 10:04 AM, Michael Kubacki wrote:
>>>> Reminder to review this series.
>>>>
>>>> Ankit Sinha has reviewed it but need a maintainer to review and merge.
>>>>
>>>> On 4/11/2022 4:58 PM, Michael Kubacki wrote:
>>>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543
>>>>>
>>>>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
>>>>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
>>>>> values in their build files.
>>>>>
>>>>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
>>>>> keep the change in sync with the source MinPlatformPkg module.
>>>>>
>>>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>>>> Cc: Eric Dong <eric.dong@intel.com>
>>>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>>>>
>>>>> Michael Kubacki (3):
>>>>>    MinPlatformPkg: Add FADT duty offset and duty width PCDs
>>>>>    MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
>>>>>    SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width 
>>>>> PCDs
>>>>>
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c 
>>>>> |  3 +++
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c 
>>>>> |  4 ++--
>>>>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
>>>>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
>>>>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf 
>>>>> |  2 ++
>>>>>   7 files changed, 29 insertions(+), 4 deletions(-)
>>>>>

Re: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> 
Sent: Monday, April 11, 2022 1:58 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (3):
  MinPlatformPkg: Add FADT duty offset and duty width PCDs
  MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
  SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
 7 files changed, 29 insertions(+), 4 deletions(-)

--
2.28.0.windows.1

Re: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

[Nate DeSimone]

The series has been pushed as ~3018b1f..61af470

-----Original Message-----
From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com> 
Sent: Monday, April 11, 2022 1:58 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543

Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Michael Kubacki (3):
  MinPlatformPkg: Add FADT duty offset and duty width PCDs
  MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
  SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c                        |  3 +++
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c                           |  4 ++--
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c   |  3 +++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c      |  4 ++--
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf                      |  2 ++
 Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec                                    | 15 +++++++++++++++
 Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
 7 files changed, 29 insertions(+), 4 deletions(-)

--
2.28.0.windows.1