Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

["Kuo, Ted" <ted.kuo@intel.com>]

Hi Andrew,

Please see my inline comment.

Thanks,
Ted

-----Original Message-----
From: Andrew Fish <afish@apple.com> 
Sent: Thursday, April 7, 2022 8:06 AM
To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
Cc: Kuo, Ted <ted.kuo@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
Subject: Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit



> On Apr 6, 2022, at 4:57 PM, Ni, Ray <ray.ni@intel.com> wrote:
> 
>> -; UINT32
>> +; UINTN
>> ; EFIAPI
>> -; AsmReadEsp (
>> +; AsmReadStackPointer (
>> ;   VOID
>> ;   );
>> ;------------------------------------------------------------------------------
>> -global ASM_PFX(AsmReadEsp)
>> -ASM_PFX(AsmReadEsp):
>> +global ASM_PFX(AsmReadStackPointer)
>> +ASM_PFX(AsmReadStackPointer):
>>     mov     eax, esp
>>     ret
>> 
> 
> I guess it's possible that bootloader sets up the stack above 4G.
> If that's the case, above code doesn't work.
> 
> 

Is there an issue with the SecSwitchStack too?
[Ted]: I believe we already handled it in IntelFsp2Pkg/FspSecCore/X64/Stack.nasm in the patch [edk2-devel][PATCH v3 4/8] IntelFsp2Pkg: FspSecCore support for X64.

Thanks,

Andrew Fish

> 
> 
> 
>