From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.1321.1649293848663370651 for ; Wed, 06 Apr 2022 18:10:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QNty16fY; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ted.kuo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649293848; x=1680829848; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cc8sduazx5PaqgbskspTxbFxLL6V/6xB/1ASY7NvvuY=; b=QNty16fY1AchYn/qm38rLALt3tl9p19WmRuNsJSYKlNEotTCRtrui6Gt sAL709/LP9GHPzmOEmxd4PYhaFBBg0Kh9XE0UTxyP/XS2OezigMu1w9OD AC6gj8B5OWfS3GrAKThk2geuy34jNuXEJ1jierHdVK2BetdA4DDCmEXjj AukousmSlWs8Ir5tFA8rDDMlNhb01/wirFH1UqPZLyc67sWsHPT6GIovA fdBJOedVboP8mcXsXCn+rup3ywl0HnSzUuseDgvuB8g1nxPxixWO3ps0h 8anqVJpbG0zC1HK/lLKREuBesXI2KfuQaau2QnboC12zgSJMw0eA57ktb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10309"; a="241789995" X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="241789995" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2022 18:10:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,241,1643702400"; d="scan'208";a="524716394" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 06 Apr 2022 18:10:43 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Apr 2022 18:10:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Apr 2022 18:10:43 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Apr 2022 18:10:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cge5wBdHCOZdsorMjoD+xSJyKLaSXsfTKp3zAhW9vIvvPwx2ujGrkomvRRQhsYbKoXJr0LYO4/pYDBRffWfUkcvKWBhf+bH4LQuLX5mE+FSkoteursDph4h8p6lrAPQiVMIQNndFt6Vaud1r+OzcY3um5vNoJ6zgLt6jZ3yaAaccWFUjHOcaDdsGxZqPetPc5Lqxg9SAnkyyu2G+1RmauKUKqBx0E2xawNhj8O80C554FG7YJjQy1iUZcc250Vh/SfsmIf2kWM7JX9OypU3Mp2RwIhkHeot6w6opDVl+5QgcMOZgZ01zQhVVVyecKWMl7yoArMHdnOLwFKkEh0mQcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=klSur2VDcxk9imnlf1K8+CmKIXOOYMO4SN5wwtA959M=; b=QQ/1OkVNEm/MPtINL04N2apsz2bgvanRLKpkUa5QcDFyHx5NeNGfJglawFo8ndia/gOkifpn2R7jDitZJfEDdRX7lRsLVxDiG82/ZND++wWEjXyNIRSj1D0xWWuYwcyGE75WKWHb3bEW6XysmlGyosirD43HRrbcan9gNEX/VjohiYrsjkcEIVENDQ7uxhoL9Q2yS8tOzzWmuKf0Bgwu5v5nXLtbbPaGI+9UOepUjRrFHkfr3TXOnzxk0AVtWnBG+w7qwUAlzEQsZqUu71hIKLfRVVVtWAuJqA5FHLjW5hw8O2TMzYzL+H1R0id/ZIVd0jTgaiM4+aLJVt92vrlKgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5932.namprd11.prod.outlook.com (2603:10b6:303:1a2::5) by BL1PR11MB5478.namprd11.prod.outlook.com (2603:10b6:208:31d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 01:10:42 +0000 Received: from MW5PR11MB5932.namprd11.prod.outlook.com ([fe80::99c1:4af2:442d:4ffa]) by MW5PR11MB5932.namprd11.prod.outlook.com ([fe80::99c1:4af2:442d:4ffa%7]) with mapi id 15.20.5123.031; Thu, 7 Apr 2022 01:10:42 +0000 From: "Kuo, Ted" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Zeng, Star" , "S, Ashraf Ali" Subject: Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit Thread-Topic: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit Thread-Index: AQHYShIakhn/0x83K0ajwN72AFoYyazjovwA Date: Thu, 7 Apr 2022 01:10:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 076d4b86-c09b-4c66-a397-08da18336f94 x-ms-traffictypediagnostic: BL1PR11MB5478:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uZ2GaN3XfaGrUVIrzW3VnlGlku8ayTmKYzaffRHQx4eJim8HPBvRJhA5PPYsnwQCaPwqTDmiwyR+Y25fNdxu1STf35nGHxfWxQsjI3jz2jIJfnY2WnmJHt+InWulHwIXIlEZV8YngO3slxIT/MaNjVWlxVMlMWsSOzwK6Oev+v/te6qV/r1zVZcVqYd33zD/4lccvt7qh2Et2IguSbdJFAJL0CIHQenUVd3u0pMtW63CJMfwlQrNZ7I3PQH44t8b0wDDAk/ZxPwPLwiGiSBdFTJoJ6dt+4XAbZco3Wiw8mOoUcbE9iBbaLXlEqkso+XIdi5+FTnPp6lU6/JQMyb6zMeC27Z8C9L3IfDhlhLnsLWcXgEaUnllL0u6mDgi/HVxaFxl8TBsViwHbqpesyWcX6Mv0cii9KOq+0UX9KsoRjmOn7hQkJcLgMeWV4cWXZ2h6NDe/Phsld8AgkBWKfh1X+LqjOPZUTG15qfu+sV6Hdy3VZXn4w9JJvkZGHYRD+jMIvzJUHaTMJlGWJ9TbNNl+iiOAC+kl9uDxjRplOETEchQQESHuRX9c4XC1iFf2wqGxfTVRidInBY7cYNVUKpYD4bNqcvxVBTc5HFhHDx+Ail2tWREymwCue2LVFNBC7edpwrK8IhUSHgGtUYjLByxC4hKKVmL9uli30R9BdicBf7eL1orX7NVIZ8H2RqSUmsdoVGXjYJY75OQKTlyussRUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW5PR11MB5932.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(508600001)(6506007)(8676002)(122000001)(55016003)(66946007)(66446008)(66556008)(110136005)(66476007)(316002)(53546011)(86362001)(83380400001)(54906003)(9686003)(7696005)(64756008)(4326008)(71200400001)(5660300002)(26005)(186003)(33656002)(8936002)(107886003)(38070700005)(52536014)(38100700002)(4744005)(2906002)(82960400001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YYg2SrvT+KHT5xrmQ047JwtXw93DknH2/NwtKczrez9TQ1iRGiVJH2f6D2fn?= =?us-ascii?Q?Bz5hANiZrLcuOEfILWoUqXmfkt5Z3JlSLuppjxLrQoqSMIcaUf+cUM5taqoW?= =?us-ascii?Q?ABJo9Tw+QbteWPHOcamAEQ8v4El084PImayfVlalrVf1GDufggfOd15XO/UB?= =?us-ascii?Q?F05g5HyEkw/4cdYurao9SsZR6yx2d7wSdm8QAIFv7fGc+6ARgEi6Pmu2KMwy?= =?us-ascii?Q?IFKbB+yZ7yO4ppBPD6KKIWLqLAXbSKFiR2YQbgGBKUmKNs1QDPp24hkQesTU?= =?us-ascii?Q?kXcmlHEFYa60iuDz5v3hdaETKRU2Iau5l1fm0DeXAFRCjO1ej+5NSCCS/DJc?= =?us-ascii?Q?aS/E4wlrWJ70Nd4tSurSv4tn1IZKSTqYedEID0NLZq6rwuEkg7d4JGFKni5T?= =?us-ascii?Q?nig3LcWe+xRIDTFRol39PC8gy162UX0upc2S6jDLdtXqZQv4fG/75jnQWV2d?= =?us-ascii?Q?VevbNyS51JPSh3PvZ1WXJKWAB8T4TJmlgimX62N6XSdzPIfHJo0xbxYH2sB5?= =?us-ascii?Q?r24Z3uYd+zyDU4UbiINfod9Eqfv4cV2X7DE4lxOxDAjObxOQD6xyqGqJ5e4j?= =?us-ascii?Q?oAtBPkAHQjW/wrhdbnlUa3kpLlpW10iX4UuTCRfopJL4J8GdW4Qh1ulyGJGS?= =?us-ascii?Q?sD0WSARd+w5jbnXh50Q77CQ8wkcwOBu9KFwFUnHXg61Kh7xa0zjQh/iUS5Bq?= =?us-ascii?Q?RZqFIeIeKuTFULX1tiSdakX4IjaDYJfpmpjCzxghpMgg99Fli02+hEcikjvI?= =?us-ascii?Q?Xa/PKp3Q8uw67h9PZRfWtTgMkXbKiNHFFmPNd78ziksIvPuG9jpJIPaN9DJP?= =?us-ascii?Q?euMa9OMvLG8kjabZfOhmJPSlQKId/HfPBlUM1gGM8ys/XApUmheJwroVHRCl?= =?us-ascii?Q?5MZsaNd+g540IphFyRF1ODgNgV1i8GX1rs0m7FTd3InEp8B0IAhjsLOZvY0i?= =?us-ascii?Q?CWLGGuS3C2kAqxVhkbig6PKnhzuMXV+cbtPxiB2vrQSPLsgE5Lfg7hrP8Alv?= =?us-ascii?Q?0zzsTZnhzD2E7aPfeDHAnkL9RCH9ZFs6M00M9awdogiM+eryM+Rc2T7faiVl?= =?us-ascii?Q?GtEfMnuZg75zVcEKVjBmwI7mMdfrbUOtCDwAajeG8Ihp+UJPB4xyoCL/dYJJ?= =?us-ascii?Q?zP9e92oRQEPeOsMEA20p4GWLEYrIVkUF6UXIlo2g4xH0GYLOkWaidbd8PS29?= =?us-ascii?Q?xFHVANXSq1o1Dp1hN2gj6QkEt8vr3J8U/i/vURRYJxcYSg1hQh/K8aeNGldS?= =?us-ascii?Q?fc0CdT0A498gyb8C/UU/SRns1CmZVd/sWNgNpv1A3deiCj5TxXHNhAo02nj5?= =?us-ascii?Q?Y9x7eYMF6JpGF9K3b0Z34HfJeob4ufhhqtHyUoagATE2zAuF57imDSElCjzH?= =?us-ascii?Q?52AP0OhhEZY5XAa1SW886m5Rnr3G8gIKNznK4XMgnnkRO1HV1VxjFpfCkvqx?= =?us-ascii?Q?fm8Q8N1UaokVwq95AsAF6iRJSZ3uYP8J/JaliueD3BEGX9MkYeJaHWbGyvVK?= =?us-ascii?Q?+cK88XShU727Ztb+mrXXZxXiURf2NLm2YWaIPNAkag/ozK5krWdaLb3Qu56J?= =?us-ascii?Q?iIawPTANjQ3dgrYNkv+v1CtRVOUpO+j0atK1keQV8lwkIfPy6YnhAUxlayh7?= =?us-ascii?Q?JmQyk/msk0ulbEWLVi9/v634rDrqi/iWjEJwCSZwcFY1K0JS/tIn+IBUzvgh?= =?us-ascii?Q?Q4lRMuW/2CtJxjO8JzWVF+5rAClF9NCNzhd6JNLgd8ZZIxDTuVOf2i7ZUIN+?= =?us-ascii?Q?CPPILF1lPQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5932.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 076d4b86-c09b-4c66-a397-08da18336f94 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 01:10:41.9195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8MuKVxdbGDFYOJxjs4ZOXhnJnhXQlzbptp54di0p8BXoTt4DLU9/Eq58PbsJomM7H1JIqvVVgJxAfawylxxrLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5478 Return-Path: ted.kuo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Please see my inline comment. Thanks, Ted -----Original Message----- From: Ni, Ray =20 Sent: Thursday, April 7, 2022 7:58 AM To: devel@edk2.groups.io; Kuo, Ted Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; S, Ashraf Ali Subject: RE: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible change= s to support PEI in 64bit > -; UINT32 > +; UINTN > ; EFIAPI > -; AsmReadEsp ( > +; AsmReadStackPointer ( > ; VOID > ; ); > ;-----------------------------------------------------------------------= ------- > -global ASM_PFX(AsmReadEsp) > -ASM_PFX(AsmReadEsp): > +global ASM_PFX(AsmReadStackPointer) > +ASM_PFX(AsmReadStackPointer): > mov eax, esp > ret >=20 I guess it's possible that bootloader sets up the stack above 4G. If that's the case, above code doesn't work. [Ted]: The above code is for IA32 only. We have a separate ReadRsp.nasm for= X64. You can find it in the patch [edk2-devel][PATCH v3 4/8] IntelFsp2Pkg:= FspSecCore support for X64.