public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kun Qin" <kun.q@outlook.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm
Date: Fri, 22 Jan 2021 04:40:48 +0000	[thread overview]
Message-ID: <MWHPR06MB310233C338636838D61C23D8F3A00@MWHPR06MB3102.namprd06.prod.outlook.com> (raw)
In-Reply-To: <CO1PR11MB4930F1191FBCAF5E5551142A8CA00@CO1PR11MB4930.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]

Hi Ray,

I was suggested not to rename the file for review easiness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (groups.io)<https://edk2.groups.io/g/devel/message/69857>

Please let me know if you still recommend renaming the files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h  # remove the "S"``` to be a separate patch between gSmst change and adding Standalone MM instance?

Thanks in advance.

Regards,
Kun

From: Ni, Ray<mailto:ray.ni@intel.com>
Sent: Thursday, January 21, 2021 20:17
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kun.q@outlook.com<mailto:kun.q@outlook.com>
Cc: Dong, Eric<mailto:eric.dong@intel.com>; Laszlo Ersek<mailto:lersek@redhat.com>; Kumar, Rahul1<mailto:rahul1.kumar@intel.com>
Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm

>
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c                               |  9 ++----
>  UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c                      | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c                     | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h                               | 12 ++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf                             |  3 +-
>  UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf => CpuIo2StandaloneMm.inf} | 18 +++++------
>  UefiCpuPkg/UefiCpuPkg.dsc                                      |  5 +++


How about do the file name change as below?
CpuIo2Smm.c/h --> CpuIo2Mm.c/h  # remove the "S"
CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It also matches to CpuIo2Smm.inf.
CpuIo2StandaloneMm.c/inf # looks good to me.



[-- Attachment #2: Type: text/html, Size: 4920 bytes --]

  reply	other threads:[~2021-01-22  4:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210114223637.2737-1-kun.q@outlook.com>
2021-01-14 22:36 ` [PATCH v3 06/18] MdeModulePkg: SmmLockBoxSmmLib: Support StandaloneMm for SmmLockBoxLib Kun Qin
2021-01-14 22:36 ` [PATCH v3 07/18] MdeModulePkg: SmmReportStatusCodeLib: ReportStatusCodeLib in StandaloneMm Kun Qin
2021-01-14 22:36 ` [PATCH v3 08/18] MdeModulePkg: StatusCodeHandler: StatusCodeHandler driver " Kun Qin
2021-01-14 22:36 ` [PATCH v3 09/18] MdeModulePkg: FirmwarePerformanceDataTable: Added StandaloneMm support Kun Qin
2021-01-14 22:36 ` [PATCH v3 10/18] MdeModulePkg: ReportStatusCodeRouter: Support StandaloneMm RSC Router Kun Qin
2021-01-14 22:36 ` [PATCH v3 11/18] MdePkg: UefiDevicePathLib: Support UefiDevicePathLib under StandaloneMm Kun Qin
2021-01-14 22:36 ` [PATCH v3 12/18] PcAtChipsetPkg: AcpiTimerLib: Added StandaloneMm instance of AcpiTimerLib Kun Qin
2021-01-14 22:36 ` [PATCH v3 13/18] SecurityPkg: Tcg2PhysicalPresenceLib: Introduce StandaloneMm instance Kun Qin
2021-01-14 22:36 ` [PATCH v3 14/18] SecurityPkg: Tcg2PpVendorLibNull: Added support for MM_STANDALONE type Kun Qin
2021-01-14 22:36 ` [PATCH v3 15/18] SecurityPkg: Tpm2DeviceLibDTpm: Introduce StandaloneMm instance Kun Qin
2021-01-14 22:36 ` [PATCH v3 16/18] UefiCpuPkg: CpuIo2Smm: Move CpuIo2Smm driver to consume gMmst Kun Qin
2021-01-15  7:12   ` Laszlo Ersek
2021-01-22  4:18     ` [edk2-devel] " Ni, Ray
2021-01-14 22:36 ` [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Kun Qin
2021-01-15  7:16   ` Laszlo Ersek
2021-01-22  4:17   ` [edk2-devel] " Ni, Ray
2021-01-22  4:40     ` Kun Qin [this message]
2021-01-22  6:29       ` Ni, Ray
2021-01-22  7:32         ` Kun Qin
2021-01-22 12:32       ` Laszlo Ersek
2021-01-22 18:10         ` Kun Qin
2021-01-14 22:36 ` [PATCH v3 18/18] UefiCpuPkg: SmmCpuExceptionHandlerLib: Added StandaloneMm module support Kun Qin
2021-01-22  3:51   ` Ni, Ray
     [not found] ` <165A3A3578F29D7F.16948@groups.io>
2021-01-21  1:46   ` [edk2-devel] [PATCH v3 12/18] PcAtChipsetPkg: AcpiTimerLib: Added StandaloneMm instance of AcpiTimerLib Kun Qin
2021-01-22  3:50     ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR06MB310233C338636838D61C23D8F3A00@MWHPR06MB3102.namprd06.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox