From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.92.19.101]) by mx.groups.io with SMTP id smtpd.web09.4676.1611290449686410541 for ; Thu, 21 Jan 2021 20:40:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=YEsXw0/V; spf=pass (domain: outlook.com, ip: 40.92.19.101, mailfrom: kun.q@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YS5sGy5/WTyiMq4cjLyUepnXvl2byjcC2wS28u+5tZrI3gPWxNdSKPrOKwqUCFS+jIPzkWsdX9GsM34ATB9YMdL1FGfT4NkZj9hx+Z37WdPUaHqffl5G+wqUTewegoUojZIzDJ7mpcTrXs7M+FaOzG+WHZHr1yw3uWaXNQa1CmhWQjwCZi/4C5Pv9qat9IxUpR7pM1mhBcfso4LiNLQaBa5os5x4YcxiBt0manyCXW2xjFbcZmjQv97wujHUiyltnO5vThzZMkkTBja9DDOiMyq9Vq2iDDQDfLQPnTV/udMtgwSMk8ym5RZ89RoSi/c9DOAR0Z29WvROHB2JHTboDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lt8/bcAuelP40qBH1Z/fAvSBVr4Mu8TSFDypZ578ImE=; b=KlIOJ7j3Vt94ykug6j4Qh/EJ4ik5gtNllyBIYnqN3X8p+NW1KvVuLyoj6Cua2utG0RN+mdoC46K3jLsGS/mqIFjedFjnhwRGBfZqD3oyL1YCfld405o7fXfxmpqgjFzUsc1kOL0u2vzhaXvYVxXffsSq9zf2fDtxxsiaSmEbzJGOuwCuW0XUww6k9cUy2gg8nO+g6kBvM+ojXYNwwNdwsEBv7XskIJkBxzJ4bzAnLDqOwM48gBzra30eDOpMMTnXVQ9/RdGLOc0Ca2EuwPoRFN44w4i4sWtkq8oaZofbz/9JfIxEf+2SsuwFDgCiaxyZezuNleTdC0M8nTTWxSyi6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lt8/bcAuelP40qBH1Z/fAvSBVr4Mu8TSFDypZ578ImE=; b=YEsXw0/VStg50D3HVdTaYnitQI/uN0HEQjBdtB1+TqCZjDtneKJEXPQKNT5pnHR0NrDhLulWJUS3yULxUpTzx6Oa5ZXVGrtHLkcEGZPW4a6ADf2NCwe6jmjGVZjhUKe9wOefR54LULgisgaAZhLYJiVuGFc/2mfEbLaC46+gsf5flHdOA4jMrvxNVEzRT+wRrIQuvAvlill3xZxtJ1Vy68b/G7djOanDma4WP7QLXL7ZFylZU593N/PW4pc6pyUbBWzHxVau3s2RSLsJR4o4fSgLPtABQxBrj4sKdm5m5qft2h4NbyxmwBDxvVkM5tgT10TdckF4xAzKdamRfJJtOA== Received: from DM6NAM11FT066.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::4c) by DM6NAM11HT119.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4d::449) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12; Fri, 22 Jan 2021 04:40:48 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com (2a01:111:e400:fc4d::4c) by DM6NAM11FT066.mail.protection.outlook.com (2a01:111:e400:fc4d::435) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Fri, 22 Jan 2021 04:40:48 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::acb3:ab69:563d:b0d6]) by MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::acb3:ab69:563d:b0d6%5]) with mapi id 15.20.3763.014; Fri, 22 Jan 2021 04:40:48 +0000 From: "Kun Qin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Topic: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Index: AQHW6sXFluaBi30pb0yhAv39oYeMAaozFV+AgAAAxoQ= Date: Fri, 22 Jan 2021 04:40:48 +0000 Message-ID: References: <20210114223637.2737-1-kun.q@outlook.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:8A6CB8151E41309065851F7FBED1F6B9A0941B41967F23A8F40DE5EB24591C7C;UpperCasedChecksum:A16D7143A60230EA09B2EE16B47DAE4F51608C7A15003131B486A402753F2625;SizeAsReceived:7210;Count:44 x-tmn: [ufcFck3LNorPbRaMnbyVukM7lX+32o6e] x-ms-publictraffictype: Email x-incomingheadercount: 44 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: cda154c2-3fa4-431a-7dc7-08d8be8fe3bb x-ms-traffictypediagnostic: DM6NAM11HT119: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: shkH45SYjEMHt6sUe3cuMbmI3tER7JY0HN/MJFEL+5gW4TJEjc8j5bfZ95DL1HeOC9PcMlLGo7S9o5kcjPuhAMjn/2JSUeBhwtT14MeGkIjR/JGIK1mrwnuU4GFPkxBgocieMRu3LWfes6pWK0Ju9cVZKeD8aIJjzh4R9ih6OnCummcHPqgtPL0Ra830jwDLjbiqR7ByHx9CL7JKg9Wera+m+57V6bBknf6NTxT9L1P2iA0KT1nb01IsGp2KdYaRf4O4AJRKhMFsumbuu3tXFcPKLz9d/vjyZ+ydSgoY698= x-ms-exchange-antispam-messagedata: XFuLGHjYjRXQHospXwdRgzAVZMvuieXFqvu0ac/cruPEoZHfo+IeDdrRKmRXXfAMWd8Z7KBZwyKAZuAu5DsHTeZW2cDBDyqzCtdIj76iZvwBV7G9YeoE7UWePuW71QcYd+3wSGGjn2BMTPFha20IiQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: cda154c2-3fa4-431a-7dc7-08d8be8fe3bb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 04:40:48.2722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM11HT119 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR06MB310233C338636838D61C23D8F3A00MWHPR06MB3102namp_" --_000_MWHPR06MB310233C338636838D61C23D8F3A00MWHPR06MB3102namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, I was suggested not to rename the file for review easiness and git history = concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuI= o2Smm: Support of CpuIo driver under StandaloneMm (groups.io) Please let me know if you still recommend renaming the files. If so, would = you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"``` to be a = separate patch between gSmst change and adding Standalone MM instance? Thanks in advance. Regards, Kun From: Ni, Ray Sent: Thursday, January 21, 2021 20:17 To: devel@edk2.groups.io; kun.q@outlook.com Cc: Dong, Eric; Laszlo Ersek; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support o= f CpuIo driver under StandaloneMm > > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++--= -- > UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++= ++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +- > UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.inf} | 18 ++= +++------ > UefiCpuPkg/UefiCpuPkg.dsc | 5 +++ How about do the file name change as below? CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S" CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It als= o matches to CpuIo2Smm.inf. CpuIo2StandaloneMm.c/inf # looks good to me. --_000_MWHPR06MB310233C338636838D61C23D8F3A00MWHPR06MB3102namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Ray,

 

I was suggested not to rename the file for review ea= siness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/1= 6] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (group= s.io)

 

Please let me know if you still recommend renaming t= he files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h&nbs= p; # remove the "S"``` to be a separate patch between gSmst chang= e and adding Standalone MM instance?

 

Thanks in advance.

 

Regards,

Kun

 

 

>
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c     &n= bsp;            = ;             |=   9 ++----
>  UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c    = ;            &n= bsp;     | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c   &nbs= p;            &= nbsp;    | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h     &n= bsp;            = ;             |= 12 ++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf     =             &nb= sp;           |  3 += -
>  UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.i= nf} | 18 +++++------
>  UefiCpuPkg/UefiCpuPkg.dsc      &nb= sp;            =             &nb= sp;      |  5 +++


How about do the file name change as below?
CpuIo2Smm.c/h --> CpuIo2Mm.c/h  # remove the "S"
CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It = also matches to CpuIo2Smm.inf.
CpuIo2StandaloneMm.c/inf # looks good to me.

 

--_000_MWHPR06MB310233C338636838D61C23D8F3A00MWHPR06MB3102namp_--