From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (NAM04-BN3-obe.outbound.protection.outlook.com [40.92.9.78]) by mx.groups.io with SMTP id smtpd.web11.8005.1614920382541410005 for ; Thu, 04 Mar 2021 20:59:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=WePs/hwI; spf=pass (domain: outlook.com, ip: 40.92.9.78, mailfrom: kun.q@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QK3ZWJrIUW22LnsqjTNE1yvMXFM3ao4qZSnF6Jf2Fq2FBBpvH4ZMqeCyqJOgvuoX6ptNWUriTmHUCIOZW9HDCaVqs4b0QACMBr7WNcOU4V6O0NgJEKftSZ2xCD2VRzUnubdNnHfF985CLv5csL3+kBKVw0+rcgJNMmyk79Aosw4v6m1yDZPXL1mb5bL5YEBIXHtN8rrzqwXFqjfHk9WtyW5mgA+V2ABNr4z1peg8cXdl1SlnzPB8y41HDJpf/8GW8x5a6yjsZOpuBENxJA2B+evHywRaFI6YkOPUB62bBaggr0bJNuyYZD9eMKSCNAOo1vieXWQMFfbwBN+x5otuNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aliAle2PC4025nqNwKD+iEVlp1dQA3N8l6Q32oYtCkw=; b=LqNOSEmhQb67gNgoB2IMW1KpgheGQY83uwUhyjSZjgFF5l/EAqwZY/bDiX9tipp1HHbuAreitmJ32JEtxHHfLhDtpIM/Jo2WZR9tELfmE8W8H7hA2E5XkZkv91aXX4H5SKNya8ax/t2VYedcwN5UL2ahlplGXH7jPIH3+MDaRnc8ntJ3kUIMS7RcZhuLaf3QRzE5tF3/qbiUXhur0tQN/eOS5d9EEXtetP/qyMASQ9FQgbjnf5GIeMVISQFe1WBmUtQTbQHci/5PkYzLoI2lkkVjir0j4onYIBr2YSREUmBkQ6Y0qPdrgS7jukhhr6nlv7EPYOlmXTPbbTvRbuOJBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aliAle2PC4025nqNwKD+iEVlp1dQA3N8l6Q32oYtCkw=; b=WePs/hwIQYTJW9TmYqxgCwI3LCnswQtKa4vjpUsXffdQkdxSOX4NDhb/4NtkKT2dMlIuJkaDbFqmfTQlpooQIXxt24n3bFVu8ufAXcbRRUElknI/ljtiS2zN71rRGn9Z7gdYpPdEo9dYaP9+fUsKkLyIQfptshjr4OmvgLGCfnJyulwH44SBgZqPRiNVC5bWnMtm8iebPi5AE1eTEGl1eWQDKXrHzGRPnU6bnRU5DEnWpYe5Jgmi8l4Pe2JI7Fn6zol2Ip3RGvMhkSrdsK5/LaY4n1hIzB7Miat4E/PNqXJMFCarvhANWM98UUEYkatjta0X3b9ipfPb4BzlSFQC2Q== Received: from SN1NAM04FT020.eop-NAM04.prod.protection.outlook.com (10.152.88.53) by SN1NAM04HT099.eop-NAM04.prod.protection.outlook.com (10.152.88.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20; Fri, 5 Mar 2021 04:59:32 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com (2a01:111:e400:7e4c::4f) by SN1NAM04FT020.mail.protection.outlook.com (2a01:111:e400:7e4c::155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20 via Frontend Transport; Fri, 5 Mar 2021 04:59:32 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::d4ee:1260:6f53:3f7b]) by MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::d4ee:1260:6f53:3f7b%7]) with mapi id 15.20.3890.028; Fri, 5 Mar 2021 04:59:31 +0000 From: "Kun Qin" To: "devel@edk2.groups.io" CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiewen Yao , Jian J Wang , Hao A Wu , Laszlo Ersek , Ard Biesheuvel , Jordan Justen , Qi Zhang , Rahul Kumar Subject: Re: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages Thread-Topic: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages Thread-Index: AQHXEXXft+4KVjiciUu+8r2eDLqS8ap0zxrb Date: Fri, 5 Mar 2021 04:59:31 +0000 Message-ID: References: <166956FE12B1DAB7.16425@groups.io> In-Reply-To: <166956FE12B1DAB7.16425@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:0CCAA7FA1F4D2A29C9CDC1400B1B88C248F0C921D1ACBDD5BEFEBEDAFAC2F0C8;UpperCasedChecksum:AD0DB0C21E4ADDD22DA45E8F51A8F7FCDEA254B878CBDD0A4D1F2E695F4E6F4C;SizeAsReceived:7222;Count:44 x-tmn: [1PSSQw4rsej57haZMX0WmqIih8m5Lk2u] x-ms-publictraffictype: Email x-incomingheadercount: 44 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: f11e401d-6c64-4662-e5c8-08d8df9376cb x-ms-traffictypediagnostic: SN1NAM04HT099: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mzJRXvfcYGLL1NMXwUTFDgoENOn2TPEwV6saWExhmT29YvyJOej5D1X0pCix8Ziz3RNu8lxFyPshLbwMwWnuiNrCco7zYh3MFV2YqYjR1O8KYVPe0LEhw1MTpnPKOJ8BfDIFFH7I2WxmcyS6lPp00FoGOD830U0qbmdIjPYNYFnMiFsdJyOWrL0xTuJNAUOIaLZeSKz19Wzfuc4CSVnSA/iHAvNOAfE5fpeKsjsFRflryv7qv5Rs1zx8G1/1jtF6Q04c4jBJwoQYTQKMXcEvn9tR+or8J8Jf1J7CZFvrRKOIL+KAKYbBdKdky4Js5IAW2ZNbeJehkJLKvOIl9BXWyUqGoDdGddkAY1dRsokstjDftZtMZ4c0Iy5w0uAej3AxkRkD2BZgq289B9u3wNMG6M3mv8SzJ/OY22dkVkubwmh6y4caO5Qo/0qTMhQQ1LR/ x-ms-exchange-antispam-messagedata: iupq8cefeTeq8cc9tvSU3YxcGb4+ua1gg9SO6HrlAYzxCG802YBHi+ZIGf+TEb24UbHH3GhOi18x5xiDvC8+rXKec3Odfa0MUawufDT5JBUXla01ROWHymsP3ImWAb4zlYf0kGK567V42bYj7QRQpQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: SN1NAM04FT020.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: f11e401d-6c64-4662-e5c8-08d8df9376cb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2021 04:59:31.7956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT099 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR06MB3102536631ECFF4D67381D23F3969MWHPR06MB3102namp_" --_000_MWHPR06MB3102536631ECFF4D67381D23F3969MWHPR06MB3102namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi, Thanks to all the reviewers helping through this patch series. Each indivi= dual patch has received reviewed-by tag in this v6 version. It has also jus= t passed all CI build tests here: Unblock mem v6 by kuqin12 =B7 Pull Reques= t #1473 =B7 tianocore/edk2 (github.com) Could one of the maintainers help to merge these patches into the= mainline when you have a chance? Please let me know if there is anything needed from me to merge in these p= atches. Thanks in advance! Regards, Kun From: Kun Qin Sent: Thursday, March 4, 2021 20:13 To: devel@edk2.groups.io Cc: Michael D Kinney; Liming Gao; Zhiguang Liu; Ji= ewen Yao; Jian J Wang; Hao A Wu; Laszlo Ersek; Ard Biesheuvel; Jordan Justen; Qi Zhang; Rahu= l Kumar Subject: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and = Usages This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/72442 v6 patches mainly focus on feedback for reviewed commits in v5 patches, including: a. Adding "Reviewed-by" and "Acked-by" tags for applicable patch; b. Updating library class description for newly added interface; Patch v6 branch: https://github.com/kuqin12/edk2/tree/unblock_mem_v6 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Jiewen Yao Cc: Jian J Wang Cc: Hao A Wu Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Qi Zhang Cc: Rahul Kumar Kun Qin (7): MdePkg: MmUnblockMemoryLib: Added definition and null instance OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeDxe) MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules SecurityPkg: Tcg2Smm: Added support for Standalone Mm SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 4= 2 + MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c | 4= 4 + SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c} | = 362 ++++----- SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c | 4= 8 ++ SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 85= 7 ++++---------------- SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c | 7= 1 ++ SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c | 8= 2 ++ MdeModulePkg/MdeModulePkg.dsc | = 1 + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | = 1 + MdePkg/Include/Library/MmUnblockMemoryLib.h | 4= 4 + MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf | 3= 4 + MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.uni | 2= 1 + MdePkg/MdePkg.dec | = 5 + MdePkg/MdePkg.dsc | = 1 + OvmfPkg/OvmfPkgIa32.dsc | = 3 + OvmfPkg/OvmfPkgIa32X64.dsc | = 3 + OvmfPkg/OvmfPkgX64.dsc | = 3 + SecurityPkg/Include/Guid/TpmNvsMm.h | 6= 8 ++ SecurityPkg/SecurityPkg.ci.yaml | = 1 + SecurityPkg/SecurityPkg.dec | = 8 + SecurityPkg/SecurityPkg.dsc | 1= 2 + SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.inf} | = 35 +- SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl | = 0 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf | 4= 3 + SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h | 12= 1 +-- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf | 2= 7 +- SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.inf} | = 50 +- 27 files changed, 952 insertions(+), 1035 deletions(-) create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNu= ll.c copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c} (72%) create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c create mode 100644 MdePkg/Include/Library/MmUnblockMemoryLib.h create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNu= ll.inf create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNu= ll.uni create mode 100644 SecurityPkg/Include/Guid/TpmNvsMm.h copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.inf} (76= %) rename SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl (100%) create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf copy SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.inf} (52%= ) -- 2.30.0.windows.1 --_000_MWHPR06MB3102536631ECFF4D67381D23F3969MWHPR06MB3102namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Hi,

 

Thanks to all the reviewers helping through this pa= tch series. Each individual patch has received reviewed-by tag in this v6 v= ersion. It has also just passed all CI build tests here: Unblock mem v6 by = kuqin12 =B7 Pull Request #1473 =B7 tianocore/edk2 (github.com) Could on= e of the maintainers help to merge these patches into the mainline when you= have a chance?

 

Please let me know if there is anything needed from= me to merge in these patches. Thanks in advance!

 

Regards,

Kun

 

From: Kun Qin
Sent: Thursday, March 4, 2021 20:13
To: devel@edk2.groups.io
Cc: Michael D Kinney<= /a>; Liming Gao; Zhiguang Liu= ; Jiewen Yao; Jian J Wang; = Hao A Wu; Laszlo Ersek; Ard Biesheuvel; Jordan Ju= sten; Qi Zhang; Rahul Kumar
Subject: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interfa= ce and Usages

 

This patch series is= a follow up of previous submission:
https://edk2.grou= ps.io/g/devel/message/72442

v6 patches mainly focus on feedback for reviewed commits in v5 patches, including:
a. Adding "Reviewed-by" and "Acked-by" tags for applic= able patch;
b. Updating library class description for newly added interface;

Patch v6 branch: https://github.com/kuqin12/edk2/tree/unblock_mem_v6

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>

Kun Qin (7):
  MdePkg: MmUnblockMemoryLib: Added definition and null instance
  OvmfPkg: resolve MmUnblockMemoryLib (mainly for VariableSmmRuntimeD= xe)
  MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory     interface
  SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst
  SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules
  SecurityPkg: Tcg2Smm: Added support for Standalone Mm
  SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS regio= n

 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c&n= bsp;  |  42 +
 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.c &nbs= p;         |  44 +
 SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c} = ;          | 362 ++++-----
 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c    = ;            &n= bsp;       |  48 ++
 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c      = ;            &n= bsp;            = ;     | 857 ++++----------------
 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c    &n= bsp;            = ;          |  71 ++
 SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c    &= nbsp;           &nbs= p;         |  82 ++
 MdeModulePkg/MdeModulePkg.dsc      &nb= sp;            =             &nb= sp;        |   1 +
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf= |   1 +
 MdePkg/Include/Library/MmUnblockMemoryLib.h    &= nbsp;           &nbs= p;         |  44 +
 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf &n= bsp;       |  34 +
 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.uni &n= bsp;       |  21 +
 MdePkg/MdePkg.dec        &nb= sp;            =             &nb= sp;            =       |   5 +
 MdePkg/MdePkg.dsc        &nb= sp;            =             &nb= sp;            =       |   1 +
 OvmfPkg/OvmfPkgIa32.dsc       &nb= sp;            =             &nb= sp;            = |   3 +
 OvmfPkg/OvmfPkgIa32X64.dsc       =             &nb= sp;            =            |   = 3 +
 OvmfPkg/OvmfPkgX64.dsc       &nbs= p;            &= nbsp;           &nbs= p;            &= nbsp; |   3 +
 SecurityPkg/Include/Guid/TpmNvsMm.h     &nb= sp;            =             &nb= sp;   |  68 ++
 SecurityPkg/SecurityPkg.ci.yaml      &= nbsp;           &nbs= p;            &= nbsp;      |   1 +
 SecurityPkg/SecurityPkg.dec       = ;            &n= bsp;            = ;          |   8 +  SecurityPkg/SecurityPkg.dsc       = ;            &n= bsp;            = ;          |  12 +
 SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.inf}&= nbsp;      |  35 +-
 SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl   =             &nb= sp;        |   0
 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf   &nb= sp;            =       |  43 +
 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h      = ;            &n= bsp;            = ;     | 121 +--
 SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf     &nb= sp;            =             &nb= sp;   |  27 +-
 SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.inf}&n= bsp;       |  50 +-
 27 files changed, 952 insertions(+), 1035 deletions(-)
 create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemory= LibNull.c
 copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.c =3D> Tcg2Acpi/Tcg2Acpi.c}= (72%)
 create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.c
 create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2StandaloneMm.c
 create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2TraditionalMm.c
 create mode 100644 MdePkg/Include/Library/MmUnblockMemoryLib.h
 create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemory= LibNull.inf
 create mode 100644 MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemory= LibNull.uni
 create mode 100644 SecurityPkg/Include/Guid/TpmNvsMm.h
 copy SecurityPkg/Tcg/{Tcg2Smm/Tcg2Smm.inf =3D> Tcg2Acpi/Tcg2Acpi.= inf} (76%)
 rename SecurityPkg/Tcg/{Tcg2Smm =3D> Tcg2Acpi}/Tpm.asl (100%)
 create mode 100644 SecurityPkg/Tcg/Tcg2Smm/Tcg2MmDependencyDxe.inf  copy SecurityPkg/Tcg/Tcg2Smm/{Tcg2Smm.inf =3D> Tcg2StandaloneMm.i= nf} (52%)

--
2.30.0.windows.1





 

--_000_MWHPR06MB3102536631ECFF4D67381D23F3969MWHPR06MB3102namp_--