From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.92.22.85]) by mx.groups.io with SMTP id smtpd.web11.5853.1611300739763809667 for ; Thu, 21 Jan 2021 23:32:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=kbXds2Sz; spf=pass (domain: outlook.com, ip: 40.92.22.85, mailfrom: kun.q@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=neKhUcOxjYCh27vXfaUU86Xke0Cv1JPKeyO0lyl4VUotpJMG2kaTNbg1dravwRhVBY2JBTiqz8Kdhq59Q9D0FzYs9Bd0/qyDQ9FbXbTlY3gas0xjAQOmuq49dN2LUmvqd8m05NVmEj1baUVIyK7vjwM0tmTUHsjwsjazz6VIFYExmmwYq3PlV0ItHZl4mglrKQAH+xOi4N8Py9/Qh9WIprxco9YmXngatJm9T3z3KtOdXmrwMuohY73Ev1rEZsazYCjA11epi7Vz4aGAJlq3mA/pC+0/f0u9vuUU7FL6FXfeXqypNJZEYXQLg7uGLHUUmZXZPlUHsV5avvzFbLF65Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsJx4m2n9iLLPcTZV5ZOV+usApayBMiDvffW1eq6i3k=; b=BW2UQ9/j67YhO0PCVba+exKdJikcfcufQ90lJ9TGnLXIDSUrHn2kcTEam1h5z6P974CnUykhhkguMvbD9lrCrgYoXBWMwPLBFlkI+mhjWnoN9diLIAw35iOhH7wf3jEAAfhvRBdwF6GRCXn6cyOBYq19jxqkdax8q0oe8h7jtZT0P52aBo50Mk3IQinmKqAEQsx7pWbaXVBD6HCWZA7sL+uD8O1X9LxNR3Waw0Nm5gfjpi4SjBT6mKbMNt95fQKnT+Za9vkpY3hotdQTFcU5Ug+zz6vy8ZrGXL+m9xcF0oB7MaZivu6RK9UXjRCLSdr0v8Z7vq9U352VzB54OVKdTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsJx4m2n9iLLPcTZV5ZOV+usApayBMiDvffW1eq6i3k=; b=kbXds2SzAs9rW62v2cQ6Ee2RZe8yxxa3VlMyQxi79+MTZNC50LliVNyM8XxrVloihuNG+0kon/I+SUsVGPq57ms54z2GRbl4Dc7w9x3xWKekldSS3TQsXJGrP7IeyqVVM9JhA+lEcScTyxyVtWHcUftD4PHJ44nnKjyd3zCwl+atAayOQ8Hqf+mLHcscnIZTa3wfCbDvVhFmb8oPFKVmA9UXzfVX1hpIt02WG3qn+nA9cG43BL8RzgiwSThMbZzkXsrR1HGvY4ySOLIlQeHohHDY5giSIrOpjHHKtqnMN2OERGYREB2EL2OoVw8Cp/VVL6UHVm1BKaWAELJSC64CUw== Received: from DM6NAM12FT006.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::4e) by DM6NAM12HT253.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.7; Fri, 22 Jan 2021 07:32:18 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com (2a01:111:e400:fc64::43) by DM6NAM12FT006.mail.protection.outlook.com (2a01:111:e400:fc64::234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.6 via Frontend Transport; Fri, 22 Jan 2021 07:32:18 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::acb3:ab69:563d:b0d6]) by MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::acb3:ab69:563d:b0d6%5]) with mapi id 15.20.3763.014; Fri, 22 Jan 2021 07:32:18 +0000 From: "Kun Qin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Topic: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Index: AQHW6sXFluaBi30pb0yhAv39oYeMAaozFV+AgAAAxoSAACQqgIAAEVDJ Date: Fri, 22 Jan 2021 07:32:17 +0000 Message-ID: References: <20210114223637.2737-1-kun.q@outlook.com> , , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:433BDF1B1023BFA5869A576476DD4EB8FFDBBF3749D3784826936CB01988386A;UpperCasedChecksum:E9A6FEDD791615FFA8BE5B184018B47E30402B62B5D1BF0012CFD3140EE62501;SizeAsReceived:7379;Count:44 x-tmn: [D5UEDKW8Ky2ZbjpEhhOZC2Kncl0MGJYh] x-ms-publictraffictype: Email x-incomingheadercount: 44 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 5558ba6a-79fe-4037-3c1c-08d8bea7d8e5 x-ms-traffictypediagnostic: DM6NAM12HT253: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +AaxD4KNkkGdJ5neEwB8ZoJ4B7wdV/EbBexzIqu/fmUewQRL9bH4xSGmRSBkcuqMFFl7b1SgTZq6uHvDcXtOQDyDKeVFv28e9qVtbhZRVyOU4DipYc+tIHQmH2eSYtt/1A1wVoPEQQZzJL4pSOk63qZSGcwK1IxqLL9EisXWj+ylp/dUHCQ0gVAPA5acSYbHLt08zq1+N7Ozqx8MzclmP8FVPk0ysgb4YDnzLWIDoUXsWiJrfiT7h4kjy0w8zvlJJqLgS9ItF4l/pqXdFw3aKbci7vIA7+nZ+ekmidJOK4c= x-ms-exchange-antispam-messagedata: +WSX7XzUfNJUEghemomKJXXRpkNE9xsKDJa7acHFZFERpaszmNkhc0/JnoU0gDhy/PDaULW0aBq83rtxxPRScRHL94PoKiX/KPkC00C7P+hPiBXJZcL9+ItzTvTGvsRWRE6Bwh+vUsC2t8a8sRrBxw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT006.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 5558ba6a-79fe-4037-3c1c-08d8bea7d8e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 07:32:17.9679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT253 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MWHPR06MB31028F5EA805C37B272FE83EF3A00MWHPR06MB3102namp_" --_000_MWHPR06MB31028F5EA805C37B272FE83EF3A00MWHPR06MB3102namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray, Thanks for confirming. I will add the renaming patch in v4. Regards, Kun From: Ni, Ray Sent: Thursday, January 21, 2021 22:29 To: Kun Qin; devel@edk2.groups.io Cc: Dong, Eric; Laszlo Ersek; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support o= f CpuIo driver under StandaloneMm Kun, Yes. I recommend renaming the files. This can make future developers easy t= o understand which file stands for which purpose. A separate rename patch looks good to me. Thanks, Ray From: Kun Qin Sent: Friday, January 22, 2021 12:41 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kum= ar, Rahul1 Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support o= f CpuIo driver under StandaloneMm Hi Ray, I was suggested not to rename the file for review easiness and git history = concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuI= o2Smm: Support of CpuIo driver under StandaloneMm (groups.io) Please let me know if you still recommend renaming the files. If so, would = you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"``` to be a = separate patch between gSmst change and adding Standalone MM instance? Thanks in advance. Regards, Kun From: Ni, Ray Sent: Thursday, January 21, 2021 20:17 To: devel@edk2.groups.io; kun.q@outlook.com Cc: Dong, Eric; Laszlo Ersek; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support o= f CpuIo driver under StandaloneMm > > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++--= -- > UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++= ++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +- > UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.inf} | 18 ++= +++------ > UefiCpuPkg/UefiCpuPkg.dsc | 5 +++ How about do the file name change as below? CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S" CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It als= o matches to CpuIo2Smm.inf. CpuIo2StandaloneMm.c/inf # looks good to me. --_000_MWHPR06MB31028F5EA805C37B272FE83EF3A00MWHPR06MB3102namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Ray,

 

Thanks for confirming. I will add the renaming patch= in v4.

 

Regards,

Kun

 

 

Kun,

Yes. I recommend renaming the files. This can make f= uture developers easy to understand which file stands for which purpose.

A separate rename patch looks good to me.=

 

Thanks,

Ray

 

From: Kun Qin <kun.q@outlook.com>
Sent: Friday, January 22, 2021 12:41 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@= redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Su= pport of CpuIo driver under StandaloneMm

 

Hi Ray,

 

I was suggested not to rename the file for review ea= siness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/1= 6] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (group= s.io)

 

Please let me know if you still recommend renaming t= he files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h&nbs= p; # remove the "S"``` to be a separate patch between gSmst chang= e and adding Standalone MM instance?

 

Thanks in advance.

 

Regards,

Kun

 

 

>
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c     &n= bsp;            = ;             |=   9 ++----
>  UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c    = ;            &n= bsp;     | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c   &nbs= p;            &= nbsp;    | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h     &n= bsp;            = ;             |= 12 ++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf     =             &nb= sp;           |  3 += -
>  UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.i= nf} | 18 +++++------
>  UefiCpuPkg/UefiCpuPkg.dsc      &nb= sp;            =             &nb= sp;      |  5 +++


How about do the file name change as below?
CpuIo2Smm.c/h --> CpuIo2Mm.c/h  # remove the "S"
CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It = also matches to CpuIo2Smm.inf.
CpuIo2StandaloneMm.c/inf # looks good to me.

 

 

--_000_MWHPR06MB31028F5EA805C37B272FE83EF3A00MWHPR06MB3102namp_--