From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.55]) by mx.groups.io with SMTP id smtpd.web09.721.1614884403990886454 for ; Thu, 04 Mar 2021 11:00:04 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=DY6cUpv9; spf=pass (domain: outlook.com, ip: 40.92.41.55, mailfrom: kun.q@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gErqnB+6z2dY2MhCnlcLUFlpa7QLiN0iI70kXJltRwiSPtQ1e/kNx+l+Neh5HfZYmYoHXy8C/5XE0t+40ngfDHvln6bpqwf6BhYpUtmcHT2/JdhSvYLRL/I7HGvtGe2ZddNaI48b++sGE0oG3K+S0n5VJZ4ECMdxQ3xPkJ1o3mjN7VA20U798nqmjqnAEtGkd9LmsW9CJO1mKNMKfk0FqC1qVBDZqcCIzJXRuUcULR2P+H+p6EiJ0RXVX4UqGR2RdS9pxnejU2owBcNaUUiXWJo6VP0ExtPp3fo05naoBkGMmP/ko33wMBh0F0wbKZa0i0xTsrzk0Qy67B2nNBNJwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89vhkuNRIEDHo/TEVGfwb8GXfbHcGRUX9G7RumAuGBs=; b=CG9n9rxS2y0s26mqGumXDYnYgHWkdA4+rweoQ1s2Pjp8e0qzbz0ywflIQgsQfO0LCAhDZAJ2CgRZZBR5kZF7z+roJYGAKI4sVan3SUqr+IsiBMY3sT7Wunec2x33gkrYu9yHXlP8TrEpFYs+3rRCDn/6eTeHqKA41DvT7x2JzOAgnTceel4+ABVO9XGT6u9cpTOD82KeKTOahDxZIIMGzkvOu2Lk+WfV3xEJLxvajPT8RpImS1K0mxp4j/+FaADs7WxX3P12QvDQAodbD9y3gO0+fx+gfAfcDDXnzu5a/Jtf91P/QrZregA/kuJZkLzqALZepf6X4CfwNjQSO8gMtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89vhkuNRIEDHo/TEVGfwb8GXfbHcGRUX9G7RumAuGBs=; b=DY6cUpv9WyEptfZQ0M7ydlPoJV/8Ot1MhExKm+vi7jvVHwDuuQPzrn2mnRdYs3WFuBEYFypPwUlHqVhywCVQULsWmHQOd+v/+OV16bOnLHfqrkb2auAaCKdArbM7sFhwbKnLxEmLi9LvuixVMWLPMJEbIZ6Ql8ppqKMJZAvhTCdRD6CG10Ph45rLCvoXxORQH0lPQ4LsHl8r72zit1gpgktkg0+fylctrkJbdi462JG2L44OU3UVtwv0dKV+ZxRyL58+p2gRcJw+C/kDHHTf63+2AZB6zV9+gUXIDAbzlQbljOAGmHXjhPSCrrzO79t02/KbftmJ8Iz0OiERj7IvHg== Received: from MW2NAM10FT057.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::4e) by MW2NAM10HT031.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Thu, 4 Mar 2021 19:00:00 +0000 Received: from MWHPR06MB3102.namprd06.prod.outlook.com (2a01:111:e400:7e87::4c) by MW2NAM10FT057.mail.protection.outlook.com (2a01:111:e400:7e87::229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Thu, 4 Mar 2021 19:00:00 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:5D93AB74D1B8AE165E787F117AB415EF8A13239803CFFBEA752874F1A8F970F9;UpperCasedChecksum:E6E05E6ACAA98128FF4A2B82974467B196D0793B60FB952ABB8474716AB32D6F;SizeAsReceived:7448;Count:47 Received: from MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::d4ee:1260:6f53:3f7b]) by MWHPR06MB3102.namprd06.prod.outlook.com ([fe80::d4ee:1260:6f53:3f7b%7]) with mapi id 15.20.3890.028; Thu, 4 Mar 2021 19:00:00 +0000 From: "Kun Qin" To: devel@edk2.groups.io CC: Jian J Wang , Hao A Wu , Liming Gao Subject: [PATCH v5 3/7] MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface Date: Thu, 4 Mar 2021 10:59:40 -0800 Message-ID: X-Mailer: git-send-email 2.30.0.windows.1 In-Reply-To: <20210304185944.1716-1-kun.q@outlook.com> References: <20210304185944.1716-1-kun.q@outlook.com> X-TMN: [oHOC5oAqtS+jW5xkB7lVmYG/7Tvubpgu] X-ClientProxiedBy: CO2PR05CA0054.namprd05.prod.outlook.com (2603:10b6:102:2::22) To MWHPR06MB3102.namprd06.prod.outlook.com (2603:10b6:301:3e::35) Return-Path: kun.q@outlook.com X-Microsoft-Original-Message-ID: <20210304185944.1716-2-kun.q@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (50.35.88.161) by CO2PR05CA0054.namprd05.prod.outlook.com (2603:10b6:102:2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.16 via Frontend Transport; Thu, 4 Mar 2021 18:59:59 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 2e81c01c-4842-4e85-0103-08d8df3fb5d1 X-MS-TrafficTypeDiagnostic: MW2NAM10HT031: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d4QUxQ6WA61FL86Ef7JpxCS1HZwLSEW4vELLdhfS35qFfx4p/aiqQZkBXrgn0eCLhxwvtLND7r/v8AHPtITYWYpWDFTjuJPdbMgRzGj0Toen+ztIcxKNHJtB3wyWKK0ZG0fjTpH/tPtVDfvGEWsh7udF1Lup0jOhpyLIXs7BOzexp5fhcPEn6v9v2oTpMD+O7Vw8VD9W3LY21K5woxQWiiETRp9u2tSDknFvX/lYFWP7p9nSoqnL7iKPvfgq4O4nX59Jg4ca1UX6kU/0CTau6W2Chw+wR06Oyc5yOPnSHLkGHMc+tBBgtz2b/HrsNqqKyQwyI5x0ztSEVdg4Ur20E00KeWLZPNLoE1XlXzcE6oWC2tRTX0//qv0Xrz+ywkYdB+KMBxcFqazj9+nQUEGNlw== X-MS-Exchange-AntiSpam-MessageData: gsfoA4I5Q7k13s+KwtsKoDhPXrNdqHklIPOJf1mdTCMxmufT3DxhUSN4ljvwOwONwrNovgcmmWcUv3s9LcIBXSkKKQ7NOsZNXIHWt4tk5DEu4G+9viUkmBjRRO6FdrFyCoD8/7bR+o9aDMK1gffKJA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e81c01c-4842-4e85-0103-08d8df3fb5d1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 19:00:00.1650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT057.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT031 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain This changes added usage of MmUnblockMemoryLib to explicitly request runtime cache regions(and its indicators) to be accessible from MM environment when PcdEnableVariableRuntimeCache is enabled. It will bring in compatibility with architectures that supports full memory blockage inside MM. Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Kun Qin Reviewed-by: Hao A Wu --- Notes: v5: - Previously reviewed, no change. =20 v4: - Added reviewed-by tag. [Hao] =20 v3: - Removed Dxe prefix to match interface change. [Jiewen] =20 v2: - Newly added in v2. MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 42 = ++++++++++++++++++++ MdeModulePkg/MdeModulePkg.dsc | 1 = + MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf | 1 = + 3 files changed, 44 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeD= xe.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c index c47e614d81f4..a166d284dfe4 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c @@ -35,6 +35,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include +#include =20 #include #include @@ -165,6 +166,7 @@ InitVariableCache ( ) { VARIABLE_STORE_HEADER *VariableCacheStorePtr; + EFI_STATUS Status; =20 if (TotalVariableCacheSize =3D=3D NULL) { return EFI_INVALID_PARAMETER; @@ -186,6 +188,18 @@ InitVariableCache ( if (*VariableCacheBuffer =3D=3D NULL) { return EFI_OUT_OF_RESOURCES; } + + // + // Request to unblock the newly allocated cache region to be accessible = from inside MM + // + Status =3D MmUnblockMemoryRequest ( + (EFI_PHYSICAL_ADDRESS) (UINTN) *VariableCacheBuffer, + EFI_SIZE_TO_PAGES (*TotalVariableCacheSize) + ); + if (Status !=3D EFI_UNSUPPORTED && EFI_ERROR (Status)) { + return Status; + } + VariableCacheStorePtr =3D *VariableCacheBuffer; SetMem32 ((VOID *) VariableCacheStorePtr, *TotalVariableCacheSize, (UINT= 32) 0xFFFFFFFF); =20 @@ -1536,6 +1550,34 @@ SendRuntimeVariableCacheContextToSmm ( SmmRuntimeVarCacheContext->ReadLock =3D &mVariableRuntimeCacheReadLock; SmmRuntimeVarCacheContext->HobFlushComplete =3D &mHobFlushComplete; =20 + // + // Request to unblock this region to be accessible from inside MM enviro= nment + // These fields "should" be all on the same page, but just to be on the = safe side... + // + Status =3D MmUnblockMemoryRequest ( + (EFI_PHYSICAL_ADDRESS) ALIGN_VALUE ((UINTN) SmmRuntimeVarCache= Context->PendingUpdate - EFI_PAGE_SIZE + 1, EFI_PAGE_SIZE), + EFI_SIZE_TO_PAGES (sizeof(mVariableRuntimeCachePendingUpdate)) + ); + if (Status !=3D EFI_UNSUPPORTED && EFI_ERROR (Status)) { + goto Done; + } + + Status =3D MmUnblockMemoryRequest ( + (EFI_PHYSICAL_ADDRESS) ALIGN_VALUE ((UINTN) SmmRuntimeVarCache= Context->ReadLock - EFI_PAGE_SIZE + 1, EFI_PAGE_SIZE), + EFI_SIZE_TO_PAGES (sizeof(mVariableRuntimeCacheReadLock)) + ); + if (Status !=3D EFI_UNSUPPORTED && EFI_ERROR (Status)) { + goto Done; + } + + Status =3D MmUnblockMemoryRequest ( + (EFI_PHYSICAL_ADDRESS) ALIGN_VALUE ((UINTN) SmmRuntimeVarCache= Context->HobFlushComplete - EFI_PAGE_SIZE + 1, EFI_PAGE_SIZE), + EFI_SIZE_TO_PAGES (sizeof(mHobFlushComplete)) + ); + if (Status !=3D EFI_UNSUPPORTED && EFI_ERROR (Status)) { + goto Done; + } + // // Send data to SMM. // diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 7ca4a1bb3080..9272da89a998 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -100,6 +100,7 @@ [LibraryClasses] SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUpdateProgressLibGr= aphics/DisplayUpdateProgressLibGraphics.inf VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Var= iablePolicyHelperLib.inf + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibN= ull.inf =20 [LibraryClasses.EBC.PEIM] IoLib|MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeD= xe.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.i= nf index b6dbc839e023..a0d8b2267e92 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf @@ -60,6 +60,7 @@ [LibraryClasses] TpmMeasurementLib SafeIntLib PcdLib + MmUnblockMemoryLib =20 [Protocols] gEfiVariableWriteArchProtocolGuid ## PRODUCES --=20 2.30.0.windows.1