From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.92.21.91]) by mx.groups.io with SMTP id smtpd.web11.10895.1596165352490955057 for ; Thu, 30 Jul 2020 20:15:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=k2UCCxnc; spf=pass (domain: outlook.com, ip: 40.92.21.91, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIa4AS/dRmlBudg47BetdOowvnRpptq+gy50NrrxaT2HKwnHd3AL9iZoOeVdziGT9QhKKOXIX2eJUU6oQklKXZ/HRyeRy8ipxD5eiwfXfThChAMTrTDvnz4gTOlCo0wGmJ94XUSBYEactg4nYxq50f5bWQ7kpys3BhEDQxxynvK1b97laOMIFIwdOECvx4qk8ilwEqERRIANPasoH0aHWSnt4rnSqu1MstaWPWbMH7SfCCv09brj4CAKPqDH/Mcg/0l/w/1ysr9gcfnZgwlBe7ZySOr4BVipyDroTczE7eO0f1cqBcBGmBwjMwRTOsrlvWukQhP5SaurjWHS9XBwEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIbI/N/T2FeI+K2uabTYeCn+cNdJM9rUrqNlJw3KYKM=; b=lYgArx2n7axXhcH14HlZ54C7ADpYCVdJnbJRYwhmfxHXBH9flZG32JRfztHzA2iOcN+RxNCgJRpJqrKixkzcIcxLp5rLllynyWFyTZqmC3F1Ok3Ogt+G9R1KGVTIGLx87FK5HO3yxcZX1adv+yl2IZOHeqdziuS+vUxkvhMVPVKC1Q2w9cxzNuGwVt/DcwQ9Pwd7WkGn7RTx+WnE/ZvthvLrZqxRe0RUfSxC1acY3AVeJWlE4Ii2g8eag56UmGe9Z+lucYg5kduwGRbLXLA7B1PWys8/mpe4JxhiREPJ81Yh3o/pCEpWOcoLH4N9cwPfZlsXnz/jbye60TvLLSJDjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uIbI/N/T2FeI+K2uabTYeCn+cNdJM9rUrqNlJw3KYKM=; b=k2UCCxnc59KVgMQsx2Aaaibp2Q0INNCm3ef1ilCX8vi7TZgluumawfrBgxL3gX88IIIj8rTkdiQEvtgyvy/JP8a/GRaFN/ywUqaXhmJDnSzaWMRRTKFmgjOXspw+2KW3QP9H0xNcGygjiEM9f1CCsBxUTQXcsvssWI2WPCneeDsmq3g321rnmPlDdPJKTUsu5S5IIK+Dv8w6QWB97iCkOHu8db3Ztyw83ghRgkgRWuITzhM5P26TiUb7U+lcWiw0plSwfaIs2cQucFjLJcgzmPC/CZGOi/xabq/C5ZnlBGRLv1ULgFAaiuq6gmH+kugbNVwHkbbettufsIwwUydrFQ== Received: from MW2NAM12FT019.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::47) by MW2NAM12HT079.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc65::314) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.14; Fri, 31 Jul 2020 03:15:51 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc65::4c) by MW2NAM12FT019.mail.protection.outlook.com (2a01:111:e400:fc65::86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.14 via Frontend Transport; Fri, 31 Jul 2020 03:15:51 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:77AF8013C12C1EE0D20C127D8F26A8378B41A544DD6C3C15B991E3743362DE5C;UpperCasedChecksum:1F54C5FF6EC4661CEE1D2E9D01666298D727C5FAE4376A2AE277F2AC9B9F870F;SizeAsReceived:7728;Count:49 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::9856:570e:1735:974e%7]) with mapi id 15.20.3216.033; Fri, 31 Jul 2020 03:15:51 +0000 From: "Michael Kubacki" To: devel@edk2.groups.io CC: Liming Gao , Michael D Kinney Subject: [PATCH v1 6/7] FmpDevicePkg/FmpDxe: Indicate ESRT GUID on invalid ImageIdName Date: Thu, 30 Jul 2020 20:14:47 -0700 Message-ID: X-Mailer: git-send-email 2.27.0.windows.1 In-Reply-To: <20200731031448.1103-1-michael.kubacki@outlook.com> References: <20200731031448.1103-1-michael.kubacki@outlook.com> X-ClientProxiedBy: CO2PR04CA0115.namprd04.prod.outlook.com (2603:10b6:104:7::17) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <20200731031448.1103-7-michael.kubacki@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (2001:4898:80e8:0:8072:23b8:48ea:d2c1) by CO2PR04CA0115.namprd04.prod.outlook.com (2603:10b6:104:7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.18 via Frontend Transport; Fri, 31 Jul 2020 03:15:51 +0000 X-Mailer: git-send-email 2.27.0.windows.1 X-Microsoft-Original-Message-ID: <20200731031448.1103-7-michael.kubacki@outlook.com> X-TMN: [M77o2PKe6iG607fYo1SA8dPfPlnsySmlR30kGFWA1s41X0+o0/aBbvn4HyrwzGPw] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 49 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a0f77657-e717-4e4d-d905-08d83500074b X-MS-TrafficTypeDiagnostic: MW2NAM12HT079: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4EIewgoHopZ5bVttncQlwSWQs/XqKJYNAlnnjLb0tpHAjnOuNx44MMs9dBHEtILjUh0nQHXJkWN1+Pe4c88+Gz4jl0VPgMNJhkIIfda/aS2gM2wLmgBYr46eebbxrSeseX/SsrrGfdxd+/ng7WiMiWLK43aHxOgEk+R0D1pCLyajr0VmclR4//AjLimtmAqoVJdYcdS72qQRTvPw4ml52Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: k4gGNEdmqw16Dg1Plt+3gul0UE8UvlQH2byIRBTpSMzX4TFgu34e9nAOWyNeg7TFI9guZmIalOnacvXO1IfVugn6By909oOt/wSwYPguqYcFrwvp9ml3aoLhRYv252bqUczenlmO/8iFBYsWMcxBevauyATrFetkhdsUlCpSPXjaG5npec360PslIYZCpZjXMBsh5rUvXx7B1OYjdOVSTg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0f77657-e717-4e4d-d905-08d83500074b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 03:15:51.3657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT019.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT079 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Michael Kubacki Updates the debug error message to include the GUID of the FMP instance that encountered the issue to help the user better isolate the problem. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index 14994ce4ee0e..a3e342591936 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -1679,7 +1679,7 @@ FmpDxeEntryPoint ( // // PcdFmpDeviceImageIdName must be set to a non-empty Unicode string // - DEBUG ((DEBUG_ERROR, "FmpDxe: PcdFmpDeviceImageIdName is an empty stri= ng.\n")); + DEBUG ((DEBUG_ERROR, "FmpDxe(%g): PcdFmpDeviceImageIdName is an empty = string.\n", &gEfiCallerIdGuid)); ASSERT (FALSE); return EFI_UNSUPPORTED; } --=20 2.27.0.windows.1