From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.92.18.45]) by mx.groups.io with SMTP id smtpd.web10.8315.1589444294575853759 for ; Thu, 14 May 2020 01:18:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=LKqkPhzi; spf=pass (domain: outlook.com, ip: 40.92.18.45, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9bnn/W3tnphN3yYogAUOMI6cLbg0UpW+whe8sG0rnsc+GhVVsCYI5bCZm5mSYIu2acPsIaS+/fPGl3oXbg06AF1GdvS2rWwZRerYDuRTiOqIx9j5zFVT/f/kPIdIN2gFAf4nMtunFmBRsTHPiK9UwSHFGO2rz76N2Jx/QpPi0frbAcltZNYQ+zWMtS/UeGBKIGAEbcLJntpnXFvZnt0fS0xzhA4u4FXr4B4K8gMw+E/OrIrPG/HmUyxbNMJgbmpYuP8Kh53nj3o1fZaT4lS0LLQNWOXULaVezXn9vKvDc4VUypzfgvcOd3UlGxHgbg70LCRtdEnG3rYbJenBObjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6MQCoxLPSwHbTsy7fsRb9AYnsBFmAz39ueR0mBKWxdE=; b=gTIY9AWbgcieJNMeorZTaX8yNAfWIaDEzyqeSNjVjjo35E38LmSMgzoyBmvT0WieGxZAOMKpV2qYsiTFFZUJgsveuGVRoRPRHzxXJDSK836VuUwdmvZzqHPjq+pb0yhrledjLkFSCc2cusjzsjyiQFWmmAbkDc4q94HJQM3vmqYUUhjXBOXOw0HBvYkEuMcKgtNb/xIoo1Tb0OV5NES696B1SqcDTf/FJo7TDsdJIe14eheH6TnEBY/7Y13JtlJIHx1n18XBSJLK8BARUmgcUI73NcvUA+XOIGGDCG8dF97yYoA0B3xredD8W8VzPq6vsDVB8xol2J6UgWXkI9t6Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6MQCoxLPSwHbTsy7fsRb9AYnsBFmAz39ueR0mBKWxdE=; b=LKqkPhzidr6te1C6R7QFU9nWll4VSeWd/30KgmtamIs2UCmaM7B//dElJvtGPo/UeSLQ1UvasP1HGIbal0BCtHU1O77X3BsG1j5GZpr3YztMjUxlfmiwodC1+8uOv6KhXKIMFB1Lg1D3uGWMDyzB3At1k6KI5x2/FQ+vAnA4C19H3Ofs1BG+iQ2Q55iNTsr5fDVzJX07jItw5dhHLXePTfoxPwsnL8xwUE7DZWTBqYFikGsZgaNoC0b0FNL9XQ1oXAGHPhwppzMRh5XbI1rHoD9FcP8KjDcboNO7q373UySs2HIOUuo9l/Xh3/SoPN0TxswXSZtSB0pDZW+c3VSO9w== Received: from BN8NAM11FT060.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::44) by BN8NAM11HT142.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19; Thu, 14 May 2020 08:18:13 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:fc4b::4d) by BN8NAM11FT060.mail.protection.outlook.com (2a01:111:e400:fc4b::467) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 08:18:13 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:BE2049C8C906B2A86177BC24F0BEA21686BAE70D25101BBE3DD048292343AB43;UpperCasedChecksum:47B08231E69103EFDC330D597A54BB38022D15783F1EF070B9AE756B4FEDED05;SizeAsReceived:9322;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::bcc9:271b:20db:52e3%6]) with mapi id 15.20.2979.033; Thu, 14 May 2020 08:18:13 +0000 Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Replace deprecated function time.clock() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , devel@edk2.groups.io, bob.c.feng@intel.com CC: "Gao, Liming" , Michael D Kinney , Laszlo Ersek References: From: "Michael Kubacki" Message-ID: Date: Thu, 14 May 2020 01:18:12 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 In-Reply-To: X-ClientProxiedBy: MWHPR22CA0055.namprd22.prod.outlook.com (2603:10b6:300:12a::17) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <8a96a97c-6b61-a3da-885f-4f2af4f38cd1@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:799f:ba92:ff26:b621] (2001:4898:80e8:7:f9c0:ba92:ff26:b621) by MWHPR22CA0055.namprd22.prod.outlook.com (2603:10b6:300:12a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Thu, 14 May 2020 08:18:12 +0000 X-Microsoft-Original-Message-ID: <8a96a97c-6b61-a3da-885f-4f2af4f38cd1@outlook.com> X-TMN: [b4H/7EIidMFLgc68s0K4iwTDDYnUetOXbxCRW0pSfmGKmxvWQhMY+04bZmzgdwE3] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: ac305702-63cf-4e6a-88de-08d7f7df5801 X-MS-TrafficTypeDiagnostic: BN8NAM11HT142: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iHCcM+k4Dm9aZdgHFAEaN1igbsH8Fqjj7sIWFFfsenpaPV+pu2XySv5lFyiRWWfoWwKaZsIhV5vxK0EoRrJmaxAomeu9HUNknqYp3iN93oxfVvUV5MSGrCXNiEuXT7wQkw6mwnBCOEtqdD6PTHl203hZ2fWrIay5nZOIbNoTmi3qNqzY+kR2ZKwGfgU3qX4IereyX2GdqyNjjkXCEleeX/Jlvyg5YNq+ugCFD84KY8MSioSHJzJ1Hqgu3PXzLvTz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR07MB3440.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: a+79cnJKxtH4nbL35j/oYkTMZB8UMP9SQpfAaJS+7F0SJ04HdXD2/U7WCf1kWModo7+rxbaKFSQ+KcfJg8xTNJTZaE7fYysToz89XOZb7Ox/RasiMBckq1p1Tkt2AUZp/HMOfWWyiQmyK5JEWtgWfI5F1ioSfZORm94AyLc+uPMR3bR3slzJM6CAdHHtOs/NEqoXyNidg0GtMQfOKmg9+A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac305702-63cf-4e6a-88de-08d7f7df5801 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2020 08:18:13.2052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT142 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Phil, It has been a policy from Microsoft contributors to not include a year=20 in the copyright header you will find this in many other existing files=20 in edk2, I am simply aligning to that practice. Bob is the maintainer and as maintainer he chose to submit the patch (it= =20 has been on the list since May 8th). It has been relatively common to=20 reply to the patch thread to indicate it was submitted with commit=20 details. I noticed the details were not updated in the BZ either in this= =20 case so I have done that and closed the BZ. Thanks, Michael On 5/14/2020 12:37 AM, Philippe Mathieu-Daud=C3=A9 wrote: > +Michael & Laszlo. >=20 > On 5/13/20 4:15 AM, Bob Feng wrote: >> Reviewed-by: Bob Feng >> >> -----Original Message----- >> From: michael.kubacki@outlook.com >> Sent: Saturday, May 9, 2020 10:23 AM >> To: devel@edk2.groups.io >> Cc: Feng, Bob C ; Gao, Liming=20 >> >> Subject: [PATCH v1 1/1] BaseTools/Ecc: Replace deprecated function=20 >> time.clock() >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2707 >> >> Ecc fails with Python 3.8 because it uses the deprecated time.clock()= =20 >> function - https://docs.python.org/3.7/library/time.html#time.clock >> >> This change updates EccMain.py to use time.perf_counter(). >> >> Cc: Bob Feng >> Cc: Liming Gao >> Signed-off-by: Michael Kubacki >> --- >> =C2=A0 BaseTools/Source/Python/Ecc/EccMain.py | 5 +++-- >> =C2=A0 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/BaseTools/Source/Python/Ecc/EccMain.py=20 >> b/BaseTools/Source/Python/Ecc/EccMain.py >> index 560bb9fd7a31..72edbea3b883 100644 >> --- a/BaseTools/Source/Python/Ecc/EccMain.py >> +++ b/BaseTools/Source/Python/Ecc/EccMain.py >> @@ -2,6 +2,7 @@ >> =C2=A0 # This file is used to be the main entrance of ECC tool=C2=A0 #= =C2=A0 #=20 >> Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
>> +# Copyright (c) Microsoft Corporation.
>=20 > When trying to apply this patch I got: >=20 > error: patch failed: BaseTools/Source/Python/Ecc/EccMain.py:2 >=20 > Because it has already been merged as commit=20 > 242ab73d7f255d5d859eaf74a23b9d68c686d177. >=20 > 1/ The copyright comment misses a year range >=20 > 2/ It is annoying to not know a patch has been merged. > What is the expected workflow? Pull repository, look at patches merged,= =20 > then go on the list to review the un-merged ones? I suppose this won't= =20 > matter once workflow is switched to GitHub. Still, not very practical. >=20 > Regards, >=20 > Phil. >=20 >> =C2=A0 # SPDX-License-Identifier: BSD-2-Clause-Patent=C2=A0 # >> @@ -406,9 +407,9 @@ if __name__ =3D=3D '__main__': >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EdkLogger.Initialize() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EdkLogger.IsRaiseError =3D False >> -=C2=A0=C2=A0=C2=A0 StartTime =3D time.clock() >> +=C2=A0=C2=A0=C2=A0 StartTime =3D time.perf_counter() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Ecc =3D Ecc() >> -=C2=A0=C2=A0=C2=A0 FinishTime =3D time.clock() >> +=C2=A0=C2=A0=C2=A0 FinishTime =3D time.perf_counter() >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 BuildDuration =3D time.strftime("%M:%S",= = =20 >> time.gmtime(int(round(FinishTime - StartTime)))) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EdkLogger.quiet("\n%s [%s]" % (time.strf= time("%H:%M:%S, %b.%d=20 >> %Y", time.localtime()), BuildDuration)) >> --=20 >> 2.16.3.windows.1 >> >> >>=20 >> >=20