From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.22]) by mx.groups.io with SMTP id smtpd.web12.738.1585243501689966746 for ; Thu, 26 Mar 2020 10:25:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=VsV088KR; spf=pass (domain: outlook.com, ip: 40.92.42.22, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/3a4yHWUZ1plqBjIDHVeuIR71RJTAXPMjq2H7YpGIye4Co0qcPGgXFwXCKtTbq1MnK/OQAStql9vPEa+DwQNKuH4SLIq2Q3vc/4kKbdDRxj7RVhjs4AEOIGQIWkOiEKzuWT8uNaaGsAvGkfwI5GxAwuti9BUEgS+haoNMYMMbKmhlg6b+0fk+uyxhRCWX3DaH1idMQJcnH0g/xeFEo9wEar7htV01t+mGB95aFsy4myBw+tPGpbVrPR8mlIHamX/hQ72LN8ehSVh7Q/6dsm/Az3QnuBvOQaDuk9MP7WZXIWj8dekG6qVm3hlAd2V8L6XiP4M2If79FVp5So++Y8oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nzh5t7I2VxS7wKHIzQ4j73LXG07wtb2jvIsfab6iWxc=; b=Pj0EgbZAeWdGCXLM42293Ifm60zyMfT9G8pQ8oQxZFnUmBVXbz3U4D/xAng+m+OAIfT/+Q31unFvqXxm47iGz695Z2xV5bmusYyHOBNfXBtGmNzmnuYd53boh30Q/q+K8KQV+wRCbs7HMJhCv1uKSWb0su3QhRoR3YPe3Es3T14aWVM+Qq/WDC86eC7pPv93qAtEdCP6kwcReui9ysTv2hctU/rhrXOZRx9eoJtZBjsWVHTV2zEK18uCpc9XzeUaRMPulr42n9AFT0s19lfBvjxDj76dV5ib8sWfDw33SHuPZbAt+j6wpLq+AMxq1vWif/zJ4AqvujmGoWE0+wlRQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nzh5t7I2VxS7wKHIzQ4j73LXG07wtb2jvIsfab6iWxc=; b=VsV088KR9U+EcLg0kIvfF6H6dkyS/ihJptAB0L1VyYYKbWTHkxCxAH5b3Nt1GaE+JCnDJzCvnl06NVk7k1WKL3tSD+wOWNshqDU77YSMVoxTX8RiaooMDv4qZI3uTBy4bhRfwg8V7O5WSi1xE2u2ykFrOoJnbMyZOVmP63tNTCPCwmAxtlfv5uxIbUk82Zw/bAoCaUNcDW/Ohi205R+BG76cRsVFSxXRedxTjYS1N1iFiM90oY7yIZToDRcNgqbaaNJ5QtWQmMxmpCBtFpAhhz3TB9Zs3ci2UV5cUa8Vf8ugiSqTtO69EZnqzPPdarUwNG15HYXK6wM3RYSKWREINQ== Received: from MW2NAM10FT042.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::50) by MW2NAM10HT101.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::356) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17; Thu, 26 Mar 2020 17:25:00 +0000 Received: from MWHPR07MB3440.namprd07.prod.outlook.com (2a01:111:e400:7e87::41) by MW2NAM10FT042.mail.protection.outlook.com (2a01:111:e400:7e87::429) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Thu, 26 Mar 2020 17:25:00 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:04F3F203E003309F50BA2267BE5DDDED272E762349C01ED1636F86136ECE0950;UpperCasedChecksum:8F5E1A65D8EFD81A2F3DC004B19D7793D9593FF0A192D61BC54EFCB7E56A9C54;SizeAsReceived:9062;Count:50 Received: from MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::f5a7:e51b:e22a:959f]) by MWHPR07MB3440.namprd07.prod.outlook.com ([fe80::f5a7:e51b:e22a:959f%7]) with mapi id 15.20.2835.023; Thu, 26 Mar 2020 17:25:00 +0000 Subject: Re: [edk2-devel] [PATCH v5 0/3] Add RpmcLib and VariableKeyLib To: devel@edk2.groups.io, jian.j.wang@intel.com Cc: Jiewen Yao , Chao Zhang , Nishant C Mistry References: <20200326074946.1304-1-jian.j.wang@intel.com> From: "Michael Kubacki" Message-ID: Date: Thu, 26 Mar 2020 10:24:58 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 In-Reply-To: <20200326074946.1304-1-jian.j.wang@intel.com> X-ClientProxiedBy: MWHPR17CA0056.namprd17.prod.outlook.com (2603:10b6:300:93::18) To MWHPR07MB3440.namprd07.prod.outlook.com (2603:10b6:301:69::28) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: <6dd6ad1c-d4b0-608c-601b-46b5579f8647@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:4898:d8:39:1c8f:afc9:a371:4ff8] (2001:4898:80e8:a:9cad:afc9:a371:4ff8) by MWHPR17CA0056.namprd17.prod.outlook.com (2603:10b6:300:93::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.21 via Frontend Transport; Thu, 26 Mar 2020 17:24:59 +0000 X-Microsoft-Original-Message-ID: <6dd6ad1c-d4b0-608c-601b-46b5579f8647@outlook.com> X-TMN: [9x2mFSfrVFCxL1wnkqoIHIMVnG4ibTOVbAOCBTlkTLH5Ag050JFTjsESh4r/mgWk] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: cf86b5c7-654e-4eb6-d263-08d7d1aa9c71 X-MS-TrafficTypeDiagnostic: MW2NAM10HT101: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bc/z0UrvmDENb2KICc8YKphBornkLubGgcKQ6bzpPxGfSWzFf19jOzxEtbzMmIwMNDtBsakG6uqd6rlSDWhcLE0hLuOQuZ91bN9A6/8CMzsXQ5E/2A41luA8ztuUvUl/1kMA50gsAtUTEq7Hu3J+8wL8FQ7TCtJXN4wnJFobVS5qwv+TDkBDidvCJb0ZtyGLoq3dQkmuhnYOtQ+jVcu90CR1ztMdhZFMGtbjDq7K9co= X-MS-Exchange-AntiSpam-MessageData: Hg1csJXiXhSfiTkOLlCK5jy3ysKDKKVYkw1VUGExgbqSXAFzsOPEHpavZZo/kleZ9LJvcd54rgAib7GRe8BBlXGfPU2GVtq25WLU/xiUj7380qb4xtssFy/2sGf5fXIvCn6LzEtdISwgl5fTV9+Cbd/xeBKceYVN8y8oobPTVDh0jiQgdVoonGnGTus/qEl2TyNR+1dR6Da+xLmu7cFHCw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf86b5c7-654e-4eb6-d263-08d7d1aa9c71 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2020 17:24:59.9103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT101 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit For the series: Reviewed-by: Michael Kubacki On 3/26/2020 12:49 AM, Wang, Jian J wrote: >> v5: change VariableRootKey to VariableKey > >> v4: remove CounterId which should not be exposed > >> v3: update retval description in RpmcLib.h and RpmcLibNull.c > >> v2: change CounterIndex to CounterId in RpmcLib prototype. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > Patch branch: https://github.com/jwang36/edk2/tree/bz2594-part1-common-interfaces-between-platform-and-edk2-v5 > > > > Cc: Jiewen Yao > > Cc: Chao Zhang > > Cc: Nishant C Mistry > > Jian J Wang (3): > SecurityPkg: add RpmcLib and VariableKeyLib public headers > SecurityPkg: add null version of RpmcLib > SecurityPkg: add null version of VariableKeyLib > > SecurityPkg/Include/Library/RpmcLib.h | 42 ++++++++++++ > SecurityPkg/Include/Library/VariableKeyLib.h | 59 ++++++++++++++++ > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 47 +++++++++++++ > .../Library/RpmcLibNull/RpmcLibNull.inf | 33 +++++++++ > .../VariableKeyLibNull/VariableKeyLibNull.c | 67 +++++++++++++++++++ > .../VariableKeyLibNull/VariableKeyLibNull.inf | 33 +++++++++ > SecurityPkg/SecurityPkg.dec | 8 +++ > SecurityPkg/SecurityPkg.dsc | 8 +++ > 8 files changed, 297 insertions(+) > create mode 100644 SecurityPkg/Include/Library/RpmcLib.h > create mode 100644 SecurityPkg/Include/Library/VariableKeyLib.h > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > create mode 100644 SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf > create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > create mode 100644 SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.inf >